exchange 0.8.0 → 0.9.0

data/spec/exchange/cache/redis_spec.rb

@@ -6,20 +6,14 @@ describe "Exchange::Cache::Redis" do
   before(:each) do
     Exchange.configuration = Exchange::Configuration.new do |c|
       c.cache = {
-        :class => :redis,
+        :subclass => :redis,
         :host => 'HOST',
         :port => 'PORT'
       }
     end
   end
   after(:each) do
-    Exchange.configuration = Exchange::Configuration.new do |c|
-      c.cache = {
-        :class => :memcached,
-        :host => 'localhost',
-        :port => 11211
-      }
-    end
+    Exchange.configuration.reset
   end
   describe "client" do
     let(:client) { mock('redis') }
@@ -43,10 +37,10 @@ describe "Exchange::Cache::Redis" do
       lambda { subject.cached('API_CLASS') }.should raise_error(Exchange::Cache::CachingWithoutBlockError)
     end
     context "when a cached result exists" do
-      context "when loading json" do
+      context "when loading" do
         before(:each) do
           subject.should_receive(:key).with('API_CLASS', {}).and_return('KEY')
-          client.should_receive(:get).with('KEY').and_return "{\"RESULT\":\"YAY\"}"
+          client.should_receive(:get).with('KEY').and_return({'RESULT' => 'YAY'}.cachify)
         end
         it "should return the JSON loaded result" do
           subject.cached('API_CLASS') { 'something' }.should == {'RESULT' => 'YAY'}
@@ -57,12 +51,8 @@ describe "Exchange::Cache::Redis" do
           subject.should_receive(:key).with('API_CLASS', {:plain => true}).and_return('KEY')
         end
         it "should return a String result in the right format" do
-          client.should_receive(:get).with('KEY').and_return "122.0"
-          subject.cached('API_CLASS', :plain => true) { 'something' }.should == "122.0"
-        end
-        it "should also return a String result in the right format when redis adds quotes and spaces" do
-          client.should_receive(:get).with('KEY').and_return "\"122.0\" "
-          subject.cached('API_CLASS', :plain => true) { 'something' }.should == "122.0"
+          client.should_receive(:get).with('KEY').and_return("122.0".cachify)
+          subject.cached('API_CLASS', :plain => true) { 'something' }.should == "122.0".cachify
         end
       end
     end
@@ -73,7 +63,7 @@ describe "Exchange::Cache::Redis" do
       end
       context "with daily cache" do
         it "should call the block and set and return the result" do
-          client.should_receive(:set).with('KEY', "{\"RESULT\":\"YAY\"}").once
+          client.should_receive(:set).with('KEY', {'RESULT' => 'YAY'}.cachify).once
           client.should_receive(:expire).with('KEY', 86400).once
           subject.cached('API_CLASS') { {'RESULT' => 'YAY'} }.should == {'RESULT' => 'YAY'}
         end
@@ -86,7 +76,7 @@ describe "Exchange::Cache::Redis" do
           Exchange.configuration.cache.expire = :daily
         end
         it "should call the block and set and return the result" do
-          client.should_receive(:set).with('KEY', "{\"RESULT\":\"YAY\"}").once
+          client.should_receive(:set).with('KEY', {'RESULT' => 'YAY'}.cachify).once
           client.should_receive(:expire).with('KEY', 3600).once
           subject.cached('API_CLASS') { {'RESULT' => 'YAY'} }.should == {'RESULT' => 'YAY'}
         end

data/spec/exchange/configuration_spec.rb

@@ -5,9 +5,9 @@ describe "Exchange::Configuration" do
   it "should have a standard configuration" do
     subject.api.retries.should == 5
     subject.api.subclass.should == Exchange::ExternalAPI::XavierMedia
-    subject.cache.subclass.should == Exchange::Cache::Memcached
-    subject.cache.host.should == 'localhost'
-    subject.cache.port.should == 11211
+    subject.cache.subclass.should == Exchange::Cache::Memory
+    subject.cache.host.should be_nil
+    subject.cache.port.should be_nil
     subject.cache.expire.should == :daily
   end
   it "should respond to all configuration getters and setters" do
@@ -46,10 +46,34 @@ describe "Exchange::Configuration" do
     subject.api.subclass.should == Exchange::ExternalAPI::Ecb
     subject.api.retries.should == 1
   end
-  after(:all) do
-    subject.api = {
-      :subclass => :currency_bot,
-      :retries => 5
+  describe "reset" do
+    Exchange.configuration = Exchange::Configuration.new {|c|
+      c.api = {
+        :subclass => :open_exchange_rates,
+        :retries => 60,
+        :app_id => '234u230482348023'
+      }
+      c.cache = {
+        :subclass => :redis,
+        :host => 'localhost',
+        :port => 112211,
+        :path => 'PATH'
+      }
+      c.allow_mixed_operations = false
     }
+    it "should restore the defaults" do
+      subject.reset
+      subject.api.subclass.should == Exchange::ExternalAPI::XavierMedia
+      subject.api.retries.should == 5
+      subject.api.app_id.should be_nil
+      subject.cache.subclass.should == Exchange::Cache::Memory
+      subject.cache.host.should be_nil
+      subject.cache.port.should be_nil
+      subject.cache.path.should be_nil
+      subject.allow_mixed_operations.should be_true
+    end
+  end
+  after(:all) do
+    Exchange.configuration.reset
   end  
 end

data/spec/exchange/core_extensions/array/cachify_spec.rb

@@ -0,0 +1,12 @@
+require 'spec_helper'
+
+describe "Exchange::Cachify" do
+  
+  describe "cachify" do
+    subject { ["hello", 23, :world ] }
+    it "should marshal dump" do
+      subject.cachify.should == Marshal.dump(subject)
+    end
+  end
+  
+end

data/spec/exchange/core_extensions/float/error_safe_spec.rb

@@ -0,0 +1,49 @@
+require 'spec_helper'
+
+describe "Exchange::ErrorSafe" do
+  before(:all) do
+    Exchange.configuration = Exchange::Configuration.new { |c| c.cache = { :subclass => :no_cache } }
+  end
+  before(:each) do
+    @time = Time.gm(2012,8,27)
+    Time.stub! :now => @time
+  end
+  after(:all) do
+    Exchange.configuration.reset
+  end
+  
+  describe "money safe calculation" do
+    describe "*" do
+      it "should calculate correctly with exchange money" do
+        (0.29 * 50.usd).round.should == 15
+      end
+      it "should not touch other operations" do
+        (0.29 * 50).round.should == 14
+      end
+    end
+    describe "/" do
+      it "should calculate correctly with exchange money" do
+        (((1829.82 / 12.usd) * 100).round.to_f / 100).to_f.should == 152.49
+      end
+      it "should not touch other operations" do
+        (((1829.82 / 12) * 100).round.to_f / 100).should == 152.48
+      end
+    end
+    describe "+" do
+      it "should calculate correctly with exchange money" do
+        (1.0e+25 + BigDecimal.new("9999999999999999900000000").usd).round.to_f.should == 2.0e+25
+      end
+      it "should not touch other operations" do
+        (1.0e+25 + BigDecimal.new("9999999999999999900000000")).round.should == 20000000000000001811939328
+      end
+    end
+    describe "-" do
+      it "should calculate correctly with exchange money" do
+        (1.0e+25 - BigDecimal.new("9999999999999999900000000").usd).round.should == 100000000
+      end
+      it "should not touch other operations" do
+        (1.0e+25 - BigDecimal.new("9999999999999999900000000")).should == 0
+      end
+    end
+  end
+end

data/spec/exchange/core_extensions/hash/cachify_spec.rb

@@ -0,0 +1,12 @@
+require 'spec_helper'
+
+describe "Exchange::Cachify" do
+  
+  describe "cachify" do
+    subject { { :bla => 'bli', "BLU" => [2,3] } }
+    it "should marshal dump" do
+      subject.cachify.should == Marshal.dump(subject)
+    end
+  end
+  
+end

data/spec/exchange/core_extensions/numeric/cachify_spec.rb

@@ -0,0 +1,26 @@
+require 'spec_helper'
+
+describe "Exchange::Cachify" do
+  
+  describe "cachify" do
+    context "with a big decimal" do
+      subject { BigDecimal.new("5") }
+      it "should marshal dump" do
+        subject.cachify.should == Marshal.dump(subject)
+      end
+    end
+    context "with a float" do
+      subject { 0.4545 }
+      it "should marshal dump" do
+        subject.cachify.should == Marshal.dump(subject)
+      end
+    end
+    context "with an integer" do
+      subject { 45 }
+      it "should marshal dump" do
+        subject.cachify.should == Marshal.dump(subject)
+      end
+    end
+  end
+  
+end

data/spec/{core_extensions → exchange/core_extensions/numeric}/conversability_spec.rb

@@ -9,35 +9,35 @@ describe "Exchange::Conversability" do
     Time.stub! :now => @time
   end
   after(:all) do
-    Exchange::configuration = Exchange::Configuration.new { |c| c.cache = { :subclass => :memcached } }
+    Exchange.configuration.reset
   end
   it "should define all currencies on Fixnum, Float and BigDecimal" do
     Exchange::ISO4217.definitions.keys.each do |c|
-      1.should be_respond_to(c.downcase.to_sym)
-      1.1.should be_respond_to(c.downcase.to_sym)
-      BigDecimal.new("1").should be_respond_to(c.downcase.to_sym)
+      1.should be_respond_to(c.to_s.downcase.to_sym)
+      1.1.should be_respond_to(c.to_s.downcase.to_sym)
+      BigDecimal.new("1").should be_respond_to(c.to_s.downcase.to_sym)
     end
   end
   context "with a fixnum" do
     it "should allow to convert to a currency" do
-      3.eur.should be_kind_of Exchange::Currency
+      3.eur.should be_kind_of Exchange::Money
       3.eur.value.should == 3
     end
     it "should allow to convert to a curreny with a negative number" do
-      -3.eur.should be_kind_of Exchange::Currency
+      -3.eur.should be_kind_of Exchange::Money
       -3.eur.value.should == -3
     end
     it "should allow to do full conversions" do
       mock_api("http://api.finance.xaviermedia.com/api/2012/08/27.xml", fixture('api_responses/example_xml_api.xml'), 3)
-      3.eur.to_chf.should be_kind_of Exchange::Currency
+      3.eur.to_chf.should be_kind_of Exchange::Money
       3.eur.to_chf.value.round(2).should == 3.68
-      3.eur.to_chf.currency.should == 'chf'
+      3.eur.to_chf.currency.should == :chf
     end
     it "should allow to do full conversions with negative numbers" do
       mock_api("http://api.finance.xaviermedia.com/api/2012/08/27.xml", fixture('api_responses/example_xml_api.xml'), 3)
-      -3.eur.to_chf.should be_kind_of Exchange::Currency
+      -3.eur.to_chf.should be_kind_of Exchange::Money
       -3.eur.to_chf.value.round(2).should == -3.68
-      -3.eur.to_chf.currency.should == 'chf'
+      -3.eur.to_chf.currency.should == :chf
     end
     it "should allow to define a historic time in which the currency should be interpreted" do
       3.chf(:at => Time.gm(2010,1,1)).time.yday.should == 1
@@ -47,24 +47,24 @@ describe "Exchange::Conversability" do
   end
   context "with a float" do
     it "should allow to convert to a currency" do
-      3.25.eur.should be_kind_of Exchange::Currency
+      3.25.eur.should be_kind_of Exchange::Money
       3.25.eur.value.round(2).should == 3.25
     end
     it "should allow to convert to a curreny with a negative number" do
-      -3.25.eur.should be_kind_of Exchange::Currency
+      -3.25.eur.should be_kind_of Exchange::Money
       -3.25.eur.value.round(2).should == -3.25
     end
     it "should allow to do full conversions" do
       mock_api("http://api.finance.xaviermedia.com/api/2012/08/27.xml", fixture('api_responses/example_xml_api.xml'), 3)
-      3.25.eur.to_chf.should be_kind_of Exchange::Currency
+      3.25.eur.to_chf.should be_kind_of Exchange::Money
       3.25.eur.to_chf.value.round(2).should == 3.99
-      3.25.eur.to_chf.currency.should == 'chf'
+      3.25.eur.to_chf.currency.should == :chf
     end
     it "should allow to do full conversions with negative numbers" do
       mock_api("http://api.finance.xaviermedia.com/api/2012/08/27.xml", fixture('api_responses/example_xml_api.xml'), 3)
-      -3.25.eur.to_chf.should be_kind_of Exchange::Currency
+      -3.25.eur.to_chf.should be_kind_of Exchange::Money
       -3.25.eur.to_chf.value.round(2).should == -3.99
-      -3.25.eur.to_chf.currency.should == 'chf'
+      -3.25.eur.to_chf.currency.should == :chf
     end
     it "should allow to define a historic time in which the currency should be interpreted" do
       3.25.chf(:at => Time.gm(2010,1,1)).time.yday.should == 1
@@ -74,24 +74,24 @@ describe "Exchange::Conversability" do
   end
   context "with a big decimal" do
     it "should allow to convert to a currency" do
-      BigDecimal.new("3.25").eur.should be_kind_of Exchange::Currency
+      BigDecimal.new("3.25").eur.should be_kind_of Exchange::Money
       BigDecimal.new("3.25").eur.value.round(2).should == 3.25
     end
     it "should allow to convert to a curreny with a negative number" do
-      BigDecimal.new("-3.25").eur.should be_kind_of Exchange::Currency
+      BigDecimal.new("-3.25").eur.should be_kind_of Exchange::Money
       BigDecimal.new("-3.25").eur.value.round(2).should == -3.25
     end
     it "should allow to do full conversions" do
       mock_api("http://api.finance.xaviermedia.com/api/2012/08/27.xml", fixture('api_responses/example_xml_api.xml'), 3)
-      BigDecimal.new("3.25").eur.to_chf.should be_kind_of Exchange::Currency
+      BigDecimal.new("3.25").eur.to_chf.should be_kind_of Exchange::Money
       BigDecimal.new("3.25").eur.to_chf.value.round(2).should == 3.99
-      BigDecimal.new("3.25").eur.to_chf.currency.should == 'chf'
+      BigDecimal.new("3.25").eur.to_chf.currency.should == :chf
     end
     it "should allow to do full conversions with negative numbers" do
       mock_api("http://api.finance.xaviermedia.com/api/2012/08/27.xml", fixture('api_responses/example_xml_api.xml'), 3)
-      BigDecimal.new("-3.25").eur.to_chf.should be_kind_of Exchange::Currency
+      BigDecimal.new("-3.25").eur.to_chf.should be_kind_of Exchange::Money
       BigDecimal.new("-3.25").eur.to_chf.value.round(2).should == -3.99
-      BigDecimal.new("-3.25").eur.to_chf.currency.should == 'chf'
+      BigDecimal.new("-3.25").eur.to_chf.currency.should == :chf
     end
     it "should allow to define a historic time in which the currency should be interpreted" do
       BigDecimal.new("3.25").chf(:at => Time.gm(2010,1,1)).time.yday.should == 1

data/spec/exchange/core_extensions/string/cachify_spec.rb

@@ -0,0 +1,59 @@
+require 'spec_helper'
+
+describe "Exchange::Cachify" do
+  
+  describe "cachify" do
+    subject { "bla" }
+    it "should marshal dump" do
+      subject.cachify.should == Marshal.dump(subject)
+    end
+  end
+  
+  describe "decachify" do
+    context "with a string" do
+      subject { "blu" }
+      it "should work" do
+        subject.cachify.decachify.should == subject
+      end
+    end
+    context "with a hash" do
+      subject { {:bla => "blu", "bli" => :blo, nil => [5,6]} }
+      it "should work" do
+        subject.cachify.decachify.should == subject
+      end
+    end
+    context "with a symbol" do
+      subject { :blu }
+      it "should work" do
+        subject.cachify.decachify.should == subject
+      end
+    end
+    context "with an array" do
+      subject { [2, 2.3, "blu", :bli, BigDecimal.new("3.345345")] }
+      it "should work" do
+        subject.cachify.decachify.should == subject
+      end
+    end
+    context "with numeric" do
+      context "big decimal" do
+        subject { BigDecimal.new("33.3333333", 3) }
+        it "should work" do
+          subject.cachify.decachify.should == subject
+        end
+      end
+      context "integer" do
+        subject { 33 }
+        it "should work" do
+          subject.cachify.decachify.should == subject
+        end
+      end
+      context "float" do
+        subject { 33.33333333 }
+        it "should work" do
+          subject.cachify.decachify.should == subject
+        end
+      end
+    end
+  end
+  
+end

data/spec/exchange/core_extensions/symbol/cachify_spec.rb

@@ -0,0 +1,12 @@
+require 'spec_helper'
+
+describe "Exchange::Cachify" do
+  
+  describe "cachify" do
+    subject { :blu }
+    it "should marshal dump" do
+      subject.cachify.should == Marshal.dump(subject)
+    end
+  end
+  
+end

data/spec/exchange/external_api/base_spec.rb

@@ -2,35 +2,38 @@ require 'spec_helper'
 
 describe "Exchange::ExternalAPI::Base" do
   subject { Exchange::ExternalAPI::Base.new }
-  before(:each) do
+  before(:all) do
     Exchange.configuration = Exchange::Configuration.new{|c|
       c.cache = {:subclass => :no_cache}
     }
   end
+  after(:all) do
+    Exchange.configuration.reset
+  end
   before(:each) do
-    subject.instance_variable_set("@rates", {'EUR' => BigDecimal.new("3.45"), 'CHF' => BigDecimal.new("5.565")})
-    subject.instance_variable_set("@base", 'usd')
+    subject.instance_variable_set("@rates", {:eur => BigDecimal.new("3.45"), :chf => BigDecimal.new("5.565")})
+    subject.instance_variable_set("@base", :usd)
   end
   describe "rate" do
     it "should put out an exchange rate for the two currencies" do
       subject.should_receive(:update).once
-      subject.rate('eur', 'chf').round(3).should == 1.613
+      subject.rate(:eur, :chf).round(3).should == 1.613
     end
     it "should put out an exchange rate for the two currencies and pass on opts" do
       time = Time.now
       subject.should_receive(:update).with(:at => time).once
-      subject.rate('eur', 'chf', :at => time).round(3).should == 1.613
+      subject.rate(:eur, :chf, :at => time).round(3).should == 1.613
     end
   end
   describe "convert" do
     it "should convert according to the given rates" do
       subject.should_receive(:update).once
-      subject.convert(80,'chf','eur').round(2).should == 49.6
+      subject.convert(80,:chf, :eur).round(2).should == 49.6
     end
     it "should convert according to the given rates and pass opts" do
       time = Time.now
       subject.should_receive(:update).with(:at => time).once
-      subject.convert(80,'chf','eur', :at => time).round(2).should == 49.6
+      subject.convert(80,:chf, :eur, :at => time).round(2).should == 49.6
     end
   end
 end