exchange 0.6.0 → 0.8.0

data/spec/exchange/currency_spec.rb

@@ -40,10 +40,16 @@ describe "Exchange::Currency" do
       it "should be able to add a float" do
         (subject + 40.5).value.should == 80.5
       end
+      it "should not modify the base value" do
+        (subject + 40.5).value.should == 80.5
+        subject.value.should == 40.0
+      end
       it "should be able to add another currency value" do
         mock_api("http://openexchangerates.org/api/latest.json?app_id=", fixture('api_responses/example_json_api.json'), 2)
         (subject + Exchange::Currency.new(30, :chf)).value.round(2).should == 72.87
         (subject + Exchange::Currency.new(30, :sek)).currency.should == :usd
+        subject.value.round(2).should == 40
+        subject.currency.should == :usd
       end
       it "should raise when currencies get mixed and the configuration does not allow it" do
         Exchange.configuration.allow_mixed_operations = false
@@ -56,19 +62,58 @@ describe "Exchange::Currency" do
         lambda { subject + Exchange::Currency.new(30, :usd) }.should_not raise_error
         Exchange.configuration.allow_mixed_operations = true
       end
+      context "modifying the base value" do
+        before(:each) do
+          # subject does not eval correctly when used with modifiers
+          @instantiated = subject
+        end
+        it "should be able to add an integer" do
+          (@instantiated += 40).value.should == 80
+        end
+        it "should be able to add a float" do
+          (@instantiated += 40.5).value.should == 80.5
+        end
+        it "should modify the base value" do
+          (@instantiated += 40.5).value.should == 80.5
+          @instantiated.value.should == 80.5
+        end
+        it "should be able to add another currency value" do
+          mock_api("http://openexchangerates.org/api/latest.json?app_id=", fixture('api_responses/example_json_api.json'), 2)
+          added = (@instantiated += Exchange::Currency.new(30, :chf))
+          added.value.round(2).should == 72.87
+          added.currency.should == :usd
+          @instantiated.value.round(2).should == 72.87
+          @instantiated.currency.should == :usd
+        end
+        it "should raise when currencies get mixed and the configuration does not allow it" do
+          Exchange.configuration.allow_mixed_operations = false
+          lambda { @instantiated += Exchange::Currency.new(30, :chf) }.should raise_error(Exchange::CurrencyMixError)
+          Exchange.configuration.allow_mixed_operations = true
+        end
+        it "should not raise when currencies get mixed and the configuration does not allow if the other currency is the same" do
+          Exchange.configuration.allow_mixed_operations = false
+          mock_api("http://openexchangerates.org/api/latest.json?app_id=", fixture('api_responses/example_json_api.json'), 2)
+          lambda { @instantiated += Exchange::Currency.new(30, :usd) }.should_not raise_error
+          Exchange.configuration.allow_mixed_operations = true
+        end
+      end
     end
     describe "- other" do
       it "should be able to subtract an integer" do
-        (subject + 40).value.should == 80
+        (subject - 40).value.should == 0
       end
       it "should be able to subtract a float" do
-        (subject + 40.5).value.should == 80.5
+        (subject - 40.5).value.should == -0.5
+      end
+      it "should not modify the base value" do
+        (subject - 40).value.should == 0
+        subject.value.should == 40.0
       end
       it "should be able to subtract another currency value" do
         mock_api("http://openexchangerates.org/api/latest.json?app_id=", fixture('api_responses/example_json_api.json'), 2)
         Exchange.configuration.allow_mixed_operations = true
-        (subject + Exchange::Currency.new(10, :chf)).value.round(2).should == 50.96
-        (subject + Exchange::Currency.new(23.3, :eur)).currency.should == :usd
+        (subject - Exchange::Currency.new(10, :chf)).value.round(2).should == 29.04
+        (subject - Exchange::Currency.new(23.3, :eur)).currency.should == :usd
       end
       it "should raise when currencies get mixed and the configuration does not allow it" do
         Exchange.configuration.allow_mixed_operations = false
@@ -81,6 +126,42 @@ describe "Exchange::Currency" do
         lambda { subject - Exchange::Currency.new(30, :usd) }.should_not raise_error
         Exchange.configuration.allow_mixed_operations = true
       end
+      context "modifying the base value" do
+        before(:each) do
+          # subject does not eval correctly when used with modifiers
+          @instantiated = subject
+        end
+        it "should be able to subtract an integer" do
+          (@instantiated -= 40).value.should == 0
+        end
+        it "should be able to subtract a float" do
+          (@instantiated -= 40.5).value.should == -0.5
+        end
+        it "should modify the base value" do
+          (@instantiated -= 40.5).value.should == -0.5
+          @instantiated.value.should == -0.5
+        end
+        it "should be able to subtract another currency value" do
+          mock_api("http://openexchangerates.org/api/latest.json?app_id=", fixture('api_responses/example_json_api.json'), 2)
+          Exchange.configuration.allow_mixed_operations = true
+          added = (@instantiated -= Exchange::Currency.new(10, :chf))
+          added.value.round(2).should == 29.04
+          added.currency.should == :usd
+          @instantiated.value.round(2).should == 29.04
+          @instantiated.currency.should == :usd
+        end
+        it "should raise when currencies get mixed and the configuration does not allow it" do
+          Exchange.configuration.allow_mixed_operations = false
+          lambda { @instantiated -= Exchange::Currency.new(30, :chf) }.should raise_error(Exchange::CurrencyMixError)
+          Exchange.configuration.allow_mixed_operations = true
+        end
+        it "should not raise when currencies get mixed and the configuration does not allow if the other currency is the same" do
+          Exchange.configuration.allow_mixed_operations = false
+          mock_api("http://openexchangerates.org/api/latest.json?app_id=", fixture('api_responses/example_json_api.json'), 2)
+          lambda { @instantiated -= Exchange::Currency.new(30, :usd) }.should_not raise_error
+          Exchange.configuration.allow_mixed_operations = true
+        end
+      end
     end
     describe "* other" do
       it "should be able to multiply by an integer" do
@@ -89,6 +170,10 @@ describe "Exchange::Currency" do
       it "should be able to multiply a float" do
         (subject * 40.5).value.should == 1620
       end
+      it "should not modify the base value" do
+        (subject * 40).value.should == 1600
+        subject.value.should == 40.0
+      end
       it "should be able to multiply by another currency value" do
         mock_api("http://openexchangerates.org/api/latest.json?app_id=", fixture('api_responses/example_json_api.json'), 2)
         Exchange.configuration.allow_mixed_operations = true
@@ -106,15 +191,60 @@ describe "Exchange::Currency" do
         lambda { subject * Exchange::Currency.new(30, :usd) }.should_not raise_error
         Exchange.configuration.allow_mixed_operations = true
       end
+      context "modifying the base value" do
+        before(:each) do
+          # subject does not eval correctly when used with modifiers
+          @instantiated = subject
+        end
+        it "should be able to multiply by an integer" do
+          (@instantiated *= 40).value.should == 1600
+        end
+        it "should be able to multiply a float" do
+          (@instantiated *= 40.5).value.should == 1620
+        end
+        it "should modify the base value" do
+          (@instantiated *= 40.5).value.should == 1620
+          @instantiated.value.should == 1620
+        end
+        it "should be able to multiply by another currency value" do
+          mock_api("http://openexchangerates.org/api/latest.json?app_id=", fixture('api_responses/example_json_api.json'), 2)
+          Exchange.configuration.allow_mixed_operations = true
+          added = (@instantiated *= Exchange::Currency.new(9, :chf))
+          added.value.round(1).should == 394.50
+          added.currency.should == :usd
+          @instantiated.value.round(1).should == 394.50
+          @instantiated.currency.should == :usd
+        end
+        it "should raise when currencies get mixed and the configuration does not allow it" do
+          Exchange.configuration.allow_mixed_operations = false
+          lambda { @instantiated *= Exchange::Currency.new(30, :chf) }.should raise_error(Exchange::CurrencyMixError)
+          Exchange.configuration.allow_mixed_operations = true
+        end
+        it "should not raise when currencies get mixed and the configuration does not allow if the other currency is the same" do
+          Exchange.configuration.allow_mixed_operations = false
+          mock_api("http://openexchangerates.org/api/latest.json?app_id=", fixture('api_responses/example_json_api.json'), 2)
+          lambda { @instantiated *= Exchange::Currency.new(30, :usd) }.should_not raise_error
+          Exchange.configuration.allow_mixed_operations = true
+        end
+      end
     end
     describe "/ other" do
-      it "should be able to multiply by an integer" do
+      it "should be able to divide by an integer" do
         (subject / 40).value.should == 1
       end
-      it "should be able to multiply a float" do
+      it "should be able to divide by a float" do
         BigDecimal.new((subject / 40.5).value.to_s).round(4).should == 0.9877
       end
-      it "should be able to multiply by another currency value" do
+      it "should not modify the base value" do
+        (subject / 40).value.should == 1
+        subject.value.should == 40.0
+      end
+      it "should modify the base value if the operator is used with =" do
+        instantiated = subject
+        (instantiated /= 40).value.should == 1
+        instantiated.value.should == 1
+      end
+      it "should be able to divide by another currency value" do
         mock_api("http://openexchangerates.org/api/latest.json?app_id=", fixture('api_responses/example_json_api.json'), 2)
         Exchange.configuration.allow_mixed_operations = true
         (subject / Exchange::Currency.new(10, :chf)).value.round(2).should == BigDecimal.new("3.65")
@@ -131,6 +261,42 @@ describe "Exchange::Currency" do
         lambda { subject / Exchange::Currency.new(30, :usd) }.should_not raise_error
         Exchange.configuration.allow_mixed_operations = true
       end
+      context "modifying the base value" do
+        before(:each) do
+          # subject does not eval correctly when used with modifiers
+          @instantiated = subject
+        end
+        it "should be able to add an integer" do
+          (@instantiated /= 40).value.should == 1
+        end
+        it "should be able to multiply a float" do
+          (@instantiated /= 13.3).value.round(2).should == 3.01
+        end
+        it "should modify the base value" do
+          (@instantiated /= 13.3).value.round(2).should == 3.01
+          @instantiated.value.round(2).should == 3.01
+        end
+        it "should be able to divide by another currency value" do
+          mock_api("http://openexchangerates.org/api/latest.json?app_id=", fixture('api_responses/example_json_api.json'), 2)
+          Exchange.configuration.allow_mixed_operations = true
+          added = (@instantiated /= Exchange::Currency.new(10, :chf))
+          added.value.round(2).should == 3.65
+          added.currency.should == :usd
+          @instantiated.value.round(2).should == 3.65
+          @instantiated.currency.should == :usd
+        end
+        it "should raise when currencies get mixed and the configuration does not allow it" do
+          Exchange.configuration.allow_mixed_operations = false
+          lambda { @instantiated /= Exchange::Currency.new(30, :chf) }.should raise_error(Exchange::CurrencyMixError)
+          Exchange.configuration.allow_mixed_operations = true
+        end
+        it "should not raise when currencies get mixed and the configuration does not allow if the other currency is the same" do
+          Exchange.configuration.allow_mixed_operations = false
+          mock_api("http://openexchangerates.org/api/latest.json?app_id=", fixture('api_responses/example_json_api.json'), 2)
+          lambda { @instantiated /= Exchange::Currency.new(30, :usd) }.should_not raise_error
+          Exchange.configuration.allow_mixed_operations = true
+        end
+      end
     end
     describe "comparison" do
       subject { Exchange::Currency.new(40.123, :usd) }
@@ -185,6 +351,10 @@ describe "Exchange::Currency" do
           subject.round.currency.should == :usd
           subject.round.should be_kind_of Exchange::Currency
         end
+        it "should not modify the base value" do
+          subject.round.value.should == 40.12
+          subject.value.should == 40.123
+        end
       end
       context "with arguments" do
         it "should apply it to its number" do
@@ -207,6 +377,10 @@ describe "Exchange::Currency" do
           subject.ceil.currency.should == :omr
           subject.ceil.should be_kind_of Exchange::Currency
         end
+        it "should not modify the base value" do
+          subject.ceil.value.should == 40.124
+          subject.value.should == 40.1236
+        end
       end
       context "with arguments" do
         it "should apply it to its number" do
@@ -229,6 +403,10 @@ describe "Exchange::Currency" do
           subject.floor.currency.should == :jpy
           subject.floor.should be_kind_of Exchange::Currency
         end
+        it "should not modify the base value" do
+          subject.floor.value.should == 40
+          subject.value.should == 40.723
+        end
       end
       context "with arguments" do
         it "should apply it to its number" do

data/spec/exchange/external_api/call_spec.rb

@@ -50,7 +50,7 @@ describe "Exchange::ExternalAPI::Call" do
     end
     it "should call the api and yield a block with the result" do
       Exchange::ExternalAPI::Call.new('XML_API', :format => :xml) do |result|
-        result.to_s.should == Nokogiri.parse(fixture('api_responses/example_xml_api.xml')).to_s
+        result.to_s.should == Nokogiri::XML.parse(fixture('api_responses/example_xml_api.xml').sub("\n", '')).to_s
       end
     end
     context "with http errors" do
@@ -61,7 +61,7 @@ describe "Exchange::ExternalAPI::Call" do
           @count == 3 ? mock('opened', :read => fixture('api_responses/example_xml_api.xml')) : raise(OpenURI::HTTPError.new('404', 'URI'))
         end
         Exchange::ExternalAPI::Call.new('XML_API', :format => :xml) do |result|
-          result.to_s.should == Nokogiri.parse(fixture('api_responses/example_xml_api.xml')).to_s
+          result.to_s.should == Nokogiri::XML.parse(fixture('api_responses/example_xml_api.xml').sub("\n", '')).to_s
         end
       end
       it "should raise if the maximum recall size is reached" do

data/spec/spec_helper.rb

@@ -11,7 +11,6 @@ rescue Bundler::BundlerError => e
   exit e.status_code
 end
 
-require 'shoulda'
 require 'exchange'
 
 module HelperMethods

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: exchange
 version: !ruby/object:Gem::Version
-  version: 0.6.0
+  version: 0.8.0
   prerelease: 
 platform: ruby
 authors:
@@ -9,16 +9,16 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-10-04 00:00:00.000000000 Z
+date: 2012-10-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
-  name: exchange
+  name: json
   requirement: !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 1.0.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -26,13 +26,13 @@ dependencies:
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 1.0.0
 - !ruby/object:Gem::Dependency
   name: yard
   requirement: !ruby/object:Gem::Requirement
     none: false
     requirements:
-    - - ~>
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: 0.7.4
   type: :development
@@ -40,7 +40,7 @@ dependencies:
   version_requirements: !ruby/object:Gem::Requirement
     none: false
     requirements:
-    - - ~>
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: 0.7.4
 - !ruby/object:Gem::Dependency
@@ -59,22 +59,6 @@ dependencies:
     - - ! '>='
       - !ruby/object:Gem::Version
         version: 1.0.0
-- !ruby/object:Gem::Dependency
-  name: jeweler
-  requirement: !ruby/object:Gem::Requirement
-    none: false
-    requirements:
-    - - ~>
-      - !ruby/object:Gem::Version
-        version: 1.8.3
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    none: false
-    requirements:
-    - - ~>
-      - !ruby/object:Gem::Version
-        version: 1.8.3
 description: ! "The Exchange Gem gives you easy access to currency functions directly
   on your Numbers. Imagine a conversion as easy as \n    1.eur.to_usd\n  or even better
   \n    1.eur.to_usd(:at => Time.now - 84600)\n  which gets you an exchange at the
@@ -82,11 +66,10 @@ description: ! "The Exchange Gem gives you easy access to currency functions dir
 email: exchange_gem@gmail.com
 executables: []
 extensions: []
-extra_rdoc_files:
-- LICENSE.txt
-- README.rdoc
+extra_rdoc_files: []
 files:
 - .document
+- .gitignore
 - .rspec
 - .travis.yml
 - Gemfile
@@ -94,8 +77,9 @@ files:
 - LICENSE.txt
 - README.rdoc
 - Rakefile
-- VERSION
 - changelog.rdoc
+- exchange-0.7.5.gem
+- exchange-0.7.6.gem
 - exchange.gemspec
 - iso4217.yml
 - lib/core_extensions/conversability.rb
@@ -158,9 +142,6 @@ required_ruby_version: !ruby/object:Gem::Requirement
   - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
-      segments:
-      - 0
-      hash: 595056188354575082
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
@@ -173,4 +154,29 @@ rubygems_version: 1.8.24
 signing_key: 
 specification_version: 3
 summary: Simple Exchange Rate operations for your ruby app
-test_files: []
+test_files:
+- spec/core_extensions/conversability_spec.rb
+- spec/exchange/cache/base_spec.rb
+- spec/exchange/cache/file_spec.rb
+- spec/exchange/cache/memcached_spec.rb
+- spec/exchange/cache/no_cache_spec.rb
+- spec/exchange/cache/rails_spec.rb
+- spec/exchange/cache/redis_spec.rb
+- spec/exchange/configuration_spec.rb
+- spec/exchange/currency_spec.rb
+- spec/exchange/external_api/base_spec.rb
+- spec/exchange/external_api/call_spec.rb
+- spec/exchange/external_api/currency_bot_spec.rb
+- spec/exchange/external_api/ecb_spec.rb
+- spec/exchange/external_api/xavier_media_spec.rb
+- spec/exchange/gem_loader_spec.rb
+- spec/exchange/helper_spec.rb
+- spec/exchange/iso_4217_spec.rb
+- spec/spec_helper.rb
+- spec/support/api_responses/example_ecb_xml_90d.xml
+- spec/support/api_responses/example_ecb_xml_daily.xml
+- spec/support/api_responses/example_ecb_xml_history.xml
+- spec/support/api_responses/example_historic_json.json
+- spec/support/api_responses/example_json_api.json
+- spec/support/api_responses/example_xml_api.xml
+has_rdoc: 

data/VERSION

@@ -1 +0,0 @@
-0.6.0