exchange 0.12.0 → 1.0.0

data/lib/exchange/money.rb

@@ -1,3 +1,4 @@
+# -*- encoding : utf-8 -*-
 # Top Level Module of the the gem.
 # @author Beat Richartz
 # @version 0.9
@@ -88,9 +89,17 @@ module Exchange
       if api_supports_currency?(other)
         opts = { :at => time, :from => self }.merge(options)
         Money.new(api.new.convert(value, currency, other, opts), other, opts)
+      elsif fallback!
+        to other, options
       else
         raise_no_rate_error(other)
       end
+    rescue ExternalAPI::APIError
+      if fallback!
+        to other, options
+      else
+        raise
+      end
     end
     alias :in :to
     
@@ -103,7 +112,8 @@ module Exchange
         #
         def install_operation op
           define_method op do |*precision|
-            Exchange::Money.new(ISO.send(op, self.value, self.currency, precision.first), currency, :at => time, :from => self)
+            psych = precision.first == :psych
+            Exchange::Money.new(ISO.send(op, self.value, self.currency, psych ? nil : precision.first, {:psych => psych}), currency, :at => time, :from => self)
           end
         end
       
@@ -296,18 +306,34 @@ module Exchange
     #   Exchange::Money.new(45, :jpy).to_s #=> "JPY 45"
     # @example Convert a currency with a three decimal minor to a string
     #   Exchange::Money.new(34.34, :omr).to_s #=> "OMR 34.340"
-    # @example Convert a currency to a string without the currency
-    #   Exchange::ISO.stringif(34.34, :omr).to_s(:iso) #=> "34.340"
+    # @example Convert a currency with a three decimal minor to a string with a currency symbol
+    #   Exchange::Money.new(34.34, :usd).to_s(:symbol) #=> "$34.34"
+    # @example Convert a currency with a three decimal minor to a string with just the amount
+    #   Exchange::Money.new(34.34, :omr).to_s(:amount) #=> "34.340"
     #
     def to_s format=:currency
-      [
-        format == :currency && ISO.stringify(value, currency),
-        format == :amount && ISO.stringify(value, currency, :amount_only => true)
-      ].detect{|l| l.is_a?(String) }
+      ISO.stringify(value, currency, :format => format)
     end
     
     private
     
+      # Fallback to the next api defined in the api fallbacks. Changes the api for the given instance
+      # @return [Boolean] true if the fallback was successful, false if not
+      # @since 1.0
+      # @version 1.0
+      #
+      def fallback!
+        fallback = Exchange.configuration.api.fallback
+        new_api  = fallback.index(api) ? fallback[fallback.index(api) + 1] : fallback.first
+        
+        if new_api
+          @api = new_api
+          return true
+        end
+        
+        return false
+      end
+    
       # determine if another given object is an instance of Exchange::Money
       # @param [Object] other The object to be tested against
       # @return [Boolean] true if the other is an instance of Exchange::Money, false if not
@@ -363,7 +389,7 @@ module Exchange
       # @version 0.7.2
       #
       def raise_no_rate_error other
-        raise NoRateError.new("Cannot convert to #{other} because the defined api does not provide a rate")
+        raise NoRateError.new("Cannot convert to #{other} because the defined api nor the fallbacks provide a rate")
       end
   
   end
@@ -372,4 +398,4 @@ module Exchange
   #
   ImplicitConversionError = Class.new(StandardError)
   
-end
+end

data/lib/exchange/typecasting.rb

@@ -1,3 +1,4 @@
+# -*- encoding : utf-8 -*-
 module Exchange
   
   # Allows to access properties of an object as currencies
@@ -159,4 +160,4 @@ module Exchange
     
   end
 
-end
+end

data/spec/exchange/cache/base_spec.rb

@@ -1,3 +1,4 @@
+# -*- encoding : utf-8 -*-
 require 'spec_helper'
 
 describe "Exchange::Cache::Base" do
@@ -26,4 +27,4 @@ describe "Exchange::Cache::Base" do
       end
     end
   end
-end
+end

data/spec/exchange/cache/configuration_spec.rb

@@ -1,3 +1,4 @@
+# -*- encoding : utf-8 -*-
 require 'spec_helper'
 
 describe "Exchange::Cache::Configuration" do
@@ -51,12 +52,14 @@ describe "Exchange::Cache::Configuration" do
       end
       it "should do so for the host" do
         subject.subclass.client.should_not be_nil
+        subject.subclass.client
         subject.subclass.instance.instance_variable_get("@client").should_not be_nil
         subject.host = 'new'
         subject.subclass.instance.instance_variable_get("@client").should be_nil
       end
       it "should do so for the port" do
         subject.subclass.client.should_not be_nil
+        subject.subclass.client
         subject.subclass.instance.instance_variable_get("@client").should_not be_nil
         subject.port = 112
         subject.subclass.instance.instance_variable_get("@client").should be_nil
@@ -91,4 +94,4 @@ describe "Exchange::Cache::Configuration" do
     end
   end
   
-end
+end

data/spec/exchange/cache/file_spec.rb

@@ -1,3 +1,4 @@
+# -*- encoding : utf-8 -*-
 require 'spec_helper'
 
 describe "Exchange::Cache::File" do
@@ -70,4 +71,4 @@ describe "Exchange::Cache::File" do
       end
     end
   end
-end
+end

data/spec/exchange/cache/memcached_spec.rb

@@ -1,3 +1,4 @@
+# -*- encoding : utf-8 -*-
 require 'spec_helper'
 
 describe "Exchange::CacheDalli::Client" do
@@ -119,4 +120,4 @@ describe "Exchange::CacheDalli::Client" do
       end
     end
   end
-end
+end

data/spec/exchange/cache/memory_spec.rb

@@ -1,3 +1,4 @@
+# -*- encoding : utf-8 -*-
 require 'spec_helper'
 
 describe "Exchange::Cache::Memory" do
@@ -37,7 +38,8 @@ describe "Exchange::Cache::Memory" do
     end
     it "should unset all expired instance variables" do
       subject.send(:clean!)
-      subject.instance_variables.reject{|i| i.to_s == "@helper" }.map{|i| subject.instance_variable_get(i) }.compact.sort_by(&:to_s).should == %W(Valid1 Valid2 Valid3 Valid4).sort
+      ivars = subject.instance_variables.reject{|i| i.to_s == "@helper" }.map{|i| subject.instance_variable_get(i) }.compact.sort_by(&:to_s)
+      ivars.select{|i| i.is_a?(String) }.should be_eql(%W(Valid1 Valid2 Valid3 Valid4))
     end
   end
   describe "cached" do
@@ -119,4 +121,4 @@ describe "Exchange::Cache::Memory" do
       end
     end
   end
-end
+end

data/spec/exchange/cache/no_cache_spec.rb

@@ -1,3 +1,4 @@
+# -*- encoding : utf-8 -*-
 require 'spec_helper'
 
 describe "Exchange::Cache::NoCache" do
@@ -20,4 +21,4 @@ describe "Exchange::Cache::NoCache" do
       lambda { subject.cached('API_CLASS') }.should raise_error(Exchange::Cache::CachingWithoutBlockError)
     end
   end
-end
+end

data/spec/exchange/cache/rails_spec.rb

@@ -1,3 +1,4 @@
+# -*- encoding : utf-8 -*-
 require 'spec_helper'
 
 describe "Exchange::Cache::Rails" do
@@ -67,4 +68,4 @@ describe "Exchange::Cache::Rails" do
       end
     end
   end
-end
+end

data/spec/exchange/cache/redis_spec.rb

@@ -1,3 +1,4 @@
+# -*- encoding : utf-8 -*-
 require 'spec_helper'
 require 'redis'
 
@@ -83,4 +84,4 @@ describe "Exchange::Cache::Redis" do
       end
     end
   end
-end
+end

data/spec/exchange/configuration_spec.rb

@@ -1,3 +1,4 @@
+# -*- encoding : utf-8 -*-
 require 'spec_helper'
 
 describe "Exchange::Configuration" do
@@ -28,7 +29,8 @@ describe "Exchange::Configuration" do
     Exchange.configuration = Exchange::Configuration.new {|c|
       c.api = {
         :subclass => :xavier_media,
-        :retries => 60
+        :retries => 60,
+        :fallback => :open_exchange_rates
       }
       c.cache = {
         :subclass => :redis
@@ -36,6 +38,7 @@ describe "Exchange::Configuration" do
     }
     Exchange.configuration.api.subclass.should == Exchange::ExternalAPI::XavierMedia
     Exchange.configuration.api.retries.should == 60
+    Exchange.configuration.api.fallback.should == [Exchange::ExternalAPI::OpenExchangeRates]
     Exchange.configuration.cache.subclass.should == Exchange::Cache::Redis
   end
   it "should allow to be set directly" do
@@ -66,6 +69,7 @@ describe "Exchange::Configuration" do
       subject.api.subclass.should == Exchange::ExternalAPI::XavierMedia
       subject.api.retries.should == 5
       subject.api.app_id.should be_nil
+      subject.api.fallback.should == [Exchange::ExternalAPI::Ecb]
       subject.cache.subclass.should == Exchange::Cache::Memory
       subject.cache.host.should be_nil
       subject.cache.port.should be_nil
@@ -76,4 +80,4 @@ describe "Exchange::Configuration" do
   after(:all) do
     Exchange.configuration.reset
   end  
-end
+end

data/spec/exchange/core_extensions/array/cachify_spec.rb

@@ -1,3 +1,4 @@
+# -*- encoding : utf-8 -*-
 require 'spec_helper'
 
 describe "Exchange::Cachify" do
@@ -9,4 +10,4 @@ describe "Exchange::Cachify" do
     end
   end
   
-end
+end

data/spec/exchange/core_extensions/float/error_safe_spec.rb

@@ -1,3 +1,4 @@
+# -*- encoding : utf-8 -*-
 require 'spec_helper'
 
 describe "Exchange::ErrorSafe" do
@@ -46,4 +47,4 @@ describe "Exchange::ErrorSafe" do
       end
     end
   end
-end
+end

data/spec/exchange/core_extensions/hash/cachify_spec.rb

@@ -1,3 +1,4 @@
+# -*- encoding : utf-8 -*-
 require 'spec_helper'
 
 describe "Exchange::Cachify" do
@@ -9,4 +10,4 @@ describe "Exchange::Cachify" do
     end
   end
   
-end
+end

data/spec/exchange/core_extensions/numeric/cachify_spec.rb

@@ -1,3 +1,4 @@
+# -*- encoding : utf-8 -*-
 require 'spec_helper'
 
 describe "Exchange::Cachify" do
@@ -23,4 +24,4 @@ describe "Exchange::Cachify" do
     end
   end
   
-end
+end

data/spec/exchange/core_extensions/numeric/conversability_spec.rb

@@ -1,3 +1,4 @@
+# -*- encoding : utf-8 -*-
 require 'spec_helper'
 
 describe "Exchange::Conversability" do
@@ -101,4 +102,4 @@ describe "Exchange::Conversability" do
       lambda { BigDecimal.new("3.25").in(:zzz) }.should raise_error(Exchange::NoCurrencyError, "zzz is not a currency nor a country code matchable to a currency")
     end
   end
-end
+end

data/spec/exchange/core_extensions/string/cachify_spec.rb

@@ -1,3 +1,4 @@
+# -*- encoding : utf-8 -*-
 require 'spec_helper'
 
 describe "Exchange::Cachify" do
@@ -56,4 +57,4 @@ describe "Exchange::Cachify" do
     end
   end
   
-end
+end

data/spec/exchange/core_extensions/symbol/cachify_spec.rb

@@ -1,3 +1,4 @@
+# -*- encoding : utf-8 -*-
 require 'spec_helper'
 
 describe "Exchange::Cachify" do
@@ -9,4 +10,4 @@ describe "Exchange::Cachify" do
     end
   end
   
-end
+end

data/spec/exchange/external_api/base_spec.rb

@@ -1,3 +1,4 @@
+# -*- encoding : utf-8 -*-
 require 'spec_helper'
 
 describe "Exchange::ExternalAPI::Base" do
@@ -36,4 +37,4 @@ describe "Exchange::ExternalAPI::Base" do
       subject.convert(80,:chf, :eur, :at => time).round(2).should == 49.6
     end
   end
-end
+end

data/spec/exchange/external_api/call_spec.rb

@@ -1,3 +1,4 @@
+# -*- encoding : utf-8 -*-
 require 'spec_helper'
 
 describe "Exchange::ExternalAPI::Call" do
@@ -81,4 +82,4 @@ describe "Exchange::ExternalAPI::Call" do
       end
     end
   end
-end
+end

data/spec/exchange/external_api/configuration_spec.rb

@@ -1,3 +1,4 @@
+# -*- encoding : utf-8 -*-
 require 'spec_helper'
 
 describe "Exchange::ExternalAPI::Configuration" do
@@ -23,14 +24,28 @@ describe "Exchange::ExternalAPI::Configuration" do
     end
   end
   
+  describe "fallback constantize" do
+    it "should automatically constantize a single fallback and wrap it in an array" do
+      subject.fallback = :xavier_media
+      
+      subject.fallback.should == [Exchange::ExternalAPI::XavierMedia]
+    end
+    it "should automatically constantize the fallbacks" do
+      subject.fallback = [:xavier_media, :random]
+      
+      subject.fallback.should == [Exchange::ExternalAPI::XavierMedia, Exchange::ExternalAPI::Random]
+    end
+  end
+  
   describe "set" do
     before(:each) do
-      @return = subject.set :subclass => :xavier_media, :retries => 55, :app_id => "KEY"
+      @return = subject.set :subclass => :xavier_media, :retries => 55, :app_id => "KEY", :fallback => [:random, :ecb]
     end
     it "should set the options given" do
       subject.subclass.should == Exchange::ExternalAPI::XavierMedia
       subject.retries.should == 55
       subject.app_id.should == 'KEY'
+      subject.fallback.should == [Exchange::ExternalAPI::Random, Exchange::ExternalAPI::Ecb]
     end
     it "should return self" do
       @return.should == subject
@@ -46,7 +61,8 @@ describe "Exchange::ExternalAPI::Configuration" do
       subject.subclass.should == Exchange::ExternalAPI::XavierMedia
       subject.retries.should == 5
       subject.app_id.should be_nil
+      subject.fallback.should == [Exchange::ExternalAPI::Ecb]
     end
   end
   
-end
+end

data/spec/exchange/external_api/ecb_spec.rb

@@ -1,3 +1,4 @@
+# -*- encoding : utf-8 -*-
 require 'spec_helper'
 
 describe "Exchange::ExternalAPI::Ecb" do
@@ -59,4 +60,4 @@ describe "Exchange::ExternalAPI::Ecb" do
       subject.convert(70, :sek, :usd, :at => Time.gm(2011,9,9)).round(2).should == 10.35
     end
   end
-end
+end

data/spec/exchange/external_api/open_exchange_rates_spec.rb

@@ -1,3 +1,4 @@
+# -*- encoding : utf-8 -*-
 require 'spec_helper'
 
 describe "Exchange::ExternalAPI::OpenExchangeRates" do
@@ -67,4 +68,4 @@ describe "Exchange::ExternalAPI::OpenExchangeRates" do
       subject.convert(70, :sek, :usd, :at => Time.gm(Time.now.year - 1,3,1)).round(2).should == 10.38
     end
   end
-end
+end

data/spec/exchange/external_api/random_spec.rb

@@ -0,0 +1,40 @@
+# -*- encoding : utf-8 -*-
+require 'spec_helper'
+
+describe "Exchange::ExternalAPI::OpenExchangeRates" do
+  before(:all) do
+    Exchange.configuration = Exchange::Configuration.new{|c|
+      c.cache = {
+        :subclass => :no_cache
+      }
+      c.api = {
+        :subclass => :random
+      }
+    }
+  end
+  after(:all) do
+    Exchange.configuration.reset
+  end
+  describe "updating rates" do
+    subject { Exchange::ExternalAPI::Random.new }
+    it "should have usd as base currency" do
+      subject.update
+      subject.base.should == :usd
+    end
+    it "should set the timestamp from time.now" do
+      time = Time.now
+      time.stub! :now => time
+      subject.update
+      subject.timestamp.should == time.to_i
+    end
+  end
+  describe "rates" do
+    subject { Exchange::ExternalAPI::Random.new }
+    it "should provide a rate for every ISO currency" do
+      subject.update
+      Exchange::ISO.currencies.each do |c|
+        subject.rates[c].should_not be_nil
+      end
+    end
+  end
+end