exceptions 0.0.10 → 0.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: b4185a231138c29c90b691eff7cc08d4242afa51
-  data.tar.gz: d1651725b49071006d7c0e815c2ab2baed52ab46
+  metadata.gz: 32152614d262fdc05078c5bd2d32c7275b08bb8a
+  data.tar.gz: c222e2cb33d29eb56ef99ea91cbe42ee39fcc8fe
 SHA512:
-  metadata.gz: e1d68b63aac5e2f604f74ad3285f37e4775c456b3232d83857a981c83b56e354ee8c96c8ddc380fb523a6a952477a4df6dd81008df6468a9dfedb430454aaf33
-  data.tar.gz: 65ff061af915bb17cf55b2b39dbbdc9da2be7723ad810367f394f632f01f8c5d817c3a574f45dccd261fd966b842abe284142dd049f97621550395782536c462
+  metadata.gz: d3daf06f4ff6e71d71d2611ebbbc446f913fce2e27fa1d164387a171425e5955eac66424f82e5a382c1ffa624eaa2a2bb0419dea62aa99013fba592ea46c55d7
+  data.tar.gz: 8c69200af84147b81ca52041fd9592c8346f025ed79c2de487161730361d7cee04391e8ecdb122f3010740451ab688d852cacc2e1434f7aa906f52d0b4c438ef

data/lib/exceptions.rb

@@ -13,6 +13,7 @@ module Exceptions
     autoload :Logger,      'exceptions/backends/logger'
     autoload :LogResult,   'exceptions/backends/log_result'
     autoload :Honeybadger, 'exceptions/backends/honeybadger'
+    autoload :Context,     'exceptions/backends/context'
   end
 
   class << self
@@ -40,13 +41,6 @@ module Exceptions
       backend.clear_context
     end
 
-    # Public: Notify a rack exception.
-    #
-    # Returns a Result object.
-    def rack_exception(exception, env)
-      backend.rack_exception exception, env
-    end
-
     # Public: The configuration object.
     #
     # Returns a Configuration instance.

data/lib/exceptions/backend.rb

@@ -28,12 +28,5 @@ module Exceptions
     # Returns nothing.
     def clear_context
     end
-
-    # Public: Called by the Rack middleware when an exception is raised.
-    #
-    # Returns and object satisfying the Result interface.
-    def rack_exception(exception, env)
-      notify(exception)
-    end
   end
 end

data/lib/exceptions/backends/context.rb

@@ -0,0 +1,27 @@
+module Exceptions
+  module Backends
+    # Public: Context is a middleware that will add the given context options
+    # whenever an exception is reported.
+    class Context < Backend
+      attr_reader :backend, :extra
+
+      def initialize(backend, context = {})
+        @backend = backend
+        @extra = context
+      end
+
+      def notify(exception, *args)
+        backend.context extra
+        backend.notify(exception, *args)
+      end
+
+      def context(*args)
+        backend.context(*args)
+      end
+
+      def clear_context(*args)
+        backend.clear_context(*args)
+      end
+    end
+  end
+end

data/lib/exceptions/backends/honeybadger.rb

@@ -12,6 +12,7 @@ module Exceptions
       end
 
       def notify(exception, options = {})
+        return if options[:rack_env] && rack_ignore?(options[:rack_env])
         defaults = { backtrace: caller.drop(1) }
         if id = honeybadger.notify_or_ignore(exception, defaults.merge(options))
           Result.new id
@@ -28,19 +29,21 @@ module Exceptions
         honeybadger.clear!
       end
 
-      def rack_exception(exception, env)
-        notify(exception, rack_env: env) unless honeybadger.
-          configuration.
-          ignore_user_agent.
-          flatten.
-          any? { |ua| ua === env['HTTP_USER_AGENT'] }
-      end
-
       class Result < ::Exceptions::Result
         def url
           "https://www.honeybadger.io/notice/#{id}"
         end
       end
+
+      private
+
+      def rack_ignore?(env)
+         return honeybadger.
+          configuration.
+          ignore_user_agent.
+          flatten.
+          any? { |ua| ua === env['HTTP_USER_AGENT'] }
+      end
     end
   end
 end

data/lib/exceptions/backends/log_result.rb

@@ -18,12 +18,6 @@ module Exceptions
         end
       end
 
-      def rack_exception(exception, env)
-        backend.rack_exception(exception, env).tap do |result|
-          log exception, result
-        end
-      end
-
       def context(*args)
         backend.context(*args)
       end

data/lib/exceptions/version.rb

@@ -1,3 +1,3 @@
 module Exceptions
-  VERSION = '0.0.10'
+  VERSION = '0.1.0'
 end

data/lib/rack/exceptions.rb

@@ -9,7 +9,7 @@ module Rack
       begin
         response = @app.call(env)
       rescue Exception => e
-        backend.rack_exception(e, env)
+        backend.notify(e, rack_env: env)
         raise
       end
 

data/spec/exceptions/backends/context_spec.rb

@@ -0,0 +1,16 @@
+require 'spec_helper'
+
+describe Exceptions::Backends::Context do
+  let(:backend) { double(Exceptions::Backend) }
+  let(:middleware) do
+    described_class.new backend, foo: 'bar'
+  end
+
+  describe '#notify' do
+    it 'sets the context' do
+      expect(backend).to receive(:context).with(foo: 'bar')
+      expect(backend).to receive(:notify).with(boom)
+      middleware.notify(boom)
+    end
+  end
+end

metadata

@@ -1,69 +1,69 @@
 --- !ruby/object:Gem::Specification
 name: exceptions
 version: !ruby/object:Gem::Version
-  version: 0.0.10
+  version: 0.1.0
 platform: ruby
 authors:
 - Eric J. Holmes
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-09-30 00:00:00.000000000 Z
+date: 2015-08-31 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '1.3'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '1.3'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: 3.1.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: 3.1.0
 - !ruby/object:Gem::Dependency
   name: honeybadger
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: 1.9.5
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: 1.9.5
 description: Exceptions is a Ruby gem for exception tracking.
@@ -73,9 +73,9 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- .gitignore
-- .rspec
-- .travis.yml
+- ".gitignore"
+- ".rspec"
+- ".travis.yml"
 - Gemfile
 - LICENSE
 - README.md
@@ -83,6 +83,7 @@ files:
 - exceptions.gemspec
 - lib/exceptions.rb
 - lib/exceptions/backend.rb
+- lib/exceptions/backends/context.rb
 - lib/exceptions/backends/honeybadger.rb
 - lib/exceptions/backends/log_result.rb
 - lib/exceptions/backends/logger.rb
@@ -93,6 +94,7 @@ files:
 - lib/exceptions/result.rb
 - lib/exceptions/version.rb
 - lib/rack/exceptions.rb
+- spec/exceptions/backends/context_spec.rb
 - spec/exceptions/backends/honeybadger/integration_spec.rb
 - spec/exceptions/backends/honeybadger_spec.rb
 - spec/exceptions/backends/log_result_spec.rb
@@ -111,21 +113,22 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.0.14
+rubygems_version: 2.4.5
 signing_key: 
 specification_version: 4
 summary: Exceptions is a Ruby gem for exception tracking.
 test_files:
+- spec/exceptions/backends/context_spec.rb
 - spec/exceptions/backends/honeybadger/integration_spec.rb
 - spec/exceptions/backends/honeybadger_spec.rb
 - spec/exceptions/backends/log_result_spec.rb