exceptional 2.0.3 → 2.0.4

data/exceptional.gemspec

@@ -1,7 +1,7 @@
 # -*- encoding: utf-8 -*-
 Gem::Specification.new do |s|
   s.name = %q{exceptional}
-  s.version = "2.0.3"
+  s.version = "2.0.4"
   s.authors = ["Contrast"]
   s.summary = %q{Exceptional is the core Ruby library for communicating with http://getexceptional.com (hosted error tracking service)}
   s.description = %q{Exceptional is the core Ruby library for communicating with http://getexceptional.com (hosted error tracking service). Use it to find out about errors that happen in your live app. It captures lots of helpful information to help you fix the errors.}

data/lib/exceptional/exception_data.rb

@@ -28,7 +28,7 @@ module Exceptional
 
     def context_stuff
       context = Thread.current[:exceptional_context]
-      context.blank? ? {} : {'context' => context}
+      (context.nil? || context.empty?) ? {} : {'context' => context}
     end
 
     def to_json
@@ -45,7 +45,7 @@ module Exceptional
     end
 
     def uniqueness_hash
-      return nil if @exception.backtrace.blank?
+      return nil if (@exception.backtrace.nil? || @exception.backtrace.empty?)
       Digest::MD5.hexdigest(@exception.backtrace.join)
     end
 

data/lib/exceptional/integration/tester.rb

@@ -4,11 +4,14 @@ module Exceptional
     end
 
     def self.test
-      data = Exceptional::ExceptionData.new(ExceptionalTestException.new, 'Test exception')
-      unless Exceptional::Remote.error(data)
-        puts "Problem sending exception to Exceptional. Check your API key."
-      else
-        puts "Exception sent successfully."
+      begin
+        raise ExceptionalTestException.new, 'Test exception'
+      rescue Exception => e
+        unless Exceptional::Remote.error(Exceptional::ExceptionData.new(e, "Test Exception"))
+          puts "Problem sending exception to Exceptional. Check your API key."
+        else
+          puts "Exception sent successfully."
+        end
       end
     end
   end

data/lib/exceptional/remote.rb

@@ -1,6 +1,7 @@
 require 'zlib'
 require 'cgi'
 require 'net/http'
+require 'net/https'
 require 'digest/md5'
 
 module Exceptional

data/spec/exceptional/exception_data_spec.rb

@@ -145,4 +145,18 @@ describe Exceptional::ControllerExceptionData, 'with request/controller/params'
     data = Exceptional::ControllerExceptionData.new(myException)
     data.uniqueness_hash.should == Digest::MD5.hexdigest('123')
   end
+  
+  it "creates a nil uniqueness_hash if nil backtrace" do
+    myException = Exception.new
+    myException.stub!(:backtrace).and_return(nil)
+    data = Exceptional::ControllerExceptionData.new(myException)    
+    data.uniqueness_hash.should == nil
+  end
+  
+  it "creates a uniqueness_hash from backtrace" do
+    myException = Exception.new
+    myException.stub!(:backtrace).and_return([])
+    data = Exceptional::ControllerExceptionData.new(myException)
+    data.uniqueness_hash.should == nil
+  end
 end

data/spec/rails_integration_spec.rb

@@ -14,6 +14,8 @@ describe ActiveSupport::JSON, 'standards compliant json' do
 end
 
 class TestingController < ActionController::Base
+  filter_parameter_logging :password, /credit_card/
+
   def raises_something
     raise StandardError
   end
@@ -34,6 +36,14 @@ describe TestingController do
     send_request(:raises_something)
     @response.code.should == '500'
   end
+
+  it "filters paramaters based on controller filter_parameter_logging" do
+    Exceptional::Config.stub!(:should_send_to_api?).and_return(true)
+    Exceptional::Remote.should_receive(:error) {|exception_data|
+      exception_data.to_hash['request']['parameters']['credit_card_number'].should == '[FILTERED]'
+    }
+    send_request(:raises_something, {:credit_card_number => '1234566777775453', :something_else => 'boo'})
+  end
 end
 
 if ActionController::Base.respond_to?(:rescue_from)

data/spec/spec_helper.rb

@@ -13,8 +13,10 @@ ENV['RAILS_ENV'] = 'test'
 require 'action_controller'
 require 'action_controller/test_process'
 
-def send_request(action = nil)
+def send_request(action = nil,params={})
   @request = ActionController::TestRequest.new
+  @request.query_parameters = @request.query_parameters.merge(params)
+  @request.stub!(:request_method).and_return('GET')
   @request.action = action ? action.to_s : ""
   @response = ActionController::TestResponse.new
   @controller.process(@request, @response)

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: exceptional
 version: !ruby/object:Gem::Version 
-  version: 2.0.3
+  version: 2.0.4
 platform: ruby
 authors: 
 - Contrast
@@ -9,7 +9,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2010-01-05 00:00:00 +00:00
+date: 2010-01-12 00:00:00 +00:00
 default_executable: 
 dependencies: []