exception_notification_sns 0.1.3 → 0.1.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 5dfa3cbc2642d58192e77af2ab359fbc91e04380
-  data.tar.gz: 247a9c6bb41940003843b49e431dee3b7af11698
+  metadata.gz: b730222081255bcfaef33ea92cc5e3e2a37837e7
+  data.tar.gz: 25631297661da6d0349211265eeb9024eed3c63c
 SHA512:
-  metadata.gz: d8179c127b1c723db16ccaad938e5050f54e890c1b0d656bc7efccc64fb7a0646ad215ca450e2af81fdb0f66aa2dbdb91f092f42a4b31463dbd7fb02a61efb5e
-  data.tar.gz: 5d3da8b0defc545cf15f18543f9e23ba9eff9065aab1d567184b89f6121cc5b86bc1f8536329150ba96cbcb1aaec9acd142e825f29f366c43cd60a54b3a03daa
+  metadata.gz: 8909bdc75d1d85431d497336d1b6d5019cb29981548bf46489f428bdac9b8c83384e25a8236b49838844f570916a92865a52dd5ebdb88797bd89d8cf0c003f3d
+  data.tar.gz: 0ebbed5b2ea7382fc6fa608d30e1c63984116eeb9afd078b7f190ec741f25c12209b5d720ece092f9d3179fcb2453f812d1ba8083a651b39d6c42bc12a3ac4bd

data/.rubocop.yml

@@ -0,0 +1,30 @@
+AllCops:
+ TargetRubyVersion: 2.2.2
+
+Style/Documentation:
+  Enabled: false
+
+Style/FrozenStringLiteralComment:
+  Enabled: false
+
+Style/Encoding:
+  Enabled: false
+
+Style/FormatStringToken:
+  EnforcedStyle: template
+
+Metrics/LineLength:
+  Max: 120
+
+Metrics/BlockLength:
+  CountComments: false  # count full line comments?
+  Max: 25
+  ExcludedMethods: ['describe', 'context', 'it', 'shared_examples', 'class_eval', 'post', 'get']
+  Exclude:
+    - config/**/*
+    - config/routes/*
+    - spec/factories/**/*
+
+Metrics/AbcSize:
+  Exclude:
+    - config/**/*

data/.ruby-version

@@ -0,0 +1 @@
+2.2.2

data/Gemfile

@@ -1,3 +1,3 @@
 source 'https://rubygems.org'
 
-gemspec
+gemspec

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    exception_notification_sns (0.1.3)
+    exception_notification_sns (0.1.4)
       aws-sdk-v1 (>= 1, < 3)
       exception_notification (= 4.2.1)
 
@@ -44,19 +44,13 @@ GEM
       thread_safe (~> 0.3, >= 0.3.4)
       tzinfo (~> 1.1)
     arel (6.0.4)
-    aws-sdk-v1 (1.66.0)
+    ast (2.4.0)
+    aws-sdk-v1 (1.67.0)
       json (~> 1.4)
-      nokogiri (>= 1.4.4)
+      nokogiri (~> 1)
     builder (3.2.3)
     concurrent-ruby (1.0.4)
-    coveralls (0.8.18)
-      json (>= 1.8, < 3)
-      simplecov (~> 0.12.0)
-      term-ansicolor (~> 1.3)
-      thor (~> 0.19.1)
-      tins (~> 1.6)
     diff-lcs (1.2.5)
-    docile (1.1.5)
     erubis (2.7.0)
     exception_notification (4.2.1)
       actionmailer (>= 4.0, < 6)
@@ -66,6 +60,7 @@ GEM
     globalid (0.3.7)
       activesupport (>= 4.1.0)
     i18n (0.7.0)
+    jaro_winkler (1.5.1)
     json (1.8.6)
     loofah (2.0.3)
       nokogiri (>= 1.5.9)
@@ -81,6 +76,10 @@ GEM
       metaclass (~> 0.0.1)
     nokogiri (1.7.0.1)
       mini_portile2 (~> 2.1.0)
+    parallel (1.12.1)
+    parser (2.5.1.0)
+      ast (~> 2.4.0)
+    powerpack (0.1.2)
     rack (1.6.5)
     rack-test (0.6.3)
       rack (>= 1.0)
@@ -108,6 +107,7 @@ GEM
       activesupport (= 4.2.7.1)
       rake (>= 0.8.7)
       thor (>= 0.18.1, < 2.0)
+    rainbow (3.0.0)
     rake (12.0.0)
     rspec (3.4.0)
       rspec-core (~> 3.4.0)
@@ -122,11 +122,15 @@ GEM
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.4.0)
     rspec-support (3.4.1)
-    simplecov (0.12.0)
-      docile (~> 1.1.0)
-      json (>= 1.8, < 3)
-      simplecov-html (~> 0.10.0)
-    simplecov-html (0.10.0)
+    rubocop (0.57.2)
+      jaro_winkler (~> 1.5.1)
+      parallel (~> 1.10)
+      parser (>= 2.5)
+      powerpack (~> 0.1)
+      rainbow (>= 2.2.2, < 4.0)
+      ruby-progressbar (~> 1.7)
+      unicode-display_width (~> 1.0, >= 1.0.1)
+    ruby-progressbar (1.9.0)
     sprockets (3.7.1)
       concurrent-ruby (~> 1.0)
       rack (> 1, < 3)
@@ -135,25 +139,23 @@ GEM
       activesupport (>= 4.0)
       sprockets (>= 3.0.0)
     sqlite3 (1.3.10)
-    term-ansicolor (1.4.0)
-      tins (~> 1.0)
     thor (0.19.4)
     thread_safe (0.3.5)
-    tins (1.13.0)
     tzinfo (1.2.2)
       thread_safe (~> 0.1)
+    unicode-display_width (1.4.0)
 
 PLATFORMS
   ruby
 
 DEPENDENCIES
-  coveralls (~> 0.8.2)
   exception_notification_sns!
   factory_girl (= 4.5)
   mocha (~> 0.13.0)
   rails (>= 4.0.0, < 6)
   rspec (= 3.4.0)
+  rubocop (~> 0.52)
   sqlite3 (= 1.3.10)
 
 BUNDLED WITH
-   1.13.7
+   1.16.2

data/README.md

@@ -25,7 +25,8 @@ Rails.application.config.middleware.use ExceptionNotification::Rack,
     access_key_id: 'AWS_ACCESS_KEY_ID',
     secret_access_key: 'AWS_SECRET_ACCESS_KEY',
     region: 'AWS_REGION',
-    topic_arn: 'AWS_SNS_TOPIC_ARN'
+    topic_arn: 'AWS_SNS_TOPIC_ARN',
+    subject: 'MESSAGE SUBJECT'
   }
 ```
 
@@ -55,14 +56,16 @@ AWS region
 
 AWS SNS topic arn
 
-## Extras 
-
-For more information about exception_notification gem on which this gem was built, visit [exception_notification](https://github.com/smartinez87/exception_notification).
+##### subject
 
-## License
+*String*
 
-Copyright (c) 2017 Matej Minažek, released under the [MIT license](http://www.opensource.org/licenses/MIT).
+Notification subject
 
+## Extras 
 
+For more information about exception_notification gem on which this gem was built, visit [exception_notification](https://github.com/smartinez87/exception_notification).
 
+## License
 
+Copyright (c) 2019 Matej Minažek, released under the [MIT license](http://www.opensource.org/licenses/MIT).

data/Rakefile

@@ -5,11 +5,11 @@ require 'appraisal'
 
 require 'rake/testtask'
 
-task :default => [:test]
+task default: [:test]
 
 Rake::TestTask.new(:test) do |t|
   t.libs << 'lib'
   t.libs << 'test'
   t.pattern = 'test/**/*_test.rb'
   t.verbose = true
-end
+end

data/exception_notification_sns.gemspec

@@ -1,11 +1,12 @@
-# encoding: UTF-8
 Gem::Specification.new do |s|
   s.platform    = Gem::Platform::RUBY
   s.name        = 'exception_notification_sns'
-  s.version     = '0.1.3'
+  s.version     = '0.1.4'
   s.summary     = 'exception_notification extension for aws sns v1'
-  s.description = 'exception_notification_sns gem is used for sending application extensions to aws sns. It extends exception_notification gem, uses aws-sdk-v1 gem to push exception notificatons to amazon sns'
-  s.required_ruby_version = '>= 2.2.0'
+  s.description = 'exception_notification_sns gem is used for sending application extensions to aws sns.
+                   It extends exception_notification gem, uses aws-sdk-v1 gem to push exception notificatons
+                   to amazon sns'
+  s.required_ruby_version = '>= 2.2.2'
 
   s.author    = 'Matej Minažek'
   s.email     = 'matej.minazek@ingemark.com'
@@ -15,14 +16,13 @@ Gem::Specification.new do |s|
   s.files = `git ls-files`.split("\n")
   s.require_path = 'lib'
 
-  s.add_runtime_dependency 'exception_notification', '4.2.1'
   s.add_runtime_dependency 'aws-sdk-v1', '>= 1', '< 3'
+  s.add_runtime_dependency 'exception_notification', '4.2.1'
 
-  s.add_development_dependency 'rails', '>= 4.0.0', '< 6'
   s.add_development_dependency 'factory_girl', '4.5'
-  s.add_development_dependency 'rspec', '3.4.0'
   s.add_development_dependency 'mocha', '~> 0.13.0'
+  s.add_development_dependency 'rails', '>= 4.0.0', '< 6'
+  s.add_development_dependency 'rspec', '3.4.0'
+  s.add_development_dependency 'rubocop', '~> 0.52'
   s.add_development_dependency 'sqlite3', '1.3.10'
-  s.add_development_dependency 'coveralls', '~> 0.8.2'
-
 end

data/lib/exception_notification_sns.rb

@@ -1,4 +1,4 @@
 require 'exception_notification'
 require 'aws-sdk-v1'
 
-require 'exception_notifier/sns_notifier'
+require 'exception_notifier/sns_notifier'

data/lib/exception_notifier/sns_notifier.rb

@@ -6,16 +6,20 @@ module ExceptionNotifier
 
     def initialize(options)
       super
+
       access_key_id = options.delete(:access_key_id)
       secret_access_key = options.delete(:secret_access_key)
       region = options.delete(:region)
 
-      @sns_client = AWS::SNS::Client.new(access_key_id: access_key_id, secret_access_key: secret_access_key, region: region)
+      @sns_client = AWS::SNS::Client.new(access_key_id: access_key_id,
+                                         secret_access_key: secret_access_key,
+                                         region: region)
       @topic_arn = options.delete(:topic_arn)
+      @subject = options.delete(:subject)
     end
 
-    def call(exception, options={})
-      return if !active?
+    def call(exception, options = {})
+      return unless active?
 
       env = options[:env] || {}
       @options = options
@@ -24,10 +28,7 @@ module ExceptionNotifier
       @kontroller = env['action_controller.instance']
       @request = ::ActionDispatch::Request.new(env) if @kontroller
 
-      @sns_client.publish({
-                              topic_arn: @topic_arn,
-                              message: compose_message.to_json
-                          })
+      @sns_client.publish(topic_arn: @topic_arn, message: compose_message.to_json, subject: @subject)
     end
 
     def active?
@@ -42,21 +43,22 @@ module ExceptionNotifier
 
     def compose_message
       message = {
-          info: compose_info,
-          backtrace: @backtrace.to_s,
-          default: compose_info
+        info: compose_info,
+        backtrace: @backtrace.to_s,
+        default: compose_info
       }
-
-      message[:request] = {
-          url: @request.url,
-          method: @request.request_method,
-          remote_ip: @request.remote_ip,
-          parameters: @request.filtered_parameters.inspect
-      } if @request
+      message[:request] = request_data if @request
 
       message
     end
+
+    def request_data
+      {
+        url: @request.url,
+        method: @request.request_method,
+        remote_ip: @request.remote_ip,
+        parameters: @request.filtered_parameters.inspect
+      }
+    end
   end
 end
-
-

data/spec/exception_notifer/sns_notifer_spec.rb

@@ -1,30 +1,30 @@
 require 'spec_helper'
 require 'exception_notifier/sns_notifier'
 
-describe 'SNS Notifer' do
-
-  before(:each) do
-    options = {
-        access_key_id: 'acces_key',
-        secret_access_key: 'secret_access_key',
-        topic_arn: 'topic_arn',
-        region: 'region'
+describe 'SNS Notifier' do
+  let(:options) do
+    {
+      access_key_id: 'acces_key',
+      secret_access_key: 'secret_access_key',
+      topic_arn: 'topic_arn',
+      region: 'region',
+      subject: 'notification_subject'
     }
-
-    @sns = ExceptionNotifier::SnsNotifier.new(options)
   end
 
+  subject { ExceptionNotifier::SnsNotifier.new(options) }
+
   it 'should send exception notification to sns if properly configured' do
-    @sns.call(fake_exception)
+    subject.call(fake_exception)
   end
 
-  it 'should compose correct message and subject' do
-    @sns.call(fake_exception)
+  it 'should compose correct message' do
+    subject.call(fake_exception)
 
-    composed_info = @sns.compose_info
+    composed_info = subject.compose_info
     expect(composed_info).to eq fake_info
 
-    composed_message = @sns.compose_message
+    composed_message = subject.compose_message
     expect(composed_message[:backtrace]).not_to be_nil
     expect(composed_message[:default]).not_to be_nil
   end
@@ -33,8 +33,8 @@ describe 'SNS Notifer' do
 
   def fake_message
     {
-        backtrace: fake_exception.backtrace.to_s,
-        default: fake_subject
+      backtrace: fake_exception.backtrace.to_s,
+      default: fake_subject
     }
   end
 
@@ -43,14 +43,9 @@ describe 'SNS Notifer' do
     info << " #{fake_exception.message.inspect}"
   end
 
-
   def fake_exception
-    begin
-      5/0
-    rescue Exception => e
-      e
-    end
+    5 / 0
+  rescue StandardError => e
+    e
   end
-
-
-end
+end

data/spec/spec_helper.rb

@@ -1,8 +1,8 @@
 # load lib in LOAD_PATH
-$:<< File.join(File.dirname(__FILE__), '../lib')
+$LOAD_PATH << File.join(File.dirname(__FILE__), '../lib')
 
 # Configure Rails Environment
-ENV["RAILS_ENV"] = "test"
+ENV['RAILS_ENV'] = 'test'
 
 require 'rspec'
 
@@ -14,5 +14,4 @@ ExceptionNotifier.testing_mode!
 AWS.stub!
 
 RSpec.configure do |config|
-
-end
+end

metadata

@@ -1,29 +1,15 @@
 --- !ruby/object:Gem::Specification
 name: exception_notification_sns
 version: !ruby/object:Gem::Version
-  version: 0.1.3
+  version: 0.1.4
 platform: ruby
 authors:
 - Matej Minažek
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-01-19 00:00:00.000000000 Z
+date: 2019-01-10 00:00:00.000000000 Z
 dependencies:
-- !ruby/object:Gem::Dependency
-  name: exception_notification
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - '='
-      - !ruby/object:Gem::Version
-        version: 4.2.1
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - '='
-      - !ruby/object:Gem::Version
-        version: 4.2.1
 - !ruby/object:Gem::Dependency
   name: aws-sdk-v1
   requirement: !ruby/object:Gem::Requirement
@@ -45,25 +31,19 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '3'
 - !ruby/object:Gem::Dependency
-  name: rails
+  name: exception_notification
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 4.0.0
-    - - "<"
+    - - '='
       - !ruby/object:Gem::Version
-        version: '6'
-  type: :development
+        version: 4.2.1
+  type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 4.0.0
-    - - "<"
+    - - '='
       - !ruby/object:Gem::Version
-        version: '6'
+        version: 4.2.1
 - !ruby/object:Gem::Dependency
   name: factory_girl
   requirement: !ruby/object:Gem::Requirement
@@ -79,72 +59,94 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '4.5'
 - !ruby/object:Gem::Dependency
-  name: rspec
+  name: mocha
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '='
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 3.4.0
+        version: 0.13.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '='
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 3.4.0
+        version: 0.13.0
 - !ruby/object:Gem::Dependency
-  name: mocha
+  name: rails
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 0.13.0
+        version: 4.0.0
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '6'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 0.13.0
+        version: 4.0.0
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '6'
 - !ruby/object:Gem::Dependency
-  name: sqlite3
+  name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 1.3.10
+        version: 3.4.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 1.3.10
+        version: 3.4.0
 - !ruby/object:Gem::Dependency
-  name: coveralls
+  name: rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.8.2
+        version: '0.52'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.8.2
-description: exception_notification_sns gem is used for sending application extensions
-  to aws sns. It extends exception_notification gem, uses aws-sdk-v1 gem to push exception
-  notificatons to amazon sns
+        version: '0.52'
+- !ruby/object:Gem::Dependency
+  name: sqlite3
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '='
+      - !ruby/object:Gem::Version
+        version: 1.3.10
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '='
+      - !ruby/object:Gem::Version
+        version: 1.3.10
+description: |-
+  exception_notification_sns gem is used for sending application extensions to aws sns.
+                     It extends exception_notification gem, uses aws-sdk-v1 gem to push exception notificatons
+                     to amazon sns
 email: matej.minazek@ingemark.com
 executables: []
 extensions: []
 extra_rdoc_files: []
 files:
 - ".gitignore"
+- ".rubocop.yml"
 - ".ruby-gemset"
-- ".ruby-verson"
+- ".ruby-version"
 - Gemfile
 - Gemfile.lock
 - LICENSE
@@ -167,7 +169,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: 2.2.0
+      version: 2.2.2
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="

data/.ruby-verson

@@ -1 +0,0 @@
-2.2.0