exception_notification 4.5.0 → 5.0.0

data/test/exception_notifier_test.rb

@@ -1,10 +1,13 @@
 # frozen_string_literal: true
 
-require 'test_helper'
+require "test_helper"
 
 class ExceptionOne < StandardError; end
+
 class ExceptionTwo < StandardError; end
 
+class StandardErrorSubclass < StandardError; end
+
 class ExceptionNotifierTest < ActiveSupport::TestCase
   setup do
     ExceptionNotifier.register_exception_notifier(:email, exception_recipients: %w[dummyexceptions@example.com])
@@ -19,25 +22,27 @@ class ExceptionNotifierTest < ActiveSupport::TestCase
     Rails.cache.clear if defined?(Rails) && Rails.respond_to?(:cache)
   end
 
-  test 'should have default ignored exceptions' do
+  test "should have default ignored exceptions" do
     assert_equal ExceptionNotifier.ignored_exceptions,
-                 ['ActiveRecord::RecordNotFound', 'Mongoid::Errors::DocumentNotFound',
-                  'AbstractController::ActionNotFound', 'ActionController::RoutingError',
-                  'ActionController::UnknownFormat', 'ActionController::UrlGenerationError']
+      ["ActiveRecord::RecordNotFound", "Mongoid::Errors::DocumentNotFound",
+        "AbstractController::ActionNotFound", "ActionController::RoutingError",
+        "ActionController::UnknownFormat", "ActionController::UrlGenerationError",
+        "ActionDispatch::Http::MimeNegotiation::InvalidType",
+        "Rack::Utils::InvalidParameterError"]
   end
 
-  test 'should have email notifier registered' do
+  test "should have email notifier registered" do
     assert_equal ExceptionNotifier.notifiers, [:email]
   end
 
-  test 'should have a valid email notifier' do
+  test "should have a valid email notifier" do
     @email_notifier = ExceptionNotifier.registered_exception_notifier(:email)
     refute_nil @email_notifier
     assert_equal @email_notifier.class, ExceptionNotifier::EmailNotifier
     assert_respond_to @email_notifier, :call
   end
 
-  test 'should allow register/unregister another notifier' do
+  test "should allow register/unregister another notifier" do
     called = false
     proc_notifier = ->(_exception, _options) { called = true }
     ExceptionNotifier.register_exception_notifier(:proc, proc_notifier)
@@ -53,7 +58,7 @@ class ExceptionNotifierTest < ActiveSupport::TestCase
     assert_equal ExceptionNotifier.notifiers, [:email]
   end
 
-  test 'should allow select notifiers to send error to' do
+  test "should allow select notifiers to send error to" do
     notifier1_calls = 0
     notifier1 = ->(_exception, _options) { notifier1_calls += 1 }
     ExceptionNotifier.register_exception_notifier(:notifier1, notifier1)
@@ -82,10 +87,10 @@ class ExceptionNotifierTest < ActiveSupport::TestCase
     assert_equal ExceptionNotifier.notifiers, [:email]
   end
 
-  test 'should ignore exception if satisfies conditional ignore' do
-    env = 'production'
+  test "should ignore exception if satisfies conditional ignore" do
+    env = "production"
     ExceptionNotifier.ignore_if do |_exception, _options|
-      env != 'production'
+      env != "production"
     end
 
     ExceptionNotifier.register_exception_notifier(:test, @test_notifier)
@@ -95,12 +100,12 @@ class ExceptionNotifierTest < ActiveSupport::TestCase
     ExceptionNotifier.notify_exception(exception, notifiers: :test)
     assert_equal @notifier_calls, 1
 
-    env = 'development'
+    env = "development"
     ExceptionNotifier.notify_exception(exception, notifiers: :test)
     assert_equal @notifier_calls, 1
   end
 
-  test 'should ignore exception if satisfies by-notifier conditional ignore' do
+  test "should ignore exception if satisfies by-notifier conditional ignore" do
     notifier1_calls = 0
     notifier1 = ->(_exception, _options) { notifier1_calls += 1 }
     ExceptionNotifier.register_exception_notifier(:notifier1, notifier1)
@@ -109,12 +114,12 @@ class ExceptionNotifierTest < ActiveSupport::TestCase
     notifier2 = ->(_exception, _options) { notifier2_calls += 1 }
     ExceptionNotifier.register_exception_notifier(:notifier2, notifier2)
 
-    env = 'production'
+    env = "production"
     ExceptionNotifier.ignore_notifier_if(:notifier1) do |_exception, _options|
-      env == 'development'
+      env == "development"
     end
     ExceptionNotifier.ignore_notifier_if(:notifier2) do |_exception, _options|
-      env == 'production'
+      env == "production"
     end
 
     exception = StandardError.new
@@ -123,20 +128,20 @@ class ExceptionNotifierTest < ActiveSupport::TestCase
     assert_equal notifier1_calls, 1
     assert_equal notifier2_calls, 0
 
-    env = 'development'
+    env = "development"
 
     ExceptionNotifier.notify_exception(exception)
     assert_equal notifier1_calls, 1
     assert_equal notifier2_calls, 1
 
-    env = 'test'
+    env = "test"
 
     ExceptionNotifier.notify_exception(exception)
     assert_equal notifier1_calls, 2
     assert_equal notifier2_calls, 2
   end
 
-  test 'should return false if all the registered notifiers are ignored' do
+  test "should return false if all the registered notifiers are ignored" do
     ExceptionNotifier.notifiers.each do |notifier|
       # make sure to register no other notifiers but the tested ones
       ExceptionNotifier.unregister_exception_notifier(notifier)
@@ -152,12 +157,12 @@ class ExceptionNotifierTest < ActiveSupport::TestCase
       exception.message =~ /non_critical_error/
     end
 
-    exception = StandardError.new('a non_critical_error occured.')
+    exception = StandardError.new("a non_critical_error occured.")
 
     refute ExceptionNotifier.notify_exception(exception)
   end
 
-  test 'should return true if one of the notifiers fires' do
+  test "should return true if one of the notifiers fires" do
     ExceptionNotifier.notifiers.each do |notifier|
       # make sure to register no other notifiers but the tested ones
       ExceptionNotifier.unregister_exception_notifier(notifier)
@@ -170,12 +175,12 @@ class ExceptionNotifierTest < ActiveSupport::TestCase
       exception.message =~ /non-critical\serror/
     end
 
-    exception = StandardError.new('a non-critical error occured')
+    exception = StandardError.new("a non-critical error occured")
 
     assert ExceptionNotifier.notify_exception(exception)
   end
 
-  test 'should not send notification if one of ignored exceptions' do
+  test "should not send notification if one of ignored exceptions" do
     ExceptionNotifier.register_exception_notifier(:test, @test_notifier)
 
     exception = StandardError.new
@@ -183,29 +188,27 @@ class ExceptionNotifierTest < ActiveSupport::TestCase
     ExceptionNotifier.notify_exception(exception, notifiers: :test)
     assert_equal @notifier_calls, 1
 
-    ExceptionNotifier.notify_exception(exception, notifiers: :test, ignore_exceptions: 'StandardError')
+    ExceptionNotifier.notify_exception(exception, notifiers: :test, ignore_exceptions: "StandardError")
     assert_equal @notifier_calls, 1
   end
 
-  test 'should not send notification if subclass of one of ignored exceptions' do
+  test "should not send notification if subclass of one of ignored exceptions" do
     ExceptionNotifier.register_exception_notifier(:test, @test_notifier)
 
-    class StandardErrorSubclass < StandardError
-    end
-
     exception = StandardErrorSubclass.new
 
     ExceptionNotifier.notify_exception(exception, notifiers: :test)
     assert_equal @notifier_calls, 1
 
-    ExceptionNotifier.notify_exception(exception, notifiers: :test, ignore_exceptions: 'StandardError')
+    ExceptionNotifier.notify_exception(exception, notifiers: :test, ignore_exceptions: "StandardError")
     assert_equal @notifier_calls, 1
   end
 
-  test 'should not send notification if extended module one of ignored exceptions' do
+  test "should not send notification if extended module one of ignored exceptions" do
     ExceptionNotifier.register_exception_notifier(:test, @test_notifier)
 
-    module StandardErrorModule; end
+    # Define module at runtime
+    Object.const_set(:StandardErrorModule, Module.new)
 
     exception = StandardError.new
     exception.extend StandardErrorModule
@@ -213,15 +216,19 @@ class ExceptionNotifierTest < ActiveSupport::TestCase
     ExceptionNotifier.notify_exception(exception, notifiers: :test)
     assert_equal @notifier_calls, 1
 
-    ignore_exceptions = 'ExceptionNotifierTest::StandardErrorModule'
+    ignore_exceptions = "StandardErrorModule"
     ExceptionNotifier.notify_exception(exception, notifiers: :test, ignore_exceptions: ignore_exceptions)
     assert_equal @notifier_calls, 1
+  ensure
+    # Clean up by removing the module
+    Object.send(:remove_const, :StandardErrorModule)
   end
 
-  test 'should not send notification if prepended module at singleton class one of ignored exceptions' do
+  test "should not send notification if prepended module at singleton class one of ignored exceptions" do
     ExceptionNotifier.register_exception_notifier(:test, @test_notifier)
 
-    module StandardErrorModule; end
+    # Define module at runtime
+    Object.const_set(:StandardErrorModule, Module.new)
 
     exception = StandardError.new
     exception.singleton_class.prepend StandardErrorModule
@@ -229,12 +236,15 @@ class ExceptionNotifierTest < ActiveSupport::TestCase
     ExceptionNotifier.notify_exception(exception, notifiers: :test)
     assert_equal @notifier_calls, 1
 
-    ignore_exceptions = 'ExceptionNotifierTest::StandardErrorModule'
+    ignore_exceptions = "StandardErrorModule"
     ExceptionNotifier.notify_exception(exception, notifiers: :test, ignore_exceptions: ignore_exceptions)
     assert_equal @notifier_calls, 1
+  ensure
+    # Clean up by removing the module
+    Object.send(:remove_const, :StandardErrorModule)
   end
 
-  test 'should call received block' do
+  test "should call received block" do
     @block_called = false
     notifier = ->(_exception, _options, &block) { block.call }
     ExceptionNotifier.register_exception_notifier(:test, notifier)
@@ -248,7 +258,7 @@ class ExceptionNotifierTest < ActiveSupport::TestCase
     assert @block_called
   end
 
-  test 'should not call group_error! or send_notification? if error_grouping false' do
+  test "should not call group_error! or send_notification? if error_grouping false" do
     exception = StandardError.new
     ExceptionNotifier.expects(:group_error!).never
     ExceptionNotifier.expects(:send_notification?).never
@@ -256,7 +266,7 @@ class ExceptionNotifierTest < ActiveSupport::TestCase
     ExceptionNotifier.notify_exception(exception)
   end
 
-  test 'should call group_error! and send_notification? if error_grouping true' do
+  test "should call group_error! and send_notification? if error_grouping true" do
     ExceptionNotifier.error_grouping = true
 
     exception = StandardError.new
@@ -266,7 +276,7 @@ class ExceptionNotifierTest < ActiveSupport::TestCase
     ExceptionNotifier.notify_exception(exception)
   end
 
-  test 'should skip notification if send_notification? is false' do
+  test "should skip notification if send_notification? is false" do
     ExceptionNotifier.error_grouping = true
 
     exception = StandardError.new
@@ -276,7 +286,7 @@ class ExceptionNotifierTest < ActiveSupport::TestCase
     refute ExceptionNotifier.notify_exception(exception)
   end
 
-  test 'should send notification if send_notification? is true' do
+  test "should send notification if send_notification? is true" do
     ExceptionNotifier.error_grouping = true
 
     exception = StandardError.new

data/test/test_helper.rb

@@ -1,19 +1,16 @@
 # frozen_string_literal: true
 
-require 'coveralls'
-Coveralls.wear!
+$LOAD_PATH.unshift File.expand_path("../lib", __dir__)
+require "exception_notification"
 
-$LOAD_PATH.unshift File.expand_path('../lib', __dir__)
-require 'exception_notification'
-
-require 'minitest/autorun'
-require 'mocha/minitest'
-require 'active_support/test_case'
-require 'action_mailer'
+require "minitest/autorun"
+require "mocha/minitest"
+require "active_support/test_case"
+require "action_mailer"
 
 ExceptionNotifier.testing_mode!
-require 'support/exception_notifier_helper'
+require "support/exception_notifier_helper"
 
-Time.zone = 'UTC'
+Time.zone = "UTC"
 ActionMailer::Base.delivery_method = :test
 ActionMailer::Base.append_view_path "#{File.dirname(__FILE__)}/support/views"

metadata

@@ -1,15 +1,16 @@
 --- !ruby/object:Gem::Specification
 name: exception_notification
 version: !ruby/object:Gem::Version
-  version: 4.5.0
+  version: 5.0.0
 platform: ruby
 authors:
 - Jamis Buck
 - Josh Peek
-autorequire: 
+- Sebastián Martínez
+- Kevin McPhillips
 bindir: bin
 cert_chain: []
-date: 2022-01-20 00:00:00.000000000 Z
+date: 2025-03-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: actionmailer
@@ -17,54 +18,40 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '5.2'
+        version: '7.1'
     - - "<"
       - !ruby/object:Gem::Version
-        version: '8'
+        version: '9'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '5.2'
+        version: '7.1'
     - - "<"
       - !ruby/object:Gem::Version
-        version: '8'
+        version: '9'
 - !ruby/object:Gem::Dependency
   name: activesupport
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '5.2'
+        version: '7.1'
     - - "<"
       - !ruby/object:Gem::Version
-        version: '8'
+        version: '9'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '5.2'
+        version: '7.1'
     - - "<"
       - !ruby/object:Gem::Version
-        version: '8'
-- !ruby/object:Gem::Dependency
-  name: appraisal
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 2.2.0
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 2.2.0
+        version: '9'
 - !ruby/object:Gem::Dependency
   name: aws-sdk-sns
   requirement: !ruby/object:Gem::Requirement
@@ -93,20 +80,6 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: 0.7.0
-- !ruby/object:Gem::Dependency
-  name: coveralls
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 0.8.2
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 0.8.2
 - !ruby/object:Gem::Dependency
   name: dogapi
   requirement: !ruby/object:Gem::Requirement
@@ -191,26 +164,40 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: ostruct
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rails
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '5.2'
+        version: '7.1'
     - - "<"
       - !ruby/object:Gem::Version
-        version: '8'
+        version: '9'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '5.2'
+        version: '7.1'
     - - "<"
       - !ruby/object:Gem::Version
-        version: '8'
+        version: '9'
 - !ruby/object:Gem::Dependency
   name: resque
   requirement: !ruby/object:Gem::Requirement
@@ -226,47 +213,47 @@ dependencies:
       - !ruby/object:Gem::Version
         version: 1.8.0
 - !ruby/object:Gem::Dependency
-  name: rubocop
+  name: sidekiq
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '='
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 0.78.0
+        version: 5.0.4
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '='
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 0.78.0
+        version: 5.0.4
 - !ruby/object:Gem::Dependency
-  name: sidekiq
+  name: slack-notifier
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 5.0.4
+        version: 1.0.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 5.0.4
+        version: 1.0.0
 - !ruby/object:Gem::Dependency
-  name: slack-notifier
+  name: standard
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 1.0.0
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 1.0.0
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: timecop
   requirement: !ruby/object:Gem::Requirement
@@ -281,17 +268,16 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: 0.9.0
-description: 
-email: smartinez87@gmail.com
+email: github@kevinmcphillips.ca
 executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- Appraisals
 - CHANGELOG.rdoc
 - CODE_OF_CONDUCT.md
 - CONTRIBUTING.md
 - Gemfile
+- Gemfile.lock
 - MIT-LICENSE
 - README.md
 - Rakefile
@@ -307,21 +293,16 @@ files:
 - docs/notifiers/sns.md
 - docs/notifiers/teams.md
 - docs/notifiers/webhook.md
-- examples/sample_app.rb
-- examples/sinatra/Gemfile
-- examples/sinatra/Gemfile.lock
-- examples/sinatra/Procfile
-- examples/sinatra/README.md
-- examples/sinatra/config.ru
-- examples/sinatra/sinatra_app.rb
 - exception_notification.gemspec
-- gemfiles/rails5_2.gemfile
-- gemfiles/rails6_0.gemfile
-- gemfiles/rails6_1.gemfile
-- gemfiles/rails7_0.gemfile
+- gemfiles/pinned_dependencies.gemfile
+- gemfiles/rails7_1.gemfile
+- gemfiles/rails7_2.gemfile
+- gemfiles/rails8_0.gemfile
 - lib/exception_notification.rb
 - lib/exception_notification/rack.rb
 - lib/exception_notification/rails.rb
+- lib/exception_notification/rails/runner_tie.rb
+- lib/exception_notification/rake.rb
 - lib/exception_notification/resque.rb
 - lib/exception_notification/sidekiq.rb
 - lib/exception_notification/version.rb
@@ -360,6 +341,7 @@ files:
 - lib/generators/exception_notification/install_generator.rb
 - lib/generators/exception_notification/templates/exception_notification.rb.erb
 - test/exception_notification/rack_test.rb
+- test/exception_notification/rake_test.rb
 - test/exception_notification/resque_test.rb
 - test/exception_notifier/datadog_notifier_test.rb
 - test/exception_notifier/email_notifier_test.rb
@@ -381,11 +363,11 @@ files:
 - test/support/views/exception_notifier/_new_section.html.erb
 - test/support/views/exception_notifier/_new_section.text.erb
 - test/test_helper.rb
-homepage: https://smartinez87.github.io/exception_notification/
+homepage: https://kmcphillips.github.io/exception_notification/
 licenses:
 - MIT
-metadata: {}
-post_install_message: 
+metadata:
+  changelog_uri: https://github.com/kmcphillips/exception_notification/blob/master/CHANGELOG.rdoc
 rdoc_options: []
 require_paths:
 - lib
@@ -393,37 +375,14 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '2.3'
+      version: '3.2'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: 1.8.11
+      version: '0'
 requirements: []
-rubygems_version: 3.2.32
-signing_key: 
+rubygems_version: 3.6.2
 specification_version: 4
-summary: Exception notification for Rails apps
-test_files:
-- test/exception_notification/rack_test.rb
-- test/exception_notification/resque_test.rb
-- test/exception_notifier/datadog_notifier_test.rb
-- test/exception_notifier/email_notifier_test.rb
-- test/exception_notifier/google_chat_notifier_test.rb
-- test/exception_notifier/hipchat_notifier_test.rb
-- test/exception_notifier/irc_notifier_test.rb
-- test/exception_notifier/mattermost_notifier_test.rb
-- test/exception_notifier/modules/error_grouping_test.rb
-- test/exception_notifier/modules/formatter_test.rb
-- test/exception_notifier/sidekiq_test.rb
-- test/exception_notifier/slack_notifier_test.rb
-- test/exception_notifier/sns_notifier_test.rb
-- test/exception_notifier/teams_notifier_test.rb
-- test/exception_notifier/webhook_notifier_test.rb
-- test/exception_notifier_test.rb
-- test/support/exception_notifier_helper.rb
-- test/support/views/exception_notifier/_new_bkg_section.html.erb
-- test/support/views/exception_notifier/_new_bkg_section.text.erb
-- test/support/views/exception_notifier/_new_section.html.erb
-- test/support/views/exception_notifier/_new_section.text.erb
-- test/test_helper.rb
+summary: Exception notification for Ruby applications
+test_files: []

data/Appraisals

@@ -1,9 +0,0 @@
-# frozen_string_literal: true
-
-rails_versions = ['~> 5.2.0', '~> 6.0.0', '~> 6.1.0', '~> 7.0.0']
-
-rails_versions.each do |rails_version|
-  appraise "rails#{rails_version.slice(/\d+\.\d+/).tr('.', '_')}" do
-    gem 'rails', rails_version
-  end
-end

data/examples/sample_app.rb

@@ -1,56 +0,0 @@
-# frozen_string_literal: true
-
-# -------------------------------------------
-# To run the application: ruby examples/sample_app.rb
-# -------------------------------------------
-
-require 'bundler/inline'
-
-gemfile do
-  source 'https://rubygems.org'
-
-  gem 'rails', '5.0.0'
-  gem 'exception_notification', '4.3.0'
-  gem 'httparty', '0.15.7'
-end
-
-class SampleApp < Rails::Application
-  config.middleware.use ExceptionNotification::Rack,
-                        webhook: {
-                          url: 'http://example.com'
-                        }
-
-  config.secret_key_base = 'my secret key base'
-
-  Rails.logger = Logger.new($stdout)
-
-  routes.draw do
-    get '/', to: 'exceptions#index'
-  end
-end
-
-require 'action_controller/railtie'
-
-class ExceptionsController < ActionController::Base
-  def index
-    raise 'Sample exception raised, you should receive a notification!'
-  end
-end
-
-require 'minitest/autorun'
-
-class Test < Minitest::Test
-  include Rack::Test::Methods
-
-  def test_raise_exception
-    get '/'
-
-    assert last_response.server_error?
-  end
-
-  private
-
-  def app
-    Rails.application
-  end
-end