exception_notification 4.1.4 → 4.2.0.rc1

data/test/dummy/test/test_helper.rb

@@ -3,11 +3,5 @@ require File.expand_path('../../config/environment', __FILE__)
 require 'rails/test_help'
 
 class ActiveSupport::TestCase
-  # Setup all fixtures in test/fixtures/*.(yml|csv) for all tests in alphabetical order.
-  #
-  # Note: You'll currently still have to declare fixtures explicitly in integration tests
-  # -- they do not yet inherit this setting
-  fixtures :all
-
   # Add more helper methods to be used by all tests here...
 end

data/test/exception_notifier/email_notifier_test.rb

@@ -1,4 +1,5 @@
 require 'test_helper'
+require 'action_mailer'
 
 class EmailNotifierTest < ActiveSupport::TestCase
   setup do
@@ -100,15 +101,7 @@ class EmailNotifierTest < ActiveSupport::TestCase
   end
 
   test "mail should have a descriptive subject" do
-    # On Rails < 4.1 the subject prefix has two spaces before the rest of the
-    # subject content.
-    if Gem::Version.new(ActionMailer::VERSION::STRING) < Gem::Version.new('4.1')
-      prefix = '[Dummy ERROR]  '
-    else
-      # On Rails 4.1 the subject prefix has a single space.
-      prefix = '[Dummy ERROR] '
-    end
-    assert_equal @mail.subject, prefix + '(ZeroDivisionError) "divided by 0"'
+    assert_match /^\[Dummy ERROR\]\s+\(ZeroDivisionError\) "divided by 0"$/, @mail.subject
   end
 
   test "mail should say exception was raised in background at show timestamp" do
@@ -127,7 +120,7 @@ class EmailNotifierTest < ActiveSupport::TestCase
   end
 
   test "mail should contain backtrace in body" do
-    assert @mail.encoded.include?("test/exception_notifier/email_notifier_test.rb:8"), "\n#{@mail.inspect}"
+    assert @mail.encoded.include?("test/exception_notifier/email_notifier_test.rb:9"), "\n#{@mail.inspect}"
   end
 
   test "mail should contain data in body" do
@@ -147,12 +140,12 @@ class EmailNotifierTest < ActiveSupport::TestCase
     rescue => e
       @ignored_exception = e
       unless ExceptionNotifier.ignored_exceptions.include?(@ignored_exception.class.name)
-        @ignored_mail = @email_notifier.create_email(@ignored_exception)
+        ignored_mail = @email_notifier.create_email(@ignored_exception)
       end
     end
 
     assert_equal @ignored_exception.class.inspect, "ActiveRecord::RecordNotFound"
-    assert_nil @ignored_mail
+    assert_nil ignored_mail
   end
 
   test "should encode environment strings" do
@@ -175,21 +168,54 @@ class EmailNotifierTest < ActiveSupport::TestCase
     assert_match /invalid_encoding\s+: R__sum__/, mail.encoded
   end
 
-  if defined?(Rails) && ('4.2'...'5.0').cover?(Rails.version)
-    test "should be able to specify ActionMailer::MessageDelivery method" do
-      email_notifier = ExceptionNotifier::EmailNotifier.new(
-        :email_prefix => '[Dummy ERROR] ',
-        :sender_address => %{"Dummy Notifier" <dummynotifier@example.com>},
-        :exception_recipients => %w{dummyexceptions@example.com},
-        :deliver_with => :deliver_now
-      )
-      # In Rails 4.2, it gives deprecation warning like "`#deliver` is
-      # deprecated and will be removed in Rails 5." when "#deliver" is
-      # used. If methods like "#deliver_now" is used, it should not
-      # give any warnings.
-      assert_silent do
-        email_notifier.call(@exception)
-      end
+  test "should send email using ActionMailer" do
+    ActionMailer::Base.deliveries.clear
+
+    email_notifier = ExceptionNotifier::EmailNotifier.new(
+      :email_prefix => '[Dummy ERROR] ',
+      :sender_address => %{"Dummy Notifier" <dummynotifier@example.com>},
+      :exception_recipients => %w{dummyexceptions@example.com},
+      :delivery_method => :test
+    )
+
+    email_notifier.call(@exception)
+
+    assert_equal 1, ActionMailer::Base.deliveries.count
+  end
+
+  test "should be able to specify ActionMailer::MessageDelivery method" do
+    ActionMailer::Base.deliveries.clear
+
+    if ActionMailer.version < Gem::Version.new("4.2")
+      deliver_with = :deliver
+    else
+      deliver_with = :deliver_now
     end
+
+    email_notifier = ExceptionNotifier::EmailNotifier.new(
+      :email_prefix => '[Dummy ERROR] ',
+      :sender_address => %{"Dummy Notifier" <dummynotifier@example.com>},
+      :exception_recipients => %w{dummyexceptions@example.com},
+      :deliver_with => deliver_with
+    )
+
+    email_notifier.call(@exception)
+
+    assert_equal 1, ActionMailer::Base.deliveries.count
+  end
+
+  test "should lazily evaluate exception_recipients" do
+    exception_recipients = %w{first@example.com second@example.com}
+    email_notifier = ExceptionNotifier::EmailNotifier.new(
+      :email_prefix => '[Dummy ERROR] ',
+      :sender_address => %{"Dummy Notifier" <dummynotifier@example.com>},
+      :exception_recipients => -> { [ exception_recipients.shift ] },
+      :delivery_method => :test
+    )
+
+    mail = email_notifier.call(@exception)
+    assert_equal %w{first@example.com}, mail.to
+    mail = email_notifier.call(@exception)
+    assert_equal %w{second@example.com}, mail.to
   end
 end

data/test/exception_notifier/mattermost_notifier_test.rb

@@ -0,0 +1,88 @@
+require 'test_helper'
+require 'httparty'
+
+class MattermostNotifierTest < ActiveSupport::TestCase
+
+  test "should send notification if properly configured" do
+    options = {
+      :webhook_url => 'http://localhost:8000'
+    }
+    mattermost_notifier = ExceptionNotifier::MattermostNotifier.new
+    mattermost_notifier.httparty = FakeHTTParty.new
+
+    options = mattermost_notifier.call ArgumentError.new("foo"), options
+
+    body = ActiveSupport::JSON.decode options[:body]
+    assert body.has_key? 'text'
+    assert body.has_key? 'username'
+
+    text = body['text'].split("\n")
+    assert_equal 4, text.size
+    assert_equal '@channel', text[0]
+    assert_equal 'An *ArgumentError* occured.', text[2]
+    assert_equal '*foo*', text[3]
+  end
+
+  test "should send notification with create issue link if specified" do
+    options = {
+      :webhook_url => 'http://localhost:8000',
+      :git_url => 'github.com/aschen'
+    }
+    mattermost_notifier = ExceptionNotifier::MattermostNotifier.new
+    mattermost_notifier.httparty = FakeHTTParty.new
+
+    options = mattermost_notifier.call ArgumentError.new("foo"), options
+
+    body = ActiveSupport::JSON.decode options[:body]
+
+    text = body['text'].split("\n")
+    assert_equal 5, text.size
+    assert_equal '[Create an issue](github.com/aschen/dummy/issues/new/?issue%5Btitle%5D=%5BBUG%5D+Error+500+%3A++%28ArgumentError%29+foo)', text[4]
+  end
+
+  test 'should add username and icon_url params to the notification if specified' do
+    options = {
+      :webhook_url => 'http://localhost:8000',
+      :username => "Test Bot",
+      :avatar => 'http://site.com/icon.png'
+    }
+    mattermost_notifier = ExceptionNotifier::MattermostNotifier.new
+    mattermost_notifier.httparty = FakeHTTParty.new
+
+    options = mattermost_notifier.call ArgumentError.new("foo"), options
+
+    body = ActiveSupport::JSON.decode options[:body]
+
+    assert_equal 'Test Bot', body['username']
+    assert_equal 'http://site.com/icon.png', body['icon_url']
+  end
+
+  test 'should add other HTTParty options to params' do
+    options = {
+      :webhook_url => 'http://localhost:8000',
+      :username => "Test Bot",
+      :avatar => 'http://site.com/icon.png',
+      :basic_auth => {
+        :username => 'clara',
+        :password => 'password'
+      }
+    }
+    mattermost_notifier = ExceptionNotifier::MattermostNotifier.new
+    mattermost_notifier.httparty = FakeHTTParty.new
+
+    options = mattermost_notifier.call ArgumentError.new("foo"), options
+
+    assert options.has_key? :basic_auth
+    assert 'clara', options[:basic_auth][:username]
+    assert 'password', options[:basic_auth][:password]
+  end
+
+end
+
+class FakeHTTParty
+
+  def post(url, options)
+    return options
+  end
+
+end

data/test/exception_notifier/slack_notifier_test.rb

@@ -5,8 +5,9 @@ class SlackNotifierTest < ActiveSupport::TestCase
 
   def setup
     @exception = fake_exception
-    @exception.stubs(:backtrace).returns(["backtrace line 1", "backtrace line 2"])
+    @exception.stubs(:backtrace).returns(fake_backtrace)
     @exception.stubs(:message).returns('exception message')
+    Socket.stubs(:gethostname).returns('example.com')
   end
 
   test "should send a slack notification if properly configured" do
@@ -130,7 +131,7 @@ class SlackNotifierTest < ActiveSupport::TestCase
     Slack::Notifier.any_instance.expects(:ping).with('',
                                                      {:icon_url => 'icon',
                                                       :attachments => [
-                                                        {:text => "backtrace line 1\nbacktrace line 2",
+                                                        {:text => fake_backtrace.join("\n"),
                                                          :color => 'danger'}
                                                      ]})
 
@@ -153,11 +154,23 @@ class SlackNotifierTest < ActiveSupport::TestCase
     StandardError.new('my custom error')
   end
 
-  def fake_notification(exception=@exception, data_string=nil)
+  def fake_backtrace
+    [
+      "backtrace line 1",
+      "backtrace line 2",
+      "backtrace line 3",
+      "backtrace line 4",
+      "backtrace line 5",
+      "backtrace line 6",
+    ]
+  end
+
+  def fake_notification(exception = @exception, data_string = nil)
     text = "*An exception occurred while doing*: ` <>`\n"
 
     fields = [ { title: 'Exception', value: exception.message} ]
-    fields.push({ title: 'Backtrace', value: "```backtrace line 1\nbacktrace line 2```" }) if exception.backtrace
+    fields.push({ title: 'Hostname', value: 'example.com' })
+    fields.push({ title: 'Backtrace', value: "```#{fake_backtrace.join("\n")}```" }) if exception.backtrace
     fields.push({ title: 'Data', value: "```#{data_string}```" }) if data_string
 
     { attachments: [ color: 'danger', text: text, fields: fields, mrkdwn_in: %w(text fields) ] }

data/test/exception_notifier_test.rb

@@ -2,7 +2,9 @@ require 'test_helper'
 
 class ExceptionNotifierTest < ActiveSupport::TestCase
   test "should have default ignored exceptions" do
-    assert_equal ExceptionNotifier.ignored_exceptions, ['ActiveRecord::RecordNotFound', 'AbstractController::ActionNotFound', 'ActionController::RoutingError', 'ActionController::UnknownFormat']
+    assert_equal ExceptionNotifier.ignored_exceptions,
+      ['ActiveRecord::RecordNotFound', 'AbstractController::ActionNotFound', 'ActionController::RoutingError',
+       'ActionController::UnknownFormat', 'ActionController::UrlGenerationError']
   end
 
   test "should have email notifier registered" do
@@ -24,6 +26,7 @@ class ExceptionNotifierTest < ActiveSupport::TestCase
     assert_equal ExceptionNotifier.notifiers.sort, [:email, :proc]
 
     exception = StandardError.new
+
     ExceptionNotifier.notify_exception(exception)
     assert called
 

data/test/test_helper.rb

@@ -15,4 +15,4 @@ require File.expand_path("../dummy/test/test_helper.rb", __FILE__)
 require "mocha/setup"
 
 Rails.backtrace_cleaner.remove_silencers!
-
+ExceptionNotifier.testing_mode!

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: exception_notification
 version: !ruby/object:Gem::Version
-  version: 4.1.4
+  version: 4.2.0.rc1
 platform: ruby
 authors:
 - Jamis Buck
@@ -9,50 +9,68 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-01-07 00:00:00.000000000 Z
+date: 2016-07-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: actionmailer
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '4.0'
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '6'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '4.0'
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '6'
 - !ruby/object:Gem::Dependency
   name: activesupport
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '4.0'
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '6'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '4.0'
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '6'
 - !ruby/object:Gem::Dependency
   name: rails
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '4.0'
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '6'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '4.0'
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '6'
 - !ruby/object:Gem::Dependency
   name: resque
   requirement: !ruby/object:Gem::Requirement
@@ -163,14 +181,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.0.0
+        version: 2.0.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.0.0
+        version: 2.0.0
 - !ruby/object:Gem::Dependency
   name: hipchat
   requirement: !ruby/object:Gem::Requirement
@@ -221,6 +239,7 @@ extra_rdoc_files: []
 files:
 - Appraisals
 - CHANGELOG.rdoc
+- CODE_OF_CONDUCT.md
 - CONTRIBUTING.md
 - Gemfile
 - MIT-LICENSE
@@ -236,6 +255,7 @@ files:
 - gemfiles/rails4_0.gemfile
 - gemfiles/rails4_1.gemfile
 - gemfiles/rails4_2.gemfile
+- gemfiles/rails5_0.gemfile
 - lib/exception_notification.rb
 - lib/exception_notification/rack.rb
 - lib/exception_notification/rails.rb
@@ -247,6 +267,7 @@ files:
 - lib/exception_notifier/email_notifier.rb
 - lib/exception_notifier/hipchat_notifier.rb
 - lib/exception_notifier/irc_notifier.rb
+- lib/exception_notifier/mattermost_notifier.rb
 - lib/exception_notifier/modules/backtrace_cleaner.rb
 - lib/exception_notifier/notifier.rb
 - lib/exception_notifier/slack_notifier.rb
@@ -270,8 +291,6 @@ files:
 - lib/generators/exception_notification/install_generator.rb
 - lib/generators/exception_notification/templates/exception_notification.rb
 - test/dummy/.gitignore
-- test/dummy/Gemfile
-- test/dummy/Gemfile.lock
 - test/dummy/Rakefile
 - test/dummy/app/controllers/application_controller.rb
 - test/dummy/app/controllers/posts_controller.rb
@@ -321,7 +340,6 @@ files:
 - test/dummy/public/stylesheets/.gitkeep
 - test/dummy/public/stylesheets/scaffold.css
 - test/dummy/script/rails
-- test/dummy/test/fixtures/posts.yml
 - test/dummy/test/functional/posts_controller_test.rb
 - test/dummy/test/test_helper.rb
 - test/exception_notification/rack_test.rb
@@ -329,12 +347,13 @@ files:
 - test/exception_notifier/email_notifier_test.rb
 - test/exception_notifier/hipchat_notifier_test.rb
 - test/exception_notifier/irc_notifier_test.rb
+- test/exception_notifier/mattermost_notifier_test.rb
 - test/exception_notifier/sidekiq_test.rb
 - test/exception_notifier/slack_notifier_test.rb
 - test/exception_notifier/webhook_notifier_test.rb
 - test/exception_notifier_test.rb
 - test/test_helper.rb
-homepage: http://smartinez87.github.com/exception_notification
+homepage: https://smartinez87.github.io/exception_notification/
 licenses:
 - MIT
 metadata: {}
@@ -354,14 +373,12 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: 1.8.11
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.5.1
+rubygems_version: 2.5.1
 signing_key: 
 specification_version: 4
 summary: Exception notification for Rails apps
 test_files:
 - test/dummy/.gitignore
-- test/dummy/Gemfile
-- test/dummy/Gemfile.lock
 - test/dummy/Rakefile
 - test/dummy/app/controllers/application_controller.rb
 - test/dummy/app/controllers/posts_controller.rb
@@ -411,7 +428,6 @@ test_files:
 - test/dummy/public/stylesheets/.gitkeep
 - test/dummy/public/stylesheets/scaffold.css
 - test/dummy/script/rails
-- test/dummy/test/fixtures/posts.yml
 - test/dummy/test/functional/posts_controller_test.rb
 - test/dummy/test/test_helper.rb
 - test/exception_notification/rack_test.rb
@@ -419,6 +435,7 @@ test_files:
 - test/exception_notifier/email_notifier_test.rb
 - test/exception_notifier/hipchat_notifier_test.rb
 - test/exception_notifier/irc_notifier_test.rb
+- test/exception_notifier/mattermost_notifier_test.rb
 - test/exception_notifier/sidekiq_test.rb
 - test/exception_notifier/slack_notifier_test.rb
 - test/exception_notifier/webhook_notifier_test.rb