exception_notification 4.0.1 → 4.1.0.rc1

data/CHANGELOG.rdoc

@@ -1,3 +1,13 @@
+== unreleased
+
+* enhancements
+  * Add support for Sidekiq 3.0 (by @mbrictson)
+  * Add IRC notifier (by @nathanjsharpe)
+  * Add ActionController::UnknownFormat to default ignored exceptions (by @rezwyi)
+  * Add message_template option to HipChat notifier (by @makimoto)
+
+* bug fixes
+  * Fix `Rails.root` exception (by @hovatterz)
 == 4.0.1
 
 * enhancements

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    exception_notification (4.0.1)
+    exception_notification (4.1.0.rc1)
       actionmailer (>= 3.0.4)
       activesupport (>= 3.0.4)
 
@@ -35,15 +35,18 @@ GEM
     activesupport (3.2.6)
       i18n (~> 0.6)
       multi_json (~> 1.0)
+    addressable (2.3.5)
     appraisal (0.5.2)
       bundler
       rake
     arel (3.0.2)
     builder (3.0.0)
-    celluloid (0.14.0)
-      timers (>= 1.0.0)
+    carrier-pigeon (0.7.0)
+      addressable
+    celluloid (0.15.2)
+      timers (~> 1.1.0)
     colorize (0.5.8)
-    connection_pool (1.0.0)
+    connection_pool (2.0.0)
     coveralls (0.6.5)
       colorize
       multi_json (~> 1.3)
@@ -66,7 +69,7 @@ GEM
       multi_xml (>= 0.5.2)
     i18n (0.6.0)
     journey (1.0.4)
-    json (1.7.3)
+    json (1.8.1)
     mail (2.4.4)
       i18n (>= 0.4.0)
       mime-types (~> 1.16)
@@ -104,20 +107,20 @@ GEM
     rake (0.9.2.2)
     rdoc (3.12)
       json (~> 1.4)
-    redis (3.0.4)
-    redis-namespace (1.3.0)
-      redis (~> 3.0.0)
+    redis (3.0.7)
+    redis-namespace (1.4.1)
+      redis (~> 3.0.4)
     resque (1.2.3)
       redis
       redis-namespace
     rest-client (1.6.7)
       mime-types (>= 1.16)
-    sidekiq (2.12.0)
-      celluloid (>= 0.14.0)
-      connection_pool (>= 1.0.0)
+    sidekiq (3.0.0)
+      celluloid (>= 0.15.2)
+      connection_pool (>= 2.0.0)
       json
-      redis (>= 3.0)
-      redis-namespace
+      redis (>= 3.0.6)
+      redis-namespace (>= 1.3.1)
     simple_oauth (0.1.9)
     simplecov (0.7.1)
       multi_json (~> 1.0)
@@ -155,6 +158,7 @@ PLATFORMS
 
 DEPENDENCIES
   appraisal
+  carrier-pigeon (>= 0.7.0)
   coveralls (~> 0.6.5)
   exception_notification!
   hipchat (>= 0.11.0)
@@ -162,6 +166,6 @@ DEPENDENCIES
   mocha (>= 0.13.0)
   rails (>= 3.0.4)
   resque (~> 1.2.0)
-  sidekiq (~> 2.0)
+  sidekiq (~> 3.0)
   sqlite3 (>= 1.3.4)
   tinder (~> 1.8)

data/README.md

@@ -266,6 +266,8 @@ Whatever::Application.config.middleware.use ExceptionNotification::Rack,
   }
 ```
 
+A complete list of `smtp_settings` options can be found in the [ActionMailer Configuration documentation](http://api.rubyonrails.org/classes/ActionMailer/Base.html#class-ActionMailer::Base-label-Configuration+options).
+
 
 ##### mailer_parent
 
@@ -367,21 +369,21 @@ The HipChat room where the notifications must be published to.
 
 The API token to allow access to your HipChat account.
 
-##### announce
+##### notify
 
-*Boolean, optionnal*
+*Boolean, optional*
 
 Notify users. Default : false.
 
 ##### color
 
-*String, optionnal*
+*String, optional*
 
 Color of the message. Default : 'red'.
 
 ##### from
 
-*String, optionnal*
+*String, optional, maximum length : 15*
 
 Message will appear from this nickname. Default : 'Exception'.
 
@@ -448,6 +450,104 @@ Whatever::Application.config.middleware.use ExceptionNotification::Rack,
 
 For more HTTParty options, check out the [documentation](https://github.com/jnunemaker/httparty).
 
+### IRC notifier
+
+This notifier sends notifications to an IRC channel using the carrier-pigeon gem.
+
+#### Usage
+
+Just add the [carrier-pigeon](https://github.com/portertech/carrier-pigeon) gem to your `Gemfile`:
+
+```ruby
+gem 'carrier-pigeon'
+```
+
+To configure it, you need to set at least the 'domain' option, like this:
+
+```ruby
+Whatever::Application.config.middleware.use ExceptionNotification::Rack,
+  :email => {
+    :email_prefix => "[Whatever] ",
+    :sender_address => %{"notifier" <notifier@example.com>},
+    :exception_recipients => %w{exceptions@example.com}
+  },
+  :irc => {
+    :domain => 'irc.example.com'
+  }
+```
+
+There are several other options, which are described below. For example, to use ssl and a password, add a prefix, post to the '#log' channel, and include recipients in the message (so that they will be notified), your configuration might look like this:
+
+```ruby
+Whatever::Application.config.middleware.use ExceptionNotification::Rack,
+  :irc => {
+    :domain => 'irc.example.com',
+    :nick => 'BadNewsBot',
+    :password => 'secret',
+    :port => 6697,
+    :channel => '#log',
+    :ssl => true,
+    :prefix => '[Exception Notification]',
+    :recipients => ['peter', 'michael', 'samir']
+  }
+
+```
+
+#### Options
+
+##### domain
+
+*String, required*
+
+The domain name of your IRC server.
+
+##### nick
+
+*String, optional*
+
+The message will appear from this nick. Default : 'ExceptionNotifierBot'.
+
+##### password
+
+*String, optional*
+
+Password for your IRC server.
+
+##### port
+
+*String, optional*
+
+Port your IRC server is listening on. Default : 6667.
+
+##### channel
+
+*String, optional*
+
+Message will appear in this channel. Default : '#log'.
+
+##### notice
+
+*Boolean, optional*
+
+Send a notice. Default : false.
+
+##### ssl
+
+*Boolean, optional*
+
+Whether to use SSL. Default : false.
+
+##### join
+
+*Boolean, optional*
+
+Join a channel. Default : false.
+
+##### recipients
+
+*Array of strings, optional*
+
+Nicks to include in the message. Default: []
 
 ### Custom notifier
 
@@ -506,7 +606,7 @@ You can choose to ignore certain exceptions, which will make ExceptionNotificati
 
 ### :ignore_exceptions
 
-*Array of strings, default: %w{ActiveRecord::RecordNotFound AbstractController::ActionNotFound ActionController::RoutingError}*
+*Array of strings, default: %w{ActiveRecord::RecordNotFound AbstractController::ActionNotFound ActionController::RoutingError ActionController::UnknownFormat}*
 
 Ignore specified exception types. To achieve that, you should use the `:ignore_exceptions` option, like this:
 
@@ -620,6 +720,10 @@ or
 
 ## Versions
 
+For v4.0.1, see this tag:
+
+http://github.com/smartinez87/exception_notification/tree/v4.0.1
+
 For v4.0.0, see this tag:
 
 http://github.com/smartinez87/exception_notification/tree/v4.0.0
@@ -632,10 +736,6 @@ For v3.0.0, see this tag:
 
 http://github.com/smartinez87/exception_notification/tree/v3.0.0
 
-For v2.6.1, see this tag:
-
-http://github.com/smartinez87/exception_notification/tree/v2.6.1
-
 For previous releases, visit:
 
 https://github.com/smartinez87/exception_notification/tags

data/exception_notification.gemspec

@@ -1,8 +1,8 @@
 Gem::Specification.new do |s|
   s.name = 'exception_notification'
-  s.version = '4.0.1'
+  s.version = '4.1.0.rc1'
   s.authors = ["Jamis Buck", "Josh Peek"]
-  s.date = %q{2013-09-15}
+  s.date = %q{2014-04-16}
   s.summary = "Exception notification for Rails apps"
   s.homepage = "http://smartinez87.github.com/exception_notification"
   s.email = "smartinez87@gmail.com"
@@ -12,6 +12,7 @@ Gem::Specification.new do |s|
   s.required_rubygems_version = '>= 1.8.11'
 
   s.files = `git ls-files`.split("\n")
+  s.files -= `git ls-files -- .??*`.split("\n")
   s.test_files = `git ls-files -- test`.split("\n")
   s.require_path = 'lib'
 
@@ -20,7 +21,7 @@ Gem::Specification.new do |s|
 
   s.add_development_dependency "rails", ">= 3.0.4"
   s.add_development_dependency "resque", "~> 1.2.0"
-  s.add_development_dependency "sidekiq", "~> 2.0"
+  s.add_development_dependency "sidekiq", "~> 3.0"
   s.add_development_dependency "tinder", "~> 1.8"
   s.add_development_dependency "httparty", "~> 0.10.2"
   s.add_development_dependency "mocha", ">= 0.13.0"
@@ -28,4 +29,5 @@ Gem::Specification.new do |s|
   s.add_development_dependency "coveralls", "~> 0.6.5"
   s.add_development_dependency "appraisal", ">= 0"
   s.add_development_dependency "hipchat", ">= 0.11.0"
+  s.add_development_dependency "carrier-pigeon", ">= 0.7.0"
 end

data/lib/exception_notification/sidekiq.rb

@@ -1,5 +1,6 @@
 require 'sidekiq'
 
+# Note: this class is only needed for Sidekiq version < 3.
 module ExceptionNotification
   class Sidekiq
 
@@ -15,8 +16,16 @@ module ExceptionNotification
   end
 end
 
-::Sidekiq.configure_server do |config|
-  config.server_middleware do |chain|
-    chain.add ::ExceptionNotification::Sidekiq
+if ::Sidekiq::VERSION < '3'
+  ::Sidekiq.configure_server do |config|
+    config.server_middleware do |chain|
+      chain.add ::ExceptionNotification::Sidekiq
+    end
+  end
+else
+  ::Sidekiq.configure_server do |config|
+    config.error_handlers << Proc.new { |ex, context|
+      ExceptionNotifier.notify_exception(ex, :data => { :sidekiq => context })
+    }
   end
 end

data/lib/exception_notifier.rb

@@ -9,6 +9,7 @@ module ExceptionNotifier
   autoload :CampfireNotifier, 'exception_notifier/campfire_notifier'
   autoload :HipchatNotifier, 'exception_notifier/hipchat_notifier'
   autoload :WebhookNotifier, 'exception_notifier/webhook_notifier'
+  autoload :IrcNotifier, 'exception_notifier/irc_notifier'
 
   class UndefinedNotifierError < StandardError; end
 
@@ -18,7 +19,7 @@ module ExceptionNotifier
 
   # Define a set of exceptions to be ignored, ie, dont send notifications when any of them are raised.
   mattr_accessor :ignored_exceptions
-  @@ignored_exceptions = %w{ActiveRecord::RecordNotFound AbstractController::ActionNotFound ActionController::RoutingError}
+  @@ignored_exceptions = %w{ActiveRecord::RecordNotFound AbstractController::ActionNotFound ActionController::RoutingError ActionController::UnknownFormat}
 
   class << self
     # Store conditions that decide when exceptions must be ignored or not.

data/lib/exception_notifier/email_notifier.rb

@@ -111,7 +111,9 @@ module ExceptionNotifier
           end
 
           def load_custom_views
-            self.prepend_view_path Rails.root.nil? ? "app/views" : "#{Rails.root}/app/views" if defined?(Rails)
+            if defined?(Rails) && Rails.respond_to?(:root)
+              self.prepend_view_path Rails.root.nil? ? "app/views" : "#{Rails.root}/app/views"
+            end
           end
         end
       end

data/lib/exception_notifier/hipchat_notifier.rb

@@ -7,10 +7,13 @@ module ExceptionNotifier
 
     def initialize(options)
       begin
-        api_token				  = options.delete(:api_token)
-        room_name 			  = options.delete(:room_name)
+        api_token         = options.delete(:api_token)
+        room_name         = options.delete(:room_name)
         @from             = options.delete(:from) || 'Exception'
-        @room     			  = HipChat::Client.new(api_token)[room_name]
+        @room             = HipChat::Client.new(api_token)[room_name]
+        @message_template = options.delete(:message_template) || ->(exception) {
+          "A new exception occurred: '#{exception.message}' on '#{exception.backtrace.first}'"
+        }
         @message_options  = options
         @message_options[:color] ||= 'red'
       rescue
@@ -21,7 +24,7 @@ module ExceptionNotifier
     def call(exception, options={})
       return if !active?
 
-      message = "A new exception occurred: '#{exception.message}' on '#{exception.backtrace.first}'"
+      message = @message_template.call(exception)
       @room.send(@from, message, @message_options)
     end
 

data/lib/exception_notifier/irc_notifier.rb

@@ -0,0 +1,45 @@
+module ExceptionNotifier
+  class IrcNotifier
+    def initialize(options)
+      @config = OpenStruct.new
+      parse_options(options)
+    end
+
+    def call(exception, options={})
+      message = "'#{exception.message}' on '#{exception.backtrace.first}'"
+      send_message([*@config.prefix, *message].join(' ')) if active?
+    end
+
+    def send_message(message)
+      CarrierPigeon.send @config.irc.merge({message: message})
+    end
+
+    private
+      def parse_options(options)
+        nick = options.fetch(:nick, 'ExceptionNotifierBot')
+        password = options[:password] ? ":#{options[:password]}" : nil
+        domain = options.fetch(:domain, nil)
+        port = options[:port] ? ":#{options[:port]}" : nil
+        channel = options.fetch(:channel, '#log')
+        notice = options.fetch(:notice, false)
+        ssl = options.fetch(:ssl, false)
+        join = options.fetch(:join, false)
+        uri = "irc://#{nick}#{password}@#{domain}#{port}/#{channel}"
+        prefix = options.fetch(:prefix, nil)
+        recipients = options[:recipients] ? options[:recipients].join(', ') + ':' : nil
+
+        @config.prefix = [*prefix, *recipients].join(' ')
+        @config.irc = { uri: uri, ssl: ssl, notice: notice, join: join }
+      end
+
+      def active?
+        valid_uri? @config.irc[:uri]
+      end
+
+      def valid_uri?(uri)
+        !!URI.parse(uri)
+      rescue URI::InvalidURIError
+        false
+      end
+  end
+end

data/lib/exception_notifier/views/exception_notifier/_backtrace.html.erb

@@ -1,3 +1,3 @@
 <pre style="font-size: 12px; padding: 10px; border: 1px solid #e1e1e8; background-color:#f5f5f5">
-  <%= raw @backtrace.join("\n") %>
+<%= @backtrace.join("\n") %>
 </pre>

data/lib/exception_notifier/views/exception_notifier/_data.html.erb

@@ -1,6 +1,6 @@
 <ul style="list-style: none">
   <li>
     <strong>data:</strong>
-    <span><%= raw PP.pp(@data, "") %></span>
+    <span><%= PP.pp(@data, "") %></span>
   </li>
 </ul>

data/lib/exception_notifier/views/exception_notifier/_request.html.erb

@@ -1,36 +1,36 @@
 <ul style="list-style: none">
   <li>
     <strong>URL:</strong>
-    <span><%= raw @request.url %></span>
+    <span><%= @request.url %></span>
   </li>
   <li>
     <strong>HTTP Method:</strong>
-    <span><%= raw @request.request_method %></span>
+    <span><%= @request.request_method %></span>
   </li>
   <li>
     <strong>IP Address:</strong>
-    <span><%= raw @request.remote_ip %></span>
+    <span><%= @request.remote_ip %></span>
   </li>
   <li>
     <strong>Parameters:</strong>
-    <span><%= raw @request.filtered_parameters.inspect %></span>
+    <span><%= @request.filtered_parameters.inspect %></span>
   </li>
   <li>
     <strong>Timestamp:</strong>
-    <span><%= raw Time.current %></span>
+    <span><%= Time.current %></span>
   </li>
   <li>
     <strong>Server:</strong>
-    <span><%= raw Socket.gethostname %></span>
+    <span><%= Socket.gethostname %></span>
   </li>
-  <% if defined?(Rails) %>
+  <% if defined?(Rails) && Rails.respond_to?(:root) %>
     <li>
       <strong>Rails root:</strong>
-      <span><%= raw Rails.root %></span>
+      <span><%= Rails.root %></span>
     </li>
   <% end %>
   <li>
     <strong>Process:</strong>
-    <span><%= raw $$ %></span>
+    <span><%= $$ %></span>
   </li>
 </ul>

data/lib/exception_notifier/views/exception_notifier/_request.text.erb

@@ -4,7 +4,7 @@
 * Parameters : <%= raw @request.filtered_parameters.inspect %>
 * Timestamp  : <%= raw Time.current %>
 * Server : <%= raw Socket.gethostname %>
-<% if defined?(Rails) %>
+<% if defined?(Rails) && Rails.respond_to?(:root) %>
 * Rails root : <%= raw Rails.root %>
 <% end %>
 * Process: <%= raw $$ %>

data/lib/exception_notifier/views/exception_notifier/_session.html.erb

@@ -1,10 +1,10 @@
 <ul style="list-style: none">
   <li>
     <strong>session_id: </strong>
-    <span><%= @request.ssl? ? "[FILTERED]" : (raw (@request.session['session_id'] || (@request.env["rack.session.options"] and @request.env["rack.session.options"][:id])).inspect.html_safe) %></span>
+    <span><%= @request.ssl? ? "[FILTERED]" : (@request.session['session_id'] || (@request.env["rack.session.options"] and @request.env["rack.session.options"][:id]).inspect) %></span>
   </li>
   <li>
     <strong>data: </strong>
-    <span><%= raw PP.pp(@request.session, "") %></span>
+    <span><%= PP.pp(@request.session.to_hash, "") %></span>
   </li>
 </ul>

data/lib/exception_notifier/views/exception_notifier/_session.text.erb

@@ -1,2 +1,2 @@
 * session id: <%= @request.ssl? ? "[FILTERED]" : (raw (@request.session['session_id'] || (@request.env["rack.session.options"] and @request.env["rack.session.options"][:id])).inspect.html_safe) %>
-* data: <%= raw PP.pp(@request.session, "") %>
+* data: <%= raw PP.pp(@request.session.to_hash, "") %>

data/lib/exception_notifier/views/exception_notifier/_title.html.erb

@@ -1,3 +1,3 @@
 <h2>
-  <%= raw title.to_s.humanize %>
+  <%= title.to_s.humanize %>
 </h2>

data/lib/exception_notifier/views/exception_notifier/background_exception_notification.html.erb

@@ -30,11 +30,11 @@
       <tr>
         <td style="padding: 10px; border: 1px solid #eed3d7; background-color: #f2dede">
           <h3 style="color: #b94a48">
-            <%= @exception.class.to_s =~ /^[aeiou]/i ? 'An' : 'A' %> <%= @exception.class %> occurred in background at <%= raw Time.current %> :
+            <%= @exception.class.to_s =~ /^[aeiou]/i ? 'An' : 'A' %> <%= @exception.class %> occurred in background at <%= Time.current %> :
           </h3>
-          <p style="color: #b94a48"><%= raw @exception.message %></p>
+          <p style="color: #b94a48"><%= @exception.message %></p>
           <pre style="font-size: 12px; padding: 5px; background-color:#f5f5f5">
-            <%= raw @backtrace.first %>
+<%= @backtrace.first %>
           </pre>
         </td>
       </tr>

data/lib/exception_notifier/views/exception_notifier/exception_notification.html.erb

@@ -32,9 +32,9 @@
           <h3 style="color: #b94a48">
             <%= @exception.class.to_s =~ /^[aeiou]/i ? 'An' : 'A' %> <%= @exception.class %> occurred in <%= @kontroller.controller_name %>#<%= @kontroller.action_name %>:
           </h3>
-          <p style="color: #b94a48"><%= raw @exception.message %></p>
+          <p style="color: #b94a48"><%= @exception.message %></p>
           <pre style="font-size: 12px; padding: 5px; background-color:#f5f5f5">
-            <%= raw @backtrace.first %>
+<%= @backtrace.first %>
           </pre>
         </td>
       </tr>

data/lib/exception_notifier/webhook_notifier.rb

@@ -17,7 +17,9 @@ module ExceptionNotifier
       options[:body] ||= {}
       options[:body][:server] = Socket.gethostname
       options[:body][:process] = $$
-      options[:body][:rails_root] = Rails.root if defined?(Rails)
+      if defined?(Rails) && Rails.respond_to?(:root)
+        options[:body][:rails_root] = Rails.root
+      end
       options[:body][:exception] = {:error_class => exception.class.to_s,
                                     :message => exception.message.inspect,
                                     :backtrace => exception.backtrace}
@@ -27,7 +29,7 @@ module ExceptionNotifier
         request = ActionDispatch::Request.new(env)
 
         request_items = {:url => request.original_url,
-                         :http_method => request.http_method,
+                         :http_method => request.method,
                          :ip_address => request.remote_ip,
                          :parameters => request.filtered_parameters,
                          :timestamp => Time.current }

data/test/dummy/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: ../../..
   specs:
-    exception_notification (4.0.0)
+    exception_notification (4.0.1)
       actionmailer (>= 3.0.4)
       activesupport (>= 3.0.4)
 

data/test/exception_notifier/hipchat_notifier_test.rb

@@ -59,6 +59,20 @@ class HipchatNotifierTest < ActiveSupport::TestCase
     assert_nil hipchat.room
   end
 
+  test "should send hipchat notification with message_template" do
+    options = {
+      :api_token => 'good_token',
+      :room_name => 'room_name',
+      :color     => 'yellow',
+      :message_template => ->(exception) { "This is custom message: '#{exception.message}'" }
+    }
+
+    HipChat::Room.any_instance.expects(:send).with('Exception', "This is custom message: '#{fake_exception.message}'", { :color => 'yellow' })
+
+    hipchat = ExceptionNotifier::HipchatNotifier.new(options)
+    hipchat.call(fake_exception)
+  end
+
   private
 
   def fake_body

data/test/exception_notifier/irc_notifier_test.rb

@@ -0,0 +1,85 @@
+require 'test_helper'
+require 'carrier-pigeon'
+
+class IrcNotifierTest < ActiveSupport::TestCase
+
+  test "should send irc notification if properly configured" do
+    options = {
+      :domain => 'irc.example.com'
+    }
+
+    CarrierPigeon.expects(:send).with(has_key(:uri)) do |v|
+      /divided by 0/.match(v[:message])
+    end
+
+    irc = ExceptionNotifier::IrcNotifier.new(options)
+    irc.call(fake_exception)
+  end
+
+  test "should properly construct URI from constituent parts" do
+    options = {
+      :nick => 'BadNewsBot',
+      :password => 'secret',
+      :domain => 'irc.example.com',
+      :port => 9999,
+      :channel => '#exceptions'
+    }
+
+    CarrierPigeon.expects(:send).with(has_entry(uri: "irc://BadNewsBot:secret@irc.example.com:9999/#exceptions"))
+
+    irc = ExceptionNotifier::IrcNotifier.new(options)
+    irc.call(fake_exception)
+  end
+
+  test "should properly add recipients if specified" do
+    options = {
+      domain: 'irc.example.com',
+      recipients: ['peter', 'michael', 'samir']
+    }
+
+    CarrierPigeon.expects(:send).with(has_key(:uri)) do |v|
+      /peter, michael, samir/.match(v[:message])
+    end
+
+    irc = ExceptionNotifier::IrcNotifier.new(options)
+    irc.call(fake_exception)
+  end
+
+  test "should properly set miscellaneous options" do
+    options = {
+      domain: 'irc.example.com',
+      ssl: true,
+      join: true,
+      notice: true,
+      prefix: '[test notification]'
+    }
+
+    CarrierPigeon.expects(:send).with(has_entries(
+      ssl: true,
+      join: true,
+      notice: true,
+    )) do |v|
+      /\[test notification\]/.match(v[:message])
+    end
+
+    irc = ExceptionNotifier::IrcNotifier.new(options)
+    irc.call(fake_exception)
+  end
+
+  test "should not send irc notification if badly configured" do
+    wrong_params = { domain: '##scriptkiddie.com###'}
+    irc = ExceptionNotifier::IrcNotifier.new(wrong_params)
+
+    assert_nil irc.call(fake_exception)
+  end
+
+  private
+
+  def fake_exception
+    exception = begin
+      5/0
+    rescue Exception => e
+      e
+    end
+  end
+end

data/test/exception_notifier/sidekiq_test.rb

@@ -0,0 +1,27 @@
+require "test_helper"
+
+# To allow sidekiq error handlers to be registered, sidekiq must be in
+# "server mode". This mode is triggered by loading sidekiq/cli. Note this
+# has to be loaded before exception_notification/sidekiq.
+require "sidekiq/cli"
+
+require "exception_notification/sidekiq"
+
+class MockSidekiqServer
+  include ::Sidekiq::ExceptionHandler
+end
+
+class SidekiqTest < ActiveSupport::TestCase
+  test "should call notify_exception when sidekiq raises an error" do
+    server = MockSidekiqServer.new
+    message = Hash.new
+    exception = RuntimeError.new
+
+    ExceptionNotifier.expects(:notify_exception).with(
+      exception,
+      :data => { :sidekiq => message }
+    )
+
+    server.handle_exception(exception, message)
+  end
+end

data/test/exception_notifier_test.rb

@@ -2,7 +2,7 @@ require 'test_helper'
 
 class ExceptionNotifierTest < ActiveSupport::TestCase
   test "should have default ignored exceptions" do
-    assert ExceptionNotifier.ignored_exceptions == ['ActiveRecord::RecordNotFound', 'AbstractController::ActionNotFound', 'ActionController::RoutingError']
+    assert ExceptionNotifier.ignored_exceptions == ['ActiveRecord::RecordNotFound', 'AbstractController::ActionNotFound', 'ActionController::RoutingError', 'ActionController::UnknownFormat']
   end
 
   test "should have email notifier registered" do

metadata

@@ -1,8 +1,8 @@
 --- !ruby/object:Gem::Specification
 name: exception_notification
 version: !ruby/object:Gem::Version
-  version: 4.0.1
-  prerelease: 
+  version: 4.1.0.rc1
+  prerelease: 6
 platform: ruby
 authors:
 - Jamis Buck
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-09-15 00:00:00.000000000 Z
+date: 2014-04-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: actionmailer
@@ -83,7 +83,7 @@ dependencies:
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: '2.0'
+        version: '3.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -91,7 +91,7 @@ dependencies:
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: '2.0'
+        version: '3.0'
 - !ruby/object:Gem::Dependency
   name: tinder
   requirement: !ruby/object:Gem::Requirement
@@ -204,15 +204,28 @@ dependencies:
     - - ! '>='
       - !ruby/object:Gem::Version
         version: 0.11.0
+- !ruby/object:Gem::Dependency
+  name: carrier-pigeon
+  requirement: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: 0.7.0
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: 0.7.0
 description: 
 email: smartinez87@gmail.com
 executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- .gemtest
-- .gitignore
-- .travis.yml
 - Appraisals
 - CHANGELOG.rdoc
 - CONTRIBUTING.md
@@ -240,6 +253,7 @@ files:
 - lib/exception_notifier/campfire_notifier.rb
 - lib/exception_notifier/email_notifier.rb
 - lib/exception_notifier/hipchat_notifier.rb
+- lib/exception_notifier/irc_notifier.rb
 - lib/exception_notifier/notifier.rb
 - lib/exception_notifier/views/exception_notifier/_backtrace.html.erb
 - lib/exception_notifier/views/exception_notifier/_backtrace.text.erb
@@ -318,6 +332,8 @@ files:
 - test/exception_notifier/campfire_notifier_test.rb
 - test/exception_notifier/email_notifier_test.rb
 - test/exception_notifier/hipchat_notifier_test.rb
+- test/exception_notifier/irc_notifier_test.rb
+- test/exception_notifier/sidekiq_test.rb
 - test/exception_notifier/webhook_notifier_test.rb
 - test/exception_notifier_test.rb
 - test/test_helper.rb
@@ -405,6 +421,8 @@ test_files:
 - test/exception_notifier/campfire_notifier_test.rb
 - test/exception_notifier/email_notifier_test.rb
 - test/exception_notifier/hipchat_notifier_test.rb
+- test/exception_notifier/irc_notifier_test.rb
+- test/exception_notifier/sidekiq_test.rb
 - test/exception_notifier/webhook_notifier_test.rb
 - test/exception_notifier_test.rb
 - test/test_helper.rb

data/.gitignore

@@ -1,2 +0,0 @@
-/coverage/
-*.gemfile.lock

data/.travis.yml

@@ -1,9 +0,0 @@
-language: ruby
-rvm:
-  - 1.9.3
-  - 2.0.0
-gemfile:
- - Gemfile
- - gemfiles/rails3_1.gemfile
- - gemfiles/rails3_2.gemfile
- - gemfiles/rails4_0.gemfile