exception_notification-rake 0.0.5 → 0.0.6

data/README.md

@@ -105,7 +105,9 @@ The most likely options you'll want to use are `:email_prefix` and `:exception_r
 	  :email_prefix => "[Rake Failure] ",
 	  :exception_recipients => %w{user1@example.com user2@example.com})
 
-This will prefix the email subjects of Rake failure notifications with `[Cron Failure]` and will send them to the two given email addresses. Note that if you set the same options when you configure `ExceptionNotifier` itself, they will be overridden but for Rake failures only.
+This will prefix the email subjects of Rake failure notifications with `[Rake Failure]` and will send them to the two given email addresses. Note that if you set the same options when you configure `ExceptionNotifier` itself, they will be overridden but for Rake failures only.
+
+`:ignore_if` and `:ignore_exceptions` are also supported. Note that the first argument to the block expected by `:ignore_if` (the environment) will always be an empty dictionary since there is no meaningful environment for background tasks.
 
 If you want to configure sections, which is unlikely, note that by default the sections `['rake', 'backtrace']` are used (where `rake` is a custom section introduced by this gem).
 

data/lib/exception_notifier/rake/rake.rb

@@ -40,6 +40,11 @@ class ExceptionNotifier
     def self.maybe_deliver_notification(exception, data={})
       if configured?
         options = notifier_options
+        if conditionally_ignored(options[:ignore_if], exception) ||
+            ignored_exception(options[:ignore_exceptions], exception)
+          return
+        end
+
         if !data.empty?
           options = options.dup
           options[:data] = data.merge(options[:data] || {})
@@ -52,5 +57,19 @@ class ExceptionNotifier
     def self.reset_for_test
       @notifier_options = {}
     end
+
+    private
+
+    # Duplicated from exception_notification
+    def self.conditionally_ignored(ignore_proc, exception)
+      ignore_proc.call({}, exception)
+    rescue Exception
+      false
+    end
+
+    # Duplicated from exception_notification
+    def self.ignored_exception(ignore_array, exception)
+        Array.wrap(ignore_array).map(&:to_s).include?(exception.class.name)
+    end
   end
 end

data/lib/exception_notifier/rake/version.rb

@@ -1,5 +1,5 @@
 class ExceptionNotifier
   class Rake
-    VERSION = '0.0.5'
+    VERSION = '0.0.6'
   end
 end

data/test/rake_test.rb

@@ -5,6 +5,9 @@ require 'exception_notifier/rake'
 
 class RakeTest < Test::Unit::TestCase
 
+  class IgnoredException < Exception
+  end
+
   def setup
     ExceptionNotifier::Rake.reset_for_test
     assert !ExceptionNotifier::Rake.configured?
@@ -56,4 +59,19 @@ class RakeTest < Test::Unit::TestCase
     ExceptionNotifier::Rake.maybe_deliver_notification(ex, data)
     assert_equal(original_options, options)
   end
+
+  def test_maybe_deliver_notifications_with_ignore_if
+    ExceptionNotifier::Rake.configure(
+      :ignore_if => lambda { |env, e| true })
+    ExceptionNotifier::Rake.maybe_deliver_notification(Exception.new)
+  end
+
+  def test_maybe_deliver_notifications_with_ignore_exceptions
+    ExceptionNotifier::Rake.configure(
+      :ignore_exceptions => ['RakeTest::IgnoredException'])
+    ExceptionNotifier::Rake.maybe_deliver_notification(IgnoredException.new)
+    ex = Exception.new
+    expect_delivery(ex, ExceptionNotifier::Rake.notifier_options)
+    ExceptionNotifier::Rake.maybe_deliver_notification(ex)
+  end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: exception_notification-rake
 version: !ruby/object:Gem::Version
-  version: 0.0.5
+  version: 0.0.6
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-04-30 00:00:00.000000000 Z
+date: 2014-01-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: exception_notification