exception_handling 3.0.pre.1 → 3.0.0.pre.2

data/{test/unit/exception_handling/log_error_stub_test.rb → spec/unit/exception_handling/log_error_stub_spec.rb}

@@ -1,27 +1,27 @@
 # frozen_string_literal: true
 
-require File.expand_path('../../test_helper',  __dir__)
+require File.expand_path('../../spec_helper',  __dir__)
 
 module ExceptionHandling
-  class LogErrorStubTest < ActiveSupport::TestCase
+  describe LogErrorStub do
 
     include LogErrorStub
 
     context "while running tests" do
-      setup do
+      before do
         setup_log_error_stub
       end
 
-      teardown do
+      after do
         teardown_log_error_stub
       end
 
-      should "raise an error when log_error and log_warning are called" do
+      it "raise an error when log_error and log_warning are called" do
         begin
           ExceptionHandling.log_error("Something happened")
           flunk
         rescue Exception => ex # LogErrorStub::UnexpectedExceptionLogged => ex
-          assert ex.to_s.starts_with?("StandardError: Something happened"), ex.to_s
+          expect(ex.to_s.starts_with?("StandardError: Something happened")).to be_truthy
         end
 
         begin
@@ -31,16 +31,16 @@ module ExceptionHandling
           begin
             ExceptionHandling.log_error(ex)
           rescue LogErrorStub::UnexpectedExceptionLogged => ex
-            assert ex.to_s.starts_with?("RaisedError: This should raise"), ex.to_s
+            expect(ex.to_s.starts_with?("RaisedError: This should raise")).to be_truthy
           end
         end
       end
 
-      should "allow for the regex specification of an expected exception to be ignored" do
+      it "allow for the regex specification of an expected exception to be ignored" do
         exception_pattern = /StandardError: This is a test error/
-        assert_nil exception_whitelist # test that exception expectations are cleared
+        expect(exception_whitelist).to be_nil  # test that exception expectations are cleared
         expects_exception(exception_pattern)
-        assert_equal exception_pattern, exception_whitelist[0][0]
+        expect(exception_whitelist[0][0]).to eq(exception_pattern)
         begin
           ExceptionHandling.log_error("This is a test error")
         rescue StandardError
@@ -48,11 +48,11 @@ module ExceptionHandling
         end
       end
 
-      should "allow for the string specification of an expected exception to be ignored" do
+      it "allow for the string specification of an expected exception to be ignored" do
         exception_pattern = "StandardError: This is a test error"
-        assert_nil exception_whitelist # test that exception expectations are cleared
+        expect(exception_whitelist).to be_nil # test that exception expectations are cleared
         expects_exception(exception_pattern)
-        assert_equal exception_pattern, exception_whitelist[0][0]
+        expect(exception_whitelist[0][0]).to eq(exception_pattern)
         begin
           ExceptionHandling.log_error("This is a test error")
         rescue StandardError
@@ -60,9 +60,9 @@ module ExceptionHandling
         end
       end
 
-      should "allow multiple errors to be ignored" do
+      it "allow multiple errors to be ignored" do
         class IgnoredError < StandardError; end
-        assert_nil exception_whitelist # test that exception expectations are cleared
+        expect(exception_whitelist).to be_nil # test that exception expectations are cleared
         expects_exception(/StandardError: This is a test error/)
         expects_exception(/IgnoredError: This should be ignored/)
         ExceptionHandling.log_error("This is a test error")
@@ -73,7 +73,7 @@ module ExceptionHandling
         end
       end
 
-      should "expect exception twice if declared twice" do
+      it "expect exception twice if declared twice" do
         expects_exception(/StandardError: ERROR: I love lamp/)
         expects_exception(/StandardError: ERROR: I love lamp/)
         ExceptionHandling.log_error("ERROR: I love lamp")
@@ -82,23 +82,39 @@ module ExceptionHandling
     end
 
     context "teardown_log_error_stub" do
-      should "support MiniTest framework for adding a failure" do
+      before do
+        RSpec.configure do |config|
+          config.mock_with :rspec do |mocks|
+            mocks.verify_partial_doubles = false
+          end
+        end
+      end
+
+      after do
+        RSpec.configure do |config|
+          config.mock_with :rspec do |mocks|
+            mocks.verify_partial_doubles = true
+          end
+        end
+      end
+
+      it "support MiniTest framework for adding a failure" do
         expects_exception(/foo/)
 
-        mock(self).is_mini_test?.returns { true }
+        expect(self).to receive(:is_mini_test?) { true }
 
-        mock(self).flunk("log_error expected 1 times with pattern: 'foo' found 0")
+        expect(self).to receive(:flunk).with("log_error expected 1 times with pattern: 'foo' found 0")
         teardown_log_error_stub
 
         self.exception_whitelist = nil
       end
 
-      should "support Test::Unit framework for adding a failure" do
+      it "support Test::Unit framework for adding a failure" do
         expects_exception(/foo/)
 
-        mock(self).is_mini_test?.returns { false }
+        expect(self).to receive(:is_mini_test?) { false }
 
-        mock(self).add_failure("log_error expected 1 times with pattern: 'foo' found 0")
+        expect(self).to receive(:add_failure).with("log_error expected 1 times with pattern: 'foo' found 0")
         teardown_log_error_stub
 
         self.exception_whitelist = nil

data/spec/unit/exception_handling/logging_methods_spec.rb

@@ -0,0 +1,38 @@
+# frozen_string_literal: true
+
+require File.expand_path('../../spec_helper',  __dir__)
+
+require_relative '../../helpers/exception_helpers'
+
+require "exception_handling/testing"
+
+module ExceptionHandling
+  describe LoggingMethods do
+    include ExceptionHelpers
+
+    def dont_stub_log_error
+      true
+    end
+
+    context "ExceptionHandling::LoggingMethods" do
+      before do
+        @controller = Testing::LoggingMethodsControllerStub.new
+        ExceptionHandling.stub_handler = nil
+      end
+
+      context "#log_warning" do
+        it "be available to the controller" do
+          klass = Class.new
+          klass.include ExceptionHandling::LoggingMethods
+          instance = klass.new
+          expect(instance.methods.include?(:log_warning)).to eq(true)
+        end
+
+        it "call ExceptionHandling#log_warning" do
+          expect(ExceptionHandling).to receive(:log_warning).with("Hi mom")
+          @controller.send(:log_warning, "Hi mom")
+        end
+      end
+    end
+  end
+end