exception_handling 2.5.0 → 2.7.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 7b8df9043df9ecc580c8ea91495410cf37316c113acf43ac7f28dfeb885e235d
-  data.tar.gz: 84f2a6eac09d7388f3c9ffd2e58a4211231aff7ccfe8869b1e307c51e9b02788
+  metadata.gz: afa095c443e845d5430949250d3322dd48aaecafe82fe4c9c2d5ccc7f5564152
+  data.tar.gz: '084ccae5591206c295baada42941ec9c30e27f251de8a5c92724508f0cceda54'
 SHA512:
-  metadata.gz: 958f9994d47ff6ab87082ed04411c62af377e5e317c8f8669c349d4d7d38f4c7d0a88f6119a2c2a83882ed1be8624baf6e4c67e5fe0bedaeeebcfea7921558e5
-  data.tar.gz: c412244a874549ce99d8e0645ceb6b56a59b9b8b92ddba6cbfab8eb83e5159954d13e5e96e119519e4c9e97e5786412f9f3d60ebef66f4bd5aa5c71dbd70901c
+  metadata.gz: 4818cdf704d8fc2c002fbb7d5d0bfa5a5b8ffeeaef5d75304b6bf383ef59b7249894232ba6ea85abb6e0baa84bf758e18cf4415ead62c9e570685825215ec616
+  data.tar.gz: 32b87f2c3ef26d7c7ac830ae7368337141336acdf7e6885df0ab8eb8b9796a1c4ba7c8398947b7f5dcb0d7ea3b4d21878ff11c4484cd9f67aaf85dd4b045bf23

data/.gitignore

@@ -1,6 +1,6 @@
 .idea
 .DS_Store
 .rubocop-http*
-test/reports/*
+spec/reports/*
 gemfiles/*.lock
 pkg/

data/.jenkins/Jenkinsfile

@@ -36,42 +36,58 @@ pipeline {
     stage('Appraisals') {
       parallel {
         stage('Current') {
+          environment {
+            JUNIT_OUTPUT = 'spec/reports/current'
+          }
+
           steps {
-            sh 'JUNIT_OUTPUT_DIR=test/reports/current bundle exec rake'
+            sh "bundle exec rspec --format RspecJunitFormatter --out ${JUNIT_OUTPUT}/rspec.xml"
           }
 
           post {
-            always { junit '*/reports/current/*.xml' }
+            always { junit "${JUNIT_OUTPUT}/*.xml" }
           }
         }
 
         stage('Rails 4') {
+          environment {
+            JUNIT_OUTPUT = 'spec/reports/rails-4'
+          }
+
           steps {
-            sh 'JUNIT_OUTPUT_DIR=test/reports/rails-4 bundle exec appraisal rails-4 rake'
+            sh "bundle exec appraisal rails-4 rspec --format RspecJunitFormatter --out ${JUNIT_OUTPUT}/rspec.xml"
           }
 
           post {
-            always { junit '*/reports/rails-4/*.xml' }
+            always { junit "${JUNIT_OUTPUT}/*.xml" }
           }
         }
 
         stage('Rails 5') {
+          environment {
+            JUNIT_OUTPUT = 'spec/reports/rails-5'
+          }
+
           steps {
-            sh 'JUNIT_OUTPUT_DIR=test/reports/rails-5 bundle exec appraisal rails-5 rake'
+            sh "bundle exec appraisal rails-5 rspec --format RspecJunitFormatter --out ${JUNIT_OUTPUT}/rspec.xml"
           }
 
           post {
-            always { junit '*/reports/rails-5/*.xml' }
+            always { junit "${JUNIT_OUTPUT}/*.xml" }
           }
         }
 
         stage('Rails 6') {
+          environment {
+            JUNIT_OUTPUT = 'spec/reports/rails-6'
+          }
+
           steps {
-            sh 'JUNIT_OUTPUT_DIR=test/reports/rails-6 bundle exec appraisal rails-6 rake'
+            sh "bundle exec appraisal rails-6 rspec --format RspecJunitFormatter --out ${JUNIT_OUTPUT}/rspec.xml"
           }
 
           post {
-            always { junit '*/reports/rails-6/*.xml' }
+            always { junit "${JUNIT_OUTPUT}/*.xml" }
           }
         }
       }

data/.rspec

@@ -0,0 +1,3 @@
+--require spec_helper
+--format progress
+--color

data/CHANGELOG.md

@@ -4,6 +4,21 @@ Inspired by [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
 
 Note: this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [2.7.0] - 2020-10-14
+### Added
+- Added `LoggingMethods` as a replacement for `Methods` without setting controller or checking for long controller action.
+### Deprecated
+- Deprecated `Methods` in favor of `LoggingMethods`.
+
+## [2.6.1] - 2020-10-14
+### Fixed
+- Fixed honeybadger_context_data to always merge `current_context_for_thread`, even if `log_context:` is passed as `nil`.
+
+## [2.6.0] - 2020-08-26
+### Changed
+- Calling `log_warning` will now log with Severity::WARNING rather than FATAL.
+- Reordered the logging to put the exception class next to the message.
+
 ## [2.5.0] - 2020-08-19
 ### Added
 - The `**log_context` passed to `log_error`/`log_warning`/`log_info` is now
@@ -37,6 +52,9 @@ Note: this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0
 ### Changed
 - No longer depends on hobo_support. Uses invoca-utils 0.3 instead.
 
+[2.7.0]: https://github.com/Invoca/exception_handling/compare/v2.6.1...v2.7.0
+[2.6.1]: https://github.com/Invoca/exception_handling/compare/v2.6.0...v2.6.1
+[2.6.0]: https://github.com/Invoca/exception_handling/compare/v2.5.0...v2.6.0
 [2.5.0]: https://github.com/Invoca/exception_handling/compare/v2.4.4...v2.5.0
 [2.4.4]: https://github.com/Invoca/exception_handling/compare/v2.4.3...v2.4.4
 [2.4.3]: https://github.com/Invoca/exception_handling/compare/v2.4.2...v2.4.3

data/Gemfile

@@ -6,10 +6,10 @@ gemspec
 
 gem 'appraisal', '~> 2.2'
 gem 'honeybadger', '3.3.1-1', git: 'git@github.com:Invoca/honeybadger-ruby', ref: 'bb5f2b8a86e4147c38a6270d39ad610fab4dd5e6'
-gem "minitest"
-gem "minitest-reporters"
 gem 'pry'
+gem 'pry-byebug'
 gem 'rake'
-gem 'rr'
+gem 'rspec'
+gem 'rspec_junit_formatter'
 gem 'rubocop'
-gem 'shoulda'
+gem 'test-unit'

data/Gemfile.lock

@@ -8,7 +8,7 @@ GIT
 PATH
   remote: .
   specs:
-    exception_handling (2.5.0)
+    exception_handling (2.7.0)
       actionmailer (>= 4.2, < 7.0)
       actionpack (>= 4.2, < 7.0)
       activesupport (>= 4.2, < 7.0)
@@ -19,56 +19,58 @@ PATH
 GEM
   remote: https://rubygems.org/
   specs:
-    actionmailer (4.2.11.1)
-      actionpack (= 4.2.11.1)
-      actionview (= 4.2.11.1)
-      activejob (= 4.2.11.1)
+    actionmailer (6.0.3.4)
+      actionpack (= 6.0.3.4)
+      actionview (= 6.0.3.4)
+      activejob (= 6.0.3.4)
       mail (~> 2.5, >= 2.5.4)
-      rails-dom-testing (~> 1.0, >= 1.0.5)
-    actionpack (4.2.11.1)
-      actionview (= 4.2.11.1)
-      activesupport (= 4.2.11.1)
-      rack (~> 1.6)
-      rack-test (~> 0.6.2)
-      rails-dom-testing (~> 1.0, >= 1.0.5)
-      rails-html-sanitizer (~> 1.0, >= 1.0.2)
-    actionview (4.2.11.1)
-      activesupport (= 4.2.11.1)
+      rails-dom-testing (~> 2.0)
+    actionpack (6.0.3.4)
+      actionview (= 6.0.3.4)
+      activesupport (= 6.0.3.4)
+      rack (~> 2.0, >= 2.0.8)
+      rack-test (>= 0.6.3)
+      rails-dom-testing (~> 2.0)
+      rails-html-sanitizer (~> 1.0, >= 1.2.0)
+    actionview (6.0.3.4)
+      activesupport (= 6.0.3.4)
       builder (~> 3.1)
-      erubis (~> 2.7.0)
-      rails-dom-testing (~> 1.0, >= 1.0.5)
-      rails-html-sanitizer (~> 1.0, >= 1.0.3)
-    activejob (4.2.11.1)
-      activesupport (= 4.2.11.1)
-      globalid (>= 0.3.0)
-    activesupport (4.2.11.1)
-      i18n (~> 0.7)
+      erubi (~> 1.4)
+      rails-dom-testing (~> 2.0)
+      rails-html-sanitizer (~> 1.1, >= 1.2.0)
+    activejob (6.0.3.4)
+      activesupport (= 6.0.3.4)
+      globalid (>= 0.3.6)
+    activesupport (6.0.3.4)
+      concurrent-ruby (~> 1.0, >= 1.0.2)
+      i18n (>= 0.7, < 2)
       minitest (~> 5.1)
-      thread_safe (~> 0.3, >= 0.3.4)
       tzinfo (~> 1.1)
-    ansi (1.5.0)
+      zeitwerk (~> 2.2, >= 2.2.2)
     appraisal (2.2.0)
       bundler
       rake
       thor (>= 0.14.0)
     ast (2.4.0)
-    builder (3.2.3)
+    builder (3.2.4)
+    byebug (11.1.3)
     coderay (1.1.2)
-    concurrent-ruby (1.1.5)
-    contextual_logger (0.9.1)
+    concurrent-ruby (1.1.7)
+    contextual_logger (0.11.0)
       activesupport
       json
     crass (1.0.6)
-    erubis (2.7.0)
+    diff-lcs (1.4.4)
+    erubi (1.9.0)
     eventmachine (1.2.7)
     globalid (0.4.2)
       activesupport (>= 4.2.0)
-    i18n (0.9.5)
+    i18n (1.8.5)
       concurrent-ruby (~> 1.0)
     invoca-utils (0.4.1)
     jaro_winkler (1.5.3)
     json (2.3.1)
-    loofah (2.6.0)
+    loofah (2.7.0)
       crass (~> 1.0.2)
       nokogiri (>= 1.5.9)
     mail (2.7.1)
@@ -76,34 +78,44 @@ GEM
     method_source (0.9.2)
     mini_mime (1.0.2)
     mini_portile2 (2.4.0)
-    minitest (5.11.3)
-    minitest-reporters (1.0.20)
-      ansi
-      builder
-      minitest (>= 5.0)
-      ruby-progressbar
+    minitest (5.14.2)
     nokogiri (1.10.10)
       mini_portile2 (~> 2.4.0)
     parallel (1.17.0)
     parser (2.6.3.0)
       ast (~> 2.4.0)
+    power_assert (1.2.0)
     pry (0.12.2)
       coderay (~> 1.1.0)
       method_source (~> 0.9.0)
-    rack (1.6.13)
-    rack-test (0.6.3)
-      rack (>= 1.0)
-    rails-deprecated_sanitizer (1.0.3)
-      activesupport (>= 4.2.0.alpha)
-    rails-dom-testing (1.0.9)
-      activesupport (>= 4.2.0, < 5.0)
-      nokogiri (~> 1.6)
-      rails-deprecated_sanitizer (>= 1.0.1)
+    pry-byebug (3.8.0)
+      byebug (~> 11.0)
+      pry (~> 0.10)
+    rack (2.2.3)
+    rack-test (1.1.0)
+      rack (>= 1.0, < 3)
+    rails-dom-testing (2.0.3)
+      activesupport (>= 4.2.0)
+      nokogiri (>= 1.6)
     rails-html-sanitizer (1.3.0)
       loofah (~> 2.3)
     rainbow (3.0.0)
     rake (13.0.1)
-    rr (1.2.1)
+    rspec (3.9.0)
+      rspec-core (~> 3.9.0)
+      rspec-expectations (~> 3.9.0)
+      rspec-mocks (~> 3.9.0)
+    rspec-core (3.9.2)
+      rspec-support (~> 3.9.3)
+    rspec-expectations (3.9.2)
+      diff-lcs (>= 1.2.0, < 2.0)
+      rspec-support (~> 3.9.0)
+    rspec-mocks (3.9.1)
+      diff-lcs (>= 1.2.0, < 2.0)
+      rspec-support (~> 3.9.0)
+    rspec-support (3.9.3)
+    rspec_junit_formatter (0.4.1)
+      rspec-core (>= 2, < 4, != 2.12.0)
     rubocop (0.74.0)
       jaro_winkler (~> 1.5.1)
       parallel (~> 1.10)
@@ -112,17 +124,14 @@ GEM
       ruby-progressbar (~> 1.7)
       unicode-display_width (>= 1.4.0, < 1.7)
     ruby-progressbar (1.10.1)
-    shoulda (3.6.0)
-      shoulda-context (~> 1.0, >= 1.0.1)
-      shoulda-matchers (~> 3.0)
-    shoulda-context (1.2.2)
-    shoulda-matchers (3.1.3)
-      activesupport (>= 4.0.0)
+    test-unit (3.3.6)
+      power_assert
     thor (1.0.1)
     thread_safe (0.3.6)
-    tzinfo (1.2.5)
+    tzinfo (1.2.7)
       thread_safe (~> 0.1)
     unicode-display_width (1.6.0)
+    zeitwerk (2.4.0)
 
 PLATFORMS
   ruby
@@ -131,13 +140,13 @@ DEPENDENCIES
   appraisal (~> 2.2)
   exception_handling!
   honeybadger (= 3.3.1.pre.1)!
-  minitest
-  minitest-reporters
   pry
+  pry-byebug
   rake
-  rr
+  rspec
+  rspec_junit_formatter
   rubocop
-  shoulda
+  test-unit
 
 BUNDLED WITH
    1.17.3

data/Rakefile

@@ -1,14 +1,15 @@
 #!/usr/bin/env rake
 # frozen_string_literal: true
 
-require "bundler/gem_tasks"
 require 'rake/testtask'
+require "bundler/gem_tasks"
 
-require_relative 'test/rake_test_warning_false'
-
-task default: :test
+require_relative 'spec/rake_test_warning_false'
 
-Rake::TestTask.new do |t|
-  t.pattern = "test/**/*_test.rb"
+desc "run rspec unit tests"
+begin
+  require 'rspec/core/rake_task'
+  RSpec::Core::RakeTask.new(:rspec)
 end
 
+task default: :rspec

data/gemfiles/rails_4.gemfile

@@ -4,13 +4,13 @@ source "https://rubygems.org"
 
 gem "appraisal", "~> 2.2"
 gem "honeybadger", "3.3.1-1", git: "git@github.com:Invoca/honeybadger-ruby", ref: "bb5f2b8a86e4147c38a6270d39ad610fab4dd5e6"
-gem "minitest"
-gem "minitest-reporters"
 gem "pry"
+gem "pry-byebug"
 gem "rake"
-gem "rr"
+gem "rspec"
+gem "rspec_junit_formatter"
 gem "rubocop"
-gem "shoulda"
+gem "test-unit"
 gem "actionmailer", "~> 4.2"
 gem "actionpack", "~> 4.2"
 gem "activesupport", "~> 4.2"

data/gemfiles/rails_5.gemfile

@@ -4,13 +4,13 @@ source "https://rubygems.org"
 
 gem "appraisal", "~> 2.2"
 gem "honeybadger", "3.3.1-1", git: "git@github.com:Invoca/honeybadger-ruby", ref: "bb5f2b8a86e4147c38a6270d39ad610fab4dd5e6"
-gem "minitest"
-gem "minitest-reporters"
 gem "pry"
+gem "pry-byebug"
 gem "rake"
-gem "rr"
+gem "rspec"
+gem "rspec_junit_formatter"
 gem "rubocop"
-gem "shoulda"
+gem "test-unit"
 gem "actionmailer", "~> 5.2"
 gem "actionpack", "~> 5.2"
 gem "activesupport", "~> 5.2"

data/gemfiles/rails_6.gemfile

@@ -4,13 +4,13 @@ source "https://rubygems.org"
 
 gem "appraisal", "~> 2.2"
 gem "honeybadger", "3.3.1-1", git: "git@github.com:Invoca/honeybadger-ruby", ref: "bb5f2b8a86e4147c38a6270d39ad610fab4dd5e6"
-gem "minitest"
-gem "minitest-reporters"
 gem "pry"
+gem "pry-byebug"
 gem "rake"
-gem "rr"
+gem "rspec"
+gem "rspec_junit_formatter"
 gem "rubocop"
-gem "shoulda"
+gem "test-unit"
 gem "actionmailer", "~> 6.0"
 gem "actionpack", "~> 6.0"
 gem "activesupport", "~> 6.0"

data/lib/exception_handling.rb

@@ -29,6 +29,8 @@ module ExceptionHandling # never included
   AUTHENTICATION_HEADERS = ['HTTP_AUTHORIZATION', 'X-HTTP_AUTHORIZATION', 'X_HTTP_AUTHORIZATION', 'REDIRECT_X_HTTP_AUTHORIZATION'].freeze
   HONEYBADGER_STATUSES   = [:success, :failure, :skipped].freeze
 
+  Deprecation3_0 = ActiveSupport::Deprecation.new('3.0', 'exception_handling')
+
   class << self
 
     #
@@ -54,8 +56,6 @@ module ExceptionHandling # never included
       @logger or raise ArgumentError, "You must assign a value to #{name}.logger"
     end
 
-    Deprecation3_0 = ActiveSupport::Deprecation.new('3.0', 'exception_handling')
-
     def logger=(logger)
       @logger = if logger.nil? || logger.is_a?(ContextualLogger::LoggerMixin)
                   logger
@@ -222,7 +222,13 @@ module ExceptionHandling # never included
     #
     def write_exception_to_log(ex, exception_context, timestamp, log_context = {})
       ActiveSupport::Deprecation.silence do
-        ExceptionHandling.logger.fatal("\nExceptionHandlingError (Error:#{timestamp}) #{ex.class} #{exception_context} (#{encode_utf8(ex.message.to_s)}):\n  " + clean_backtrace(ex).join("\n  ") + "\n\n", log_context)
+        log_message = "#{exception_context}\n#{ex.class}: (#{encode_utf8(ex.message.to_s)}):\n  " + clean_backtrace(ex).join("\n  ") + "\n\n"
+
+        if ex.is_a?(Warning)
+          ExceptionHandling.logger.warn("\nExceptionHandlingWarning (Warning:#{timestamp}) #{log_message}", log_context)
+        else
+          ExceptionHandling.logger.fatal("\nExceptionHandlingError (Error:#{timestamp}) #{log_message}", log_context)
+        end
       end
     end