exception_handling 0.1.1 → 0.1.2

checksums.yaml

@@ -0,0 +1,7 @@
+---
+SHA1:
+  metadata.gz: f044af7181eaef68a7eb2256d23d600c4a00e40a
+  data.tar.gz: 68e5bb626894789472c54d2cb3013f93420ea0aa
+SHA512:
+  metadata.gz: 4669ab83c2a33f593522f035ff2c79374bd515aea0b7e1499ed3c2027a1ef899a6bae41813bb7184324b292eddbb6160f68399799d0f19b119be5df537f3c124
+  data.tar.gz: cbe924a30ee2899b16e8c83e5625042c6547c6c476527c0c15c66b5679d22dafac6e40d993218a0e2440e854513e44913b3cc08dfa45e87c5dd7dcd0f0e56da6

data/.ruby-version

@@ -0,0 +1 @@
+2.0.0-p247

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    exception_handling (0.1.1)
+    exception_handling (0.1.2)
       actionmailer (= 3.2.13)
       actionpack (= 3.2.13)
       activesupport (= 3.2.13)
@@ -41,7 +41,7 @@ GEM
       mime-types (~> 1.16)
       treetop (~> 1.4.8)
     metaclass (0.0.1)
-    mime-types (1.24)
+    mime-types (1.25.1)
     mocha (0.13.0)
       metaclass (~> 0.0.1)
     multi_json (1.7.8)

data/lib/exception_handling/version.rb

@@ -1,3 +1,3 @@
 module ExceptionHandling
-  VERSION = "0.1.1"
+  VERSION = "0.1.2"
 end

data/lib/exception_handling.rb

@@ -209,6 +209,14 @@ EOF
       return nil
     end
 
+    def ensure_completely_safe( exception_context = "" )
+      yield
+    rescue SystemExit, SystemStackError, NoMemoryError, SecurityError, SignalException
+      raise
+    rescue Exception => ex
+      log_error ex, exception_context
+    end
+
     def ensure_escalation( email_subject )
       begin
         yield

data/test/exception_handling_test.rb

@@ -178,41 +178,94 @@ end
       end
     end
 
-    context "ExceptionHandling::ensure_safe" do
+    context "ExceptionHandling.ensure_safe" do
       should "log an exception if an exception is raised." do
         ExceptionHandling.logger.expects(:fatal).with( ) { |ex| ex =~ /\(blah\):\n.*exception_handling_test\.rb/ or raise "Unexpected: #{ex.inspect}" }
-        ExceptionHandling::ensure_safe { raise ArgumentError.new("blah") }
+        ExceptionHandling.ensure_safe { raise ArgumentError.new("blah") }
       end
 
       should "should not log an exception if an exception is not raised." do
         ExceptionHandling.logger.expects(:fatal).never
-        ExceptionHandling::ensure_safe { ; }
+        ExceptionHandling.ensure_safe { ; }
       end
 
       should "return its value if used during an assignment" do
         ExceptionHandling.logger.expects(:fatal).never
-        b = ExceptionHandling::ensure_safe { 5 }
+        b = ExceptionHandling.ensure_safe { 5 }
         assert_equal 5, b
       end
 
       should "return nil if an exception is raised during an assignment" do
         ExceptionHandling.logger.expects(:fatal).returns(nil)
-        b = ExceptionHandling::ensure_safe { raise ArgumentError.new("blah") }
+        b = ExceptionHandling.ensure_safe { raise ArgumentError.new("blah") }
         assert_equal nil, b
       end
 
       should "allow a message to be appended to the error when logged." do
         ExceptionHandling.logger.expects(:fatal).with( ) { |ex| ex =~ /mooo \(blah\):\n.*exception_handling_test\.rb/ or raise "Unexpected: #{ex.inspect}" }
-        b = ExceptionHandling::ensure_safe("mooo") { raise ArgumentError.new("blah") }
+        b = ExceptionHandling.ensure_safe("mooo") { raise ArgumentError.new("blah") }
         assert_nil b
       end
+
+      should "only rescue StandardError and descendents" do
+        assert_raise(Exception) { ExceptionHandling.ensure_safe("mooo") { raise Exception } }
+
+        ExceptionHandling.logger.expects(:fatal).with( ) { |ex| ex =~ /mooo \(blah\):\n.*exception_handling_test\.rb/ or raise "Unexpected: #{ex.inspect}" }
+        b = ExceptionHandling.ensure_safe("mooo") { raise StandardError.new("blah") }
+        assert_nil b
+      end
+    end
+
+    context "ExceptionHandling.ensure_completely_safe" do
+      should "log an exception if an exception is raised." do
+        ExceptionHandling.logger.expects(:fatal).with( ) { |ex| ex =~ /\(blah\):\n.*exception_handling_test\.rb/ or raise "Unexpected: #{ex.inspect}" }
+        ExceptionHandling.ensure_completely_safe { raise ArgumentError.new("blah") }
+      end
+
+      should "should not log an exception if an exception is not raised." do
+        ExceptionHandling.logger.expects(:fatal).never
+        ExceptionHandling.ensure_completely_safe { ; }
+      end
+
+      should "return its value if used during an assignment" do
+        ExceptionHandling.logger.expects(:fatal).never
+        b = ExceptionHandling.ensure_completely_safe { 5 }
+        assert_equal 5, b
+      end
+
+      should "return nil if an exception is raised during an assignment" do
+        ExceptionHandling.logger.expects(:fatal).returns(nil)
+        b = ExceptionHandling.ensure_completely_safe { raise ArgumentError.new("blah") }
+        assert_equal nil, b
+      end
+
+      should "allow a message to be appended to the error when logged." do
+        ExceptionHandling.logger.expects(:fatal).with( ) { |ex| ex =~ /mooo \(blah\):\n.*exception_handling_test\.rb/ or raise "Unexpected: #{ex.inspect}" }
+        b = ExceptionHandling.ensure_completely_safe("mooo") { raise ArgumentError.new("blah") }
+        assert_nil b
+      end
+
+      should "rescue any instance or child of Exception" do
+        ExceptionHandling.logger.expects(:fatal).with( ) { |ex| ex =~ /\(blah\):\n.*exception_handling_test\.rb/ or raise "Unexpected: #{ex.inspect}" }
+        ExceptionHandling::ensure_completely_safe { raise Exception.new("blah") }
+      end
+
+      should "not rescue the special exceptions that Ruby uses" do
+        [SystemExit, SystemStackError, NoMemoryError, SecurityError].each do |exception|
+          assert_raise exception do
+            ExceptionHandling.ensure_completely_safe do
+              raise exception.new
+            end
+          end
+        end
+      end
     end
 
-    context "ExceptionHandling::ensure_escalation" do
+    context "ExceptionHandling.ensure_escalation" do
       should "log the exception as usual and send the proper email" do
         assert_equal 0, ActionMailer::Base.deliveries.count
         ExceptionHandling.logger.expects(:fatal).with( ) { |ex| ex =~ /\(blah\):\n.*exception_handling_test\.rb/ or raise "Unexpected: #{ex.inspect}" }
-        ExceptionHandling::ensure_escalation( "Favorite Feature") { raise ArgumentError.new("blah") }
+        ExceptionHandling.ensure_escalation( "Favorite Feature") { raise ArgumentError.new("blah") }
         assert_equal 2, ActionMailer::Base.deliveries.count
         email = ActionMailer::Base.deliveries.last
         assert_equal 'test Escalation: Favorite Feature', email.subject
@@ -223,7 +276,7 @@ end
       should "should not escalate if an exception is not raised." do
         assert_equal 0, ActionMailer::Base.deliveries.count
         ExceptionHandling.logger.expects(:fatal).never
-        ExceptionHandling::ensure_escalation('Ignored') { ; }
+        ExceptionHandling.ensure_escalation('Ignored') { ; }
         assert_equal 0, ActionMailer::Base.deliveries.count
       end
 
@@ -234,7 +287,7 @@ end
 
         $stderr.stubs(:puts)
         ExceptionHandling.logger.expects(:fatal).times(2).with { |ex| ex =~ exception_regexs[exception_count] or raise "Unexpected [#{exception_count}]: #{ex.inspect}"; exception_count += 1; true }
-        ExceptionHandling::ensure_escalation("Not Used") { raise ArgumentError.new("first_test_exception") }
+        ExceptionHandling.ensure_escalation("Not Used") { raise ArgumentError.new("first_test_exception") }
         #assert_equal 0, ActionMailer::Base.deliveries.count
       end
     end
@@ -246,7 +299,7 @@ end
 
       should "include the timestamp when the exception is logged" do
         ExceptionHandling.logger.expects(:fatal).with { |ex| ex =~ /\(Error:517033020\) ArgumentError mooo \(blah\):\n.*exception_handling_test\.rb/ or raise "Unexpected: #{ex.inspect}" }
-        b = ExceptionHandling::ensure_safe("mooo") { raise ArgumentError.new("blah") }
+        b = ExceptionHandling.ensure_safe("mooo") { raise ArgumentError.new("blah") }
         assert_nil b
 
         assert_equal 517033020, ExceptionHandling.last_exception_timestamp
@@ -732,20 +785,20 @@ end
           end
         end
 
-        context "ExceptionHandling::log_error" do
+        context "ExceptionHandling.log_error" do
           should "log errors" do
             ExceptionHandling.logger.expects(:fatal).with( ) { |ex| ex =~ /\(blah\):\n.*exception_handling_test\.rb/ or raise "Unexpected: #{ex.inspect}" }
-            ExceptionHandling::log_error( @argument_error )
+            ExceptionHandling.log_error( @argument_error )
           end
 
           should "log errors from strings" do
             ExceptionHandling.logger.expects(:fatal).with( ) { |ex| ex =~ /\(blah\):\n.*exception_handling\.rb/ or raise "Unexpected: #{ex.inspect}" }
-            ExceptionHandling::log_error( "blah" )
+            ExceptionHandling.log_error( "blah" )
           end
 
           should "log errors with strings" do
             ExceptionHandling.logger.expects(:fatal).with( ) { |ex| ex =~ /mooo.*\(blah\):\n.*exception_handling_test\.rb/ or raise "Unexpected: #{ex.inspect}" }
-            ExceptionHandling::log_error( @argument_error, "mooo" )
+            ExceptionHandling.log_error( @argument_error, "mooo" )
           end
         end
       end

metadata

@@ -1,130 +1,122 @@
---- !ruby/object:Gem::Specification 
+--- !ruby/object:Gem::Specification
 name: exception_handling
-version: !ruby/object:Gem::Version 
-  prerelease: false
-  segments: 
-  - 0
-  - 1
-  - 1
-  version: 0.1.1
+version: !ruby/object:Gem::Version
+  version: 0.1.2
 platform: ruby
-authors: 
+authors:
 - Colin Kelley
 autorequire: 
 bindir: bin
 cert_chain: []
-
-date: 2013-08-26 00:00:00 -07:00
-default_executable: 
-dependencies: 
-- !ruby/object:Gem::Dependency 
-  type: :runtime
-  version_requirements: &id001 !ruby/object:Gem::Requirement 
-    requirements: 
-    - - ">="
-      - !ruby/object:Gem::Version 
-        segments: 
-        - 0
-        - 12
-        - 10
-        version: 0.12.10
+date: 2014-01-27 00:00:00.000000000 Z
+dependencies:
+- !ruby/object:Gem::Dependency
   name: eventmachine
-  requirement: *id001
-  prerelease: false
-- !ruby/object:Gem::Dependency 
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: 0.12.10
   type: :runtime
-  version_requirements: &id002 !ruby/object:Gem::Requirement 
-    requirements: 
-    - - "="
-      - !ruby/object:Gem::Version 
-        segments: 
-        - 3
-        - 2
-        - 13
-        version: 3.2.13
-  name: activesupport
-  requirement: *id002
   prerelease: false
-- !ruby/object:Gem::Dependency 
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: 0.12.10
+- !ruby/object:Gem::Dependency
+  name: activesupport
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '='
+      - !ruby/object:Gem::Version
+        version: 3.2.13
   type: :runtime
-  version_requirements: &id003 !ruby/object:Gem::Requirement 
-    requirements: 
-    - - "="
-      - !ruby/object:Gem::Version 
-        segments: 
-        - 3
-        - 2
-        - 13
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '='
+      - !ruby/object:Gem::Version
         version: 3.2.13
+- !ruby/object:Gem::Dependency
   name: actionpack
-  requirement: *id003
-  prerelease: false
-- !ruby/object:Gem::Dependency 
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '='
+      - !ruby/object:Gem::Version
+        version: 3.2.13
   type: :runtime
-  version_requirements: &id004 !ruby/object:Gem::Requirement 
-    requirements: 
-    - - "="
-      - !ruby/object:Gem::Version 
-        segments: 
-        - 3
-        - 2
-        - 13
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '='
+      - !ruby/object:Gem::Version
         version: 3.2.13
+- !ruby/object:Gem::Dependency
   name: actionmailer
-  requirement: *id004
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '='
+      - !ruby/object:Gem::Version
+        version: 3.2.13
+  type: :runtime
   prerelease: false
-- !ruby/object:Gem::Dependency 
-  type: :development
-  version_requirements: &id005 !ruby/object:Gem::Requirement 
-    requirements: 
-    - - ">="
-      - !ruby/object:Gem::Version 
-        segments: 
-        - 0
-        - 9
-        version: "0.9"
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '='
+      - !ruby/object:Gem::Version
+        version: 3.2.13
+- !ruby/object:Gem::Dependency
   name: rake
-  requirement: *id005
-  prerelease: false
-- !ruby/object:Gem::Dependency 
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0.9'
   type: :development
-  version_requirements: &id006 !ruby/object:Gem::Requirement 
-    requirements: 
-    - - "="
-      - !ruby/object:Gem::Version 
-        segments: 
-        - 3
-        - 1
-        - 1
-        version: 3.1.1
-  name: shoulda
-  requirement: *id006
   prerelease: false
-- !ruby/object:Gem::Dependency 
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0.9'
+- !ruby/object:Gem::Dependency
+  name: shoulda
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '='
+      - !ruby/object:Gem::Version
+        version: 3.1.1
   type: :development
-  version_requirements: &id007 !ruby/object:Gem::Requirement 
-    requirements: 
-    - - "="
-      - !ruby/object:Gem::Version 
-        segments: 
-        - 0
-        - 13
-        - 0
-        version: 0.13.0
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '='
+      - !ruby/object:Gem::Version
+        version: 3.1.1
+- !ruby/object:Gem::Dependency
   name: mocha
-  requirement: *id007
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '='
+      - !ruby/object:Gem::Version
+        version: 0.13.0
+  type: :development
   prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '='
+      - !ruby/object:Gem::Version
+        version: 0.13.0
 description: Exception handling logger/emailer
-email: 
+email:
 - colindkelley@gmail.com
 executables: []
-
 extensions: []
-
 extra_rdoc_files: []
-
-files: 
+files:
 - .gitignore
+- .ruby-version
 - Gemfile
 - Gemfile.lock
 - LICENSE
@@ -141,37 +133,31 @@ files:
 - views/exception_handling/mailer/escalation_notification.html.erb
 - views/exception_handling/mailer/exception_notification.html.erb
 - views/exception_handling/mailer/log_parser_exception_notification.html.erb
-has_rdoc: true
 homepage: https://github.com/RingRevenue/exception_handling
 licenses: []
-
+metadata: {}
 post_install_message: 
 rdoc_options: []
-
-require_paths: 
+require_paths:
 - lib
-required_ruby_version: !ruby/object:Gem::Requirement 
-  requirements: 
-  - - ">="
-    - !ruby/object:Gem::Version 
-      segments: 
-      - 0
-      version: "0"
-required_rubygems_version: !ruby/object:Gem::Requirement 
-  requirements: 
-  - - ">="
-    - !ruby/object:Gem::Version 
-      segments: 
-      - 0
-      version: "0"
+required_ruby_version: !ruby/object:Gem::Requirement
+  requirements:
+  - - '>='
+    - !ruby/object:Gem::Version
+      version: '0'
+required_rubygems_version: !ruby/object:Gem::Requirement
+  requirements:
+  - - '>='
+    - !ruby/object:Gem::Version
+      version: '0'
 requirements: []
-
 rubyforge_project: 
-rubygems_version: 1.3.6
+rubygems_version: 2.0.3
 signing_key: 
-specification_version: 3
-summary: RingRevenue's exception handling logger/emailer layer, based on exception_notifier. Works with Rails or EventMachine or EventMachine+Synchrony.
-test_files: 
+specification_version: 4
+summary: RingRevenue's exception handling logger/emailer layer, based on exception_notifier.
+  Works with Rails or EventMachine or EventMachine+Synchrony.
+test_files:
 - test/exception_handling_test.rb
 - test/mocha_patch.rb
 - test/test_helper.rb