excellent 2.0.0 → 2.0.1

data/lib/simplabs/excellent.rb

@@ -9,7 +9,7 @@ module Simplabs #:nodoc:
 
   module Excellent #:nodoc:
 
-    VERSION = '2.0.0'
+    VERSION = '2.0.1'
 
   end
 

data/lib/simplabs/excellent/parsing/call_context.rb

@@ -48,8 +48,15 @@ module Simplabs
           end
 
           def record_validation
-            if ClassContext::VALIDATIONS.include?(@method) && @parent && @parent.is_a?(ClassContext) && @parent.active_record_model?
-              @parent.validations << @method
+            active_record_parent = if @parent.is_a?(ClassContext)
+              @parent if @parent.active_record_model?
+            elsif @parent.is_a?(BlockContext) && @parent.parent.is_a?(ClassContext)
+              @parent.parent if @parent.parent.active_record_model?
+            else
+              nil
+            end
+            if ClassContext::VALIDATIONS.include?(@method) && !!active_record_parent
+              active_record_parent.validations << @method
             end
           end
 

data/lib/simplabs/excellent/parsing/class_context.rb

@@ -12,6 +12,11 @@ module Simplabs
         include Scopeable
 
         VALIDATIONS = %w(
+          validate
+          validates
+          validates!
+          validates_each
+          validates_with
           validates_acceptance_of
           validates_associated
           validates_confirmation_of

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: excellent
 version: !ruby/object:Gem::Version
-  version: 2.0.0
+  version: 2.0.1
   prerelease: 
 platform: ruby
 authors:
@@ -13,7 +13,7 @@ date: 2009-08-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: ruby_parser
-  requirement: &70322483230640 !ruby/object:Gem::Requirement
+  requirement: !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -21,10 +21,15 @@ dependencies:
         version: '3.0'
   type: :runtime
   prerelease: false
-  version_requirements: *70322483230640
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '3.0'
 - !ruby/object:Gem::Dependency
   name: sexp_processor
-  requirement: &70322483229880 !ruby/object:Gem::Requirement
+  requirement: !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -32,10 +37,15 @@ dependencies:
         version: '4.0'
   type: :runtime
   prerelease: false
-  version_requirements: *70322483229880
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '4.0'
 - !ruby/object:Gem::Dependency
   name: hashr
-  requirement: &70322483228960 !ruby/object:Gem::Requirement
+  requirement: !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -43,7 +53,12 @@ dependencies:
         version: 0.0.10
   type: :runtime
   prerelease: false
-  version_requirements: *70322483228960
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: 0.0.10
 description: Excellent finds the nasty lines in your code. It implements a comprehensive
   set of checks for possibly buggy parts of your app that would otherwise make it
   into your repo and eventually to the production server.
@@ -53,9 +68,7 @@ executables:
 extensions: []
 extra_rdoc_files: []
 files:
-- MIT-LICENSE
 - README.md
-- History.txt
 - bin/excellent
 - lib/simplabs/excellent/checks/abc_metric_method_check.rb
 - lib/simplabs/excellent/checks/assignment_in_conditional_check.rb
@@ -152,7 +165,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 1.8.11
+rubygems_version: 1.8.23
 signing_key: 
 specification_version: 2
 summary: Source Code analysis gem for Ruby and Rails

data/History.txt

@@ -1,107 +0,0 @@
-=======
-= 2.0.0
-
-* now supporting config file .excellent.yml in current working directory to configure which specs to run/ not to run with thresholds, patterns etc.
-* predefined globals will not be reported anymore ($!, $@, $&, $`, $', $+, $1, $2.., $~, $=, $/, $\, $,, $;, $., $<, $>, $_, $0, $*, $$, $?, $:, $", $DEBUG, $FILENAME, $LOAD_PATH, $stdin, $stdout, $stderr, $VERBOSE, option variables, $-0, $-a, $-d, $-F, $-i, $-I, $-l, $-p, $-v)
-* enabled previously disable checks again: AbcMetricMethodCheck, ControlCouplingCheck, CyclomaticComplexityBlockCheck, CyclomaticComplexityMethodCheck, ForLoopCheck, FlogBlockCheck, FlogClassCheck, FlogMethodCheck
-* testing now uses Rspec 2
-* internal cleanups/ simplifications
-
-= 1.7.2
-
-* fixed Simplabs::Excellent::Checks::Rails::CustomInitializeMethodCheck
-* fixed Simplabs::Excellent::Checks::MethodNameCheck so it allows method names that exist in Ruby itself
-* fixed Simplabs::Excellent::Checks::GlobalVariableCheck so it doesn't report false positives for rescue bodies
-* made the parser more forgiving/stable in some situations
-
-= 1.7.1
-
-* fixed excellent for Ruby 2.0
-* some internal cleanup
-* support -v switch on command line
-
-= 1.7.0
-
-* fixed issue #24
-* updated ruby_parser and sexp_processor dependencies
-* fixed some wrong line number reports
-
-= 1.6.0
-
-* added Gemfile
-* internal refactoring/cleanups
-
-= 1.5.5
-
-* better option parsing in the executable, (thanks trans, http://github.com/trans)
-* added line count parser (not yet used), (thanks trans, http://github.com/trans)
-
-= 1.5.4
-
-* fixed handling of parser errors
-
-= 1.5.3
-
-* added missing dependency to facets gem
-
-= 1.5.2
-
-* added GlobalVariableCheck
-* added Rails::CustomInitializeMethodCheck
-* added Rails::ParamsHashInViewCheck
-* added Rails::SessionHashInViewCheck
-
-= 1.5.1
-
-* removed duplication checks (they are just too coarse for dynamic languages like Ruby and especially Rails apps where you would call e.g. params all over the place)
-* added Rails::ValidationsCheck to the default checks
-
-= 1.5.0
-
-* new check Rails::ValidationsCheck that reports ActiveRecord models that do not validate anything
-* added DuplicationCheck to default checks
-* split DuplicationCheck up into MethodDuplicationCheck and BlockDuplicationCheck
-
-= 1.4.1
-
-* added Rake Task (see Rakefile for example)
-
-= 1.4.0
-
-* Excellent not parses *.erb files
-* added new check InstanceVarInPartialCheck
-
-= 1.3.1
-
-* FIX (forgot files in gemspec on 1.3.0)
-
-= 1.3.0
-
-* added formatters (currently text and HTML formatting is supported, see README)
-
-= 1.2.2
-
-* fixed specs
-
-= 1.2.1
-
-* renamed Error to Warning
-* added documentation
-
-= 1.2.0
-
-* cleanup
-* added 2 Rails specific checks, AttrAccessibleCheck and AttrProtectedCheck
-
-= 1.1.0
-
-* completely restructured, made everything running in the flow of the SexpProcessor
-* added most tests from reek (except for UtilityFunction and FeatureEnvy)
-
-= 1.0.1
-
-* fixed some errors
-
-= 1.0.0
-
-* this is basically just a custom version of roodi, converted to ruby_parser to be 1.9 safe

data/MIT-LICENSE

@@ -1,20 +0,0 @@
-Copyright (c) 2008-2009 Marco Otte-Witte
-
-Permission is hereby granted, free of charge, to any person obtaining
-a copy of this software and associated documentation files (the
-"Software"), to deal in the Software without restriction, including
-without limitation the rights to use, copy, modify, merge, publish,
-distribute, sublicense, and/or sell copies of the Software, and to
-permit persons to whom the Software is furnished to do so, subject to
-the following conditions:
-
-The above copyright notice and this permission notice shall be
-included in all copies or substantial portions of the Software.
-
-THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
-EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
-MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
-NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE
-LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION
-OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION
-WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.