excel_to_code 0.3.11 → 0.3.12

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 7be4eb5782ad34fe1d4a42bf50083440afcc72e2
-  data.tar.gz: ac3bbda110cc0d9ce8dcbc504fce982e79c849d0
+  metadata.gz: 1ebf3386f4d5efa91662f276d92a69aa8c417b3c
+  data.tar.gz: 555a3e29d093d245839f48220315ad2169f63e96
 SHA512:
-  metadata.gz: 2ca73c4cac5b6acef852961b40cd495e91793b5424ef1833b9bdfbf4614c012bcb7c058eda8139b877e2fa8496d4b74014bd9e6066650e2852e6cf8e68bf7456
-  data.tar.gz: df4a7cc607b058104cabd6f03f1fe2675d352a90d1c63fc5591f22e2ba76450c46cfd076f70ca2ef9d7bf29b98ddb1b82ca4657b35bdb064a189b6126241ef12
+  metadata.gz: 8f8033aa4e8873a5e9b21450f69559de94fbf67c1a717dc9758faebdb753238d551c609e4ff77013fbc7c65879b46e1689ace91bf30b11082a187fde9402925a
+  data.tar.gz: ef3a5b2e3a1a357825ad45de11aaf3706b26a8169219d45a3cdf1fc6a4b3dfe27a64be281d820ce1ea784db8fe2c61e49543e430d695e4c95c8a325811492eb4

data/TODO

@@ -7,7 +7,7 @@ See doc/How_to_fix_parsing_bugs.md for help
 * Whitespace handling in table references
 * Whitespace handling between arguments in a list
 * Doesn't do range unions (e.g., 10:10 C:C == C:10)
-* Doesn't do manually entered arrays {1,2,3;4,5,6}
+* Doesn't do ranges where both arts have a sheet reference, e.g.: 'G.20 (data)'!Q1149:'G.20 (data)'!Q1153
 
 ## Missing functions
 
@@ -17,13 +17,9 @@ See doc/How_to_add_a_missing_function.md
 
 ## Simplification & optimisation bugs
 
-* Optimize IF, CHOOSE, MATCH, VLOOKUP and similar functions so that they don't have to calculate all their arguments
+* Optimize CHOOSE, MATCH, VLOOKUP and similar functions so that they don't have to calculate all their arguments
 * Fix it so that cells that are being reported as empty, that excel would give a numeric value of zero, are fixed
 
 ## Things that are badly written
 
-* Rewrite the excel_to_ruby command to use command line options
-* Refactor excel_to_c_runtime - split the functions? split the tests?
-* Tool for turning spreadsheets into tests
 * Tool to create minimal failing example out of test run
-* The whole thing is slow. Could hold the whole excel AST in memory and apply transforms?

data/src/commands/excel_to_x.rb

@@ -1022,12 +1022,6 @@ class ExcelToX
 
       @cells_with_formulae.each do |ref, ast|
         begin
-          # FIXME: Shouldn't need to wrap ref.fist in an array
-          inline_replacer.current_sheet_name = [ref.first]
-          inline_replacer.map(ast)
-          # If a formula references a cell containing a value, the reference is replaced with the value (e.g., if A1 := 2 and A2 := A1 + 1 then becomes: A2 := 2 + 1)
-          #require 'pry'; binding.pry if ref == [:"Outputs - Summary table", :E77]
-          value_replacer.map(ast)
           column_and_row_function_replacement.current_reference = ref.last
           if column_and_row_function_replacement.replace(ast)
             references_that_need_updating[ref] = ast
@@ -1035,6 +1029,12 @@ class ExcelToX
           if offset_replacement.replace(ast)
             references_that_need_updating[ref] = ast
           end
+          # FIXME: Shouldn't need to wrap ref.fist in an array
+          inline_replacer.current_sheet_name = [ref.first]
+          inline_replacer.map(ast)
+          # If a formula references a cell containing a value, the reference is replaced with the value (e.g., if A1 := 2 and A2 := A1 + 1 then becomes: A2 := 2 + 1)
+          #require 'pry'; binding.pry if ref == [:"Outputs - Summary table", :E77]
+          value_replacer.map(ast)
           if indirect_replacement.replace(ast)
             references_that_need_updating[ref] = ast
           end

data/src/excel_to_code.rb

@@ -1,5 +1,5 @@
 class ExcelToCode
-  def self.version() "0.3.11" end
+  def self.version() "0.3.12" end
 end
 
 require_relative 'commands'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: excel_to_code
 version: !ruby/object:Gem::Version
-  version: 0.3.11
+  version: 0.3.12
 platform: ruby
 authors:
 - Thomas Counsell, Green on Black Ltd
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-02-06 00:00:00.000000000 Z
+date: 2015-02-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubypeg