excel_functions 0.0.3 → 0.0.4

checksums.yaml

@@ -0,0 +1,15 @@
+---
+!binary "U0hBMQ==":
+  metadata.gz: !binary |-
+    YjVlMWMzZTlkYzhhYjM4MTMwYjI2MDQ2OWY5ODQ1ZDQ5ZTNmZDg4Yw==
+  data.tar.gz: !binary |-
+    YjhiYTNlNzVmMmM0NTlkYjFmZDRmZDIyZGQ5NmY5NjA4N2EwZmM0Yw==
+!binary "U0hBNTEy":
+  metadata.gz: !binary |-
+    OTIzY2RiYjVkMjAwZWRjMjMyYWFlN2I4YjQ2NzJjOTFiNTYxY2MyZWM5ZTg3
+    NDk5MTAwMTFjMTRhNjE0ZTMxYjliNjUzMjk1MzY2MGU2YzM3OWZlY2FiNGMx
+    NjliNTE5YWE0NGI5ZTA1YmU0NmUyYzU4YTMzNGNiYzgyNDQ1ZWY=
+  data.tar.gz: !binary |-
+    MWQ0MmIxMTU0YjVhYjJiNzExZDIzMjZmZjVlNWQzYjg5OTdhMjRhODY4Mjc2
+    ZjZlZjU4MDk1ODRiYzYxNDA1NzJkODg1OWQ3ZWUyZmY0ZDk3OGEwNGQzNTQ3
+    OTU0OTdkMWY5ODc0ZDBmN2M4ZDcxZmE3YTIzODNjMzNjNWM0ZGQ=

data/lib/excel_functions/lookup.rb

@@ -18,12 +18,11 @@ module ExcelFunctions
 
     lookup_array = lookup_array.map{|arr| Array(arr)[0]}
 
-    
-    raise "lookup_array must be sorted" unless lookup_array.sort == lookup_array #better way to check sorted?
-
     index = lookup_array.find_index(value)
     return output_array[index] if index
 
+    #raise only after exact check fails, we only need sorted for approx lookup
+    raise "lookup_array must be sorted" unless lookup_array.sort == lookup_array #better way to check sorted?
     
     first_greater_index = lookup_array.find_index{|look| look > value} || lookup_array.count 
     less_than_index = first_greater_index - 1

data/lib/excel_functions/version.rb

@@ -1,3 +1,3 @@
 module ExcelFunctions
-  VERSION = "0.0.3"
+  VERSION = "0.0.4"
 end

data/spec/excelfunctions_spec.rb

@@ -15,26 +15,35 @@ describe Excel do
   end
   describe "Lookup" do
     #should this be 3 it blocks?
-    it "performs lookup correctly" do
-      input_arr =  [0,0.05,0.1,0.15]
-      output_arr = ["a","b","c","d"]
-      tests = [
+    let(:input_arr){[0,0.05,0.1,0.15]}
+    let(:output_arr){["a","b","c","d"]}
+    let(:tests){[
         [0, "a"],
         [0.1, "c"],
         [0.12, "c"],
         [1, "d"],
         [-1, nil]
-      ]
+      ]}
+    it "performs lookup correctly with 2 arrays" do
       #2 arrays
       tests.each do |(value, result)|
         expect(Excel.lookup(value,input_arr, output_arr)).to be_eql(result)
       end
+    end
+    it "performs lookup correctly with 1 array" do
       #single array
       tests.each do |(value, result)|
         expect(Excel.lookup(value,input_arr.zip(output_arr))).to be_eql(result)
       end
+    end
 
-      expect{Excel.lookup(0.1,input_arr.reverse,output_arr)}.to raise_error
+    context "Unsorted arrays" do
+      it "raises error if unsorted and rough match" do
+        expect{Excel.lookup(0.11,input_arr.reverse,output_arr)}.to raise_error
+      end
+      it "doesnt raise error if unsorted but has exact match" do
+        expect{Excel.lookup(0.1,input_arr.reverse,output_arr)}.to_not raise_error
+      end
     end
   end
 end

metadata

@@ -1,20 +1,18 @@
 --- !ruby/object:Gem::Specification
 name: excel_functions
 version: !ruby/object:Gem::Version
-  version: 0.0.3
-  prerelease: 
+  version: 0.0.4
 platform: ruby
 authors:
 - Karthik T
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-01-29 00:00:00.000000000 Z
+date: 2014-03-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -22,7 +20,6 @@ dependencies:
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -30,7 +27,6 @@ dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
@@ -38,7 +34,6 @@ dependencies:
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
@@ -46,7 +41,6 @@ dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
@@ -54,7 +48,6 @@ dependencies:
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
@@ -81,28 +74,26 @@ files:
 homepage: https://github.com/ktaragorn/excel_functions
 licenses:
 - MIT
+metadata: {}
 post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
   - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
   - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 1.8.23
+rubygems_version: 2.0.5
 signing_key: 
-specification_version: 3
+specification_version: 4
 summary: This gem can be used if you need to reverse engineer any excel spreadsheets.
 test_files:
 - spec/excelfunctions_spec.rb
-has_rdoc: