evilution 1.2.0 → 1.3.0

data/lib/evilution/cli/parser/options_builder.rb

@@ -1,6 +1,7 @@
 # frozen_string_literal: true
 
 require "optparse"
+require_relative "../parser"
 require_relative "../../version"
 require_relative "file_args"
 
@@ -119,6 +120,8 @@ class Evilution::CLI::Parser::OptionsBuilder
                               "(default: auto-detect spec/rails_helper.rb -> spec/spec_helper.rb -> " \
                               "test/test_helper.rb for Rails projects)") { |f| @options[:preload] = f }
     opts.on("--no-preload", "Disable parent-process preload even for Rails projects") { @options[:preload] = false }
+    opts.on("--warmup NAME", "After preload, warm lazily-initialised framework state once " \
+                             "in the parent: none, rails (default: none)") { |w| @options[:warmup] = w }
   end
 
   def add_output_options(opts)

data/lib/evilution/cli/parser/stdin_reader.rb

@@ -1,5 +1,6 @@
 # frozen_string_literal: true
 
+require_relative "../parser"
 require_relative "file_args"
 
 class Evilution::CLI::Parser::StdinReader

data/lib/evilution/cli/parser.rb

@@ -1,5 +1,6 @@
 # frozen_string_literal: true
 
+require_relative "../cli"
 require_relative "parsed_args"
 
 class Evilution::CLI::Parser

data/lib/evilution/cli/printers/tests_list.rb

@@ -24,16 +24,17 @@ class Evilution::CLI::Printers::TestsList
     io.puts(@specs.length == 1 ? "1 spec file" : "#{@specs.length} spec files")
   end
 
+  # Each entry is `{ source:, specs: [...] }`; a source can resolve to several
+  # spec files (spec_mappings), and each gets its own line.
   def render_resolved(io)
     unique_specs = []
     @entries.each do |entry|
       source = entry[:source]
-      spec = entry[:spec]
-      if spec
+      specs = entry[:specs]
+      io.puts("  #{source}  (no spec found)") if specs.empty?
+      specs.each do |spec|
         unique_specs << spec
         io.puts("  #{spec}  (#{source})")
-      else
-        io.puts("  #{source}  (no spec found)")
       end
     end
 

data/lib/evilution/cli/printers.rb

@@ -1,4 +1,6 @@
 # frozen_string_literal: true
 
+require_relative "../cli"
+
 module Evilution::CLI::Printers
 end

data/lib/evilution/cli/result.rb

@@ -1,5 +1,7 @@
 # frozen_string_literal: true
 
+require_relative "../cli"
+
 class Evilution::CLI
   Result = Struct.new(:exit_code, :error, :error_rendered, keyword_init: true) do
     def initialize(exit_code:, error: nil, error_rendered: false)

data/lib/evilution/cli.rb

@@ -1,6 +1,11 @@
 # frozen_string_literal: true
 
 require_relative "version"
+
+# Declared before the children are required: each child requires this file
+# and nests under Evilution::CLI, so the namespace must exist first.
+class Evilution::CLI; end # rubocop:disable Lint/EmptyClass
+
 require_relative "cli/parser"
 require_relative "cli/parsed_args"
 require_relative "cli/printers/subjects"

data/lib/evilution/config/builders.rb

@@ -1,4 +1,6 @@
 # frozen_string_literal: true
 
+require_relative "../config"
+
 module Evilution::Config::Builders
 end

data/lib/evilution/config/env_loader.rb

@@ -1,5 +1,7 @@
 # frozen_string_literal: true
 
+require_relative "../config"
+
 module Evilution::Config::EnvLoader
   module_function
 

data/lib/evilution/config/file_loader.rb

@@ -1,6 +1,7 @@
 # frozen_string_literal: true
 
 require "yaml"
+require_relative "../config"
 
 module Evilution::Config::FileLoader
   module_function

data/lib/evilution/config/sources.rb

@@ -1,5 +1,6 @@
 # frozen_string_literal: true
 
+require_relative "../config"
 require_relative "file_loader"
 require_relative "env_loader"
 

data/lib/evilution/config/validators/example_targeting_cache.rb

@@ -1,5 +1,6 @@
 # frozen_string_literal: true
 
+require_relative "../validators"
 require_relative "base"
 
 class Evilution::Config::Validators::ExampleTargetingCache < Evilution::Config::Validators::Base

data/lib/evilution/config/validators/example_targeting_fallback.rb

@@ -1,5 +1,6 @@
 # frozen_string_literal: true
 
+require_relative "../validators"
 require_relative "base"
 
 class Evilution::Config::Validators::ExampleTargetingFallback < Evilution::Config::Validators::Base

data/lib/evilution/config/validators/example_targeting_strategy.rb

@@ -1,5 +1,6 @@
 # frozen_string_literal: true
 
+require_relative "../validators"
 require_relative "base"
 
 class Evilution::Config::Validators::ExampleTargetingStrategy < Evilution::Config::Validators::Base

data/lib/evilution/config/validators/fail_fast.rb

@@ -1,5 +1,6 @@
 # frozen_string_literal: true
 
+require_relative "../validators"
 require_relative "base"
 
 class Evilution::Config::Validators::FailFast < Evilution::Config::Validators::Base

data/lib/evilution/config/validators/hooks.rb

@@ -1,5 +1,6 @@
 # frozen_string_literal: true
 
+require_relative "../validators"
 require_relative "base"
 
 class Evilution::Config::Validators::Hooks < Evilution::Config::Validators::Base

data/lib/evilution/config/validators/ignore_patterns.rb

@@ -1,5 +1,6 @@
 # frozen_string_literal: true
 
+require_relative "../validators"
 require_relative "base"
 
 class Evilution::Config::Validators::IgnorePatterns < Evilution::Config::Validators::Base

data/lib/evilution/config/validators/integration.rb

@@ -1,5 +1,6 @@
 # frozen_string_literal: true
 
+require_relative "../validators"
 require_relative "base"
 
 class Evilution::Config::Validators::Integration < Evilution::Config::Validators::Base

data/lib/evilution/config/validators/isolation.rb

@@ -1,5 +1,6 @@
 # frozen_string_literal: true
 
+require_relative "../validators"
 require_relative "base"
 
 class Evilution::Config::Validators::Isolation < Evilution::Config::Validators::Base

data/lib/evilution/config/validators/jobs.rb

@@ -1,5 +1,6 @@
 # frozen_string_literal: true
 
+require_relative "../validators"
 require_relative "base"
 
 class Evilution::Config::Validators::Jobs < Evilution::Config::Validators::Base

data/lib/evilution/config/validators/preload.rb

@@ -1,5 +1,6 @@
 # frozen_string_literal: true
 
+require_relative "../validators"
 require_relative "base"
 
 class Evilution::Config::Validators::Preload < Evilution::Config::Validators::Base

data/lib/evilution/config/validators/profile.rb

@@ -1,5 +1,6 @@
 # frozen_string_literal: true
 
+require_relative "../validators"
 require_relative "base"
 
 class Evilution::Config::Validators::Profile < Evilution::Config::Validators::Base

data/lib/evilution/config/validators/spec_mappings.rb

@@ -1,5 +1,6 @@
 # frozen_string_literal: true
 
+require_relative "../validators"
 require_relative "base"
 
 class Evilution::Config::Validators::SpecMappings < Evilution::Config::Validators::Base

data/lib/evilution/config/validators/spec_pattern.rb

@@ -1,5 +1,6 @@
 # frozen_string_literal: true
 
+require_relative "../validators"
 require_relative "base"
 
 class Evilution::Config::Validators::SpecPattern < Evilution::Config::Validators::Base

data/lib/evilution/config/validators/warmup.rb

@@ -0,0 +1,17 @@
+# frozen_string_literal: true
+
+require_relative "../validators"
+require_relative "base"
+
+# `warmup: rails` warms Rails' lazily-initialised state in the parent after
+# the preload; `none` (the default) skips it. `false` is accepted as `none`
+# so `warmup: false` reads naturally in .evilution.yml.
+class Evilution::Config::Validators::Warmup < Evilution::Config::Validators::Base
+  ALLOWED = %i[none rails].freeze
+
+  def self.call(value)
+    return :none if value == false
+
+    coerce_symbol!(value, allowed: ALLOWED, name: "warmup")
+  end
+end

data/lib/evilution/config/validators.rb

@@ -1,4 +1,6 @@
 # frozen_string_literal: true
 
+require_relative "../config"
+
 module Evilution::Config::Validators
 end

data/lib/evilution/config.rb

@@ -21,7 +21,7 @@ class Evilution::Config
     example_targeting_fallback: :full_file, example_targeting_strategy: :lexical,
     example_targeting_cache: { max_files: 50, max_blocks: 10_000 },
     quiet_children: false, quiet_children_dir: "tmp/evilution_children",
-    profile: :default, canary: true
+    profile: :default, canary: true, warmup: :none
   }.freeze
 
   attr_reader :target_files, :schema_version, :timeout, :format,
@@ -33,7 +33,7 @@ class Evilution::Config
               :fallback_to_full_suite, :preload, :spec_mappings, :spec_pattern,
               :example_targeting, :example_targeting_fallback, :example_targeting_strategy,
               :example_targeting_cache,
-              :spec_selector, :quiet_children, :quiet_children_dir, :profile, :canary
+              :spec_selector, :quiet_children, :quiet_children_dir, :profile, :canary, :warmup
 
   def initialize(**options)
     skip_file = options.delete(:skip_config_file) ? true : false
@@ -274,7 +274,7 @@ class Evilution::Config
 
   VALIDATED_ATTRS = %i[
     integration jobs fail_fast isolation ignore_patterns
-    hooks preload spec_mappings spec_pattern profile
+    hooks preload spec_mappings spec_pattern profile warmup
   ].freeze
   private_constant :VALIDATED_ATTRS
 
@@ -311,6 +311,7 @@ require_relative "config/validators/example_targeting_fallback"
 require_relative "config/validators/example_targeting_strategy"
 require_relative "config/validators/example_targeting_cache"
 require_relative "config/validators/profile"
+require_relative "config/validators/warmup"
 require_relative "config/builders"
 require_relative "config/builders/spec_resolver"
 require_relative "config/builders/spec_selector"

data/lib/evilution/coverage.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require_relative "../evilution"
+require_relative "version"
 
 # Per-example line-coverage support: build a `source file:line -> [examples]`
 # map so mutation targeting can run exactly the examples that execute a line.

data/lib/evilution/coverage_example_filter.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require_relative "../evilution"
+require_relative "version"
 require_relative "coverage/map"
 
 # Per-mutation example targeting backed by a real line-coverage Map (EV-ndjd).

data/lib/evilution/diagnostic.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require_relative "../evilution"
+require_relative "version"
 
 # Evilution's own advisory messages -- "no matching spec found", and the like.
 #

data/lib/evilution/example_filter.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 require "prism"
-require_relative "../evilution"
+require_relative "version"
 require_relative "spec_ast_cache"
 
 class Evilution::ExampleFilter

data/lib/evilution/integration/loading/body_call_neutralizer.rb

@@ -13,7 +13,9 @@ require_relative "../loading"
 # Strategy: walk Prism tree, find CallNodes that sit directly under a class
 # or module body (not inside a def). Calls on a small allowlist of patterns
 # known to be idempotent (`include`, `attr_*`, visibility modifiers, etc.)
-# are preserved; everything else is replaced byte-for-byte with `nil`.
+# are preserved; everything else has its source range replaced with `()`.
+# The replacement is shorter than the call it replaces, so edits are applied
+# from the end of the source backwards to keep earlier offsets valid.
 class Evilution::Integration::Loading::BodyCallNeutralizer
   IDEMPOTENT_CALLS = %i[
     include extend prepend using
@@ -25,6 +27,12 @@ class Evilution::Integration::Loading::BodyCallNeutralizer
     require require_relative autoload
   ].to_set.freeze
 
+  # `()` rather than `nil`: under -w Ruby flags a bare `nil` statement as
+  # "possibly useless use of nil in void context", which a project raising on
+  # warnings turns into an error for every mutation of the file. `()` evaluates
+  # to nil without the warning on every supported Ruby (`(nil)` still warns on 3.3).
+  REPLACEMENT = "()"
+
   class << self
     attr_writer :preloaded_features
 
@@ -80,7 +88,7 @@ class Evilution::Integration::Loading::BodyCallNeutralizer
   def apply_edits(source, edits)
     bytes = source.b
     edits.sort_by!(&:first).reverse_each do |start_offset, end_offset|
-      bytes[start_offset, end_offset - start_offset] = "nil"
+      bytes[start_offset, end_offset - start_offset] = REPLACEMENT
     end
     bytes.force_encoding(source.encoding)
   end

data/lib/evilution/integration/loading/test_load_path.rb

@@ -22,29 +22,37 @@ module Evilution::Integration::Loading::TestLoadPath
   # Prepend every relevant test directory to $LOAD_PATH (idempotently).
   # Iterate in reverse so the first entry from #dirs_for ends up frontmost,
   # preserving its order (mirrors how `ruby -Ia -Ib` lands a before b).
-  def add!(files, base: Evilution.project_base_dir)
-    dirs_for(files, base).reverse_each do |dir|
+  def add!(files, base: Evilution.project_base_dir, outside_root_dirs: true)
+    dirs_for(files, base, outside_root_dirs: outside_root_dirs).reverse_each do |dir|
       $LOAD_PATH.unshift(dir) unless $LOAD_PATH.include?(dir)
     end
   end
 
-  # The directories to put on $LOAD_PATH for the given resolved test files:
-  # the conventional test/ and spec/ roots under base, each file's own
-  # directory, and the topmost test/spec ancestor of each file (covers nested
-  # layouts like test/unit, spec/lib, spec/unit). Existing directories only,
-  # and only those inside the project base -- never a broad outside-project dir
-  # (e.g. a /tmp test file), which would over-widen $LOAD_PATH for the whole
-  # process (the baseline runs in the long-lived parent).
-  def dirs_for(files, base)
+  # The directories to put on $LOAD_PATH for the given files: the
+  # conventional test/ and spec/ roots under base, each file's own directory,
+  # and the topmost test/spec ancestor of each file (covers nested layouts
+  # like test/unit, spec/lib, spec/unit). Existing directories only, and only
+  # those inside the project base -- never a broad outside-project dir (e.g. a
+  # /tmp test file), which would over-widen $LOAD_PATH for the whole process
+  # (the baseline runs in the long-lived parent).
+  #
+  # A resolved test file outside every test root (a tests/ layout, a test
+  # reached through --spec or spec_mappings) still contributes its own
+  # directory, mirroring `ruby -Itests`. A preload does not: with
+  # `outside_root_dirs: false`, a `--preload config/evilution_preload.rb`
+  # would otherwise put config/ ahead of the gems, and `require "puma"` during
+  # Bundler.require would load the app's config/puma.rb (GH #1597).
+  def dirs_for(files, base, outside_root_dirs: true)
     base = File.expand_path(base)
     dirs = conventional_roots(base)
     Array(files).each do |file|
       file_dir = File.dirname(File.expand_path(file, base))
-      dirs << file_dir
       root = root_ancestor(file_dir, base)
-      dirs << root if root
+      next unless root || outside_root_dirs
+
+      dirs << file_dir << root
     end
-    dirs.uniq.select { |dir| File.directory?(dir) && within?(dir, base) }
+    dirs.compact.uniq.select { |dir| File.directory?(dir) && within?(dir, base) }
   end
 
   def within?(dir, base)

data/lib/evilution/integration/rspec/state_guard/configuration_state.rb

@@ -1,5 +1,6 @@
 # frozen_string_literal: true
 
+require_relative "../state_guard"
 require_relative "../../rspec"
 
 # Restores the RSpec.configuration state that ::RSpec::Core::Runner.run mutates

data/lib/evilution/integration/rspec/state_guard/configuration_streams.rb

@@ -1,5 +1,6 @@
 # frozen_string_literal: true
 
+require_relative "../state_guard"
 require_relative "../../rspec"
 require_relative "internals"
 

data/lib/evilution/integration/rspec/state_guard/example_groups_constants.rb

@@ -1,9 +1,8 @@
 # frozen_string_literal: true
 
+require_relative "../state_guard"
 require_relative "../../rspec"
 
-class Evilution::Integration::RSpec::StateGuard; end unless defined?(Evilution::Integration::RSpec::StateGuard) # rubocop:disable Lint/EmptyClass
-
 class Evilution::Integration::RSpec::StateGuard::ExampleGroupsConstants
   def snapshot
     return nil unless defined?(::RSpec::ExampleGroups)

data/lib/evilution/integration/rspec/state_guard/internals.rb

@@ -1,9 +1,8 @@
 # frozen_string_literal: true
 
+require_relative "../state_guard"
 require_relative "../../rspec"
 
-class Evilution::Integration::RSpec::StateGuard; end unless defined?(Evilution::Integration::RSpec::StateGuard) # rubocop:disable Lint/EmptyClass
-
 module Evilution::Integration::RSpec::StateGuard::Internals
   module_function
 

data/lib/evilution/integration/rspec/state_guard/object_space_example_groups.rb

@@ -1,9 +1,8 @@
 # frozen_string_literal: true
 
+require_relative "../state_guard"
 require_relative "../../rspec"
 
-class Evilution::Integration::RSpec::StateGuard; end unless defined?(Evilution::Integration::RSpec::StateGuard) # rubocop:disable Lint/EmptyClass
-
 class Evilution::Integration::RSpec::StateGuard::ObjectSpaceExampleGroups
   def snapshot
     groups = Set.new

data/lib/evilution/integration/rspec/state_guard/reporter_arrays.rb

@@ -1,5 +1,6 @@
 # frozen_string_literal: true
 
+require_relative "../state_guard"
 require_relative "../../rspec"
 require_relative "internals"
 

data/lib/evilution/integration/rspec/state_guard/world_example_groups.rb

@@ -1,5 +1,6 @@
 # frozen_string_literal: true
 
+require_relative "../state_guard"
 require_relative "../../rspec"
 require_relative "internals"
 

data/lib/evilution/integration/rspec/state_guard/world_filtered_examples.rb

@@ -1,5 +1,6 @@
 # frozen_string_literal: true
 
+require_relative "../state_guard"
 require_relative "../../rspec"
 require_relative "internals"
 

data/lib/evilution/integration/rspec/state_guard/world_sources_by_path.rb

@@ -1,5 +1,6 @@
 # frozen_string_literal: true
 
+require_relative "../state_guard"
 require_relative "../../rspec"
 require_relative "internals"
 

data/lib/evilution/integration/rspec/state_guard.rb

@@ -1,6 +1,12 @@
 # frozen_string_literal: true
 
 require_relative "../rspec"
+
+# Declared before the children are required: each child requires this file
+# and nests under StateGuard, while DEFAULT_STRATEGIES below needs the
+# children loaded, so the namespace must exist first.
+class Evilution::Integration::RSpec::StateGuard; end # rubocop:disable Lint/EmptyClass
+
 require_relative "state_guard/object_space_example_groups"
 require_relative "state_guard/world_example_groups"
 require_relative "state_guard/world_sources_by_path"

data/lib/evilution/mcp/info_tool/actions/environment.rb

@@ -1,5 +1,6 @@
 # frozen_string_literal: true
 
+require_relative "../actions"
 require_relative "base"
 require_relative "../../../config"
 require_relative "../../../version"

data/lib/evilution/mcp/info_tool/actions/feedback.rb

@@ -1,5 +1,6 @@
 # frozen_string_literal: true
 
+require_relative "../actions"
 require_relative "base"
 require_relative "../../../version"
 require_relative "../../../feedback"

data/lib/evilution/mcp/info_tool/actions/statuses.rb

@@ -1,5 +1,6 @@
 # frozen_string_literal: true
 
+require_relative "../actions"
 require_relative "base"
 require_relative "../status_glossary"
 

data/lib/evilution/mcp/info_tool/actions/subjects.rb

@@ -1,5 +1,6 @@
 # frozen_string_literal: true
 
+require_relative "../actions"
 require_relative "base"
 require_relative "../config_factory"
 require_relative "../../../runner"

data/lib/evilution/mcp/info_tool/actions/tests.rb

@@ -1,5 +1,6 @@
 # frozen_string_literal: true
 
+require_relative "../actions"
 require_relative "base"
 require_relative "../config_factory"
 require_relative "../../../runner"

data/lib/evilution/mutation.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 require "diff/lcs"
-require_relative "../evilution"
+require_relative "version"
 
 class Evilution::Mutation
   Sources = Data.define(:original, :mutated)

data/lib/evilution/mutator/operator/argument_list_removal.rb

@@ -0,0 +1,52 @@
+# frozen_string_literal: true
+
+require_relative "../operator"
+
+# Drop a call's whole argument list: `combine(a, b)` becomes `combine`,
+# `normalize(value)` becomes `normalize`. Every argument kind goes —
+# positional, splat, keywords and `...` — while a block-pass stays attached
+# (`each_slice(2, &block)` becomes `each_slice(&block)`) and so does a
+# literal block.
+#
+# A kill by ArgumentError proves arity is asserted; a survivor means the
+# arguments never mattered. argument_removal drops one argument at a time and
+# only from calls with two or more.
+#
+# Operator methods (`a + b`, `a[i]`) are left to binary operand promotion and
+# attribute writes to attribute_write_to_read.
+class Evilution::Mutator::Operator::ArgumentListRemoval < Evilution::Mutator::Base
+  IDENTIFIER = /\A[[:alpha:]_]/
+  private_constant :IDENTIFIER
+
+  def visit_call_node(node)
+    remove_argument_list(node) if removable?(node)
+    super
+  end
+
+  private
+
+  def removable?(node)
+    node.arguments && node.message_loc && node.name.match?(IDENTIFIER) && !node.attribute_write?
+  end
+
+  def remove_argument_list(node)
+    block_pass = node.block if node.block.is_a?(Prism::BlockArgumentNode)
+    start = node.message_loc.end_offset
+
+    add_mutation(
+      offset: start,
+      length: argument_list_end(node, block_pass) - start,
+      replacement: block_pass ? "(#{block_pass.slice})" : "",
+      node: node
+    )
+  end
+
+  # Without parentheses the list ends at its last element: the block-pass
+  # when there is one (it always comes last), else the last argument. The
+  # call node itself would reach past a literal `do ... end` block.
+  def argument_list_end(node, block_pass)
+    return node.closing_loc.end_offset if node.closing_loc
+
+    (block_pass || node.arguments).end_offset
+  end
+end