evilution 0.27.0 → 0.28.0

data/lib/evilution/integration/rspec/state_guard/object_space_example_groups.rb

@@ -9,7 +9,10 @@ class Evilution::Integration::RSpec::StateGuard::ObjectSpaceExampleGroups
     groups = Set.new
     ObjectSpace.each_object(Class) do |klass|
       groups << klass.object_id if klass < ::RSpec::Core::ExampleGroup
-    rescue TypeError # rubocop:disable Lint/SuppressedException
+    rescue TypeError
+      # ObjectSpace iteration may surface partially-initialized or anonymous
+      # classes whose `<` comparison raises. Skipping them is safe — they
+      # cannot be ExampleGroup descendants we need to track.
     end
     groups
   end
@@ -23,13 +26,18 @@ class Evilution::Integration::RSpec::StateGuard::ObjectSpaceExampleGroups
 
       klass.constants(false).each do |const|
         klass.send(:remove_const, const)
-      rescue NameError # rubocop:disable Lint/SuppressedException
+      rescue NameError
+        # Constant may have been removed concurrently (e.g. via autoload
+        # reload) between #constants(false) and #remove_const. Best-effort
+        # cleanup — nothing to do if it's already gone.
       end
 
       klass.instance_variables.each do |ivar|
         klass.remove_instance_variable(ivar)
       end
-    rescue TypeError # rubocop:disable Lint/SuppressedException
+    rescue TypeError
+      # Same defensive case as #snapshot: skip classes whose `<` raises
+      # mid-iteration.
     end
   end
 end

data/lib/evilution/isolation/fork.rb

@@ -5,6 +5,7 @@ require "tmpdir"
 require_relative "../memory"
 require_relative "../temp_dir_tracker"
 require_relative "../child_output"
+require_relative "../process_cleanup"
 
 require_relative "../isolation"
 
@@ -49,13 +50,13 @@ class Evilution::Isolation::Fork
     read_io&.close
     write_io&.close
     ensure_reaped(pid)
-    restore_original_source(mutation)
+    restore_original_source
     FileUtils.rm_rf(sandbox_dir) if sandbox_dir
   end
 
   private
 
-  def restore_original_source(mutation) # rubocop:disable Lint/UnusedMethodArgument
+  def restore_original_source
     Evilution::TempDirTracker.cleanup_all
   end
 
@@ -88,7 +89,7 @@ class Evilution::Isolation::Fork
       if data.empty?
         { timeout: false, passed: false, error: "empty result from child" }
       else
-        { timeout: false }.merge(Marshal.load(data)) # rubocop:disable Security/MarshalLoad
+        { timeout: false }.merge(Marshal.load(data))
       end
     else
       terminate_child(pid)
@@ -113,7 +114,7 @@ class Evilution::Isolation::Fork
   end
 
   def terminate_child(pid)
-    ::Process.kill("TERM", pid) rescue nil # rubocop:disable Style/RescueModifier
+    Evilution::ProcessCleanup.safe_kill("TERM", pid)
     _, status = ::Process.waitpid2(pid, ::Process::WNOHANG)
     return if status
 
@@ -121,8 +122,8 @@ class Evilution::Isolation::Fork
     _, status = ::Process.waitpid2(pid, ::Process::WNOHANG)
     return if status
 
-    ::Process.kill("KILL", pid) rescue nil # rubocop:disable Style/RescueModifier
-    ::Process.wait(pid) rescue nil # rubocop:disable Style/RescueModifier
+    Evilution::ProcessCleanup.safe_kill("KILL", pid)
+    Evilution::ProcessCleanup.safe_wait(pid)
   end
 
   def classify_status(result)
@@ -143,11 +144,15 @@ class Evilution::Isolation::Fork
       status: status,
       duration: duration,
       test_command: result[:test_command],
-      child_rss_kb: result[:child_rss_kb],
-      parent_rss_kb: parent_rss_kb,
-      error_message: result[:error],
-      error_class: result[:error_class],
-      error_backtrace: result[:error_backtrace]
+      memory: Evilution::Result::MemoryStats.from_fields(
+        child_rss_kb: result[:child_rss_kb],
+        parent_rss_kb: parent_rss_kb
+      ),
+      error: Evilution::Result::ErrorInfo.from_fields(
+        message: result[:error],
+        klass: result[:error_class],
+        backtrace: result[:error_backtrace]
+      )
     )
   end
 end

data/lib/evilution/isolation/in_process.rb

@@ -80,12 +80,16 @@ class Evilution::Isolation::InProcess
       status: status,
       duration: duration,
       test_command: result[:test_command],
-      child_rss_kb: rss_after,
-      memory_delta_kb: memory_delta_kb,
-      parent_rss_kb: rss_before,
-      error_message: result[:error],
-      error_class: result[:error_class],
-      error_backtrace: result[:error_backtrace]
+      memory: Evilution::Result::MemoryStats.from_fields(
+        child_rss_kb: rss_after,
+        memory_delta_kb: memory_delta_kb,
+        parent_rss_kb: rss_before
+      ),
+      error: Evilution::Result::ErrorInfo.from_fields(
+        message: result[:error],
+        klass: result[:error_class],
+        backtrace: result[:error_backtrace]
+      )
     )
   end
 end

data/lib/evilution/mcp/info_tool.rb

@@ -70,7 +70,6 @@ class Evilution::MCP::InfoTool < MCP::Tool
   )
 
   class << self
-    # rubocop:disable Lint/UnusedMethodArgument
     def call(server_context:, action: nil, files: nil, target: nil, spec: nil, integration: nil, skip_config: nil)
       return ResponseFormatter.error("config_error", "action is required") unless action
       return ResponseFormatter.error("config_error", "unknown action: #{action}") unless ACTIONS.key?(action)
@@ -84,7 +83,6 @@ class Evilution::MCP::InfoTool < MCP::Tool
     rescue Evilution::Error => e
       ResponseFormatter.error_for(e)
     end
-    # rubocop:enable Lint/UnusedMethodArgument
   end
 end
 

data/lib/evilution/mcp/mutate_tool/progress_streamer.rb

@@ -10,15 +10,19 @@ module Evilution::MCP::MutateTool::ProgressStreamer
 
     suggestion = Evilution::Reporter::Suggestion.new(suggest_tests: true, integration: integration)
     survivor_index = 0
+    disabled = false
 
     proc do |result|
       next unless result.survived?
+      next if disabled
 
       begin
         survivor_index += 1
         detail = build_suggestion_detail(result.mutation, suggestion)
         server_context.report_progress(survivor_index, message: ::JSON.generate(detail))
-      rescue StandardError # rubocop:disable Lint/SuppressedException
+      rescue StandardError => e
+        warn "[evilution] progress stream disabled after error: #{e.class}: #{e.message}"
+        disabled = true
       end
     end
   end

data/lib/evilution/mcp/session_tool.rb

@@ -51,7 +51,6 @@ class Evilution::MCP::SessionTool < MCP::Tool
   VALID_ACTIONS = %w[list show diff].freeze
 
   class << self
-    # rubocop:disable Lint/UnusedMethodArgument
     def call(server_context:, action: nil, results_dir: nil, limit: nil, path: nil, base: nil, head: nil)
       return error_response("config_error", "action is required") unless action
       return error_response("config_error", "unknown action: #{action}") unless VALID_ACTIONS.include?(action)
@@ -62,7 +61,6 @@ class Evilution::MCP::SessionTool < MCP::Tool
       when "diff" then diff_action(base: base, head: head, results_dir: results_dir)
       end
     end
-    # rubocop:enable Lint/UnusedMethodArgument
 
     private
 

data/lib/evilution/mutation.rb

@@ -1,30 +1,53 @@
 # frozen_string_literal: true
 
 require "diff/lcs"
+require_relative "../evilution"
 
 class Evilution::Mutation
-  attr_reader :subject, :operator_name, :original_source,
-              :mutated_source, :original_slice, :mutated_slice,
-              :file_path, :line, :column, :parse_status
-
-  # rubocop:disable Metrics/ParameterLists
-  def initialize(subject:, operator_name:, original_source:, mutated_source:,
-                 file_path:, line:, column: 0, original_slice: nil, mutated_slice: nil,
-                 parse_status: :ok)
-    # rubocop:enable Metrics/ParameterLists
+  Sources = Data.define(:original, :mutated)
+  Slice = Data.define(:original, :mutated)
+  Location = Data.define(:file_path, :line, :column)
+
+  attr_reader :subject, :operator_name, :parse_status, :location
+
+  def initialize(subject:, operator_name:, sources:, location:, slice: nil, parse_status: :ok)
     @subject = subject
     @operator_name = operator_name
-    @original_source = original_source
-    @mutated_source = mutated_source
-    @original_slice = original_slice
-    @mutated_slice = mutated_slice
-    @file_path = file_path
-    @line = line
-    @column = column
+    @sources = sources
+    @location = location
+    @slice = slice
     @parse_status = parse_status
     @diff = nil
   end
 
+  def original_source
+    @sources&.original
+  end
+
+  def mutated_source
+    @sources&.mutated
+  end
+
+  def original_slice
+    @slice&.original
+  end
+
+  def mutated_slice
+    @slice&.mutated
+  end
+
+  def file_path
+    @location.file_path
+  end
+
+  def line
+    @location.line
+  end
+
+  def column
+    @location.column
+  end
+
   def unparseable?
     @parse_status == :unparseable
   end
@@ -41,8 +64,11 @@ class Evilution::Mutation
 
   def strip_sources!
     diff # ensure diff is cached before clearing sources
-    @original_source = nil
-    @mutated_source = nil
+    @sources = nil
+  end
+
+  def to_s
+    "#{operator_name}: #{file_path}:#{line}"
   end
 
   private
@@ -67,10 +93,10 @@ class Evilution::Mutation
   end
 
   def compute_unified_diff
-    return nil if @original_slice.nil? || @mutated_slice.nil?
+    return nil if @slice.nil?
 
-    original_lines = @original_slice.lines
-    mutated_lines = @mutated_slice.lines
+    original_lines = @slice.original.lines
+    mutated_lines = @slice.mutated.lines
     body = ::Diff::LCS.sdiff(original_lines, mutated_lines).map { |c| format_sdiff_change(c) }.join("\n")
     [
       "--- a/#{file_path}",
@@ -88,10 +114,4 @@ class Evilution::Mutation
     when "!" then "-#{change.old_element.chomp}\n+#{change.new_element.chomp}"
     end
   end
-
-  public
-
-  def to_s
-    "#{operator_name}: #{file_path}:#{line}"
-  end
 end

data/lib/evilution/mutator/base.rb

@@ -45,14 +45,14 @@ class Evilution::Mutator::Base < Prism::Visitor
     @mutations << Evilution::Mutation.new(
       subject: @subject,
       operator_name: self.class.operator_name,
-      original_source: @file_source,
-      mutated_source: mutated_source,
-      original_slice: original_slice,
-      mutated_slice: mutated_slice,
-      parse_status: surgery.status,
-      file_path: @subject.file_path,
-      line: node.location.start_line,
-      column: node.location.start_column
+      sources: Evilution::Mutation::Sources.new(original: @file_source, mutated: mutated_source),
+      slice: Evilution::Mutation::Slice.new(original: original_slice, mutated: mutated_slice),
+      location: Evilution::Mutation::Location.new(
+        file_path: @subject.file_path,
+        line: node.location.start_line,
+        column: node.location.start_column
+      ),
+      parse_status: surgery.status
     )
   end
 

data/lib/evilution/mutator/operator/predicate_to_nil.rb

@@ -0,0 +1,20 @@
+# frozen_string_literal: true
+
+require_relative "../operator"
+
+class Evilution::Mutator::Operator::PredicateToNil < Evilution::Mutator::Base
+  def visit_call_node(node)
+    if node.name.to_s.end_with?("?")
+      loc = node.location
+
+      add_mutation(
+        offset: loc.start_offset,
+        length: loc.length,
+        replacement: "nil",
+        node: node
+      )
+    end
+
+    super
+  end
+end

data/lib/evilution/mutator/registry.rb

@@ -3,6 +3,26 @@
 require_relative "../mutator"
 
 class Evilution::Mutator::Registry
+  STRICT_EXTRA_OPERATORS = [
+    Evilution::Mutator::Operator::PredicateToNil
+  ].freeze
+
+  def self.for_profile(profile)
+    unless profile.is_a?(Symbol) || profile.is_a?(String)
+      raise ArgumentError, "unknown profile: #{profile.inspect} (expected :default or :strict)"
+    end
+
+    case profile.to_sym
+    when :default then default
+    when :strict
+      registry = default
+      STRICT_EXTRA_OPERATORS.each { |op| registry.register(op) }
+      registry
+    else
+      raise ArgumentError, "unknown profile: #{profile.inspect} (expected :default or :strict)"
+    end
+  end
+
   def self.default
     registry = new
     [

data/lib/evilution/parallel/work_queue/channel/frame.rb

@@ -10,12 +10,16 @@ module Evilution::Parallel::WorkQueue::Channel::Frame
     [payload.bytesize].pack("N") + payload
   end
 
+  # Marshal.load is safe here: payload originates from a sibling worker the
+  # parent itself forked, transferred over a private pipe inside our process
+  # tree. No external/untrusted input ever reaches this code. See
+  # .rubocop.yml (Security/MarshalLoad) for the full rationale.
   def decode(header, payload)
     return nil if header.nil? || header.bytesize < 4
 
     length = header.unpack1("N")
     return nil if payload.nil? || payload.bytesize < length
 
-    Marshal.load(payload) # rubocop:disable Security/MarshalLoad
+    Marshal.load(payload)
   end
 end

data/lib/evilution/parallel/work_queue/worker/loop.rb

@@ -36,7 +36,7 @@ module Evilution::Parallel::WorkQueue::Worker::Loop
       result = block.call(item)
       elapsed = Process.clock_gettime(Process::CLOCK_MONOTONIC) - t0
       Evilution::Parallel::WorkQueue::Channel.write(res_io, [index, :ok, result])
-    rescue Exception => e # rubocop:disable Lint/RescueException
+    rescue StandardError, ScriptError, SystemStackError, NoMemoryError, SecurityError => e
       elapsed = Process.clock_gettime(Process::CLOCK_MONOTONIC) - t0
       Evilution::Parallel::WorkQueue::Channel.write(res_io, [index, :error, e])
     end

data/lib/evilution/process_cleanup.rb

@@ -0,0 +1,19 @@
+# frozen_string_literal: true
+
+require_relative "version"
+
+module Evilution::ProcessCleanup
+  module_function
+
+  def safe_kill(signal, pid)
+    ::Process.kill(signal, pid)
+  rescue Errno::ESRCH
+    nil
+  end
+
+  def safe_wait(pid)
+    ::Process.wait(pid)
+  rescue Errno::ECHILD
+    nil
+  end
+end

data/lib/evilution/reporter/html/baseline_keys.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require_relative "namespace"
+require_relative "../html"
 
 class Evilution::Reporter::HTML::BaselineKeys
   def initialize(baseline)

data/lib/evilution/reporter/html/diff_formatter.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require_relative "namespace"
+require_relative "../html"
 require_relative "escape"
 
 module Evilution::Reporter::HTML::DiffFormatter

data/lib/evilution/reporter/html/escape.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 require "cgi"
-require_relative "namespace"
+require_relative "../html"
 
 module Evilution::Reporter::HTML::Escape
   module_function

data/lib/evilution/reporter/html/section.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 require "erb"
-require_relative "namespace"
+require_relative "../html"
 require_relative "escape"
 
 class Evilution::Reporter::HTML::Section

data/lib/evilution/reporter/html/sections.rb

@@ -1,4 +1,6 @@
 # frozen_string_literal: true
 
-require_relative "namespace"
-require_relative "section"
+require_relative "../html"
+
+module Evilution::Reporter::HTML::Sections
+end

data/lib/evilution/reporter/html/stylesheet.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require_relative "namespace"
+require_relative "../html"
 
 module Evilution::Reporter::HTML::Stylesheet
   PATH = File.expand_path("assets/style.css", __dir__)

data/lib/evilution/reporter/html.rb

@@ -2,11 +2,16 @@
 
 require_relative "../reporter"
 require_relative "suggestion"
-require_relative "html/escape"
-require_relative "html/baseline_keys"
-require_relative "html/report"
 
 class Evilution::Reporter::HTML
+  autoload :Escape, "evilution/reporter/html/escape"
+  autoload :BaselineKeys, "evilution/reporter/html/baseline_keys"
+  autoload :Section, "evilution/reporter/html/section"
+  autoload :Sections, "evilution/reporter/html/sections"
+  autoload :Stylesheet, "evilution/reporter/html/stylesheet"
+  autoload :DiffFormatter, "evilution/reporter/html/diff_formatter"
+  autoload :Report, "evilution/reporter/html/report"
+
   def initialize(baseline: nil, integration: :rspec)
     @suggestion = Evilution::Reporter::Suggestion.new(integration: integration)
     @baseline = baseline

data/lib/evilution/reporter/suggestion/registry.rb

@@ -1,13 +1,9 @@
 # frozen_string_literal: true
 
 require_relative "../suggestion"
-
-# rubocop:disable Style/OneClassPerFile
-module Evilution::Reporter::Suggestion::Templates
-end
+require_relative "templates"
 
 class Evilution::Reporter::Suggestion::Registry
-  # rubocop:enable Style/OneClassPerFile
   def self.default
     return @default if @default
 

data/lib/evilution/reporter/suggestion/templates/generic.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require_relative "../registry"
+require_relative "../templates"
 
 module Evilution::Reporter::Suggestion::Templates::Generic
   GENERIC_ENTRIES = {