evil-client 2.1.1 → 3.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 2ccf12ec7a65e3b93d702235488587267b4b63bf
-  data.tar.gz: 24d639ea31d94a956cf919c873098f3ec2beea75
+  metadata.gz: 7421a1b4c64b31e781aa9a7b8468d2590bbdb89a
+  data.tar.gz: accdb2d3b7687f9e2729a319bd52059f0c13f656
 SHA512:
-  metadata.gz: c0db70d946408b64ec9875605b37c7f26af598c0f062c31bf4524ddb820b41ff43d598626e9f865ffd859ab7a911c7c20c4add08f3e080ab0ba6e83c128ba050
-  data.tar.gz: 25f5a6ffb7c7c05ed40ceb47a3899ce651db16453f7561b631c6bb680a4713b963ba10eb291044a4ce168d9fd653abe214537555828bf0882471018020f6cf39
+  metadata.gz: a7e681e013572dca96e759387b5c4fa3462e4dcd78f173376628fd620e839e2e388409f1f57cb97157e7a16b431e925dbd2ef5f5593627c6e1a89223a74ed9ec
+  data.tar.gz: a5327b283c6481d972dd9f0c3939200e55c1b6e9021d918997cb6cc3a956b3d2612d47228c3e4ad6cb77a6c03b198a891300b477dff7d5ea980f02daae8b1a1e

data/.rubocop.yml

@@ -6,6 +6,10 @@ AllCops:
 Lint/AmbiguousBlockAssociation:
   Enabled: false
 
+Naming/FileName:
+  Exclude:
+    - lib/evil-client.rb
+
 Metrics/BlockLength:
   Enabled: false
 
@@ -18,10 +22,6 @@ Style/ClassAndModuleChildren:
 Style/DateTime:
   Enabled: false
 
-Style/FileName:
-  Exclude:
-    - lib/evil-client.rb
-
 Style/FrozenStringLiteralComment:
   Enabled: false
 

data/CHANGELOG.md

@@ -4,6 +4,16 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog], and this project adheres
 to [Semantic Versioning].
 
+## [3.0.0] [2018-01-05]
+
+### [BREAKING] Changed
+
+- Stop re-raising exceptions in model constructors, and remove `Evil::Client::ValidationError` (nepalez)
+
+  Instead of ValidationError, the original StandardError exceptions will be risen.
+  
+  See [the issue #22 by Envek](https://github.com/evilmartians/evil-client/issues/22)
+
 ## [2.1.1] [2018-01-05]
 
 ### Changed
@@ -447,3 +457,5 @@ formats will be added.
 [1.1.0]: https://github.com/evilmartians/evil-client/compare/v1.0.0...v1.1.0
 [2.0.0]: https://github.com/evilmartians/evil-client/compare/v1.1.0...v2.0.0
 [2.1.0]: https://github.com/evilmartians/evil-client/compare/v2.0.0...v2.1.0
+[2.1.1]: https://github.com/evilmartians/evil-client/compare/v2.1.0...v2.1.1
+[3.0.0]: https://github.com/evilmartians/evil-client/compare/v2.1.1...v3.0.0

data/evil-client.gemspec

@@ -1,6 +1,6 @@
 Gem::Specification.new do |gem|
   gem.name     = "evil-client"
-  gem.version  = "2.1.1"
+  gem.version  = "3.0.0"
   gem.author   = ["Andrew Kozin (nepalez)", "Ravil Bairamgalin (brainopia)"]
   gem.email    = ["andrew.kozin@gmail.com", "nepalez@evilmartians.com"]
   gem.homepage = "https://github.com/evilmartians/evil-client"
@@ -16,7 +16,7 @@ Gem::Specification.new do |gem|
   gem.add_runtime_dependency "dry-initializer", "~> 2.1"
   gem.add_runtime_dependency "mime-types", "~> 3.1"
   gem.add_runtime_dependency "rack", "~> 2"
-  gem.add_runtime_dependency "tram-policy", "~> 0.2.3"
+  gem.add_runtime_dependency "tram-policy", "~> 0.3.0"
 
   gem.add_development_dependency "rake", ">= 10"
   gem.add_development_dependency "rspec", "~> 3.0"

data/lib/evil/client.rb

@@ -25,7 +25,6 @@ module Evil
     require_relative "client/exceptions/name_error"
     require_relative "client/exceptions/response_error"
     require_relative "client/exceptions/type_error"
-    require_relative "client/exceptions/validation_error"
 
     require_relative "client/chaining"
     require_relative "client/options"

data/lib/evil/client/model.rb

@@ -93,8 +93,6 @@ class Evil::Client
       def new(op = {})
         op = Hash(op).each_with_object({}) { |(k, v), obj| obj[k.to_sym] = v }
         super(op).tap { |item| in_english { policy[item].validate! } }
-      rescue StandardError => error
-        raise ValidationError, error.message
       end
       alias call new
       alias []   call

data/spec/features/operation/options_spec.rb

@@ -48,24 +48,24 @@ RSpec.describe "operation options" do
   context "when required options missed" do
     subject { users.operations[:create].new(language: "it") }
 
-    it "raises Evil::Client::ValidationError" do
-      expect { subject }.to raise_error Evil::Client::ValidationError, /name/
+    it "raises StandardError" do
+      expect { subject }.to raise_error StandardError, /name/
     end
   end
 
   context "when operation validation failed" do
     subject { users.operations[:filter].new }
 
-    it "raises Evil::Client::ValidationError" do
-      expect { subject }.to raise_error Evil::Client::ValidationError, /id/
+    it "raises StandardError" do
+      expect { subject }.to raise_error StandardError, /id/
     end
   end
 
   context "when scope validation failed" do
     subject { users.operations[:fetch].new id: 8, token: nil }
 
-    it "raises Evil::Client::ValidationError" do
-      expect { subject }.to raise_error Evil::Client::ValidationError, /token/
+    it "raises StandardError" do
+      expect { subject }.to raise_error StandardError, /token/
     end
   end
 end

data/spec/features/scope/options_spec.rb

@@ -35,18 +35,18 @@ RSpec.describe "scope options" do
   context "when required options missed" do
     subject { client.crm }
 
-    it "raises Evil::Client::ValidationError" do
+    it "raises StandardError" do
       expect { subject }
-        .to raise_error Evil::Client::ValidationError, /version/
+        .to raise_error StandardError, /version/
     end
   end
 
   context "when some validation failed" do
     subject { crm.users(token: nil) }
 
-    it "raises Evil::Client::ValidationError" do
+    it "raises StandardError" do
       expect { subject }
-        .to raise_error Evil::Client::ValidationError, /token/
+        .to raise_error StandardError, /token/
     end
   end
 end

data/spec/unit/model_spec.rb

@@ -69,7 +69,7 @@ RSpec.describe Evil::Client::Model do
     it "adds validation for an instance" do
       # see spec/fixtures/locale/en.yml
       expect { model }
-        .to raise_error(Evil::Client::ValidationError, /The user has no name/)
+        .to raise_error(StandardError, /The user has no name/)
     end
   end
 
@@ -79,8 +79,8 @@ RSpec.describe Evil::Client::Model do
     context "with wrong options" do
       before { klass.option :user, as: :customer }
 
-      it "raises Evil::Client::ValidationError" do
-        expect { subject }.to raise_error Evil::Client::ValidationError, /user/
+      it "raises StandardError" do
+        expect { subject }.to raise_error StandardError, /user/
       end
     end
   end

data/spec/unit/settings_spec.rb

@@ -98,7 +98,7 @@ RSpec.describe Evil::Client::Settings do
     it "adds validation for an instance" do
       # see spec/fixtures/locale/en.yml
       expect { settings }
-        .to raise_error(Evil::Client::ValidationError, /The user has no name/)
+        .to raise_error(StandardError, /The user has no name/)
     end
   end
 
@@ -161,8 +161,8 @@ RSpec.describe Evil::Client::Settings do
     context "with wrong options" do
       before { klass.option :user, as: :customer }
 
-      it "raises Evil::Client::ValidationError" do
-        expect { subject }.to raise_error Evil::Client::ValidationError, /user/
+      it "raises StandardError" do
+        expect { subject }.to raise_error StandardError, /user/
       end
     end
   end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: evil-client
 version: !ruby/object:Gem::Version
-  version: 2.1.1
+  version: 3.0.0
 platform: ruby
 authors:
 - Andrew Kozin (nepalez)
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-01-04 00:00:00.000000000 Z
+date: 2018-01-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: dry-initializer
@@ -59,14 +59,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.2.3
+        version: 0.3.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.2.3
+        version: 0.3.0
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -205,7 +205,6 @@ files:
 - lib/evil/client/exceptions/name_error.rb
 - lib/evil/client/exceptions/response_error.rb
 - lib/evil/client/exceptions/type_error.rb
-- lib/evil/client/exceptions/validation_error.rb
 - lib/evil/client/formatter.rb
 - lib/evil/client/formatter/form.rb
 - lib/evil/client/formatter/multipart.rb
@@ -259,7 +258,6 @@ files:
 - spec/unit/exceptions/name_error_spec.rb
 - spec/unit/exceptions/response_error_spec.rb
 - spec/unit/exceptions/type_error_spec.rb
-- spec/unit/exceptions/validation_error_spec.rb
 - spec/unit/formatter/form_spec.rb
 - spec/unit/formatter/multipart_spec.rb
 - spec/unit/formatter/part_spec.rb
@@ -333,7 +331,6 @@ test_files:
 - spec/unit/exceptions/name_error_spec.rb
 - spec/unit/exceptions/response_error_spec.rb
 - spec/unit/exceptions/type_error_spec.rb
-- spec/unit/exceptions/validation_error_spec.rb
 - spec/unit/formatter/form_spec.rb
 - spec/unit/formatter/multipart_spec.rb
 - spec/unit/formatter/part_spec.rb

data/lib/evil/client/exceptions/validation_error.rb

@@ -1,27 +0,0 @@
-class Evil::Client
-  #
-  # Exception to be risen when scope or operation cannot be initialized
-  # due to some options or their composition are invalid
-  #
-  class ValidationError < ArgumentError
-    private
-
-    def initialize(key, scope = nil, **options)
-      scope = "evil.client.errors.#{scope}"
-              .split(".")
-              .map { |part| __underscore__(part) }
-
-      super key.is_a?(Symbol) ? I18n.t(key, scope: scope, **options) : key
-    end
-
-    def __underscore__(name)
-      name.dup.tap do |n|
-        n.gsub!(/([A-Z]+)([A-Z][a-z])/, '\1_\2')
-        n.gsub!(/([a-z\d])([A-Z])/, '\1_\2')
-        n.gsub!("::", "/")
-        n.tr!("-", "_")
-        n.downcase!
-      end
-    end
-  end
-end

data/spec/unit/exceptions/validation_error_spec.rb

@@ -1,13 +0,0 @@
-RSpec.describe Evil::Client::ValidationError, "#message" do
-  let(:error)   { described_class.new key, scope, options }
-  let(:key)     { :token_present }
-  let(:scope)   { "Test::Api.users.update" }
-  let(:options) { { id: 3, name: "Andrew" } }
-
-  subject { error.message }
-
-  it "builds a proper error message" do
-    # see spec/fixtures/locales/en.yml
-    expect(subject).to eq "To update user id:3 you must provide a token"
-  end
-end