everypolitician-popolo 0.5.0 → 0.6.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 02929dc6bc5bd531b724d07047844435bfd223ad
-  data.tar.gz: aa9c71d31ff43c43cd5edc4ea5b043b90f494213
+  metadata.gz: 262682eaaa9963c7749cd96f5a5134fab88e815f
+  data.tar.gz: 3d90b328a132fba3ea0a3d2100f5a00e585dd1b1
 SHA512:
-  metadata.gz: 80c7c8dfa484a3c3f6e6533edb8099fbd5887bcf7562199c75035050cf508ec616f1c8d2a09e0030874275749b2dec51688330267760f688651a5b12407f766e
-  data.tar.gz: 243c3f25a16496072e70a326ace166fc91d73f50a8dc102cbe3239fd81cbdecf8251fb98b32163aed0f2ab96543e1c396ccddbdba6cf2ac2dd6945a5aca482d4
+  metadata.gz: 29f9a20d955a4281608a4482fc8374c5dee19d75c0b040f6f7a46aeaa70715c1104000b6c074655394c48717226bffd755396d873a6a56bd946f146649fd5786
+  data.tar.gz: 593e9de9b997aa687a2e3967918938ed49a30b2964953e772b3fd7dd0369d0caf4462f8c0765a769c6e21f8d6e4ec0bed0e75328276f1dcb2dc2e6bc9d574dc9

data/.rubocop.yml

@@ -1,53 +1,5 @@
-Style/AlignHash:
-  EnforcedHashRocketStyle: table
-  EnforcedColonStyle: table
+inherit_from:
+  - https://raw.githubusercontent.com/everypolitician/everypolitician-data/master/.rubocop_base.yml
+  - .rubocop_todo.yml
 
-Style/ClassAndModuleCamelCase:
-  Enabled: false
 
-Style/CollectionMethods:
-  Enabled: true
-
-Style/Documentation:
-  Enabled: false
-
-Style/FormatString:
-  EnforcedStyle: percent
-
-Style/HashSyntax:
-  EnforcedStyle: ruby19_no_mixed_keys
-
-Style/RescueModifier:
-  Enabled: false
-
-Style/SignalException:
-  Enabled: false
-
-Style/SymbolArray:
-  Enabled: true
-
-Style/TrailingCommaInLiteral:
-  EnforcedStyleForMultiline: consistent_comma
-
-
-Metrics/ClassLength:
-  Max: 250
-
-Metrics/MethodLength:
-  Max: 20
-
-Metrics/LineLength:
-  Max: 150
-
-Metrics/AbcSize:
-  Max: 50
-
-Metrics/CyclomaticComplexity:
-  Max: 7
-
-Metrics/PerceivedComplexity:
-  Max: 8
-
-
-# Temporarily! (2016-08-01)
-inherit_from: .rubocop_todo.yml

data/.rubocop_todo.yml

@@ -1,7 +1,31 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2016-08-01 14:20:19 +0100 using RuboCop version 0.42.0.
+# on 2016-08-08 18:05:16 +0100 using RuboCop version 0.42.0.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
 # versions of RuboCop, may require this file to be generated again.
+
+# Offense count: 1
+Metrics/AbcSize:
+  Max: 21
+
+# Offense count: 1
+# Configuration parameters: CountComments.
+Metrics/ClassLength:
+  Max: 164
+
+# Offense count: 2
+Metrics/CyclomaticComplexity:
+  Max: 7
+
+# Offense count: 42
+# Configuration parameters: AllowHeredoc, AllowURI, URISchemes.
+# URISchemes: http, https
+Metrics/LineLength:
+  Max: 148
+
+# Offense count: 3
+# Configuration parameters: CountComments.
+Metrics/MethodLength:
+  Max: 19

data/CHANGELOG.md

@@ -3,6 +3,24 @@
 All notable changes to this project will be documented in this file.
 This project adheres to [Semantic Versioning](http://semver.org/).
 
+## [0.6.1] - 2016-09-12
+
+### Fixes
+
+- Version 0.6.0 was accidentally tagged at the wrong (broken) point in history,
+  which included a broken fix for removing the `id` prefix from entities
+  ([#48](https://github.com/everypolitician/everypolitician-popolo/pull/48)),
+  but not the pull request reverting that change
+  ([#49](https://github.com/everypolitician/everypolitician-popolo/pull/49)).
+  0.6.0 has been yanked from RubyGems and we recommend using version 0.6.1.
+
+## [0.6.0] (yanked from RubyGems.org) - 2016-09-03
+
+### Fixed
+
+- `Entitiy#identifiers` will now return an empty list if no identifiers
+exist, rather than blowing up.
+
 ## [0.5.0] - 2016-08-01
 
 ### Added
@@ -52,4 +70,8 @@ This project adheres to [Semantic Versioning](http://semver.org/).
 
 [0.2.0]: https://github.com/everypolitician/everypolitician-popolo/compare/v0.1.0...v0.2.0
 [0.3.0]: https://github.com/everypolitician/everypolitician-popolo/compare/v0.2.0...v0.3.0
-[0.3.0]: https://github.com/everypolitician/everypolitician-popolo/compare/v0.3.0...v0.3.1
+[0.3.1]: https://github.com/everypolitician/everypolitician-popolo/compare/v0.3.0...v0.3.1
+[0.3.2]: https://github.com/everypolitician/everypolitician-popolo/compare/v0.3.1...v0.3.2
+[0.4.0]: https://github.com/everypolitician/everypolitician-popolo/compare/v0.3.0...v0.4.0
+[0.5.0]: https://github.com/everypolitician/everypolitician-popolo/compare/v0.4.0...v0.5.0
+[0.6.0]: https://github.com/everypolitician/everypolitician-popolo/compare/v0.5.0...v0.6.0

data/Gemfile

@@ -2,4 +2,3 @@ source 'https://rubygems.org'
 
 # Specify your gem's dependencies in everypolitician-popolo.gemspec
 gemspec
-

data/README.md

@@ -1,6 +1,6 @@
 # Everypolitician::Popolo
 
-[EveryPolitician](http://everypolitician.org) provides its data in [Popolo](http://www.popoloproject.com/) format. If you want to interact with this data from Ruby then this library should make that task simpler.
+[EveryPolitician](http://everypolitician.org) provides its data in [Popolo](http://www.popoloproject.com/) format. If you want to interact with this data from Ruby then this library makes that task simpler.
 
 ## Installation
 
@@ -20,7 +20,9 @@ Or install it yourself as:
 
 ## Usage
 
-You'll need to download a Popolo file from [EveryPolitician](http://everypolitician.org/). The following example uses [Åland Lagting](https://github.com/everypolitician/everypolitician-data/raw/master/data/Aland/Lagting/ep-popolo-v1.0.json) (which is the legislature of the Åland islands,
+You can download a Popolo file manually from [EveryPolitician](http://everypolitician.org/)
+(although there's [another library](#see-also-everypolitician-ruby)
+if you want to automate that). The following example uses [Åland Lagting](https://github.com/everypolitician/everypolitician-data/raw/master/data/Aland/Lagting/ep-popolo-v1.0.json) (which is the legislature of the Åland islands,
 available as JSON data from the
 [EveryPolitician page for Åland](http://everypolitician.org/aland/)).
 
@@ -53,7 +55,7 @@ person.wikidata # => "Q4934081"
 You can also find individual records or collections based on their attributes:
 
 ```ruby
-popolo.persons.find_by(name: "Aaltonen Carina", wikidata: "Q4934081")
+popolo.persons.find_by(name: "Aaltonen Carina")
     # => #<Everypolitician::Popolo::Person:0x0000000237dfc8
     #      @document={:id=>"0c705344-23aa-4fa2-9391-af41c1c775b7",
     #                 :identifiers=>[{:identifier=>"Q4934081", :scheme=>"wikidata"}],
@@ -72,6 +74,27 @@ popolo.organizations.where(classification: "party")
     #    ]
 ```
 
+### See also: everypolitician-ruby
+
+In the example above, the Popolo data comes from a downloaded file
+(`ep-popolo-v1.0.json`), which is the kind of file you can get from the 
+[EveryPolitician website](http://everypolitician.org).
+But your Ruby application can also interact directly with the EveryPolitician
+data using the
+[everypolitician-ruby gem](http://github.com/everypolitician/everypolitician-ruby),
+so you don't need to handle JSON files at all. The data the gem returns is in
+`Everypolitician::Popolo` format.
+
+```ruby
+require 'everypolitician'
+
+australia = Everypolitician::Index.new.country('Australia')
+australia.code # => "AU"
+senate = australia.legislature('Senate')
+senate.persons.find_by(name: "Aden Ridgeway")
+```
+
+
 ## Development
 
 After checking out the repo, run `bin/setup` to install dependencies. Then, run `rake test` to run the tests. You can also run `bin/console` for an interactive prompt that will allow you to experiment.

data/lib/everypolitician/popolo/entity.rb

@@ -31,6 +31,10 @@ module Everypolitician
       end
       alias eql? ==
 
+      def identifiers
+        document.fetch(:identifiers, [])
+      end
+
       def identifier(scheme)
         identifiers.find(-> { {} }) { |i| i[:scheme] == scheme }[:identifier]
       end

data/lib/everypolitician/popolo/person.rb

@@ -15,10 +15,6 @@ module Everypolitician
         links.find(-> { {} }) { |i| i[:note] == type }[:url]
       end
 
-      def identifiers
-        document.fetch(:identifiers, [])
-      end
-
       def contact_details
         document.fetch(:contact_details, [])
       end

data/lib/everypolitician/popolo/version.rb

@@ -1,5 +1,5 @@
 module Everypolitician
   module Popolo
-    VERSION = '0.5.0'.freeze
+    VERSION = '0.6.1'.freeze
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: everypolitician-popolo
 version: !ruby/object:Gem::Version
-  version: 0.5.0
+  version: 0.6.1
 platform: ruby
 authors:
 - Chris Mytton