evergreen_holdings 0.3.1 → 0.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: da13869aee1d6030dc730f20f662d3bbae682f1b
-  data.tar.gz: efbf034638ed3b6b301934de474f1dc1365bcfcb
+SHA256:
+  metadata.gz: e5800a7a145695ef115c882d45a1ba4264ea8f97888d7d305b7fdbbda4085b84
+  data.tar.gz: 0eaf07e5c8bb021fd79fcee3ec8584beff6b1842d097de72b7285614e2866368
 SHA512:
-  metadata.gz: 8a874195ffa5f2c7b0a202cecf66121d487d8eca4f60cf8ba0536f258040cc9a58d50dda5d6b4f62d6dcb17ce93a46654cdc3e3b0b6b81d0f0ca16872839ef6b
-  data.tar.gz: 9557150bed33a4e14d189e1ee2cd0e8f6048ca44d63cd289bb10e32547e315ed7b2a5c2ad8efc73d346b1179dca1d5d52686a951e06c6e66ee6c62f443b98138
+  metadata.gz: 14af7152bf4201748e500b1821152cc0331413e6b4e7df8ede03983b180bfbe3e32f9d368714b8bf7d5f9a015003500b32fcfce5a98e757b98c40ced3813166e
+  data.tar.gz: e4e82b9fe288ae589cad6089d34464421a5f0ffb698abbaa1ae2d41e55a9f1b6cbd2477ba545e0fc7bbc897828f3bce8fc3262a9e79872c16d3c6e20fa23c881

data/lib/evergreen_holdings.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'net/http'
 require 'json'
 require 'evergreen_holdings/errors'
@@ -7,229 +9,225 @@ require 'open-uri'
 OSRF_PATH = '/osrf-gateway-v1'
 
 module EvergreenHoldings
-    class Connection
-        attr_reader :org_units
-        # Create a new object with the evergreen_domain
-        # specified, e.g. http://libcat.linnbenton.edu
-        #
-        # Usage: `conn = EvergreenHoldings::Connection.new 'http://gapines.org'`
-        def initialize evergreen_domain
-            @evergreen_domain = evergreen_domain
-            @gateway = URI evergreen_domain+OSRF_PATH
-            fetch_idl_order
-            unless fetch_statuses
-                raise CouldNotConnectToEvergreenError
-            end
-            fetch_ou_tree
+  class Connection
+    attr_reader :org_units
+    # Create a new object with the evergreen_domain
+    # specified, e.g. http://libcat.linnbenton.edu
+    #
+    # Usage: `conn = EvergreenHoldings::Connection.new 'http://gapines.org'`
+    def initialize(evergreen_domain)
+      @evergreen_domain = evergreen_domain
+      @gateway = URI evergreen_domain + OSRF_PATH
+      @acpl_cache = {}
+      fetch_idl_order
+      raise CouldNotConnectToEvergreenError unless fetch_statuses
+
+      fetch_ou_tree
+    end
+
+    # Fetch holdings data from the Evergreen server
+    # Returns a Status object
+    #
+    # Usage: `stat = conn.get_holdings 23405`
+    # If you just want holdings at a specific org_unit: `my_connection.get_holdings 23405, org_unit: 5`
+    def get_holdings(tcn, options = {})
+      if options.key?(:org_unit)
+        if options[:descendants]
+          params = "format=json&input_format=json&service=open-ils.cat&method=open-ils.cat.asset.copy_tree.retrieve&param=auth_token_not_needed_for_this_call&param=#{tcn}"
+          @org_units[options[:org_unit]][:descendants]&.each do |ou|
+            params << + "&param=#{ou}"
+          end
+        else
+          params = "format=json&input_format=json&service=open-ils.cat&method=open-ils.cat.asset.copy_tree.retrieve&param=auth_token_not_needed_for_this_call&param=#{tcn}&param=#{options[:org_unit]}"
         end
+      else
+        params = "format=json&input_format=json&service=open-ils.cat&method=open-ils.cat.asset.copy_tree.global.retrieve&param=auth_token_not_needed_for_this_call&param=#{tcn}"
+      end
+      @gateway.query = params
 
-        # Fetch holdings data from the Evergreen server
-        # Returns a Status object
-        #
-        # Usage: `stat = conn.get_holdings 23405`
-        # If you just want holdings at a specific org_unit: `my_connection.get_holdings 23405, org_unit: 5`
-        def get_holdings tcn, options = {}
-            if options.key?(:org_unit)
-                if options[:descendants]
-                    params = "format=json&input_format=json&service=open-ils.cat&method=open-ils.cat.asset.copy_tree.retrieve&param=auth_token_not_needed_for_this_call&param=#{tcn}"
-                    if @org_units[options[:org_unit]][:descendants]
-                        @org_units[options[:org_unit]][:descendants].each do |ou|
-                            params <<  + "&param=#{ou}"
-                        end
-                    end
-                else
-                    params = "format=json&input_format=json&service=open-ils.cat&method=open-ils.cat.asset.copy_tree.retrieve&param=auth_token_not_needed_for_this_call&param=#{tcn}&param=#{options[:org_unit]}"
-                end
-            else
-                params = "format=json&input_format=json&service=open-ils.cat&method=open-ils.cat.asset.copy_tree.global.retrieve&param=auth_token_not_needed_for_this_call&param=#{tcn}"
-            end
-            @gateway.query = params
+      res = send_query
+      return Status.new res.body, @idl_order, self if res
+    end
 
-            res = send_query
-            return Status.new res.body, @idl_order, self if res
-        end
+    # Given an ID, returns a human-readable name
+    def location_name(id)
+      @acpl_cache.fetch(id) { |id| fetch_new_acpl(id) || id }
+    end
 
-	# Given an ID, returns a human-readable name
-        def location_name id
-            params = "format=json&input_format=json&service=open-ils.circ&method=open-ils.circ.copy_location.retrieve&param=#{id}"
-            @gateway.query = params
-            res = send_query
-            if res
-                data = JSON.parse(res.body)['payload'][0]
-                unless data.key? 'stacktrace'
-                    return data['__p'][@idl_order[:acpl]['name']]
-                end
-            end
-            return id
-        end
+    def status_name(id)
+      @possible_item_statuses[id]
+    end
 
-        def status_name id
-            return @possible_item_statuses[id]
+    def ou_name(id)
+      @org_units[id][:name]
         end
 
-	def ou_name id
-            return @org_units[id][:name]
-        end
+    private
 
-        private
-
-	def add_ou_descendants id, parent
-            (@org_units[parent][:descendants] ||= []) << id
-	    if @org_units[parent][:parent]
-	    add_ou_descendants id, @org_units[parent][:parent]
-	    end
-	end
-
-	def take_info_from_ou_tree o
-            id = o[@idl_order[:aou]['id']]
-	    @org_units[id] = {}
-	    @org_units[id][:name] = o[@idl_order[:aou]['name']]
-	    if o[@idl_order[:aou]['parent_ou']]
-	        @org_units[id][:parent] = o[@idl_order[:aou]['parent_ou']]
-	        add_ou_descendants id, o[@idl_order[:aou]['parent_ou']]
-            end
-	    o[@idl_order[:aou]['children']].each do |p|
-	        take_info_from_ou_tree p['__p']
-	    end 
-	end
+    def add_ou_descendants(id, parent)
+      (@org_units[parent][:descendants] ||= []) << id
+      add_ou_descendants id, @org_units[parent][:parent] if @org_units[parent][:parent]
+    end
 
+    def take_info_from_ou_tree(o)
+      id = o[@idl_order[:aou]['id']]
+      @org_units[id] = {}
+      @org_units[id][:name] = o[@idl_order[:aou]['name']]
+      if o[@idl_order[:aou]['parent_ou']]
+        @org_units[id][:parent] = o[@idl_order[:aou]['parent_ou']]
+        add_ou_descendants id, o[@idl_order[:aou]['parent_ou']]
+          end
+      o[@idl_order[:aou]['children']].each do |p|
+        take_info_from_ou_tree p['__p']
+      end
+    end
 
-        def send_query
-            begin
-                res = Net::HTTP.get_response(@gateway)
-            rescue Errno::ECONNREFUSED, Net::ReadTimeout
-                return nil
-            end
-            return res if res.is_a?(Net::HTTPSuccess)
-            return nil
-        end
+    # Given the ID of a shelving location, this method
+    # finds the name of the location, caches it, and
+    # returns it
+    def fetch_new_acpl(id)
+      params = "format=json&input_format=json&service=open-ils.circ&method=open-ils.circ.copy_location.retrieve&param=#{id}"
+      @gateway.query = params
+      res = send_query
+      if res
+        data = JSON.parse(res.body)['payload'][0]
+        name = data['__p'][@idl_order[:acpl]['name']] unless data.key? 'stacktrace'
+        @acpl_cache[id] = name
+        return name if name
+      end
+      false
+    end
 
-        def fetch_idl_order
-            @idl_order = {}
+    def send_query
+      begin
+        res = Net::HTTP.get_response(@gateway)
+      rescue Errno::ECONNREFUSED, Net::ReadTimeout
+        return nil
+      end
+      return res if res.is_a?(Net::HTTPSuccess)
 
-            idl = Nokogiri::XML(open(@evergreen_domain + '/reports/fm_IDL.xml'))
+      nil
+    end
 
-            [:acn, :acp, :acpl, :aou, :ccs, :circ].each do |idl_class|
-                i = 0
-                @idl_order[idl_class] = {}
-                fields = idl.xpath("//idl:class[@id='#{idl_class}']/idl:fields/idl:field", 'idl' => 'http://opensrf.org/spec/IDL/base/v1')
-                fields.each do |field|
-                    @idl_order[idl_class][field['name']] = i
-                    i = i + 1
-                end
-            end
-        end
+    def fetch_idl_order
+      @idl_order = {}
 
-        def fetch_statuses
-            @possible_item_statuses = []
-            params = 'format=json&input_format=json&service=open-ils.search&method=open-ils.search.config.copy_status.retrieve.all'
-            @gateway.query = params
-            res = send_query
-            if res
-                stats = JSON.parse(res.body)['payload'][0]
-                stats.each do |stat|
-                    @possible_item_statuses[stat['__p'][@idl_order[:ccs]['id']]] = stat['__p'][@idl_order[:ccs]['name']]
-                end
-                return true if stats.size > 0
-            end
-            return false
-        end
+      idl = Nokogiri::XML(open(@evergreen_domain + '/reports/fm_IDL.xml'))
 
-        def fetch_ou_tree
-            @org_units = {}
-	    params = 'format=json&input_format=json&service=open-ils.actor&method=open-ils.actor.org_tree.retrieve'
-            @gateway.query = params
-            res = send_query
-            if res
-                raw_orgs = JSON.parse(res.body)['payload'][0]['__p']
-		take_info_from_ou_tree raw_orgs
-                return true if @org_units.size > 0
-            end
-            return false
+      %i[acn acp acpl aou ccs circ].each do |idl_class|
+        i = 0
+        @idl_order[idl_class] = {}
+        fields = idl.xpath("//idl:class[@id='#{idl_class}']/idl:fields/idl:field", 'idl' => 'http://opensrf.org/spec/IDL/base/v1')
+        fields.each do |field|
+          @idl_order[idl_class][field['name']] = i
+          i += 1
         end
-
+      end
     end
 
-    # Status objects represent all the holdings attached to a specific tcn
-    class Status
-        attr_reader :copies, :libraries
-        def initialize json_data, idl_order, connection = nil
-            @idl_order = idl_order
-            @connection = connection
-            @raw_data = JSON.parse(json_data)['payload'][0]
-            extract_copies
-            substitute_values_for_ids unless @connection.nil?
-            @available_copies = []
-            @next_copy_available = 'a date'
+    def fetch_statuses
+      @possible_item_statuses = []
+      params = 'format=json&input_format=json&service=open-ils.search&method=open-ils.search.config.copy_status.retrieve.all'
+      @gateway.query = params
+      res = send_query
+      if res
+        stats = JSON.parse(res.body)['payload'][0]
+        stats.each do |stat|
+          @possible_item_statuses[stat['__p'][@idl_order[:ccs]['id']]] = stat['__p'][@idl_order[:ccs]['name']]
         end
+        return true unless stats.empty?
+      end
+      false
+    end
 
-        # Determines if any copies are available for your patrons
-        def any_copies_available?
-            @copies.each do |copy|
-                return true if 0 == copy.status
-                return true if 'Available' == copy.status
-            end
-            return false
-        end
+    def fetch_ou_tree
+      @org_units = {}
+      params = 'format=json&input_format=json&service=open-ils.actor&method=open-ils.actor.org_tree.retrieve'
+      @gateway.query = params
+      res = send_query
+      if res
+        raw_orgs = JSON.parse(res.body)['payload'][0]['__p']
+        take_info_from_ou_tree raw_orgs
+        return true unless @org_units.empty?
+      end
+      false
+    end
+  end
+
+  # Status objects represent all the holdings attached to a specific tcn
+  class Status
+    attr_reader :copies, :libraries
+    def initialize(json_data, idl_order, connection = nil)
+      @idl_order = idl_order
+      @connection = connection
+      @raw_data = JSON.parse(json_data)['payload'][0]
+      extract_copies
+      substitute_values_for_ids unless @connection.nil?
+      @available_copies = []
+      @next_copy_available = 'a date'
+    end
 
-        private
-
-        # Look through @raw_data and find the copies
-        def extract_copies 
-            @copies = Array.new
-            @raw_data.each do |vol|
-                if vol['__p'][0].size > 0
-                    vol['__p'][0].each do |item|
-			i = 0
-                        item_info = {
-                            barcode: item['__p'][@idl_order[:acp]['barcode']],
-                            call_number: vol['__p'][@idl_order[:acn]['label']],
-                            location: item['__p'][@idl_order[:acp]['location']],
-                            status: item['__p'][@idl_order[:acp]['status']],
-                            owning_lib: item['__p'][@idl_order[:acp]['circ_lib']],
-                        }
-                        unless item['__p'][@idl_order[:acp]['circulations']].is_a? Array
-				@copies.push Item.new item_info
-                        else
-                            begin
-                                    item_info[:due_date] = item['__p'][@idl_order[:acp]['circulations']][0]['__p'][@idl_order[:circ]['due_date']]
-                            rescue
-                            end
-	                    @copies.push Item.new item_info
-                        end
-                    end
-                end
-           end
-        end
+    # Determines if any copies are available for your patrons
+    def any_copies_available?
+      @copies.each do |copy|
+        return true if copy.status.zero?
+        return true if copy.status == 'Available'
+      end
+      false
+    end
 
-        def substitute_values_for_ids
-	    @libraries = @connection.org_units.clone
-	    @libraries.each { |key, lib| lib[:copies] = Array.new }
-            @copies.each do |copy|
-                if copy.location.is_a? Numeric
-                    copy.location = @connection.location_name copy.location
-                end
-                if copy.status.is_a? Numeric
-                    copy.status = @connection.status_name copy.status
-                end
-                if copy.owning_lib.is_a? Numeric
-                    ou_id = copy.owning_lib
-                    copy.owning_lib = @connection.ou_name copy.owning_lib
-                    @libraries[ou_id][:copies].push copy
-                end
+    private
+
+    # Look through @raw_data and find the copies
+    def extract_copies
+      @copies = []
+      @raw_data.each do |vol|
+        next if vol['__p'][0].empty?
+
+        vol['__p'][0].each do |item|
+          item_info = {
+            barcode: item['__p'][@idl_order[:acp]['barcode']],
+            call_number: vol['__p'][@idl_order[:acn]['label']],
+            location: item['__p'][@idl_order[:acp]['location']],
+            status: item['__p'][@idl_order[:acp]['status']],
+            owning_lib: item['__p'][@idl_order[:acp]['circ_lib']]
+          }
+          if item['__p'][@idl_order[:acp]['circulations']].is_a? Array
+            begin
+                    item_info[:due_date] = item['__p'][@idl_order[:acp]['circulations']][0]['__p'][@idl_order[:circ]['due_date']]
+            rescue StandardError
+                  end
+            @copies.push Item.new item_info
+          else
+            @copies.push Item.new item_info
             end
         end
-
+      end
     end
 
-    # A physical copy of an item
-    class Item
-        attr_accessor :location, :status, :owning_lib
-        attr_reader :barcode, :call_number, :due_date
-        def initialize data = {}
-            data.each do |k,v|
-                instance_variable_set("@#{k}", v) unless v.nil?
-            end
-        end
+    def substitute_values_for_ids
+      @libraries = @connection.org_units.clone
+      @libraries.each { |_key, lib| lib[:copies] = [] }
+      @copies.each do |copy|
+        copy.location = @connection.location_name copy.location if copy.location.is_a? Numeric
+        copy.status = @connection.status_name copy.status if copy.status.is_a? Numeric
+        next unless copy.owning_lib.is_a? Numeric
+
+        ou_id = copy.owning_lib
+        copy.owning_lib = @connection.ou_name copy.owning_lib
+        @libraries[ou_id][:copies].push copy
+      end
+    end
+  end
+
+  # A physical copy of an item
+  class Item
+    attr_accessor :location, :status, :owning_lib
+    attr_reader :barcode, :call_number, :due_date
+    def initialize(data = {})
+      data.each do |k, v|
+        instance_variable_set("@#{k}", v) unless v.nil?
+      end
     end
+  end
 end

metadata

@@ -1,22 +1,22 @@
 --- !ruby/object:Gem::Specification
 name: evergreen_holdings
 version: !ruby/object:Gem::Version
-  version: 0.3.1
+  version: 0.4.0
 platform: ruby
 authors:
 - Jane Sandberg
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
 date: 2019-12-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
-  name: nokogiri
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '1.11'
+  name: nokogiri
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -25,33 +25,53 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '1.11'
 - !ruby/object:Gem::Dependency
-  name: minitest
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 5.0.0
+        version: 0.7.0
+  name: coveralls
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 5.0.0
+        version: 0.7.0
 - !ruby/object:Gem::Dependency
-  name: coveralls
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.7.0
+        version: 5.0.0
+  name: minitest
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.7.0
+        version: 5.0.0
+- !ruby/object:Gem::Dependency
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">"
+      - !ruby/object:Gem::Version
+        version: 1.0.0
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '2'
+  name: rubocop
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">"
+      - !ruby/object:Gem::Version
+        version: 1.0.0
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '2'
 description: Access holdings information from Evergreen ILS
 email: sandbej@linnbenton.edu
 executables: []
@@ -65,7 +85,7 @@ homepage: https://github.com/sandbergja/evergreen_holdings_gem
 licenses:
 - MIT
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -80,9 +100,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.6.13
-signing_key: 
+rubygems_version: 3.0.6
+signing_key:
 specification_version: 4
 summary: A ruby gem for getting information about copy availability from Evergreen
   ILS