eventsimple 1.1.1 → 1.1.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 46f6a80be5a43cb84c321b67e9a27dde596b2eb3aa3d55ce8f635e395f42ce19
-  data.tar.gz: c3abab5c2bd25bee61695d24cdb9104cd11d403bb2b360ad1417f71f3006cd54
+  metadata.gz: 80288a15a3b05c634212479375312858866bdc7371cc74633c3ca59e23d97b1f
+  data.tar.gz: d3a9129566b5080b8dd62bc25b1e44cd93e97d919c2e3e844a7519c31ebcfbff
 SHA512:
-  metadata.gz: 3eb05c140311c7466f6cc27fe2a63e033f4464123449d9c9bc20b4b3ae9dd207b03bfe3acfd00cbf6c04bfa4c55456910fb2cee80056e04b5ec5aff70a4b73c1
-  data.tar.gz: fe56e5c4b5fa1608bd05a01f2b05f2051c8d7491170dc0c06790279a134a5d2b19465feca5104420d7dc43dcf2816e982d7aafbaa0aa65bfeadcca0ad476948d
+  metadata.gz: 6d66922352e0cc3f3115ec7dd648a84b7d2c739faf25ed871b634a3165ea67c459677e2958657f0469ee23dfa44ddfbabf447cb270ce93521d818d063357a075
+  data.tar.gz: 32379b97f433cd15e6fb2e1cdb0eb85ec9a07ba09a2edefe303b785723d38d8b91788628055afa7ab1b3b6ee0d69c51b574afdd5f74875d2d96eb653635a518d

data/CHANGELOG.md

@@ -6,6 +6,14 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## Unreleased
 
+## 1.1.3 - 2023-07-07
+### Changed
+- Sidekiq is no longer a required dependency.
+
+## 1.1.2 - 2023-06-22
+### Changed
+- Fix exception noise generated by early global_id desrialization
+
 ## 1.1.1 - 2023-06-19
 ### Changed
 - Remove active_job_parent_klass config introduced in 1.1.0. There isn't a usecase for it yet,

data/Gemfile.lock

@@ -1,78 +1,77 @@
 PATH
   remote: .
   specs:
-    eventsimple (1.1.1)
+    eventsimple (1.1.3)
       dry-struct (~> 1.6)
       dry-types (~> 1.7)
       pg (~> 1.4)
       rails (~> 7.0)
       retriable (~> 3.1)
-      sidekiq (~> 7.0)
 
 GEM
   remote: https://rubygems.org/
   specs:
-    actioncable (7.0.5)
-      actionpack (= 7.0.5)
-      activesupport (= 7.0.5)
+    actioncable (7.0.6)
+      actionpack (= 7.0.6)
+      activesupport (= 7.0.6)
       nio4r (~> 2.0)
       websocket-driver (>= 0.6.1)
-    actionmailbox (7.0.5)
-      actionpack (= 7.0.5)
-      activejob (= 7.0.5)
-      activerecord (= 7.0.5)
-      activestorage (= 7.0.5)
-      activesupport (= 7.0.5)
+    actionmailbox (7.0.6)
+      actionpack (= 7.0.6)
+      activejob (= 7.0.6)
+      activerecord (= 7.0.6)
+      activestorage (= 7.0.6)
+      activesupport (= 7.0.6)
       mail (>= 2.7.1)
       net-imap
       net-pop
       net-smtp
-    actionmailer (7.0.5)
-      actionpack (= 7.0.5)
-      actionview (= 7.0.5)
-      activejob (= 7.0.5)
-      activesupport (= 7.0.5)
+    actionmailer (7.0.6)
+      actionpack (= 7.0.6)
+      actionview (= 7.0.6)
+      activejob (= 7.0.6)
+      activesupport (= 7.0.6)
       mail (~> 2.5, >= 2.5.4)
       net-imap
       net-pop
       net-smtp
       rails-dom-testing (~> 2.0)
-    actionpack (7.0.5)
-      actionview (= 7.0.5)
-      activesupport (= 7.0.5)
+    actionpack (7.0.6)
+      actionview (= 7.0.6)
+      activesupport (= 7.0.6)
       rack (~> 2.0, >= 2.2.4)
       rack-test (>= 0.6.3)
       rails-dom-testing (~> 2.0)
       rails-html-sanitizer (~> 1.0, >= 1.2.0)
-    actiontext (7.0.5)
-      actionpack (= 7.0.5)
-      activerecord (= 7.0.5)
-      activestorage (= 7.0.5)
-      activesupport (= 7.0.5)
+    actiontext (7.0.6)
+      actionpack (= 7.0.6)
+      activerecord (= 7.0.6)
+      activestorage (= 7.0.6)
+      activesupport (= 7.0.6)
       globalid (>= 0.6.0)
       nokogiri (>= 1.8.5)
-    actionview (7.0.5)
-      activesupport (= 7.0.5)
+    actionview (7.0.6)
+      activesupport (= 7.0.6)
       builder (~> 3.1)
       erubi (~> 1.4)
       rails-dom-testing (~> 2.0)
       rails-html-sanitizer (~> 1.1, >= 1.2.0)
-    activejob (7.0.5)
-      activesupport (= 7.0.5)
+    activejob (7.0.6)
+      activesupport (= 7.0.6)
       globalid (>= 0.3.6)
-    activemodel (7.0.5)
-      activesupport (= 7.0.5)
-    activerecord (7.0.5)
-      activemodel (= 7.0.5)
-      activesupport (= 7.0.5)
-    activestorage (7.0.5)
-      actionpack (= 7.0.5)
-      activejob (= 7.0.5)
-      activerecord (= 7.0.5)
-      activesupport (= 7.0.5)
+    activemodel (7.0.6)
+      activesupport (= 7.0.6)
+    activerecord (7.0.6)
+      activemodel (= 7.0.6)
+      activesupport (= 7.0.6)
+    activestorage (7.0.6)
+      actionpack (= 7.0.6)
+      activejob (= 7.0.6)
+      activerecord (= 7.0.6)
+      activesupport (= 7.0.6)
       marcel (~> 1.0)
       mini_mime (>= 1.1.0)
-    activesupport (7.0.5)
+    activesupport (7.0.6)
       concurrent-ruby (~> 1.0, >= 1.0.2)
       i18n (>= 1.6, < 2)
       minitest (>= 5.1)
@@ -88,7 +87,6 @@ GEM
       thor (~> 1.0)
     coderay (1.1.3)
     concurrent-ruby (1.2.2)
-    connection_pool (2.4.1)
     crass (1.0.6)
     date (3.3.3)
     diff-lcs (1.5.0)
@@ -141,7 +139,7 @@ GEM
     ice_nine (0.11.2)
     json (2.6.3)
     language_server-protocol (3.17.0.3)
-    lint_roller (1.0.0)
+    lint_roller (1.1.0)
     listen (3.8.0)
       rb-fsevent (~> 0.10, >= 0.10.3)
       rb-inotify (~> 0.9, >= 0.9.10)
@@ -157,7 +155,7 @@ GEM
     marcel (1.0.2)
     method_source (1.0.0)
     mini_mime (1.1.2)
-    minitest (5.18.0)
+    minitest (5.18.1)
     nenv (0.3.0)
     net-imap (0.3.6)
       date
@@ -169,9 +167,9 @@ GEM
     net-smtp (0.3.3)
       net-protocol
     nio4r (2.5.9)
-    nokogiri (1.15.2-arm64-darwin)
+    nokogiri (1.15.3-arm64-darwin)
       racc (~> 1.4)
-    nokogiri (1.15.2-x86_64-linux)
+    nokogiri (1.15.3-x86_64-linux)
       racc (~> 1.4)
     notiffany (0.1.3)
       nenv (~> 0.1)
@@ -190,33 +188,34 @@ GEM
     public_suffix (5.0.1)
     puma (6.3.0)
       nio4r (~> 2.0)
-    racc (1.7.0)
+    racc (1.7.1)
     rack (2.2.7)
     rack-test (2.1.0)
       rack (>= 1.3)
-    rails (7.0.5)
-      actioncable (= 7.0.5)
-      actionmailbox (= 7.0.5)
-      actionmailer (= 7.0.5)
-      actionpack (= 7.0.5)
-      actiontext (= 7.0.5)
-      actionview (= 7.0.5)
-      activejob (= 7.0.5)
-      activemodel (= 7.0.5)
-      activerecord (= 7.0.5)
-      activestorage (= 7.0.5)
-      activesupport (= 7.0.5)
+    rails (7.0.6)
+      actioncable (= 7.0.6)
+      actionmailbox (= 7.0.6)
+      actionmailer (= 7.0.6)
+      actionpack (= 7.0.6)
+      actiontext (= 7.0.6)
+      actionview (= 7.0.6)
+      activejob (= 7.0.6)
+      activemodel (= 7.0.6)
+      activerecord (= 7.0.6)
+      activestorage (= 7.0.6)
+      activesupport (= 7.0.6)
       bundler (>= 1.15.0)
-      railties (= 7.0.5)
-    rails-dom-testing (2.0.3)
-      activesupport (>= 4.2.0)
+      railties (= 7.0.6)
+    rails-dom-testing (2.1.1)
+      activesupport (>= 5.0.0)
+      minitest
       nokogiri (>= 1.6)
     rails-html-sanitizer (1.6.0)
       loofah (~> 2.21)
       nokogiri (~> 1.14)
-    railties (7.0.5)
-      actionpack (= 7.0.5)
-      activesupport (= 7.0.5)
+    railties (7.0.6)
+      actionpack (= 7.0.6)
+      activesupport (= 7.0.6)
       method_source
       rake (>= 12.2)
       thor (~> 1.0)
@@ -227,8 +226,6 @@ GEM
     rb-inotify (0.10.1)
       ffi (~> 1.0)
     rchardet (1.8.0)
-    redis-client (0.14.1)
-      connection_pool
     regexp_parser (2.8.1)
     retriable (3.1.2)
     rexml (3.2.5)
@@ -252,11 +249,11 @@ GEM
       rspec-expectations (~> 3.12)
       rspec-mocks (~> 3.12)
       rspec-support (~> 3.12)
-    rspec-support (3.12.0)
-    rubocop (1.52.0)
+    rspec-support (3.12.1)
+    rubocop (1.52.1)
       json (~> 2.3)
       parallel (~> 1.10)
-      parser (>= 3.2.0.0)
+      parser (>= 3.2.2.3)
       rainbow (>= 2.2.2, < 4.0)
       regexp_parser (>= 1.8, < 3.0)
       rexml (>= 3.2.5, < 4.0)
@@ -284,11 +281,6 @@ GEM
       rubocop (>= 0.53.0)
     ruby-progressbar (1.13.0)
     shellany (0.0.1)
-    sidekiq (7.1.2)
-      concurrent-ruby (< 2)
-      connection_pool (>= 2.3.0)
-      rack (>= 2.2.4)
-      redis-client (>= 0.14.0)
     standard (1.29.0)
       language_server-protocol (~> 3.17.0.2)
       lint_roller (~> 1.0)
@@ -297,14 +289,14 @@ GEM
       standard-performance (~> 1.1.0)
     standard-custom (1.0.1)
       lint_roller (~> 1.0)
-    standard-performance (1.1.0)
-      lint_roller (~> 1.0)
+    standard-performance (1.1.1)
+      lint_roller (~> 1.1)
       rubocop-performance (~> 1.18.0)
     standard-rails (0.1.0)
       lint_roller (~> 1.0)
       rubocop-rails (~> 2.19.0)
     thor (1.2.2)
-    timeout (0.3.2)
+    timeout (0.4.0)
     treetop (1.6.12)
       polyglot (~> 0.3)
     tzinfo (2.0.6)
@@ -313,7 +305,7 @@ GEM
     websocket-driver (0.7.5)
       websocket-extensions (>= 0.1.0)
     websocket-extensions (0.1.5)
-    ws-style (7.1.0)
+    ws-style (7.1.1)
       rubocop-rspec (>= 2.2.0)
       rubocop-vendor (>= 0.11)
       standard (>= 1.28.2)

data/README.md

@@ -82,6 +82,19 @@ Setup an initializer in `config/initializers/eventsimple.rb`:
   end
 ```
 
+If using `Sidekiq` as a backend to `ActiveJob` for async reactors, please add this setting to
+`config/application.rb`:
+```ruby
+  config.active_job.queue_adapter = :sidekiq
+```
+The jobs are pushed into a queue named `eventsimple`, so please add it to your
+`sidekiq.yml` as follows:
+```yml
+:queues:
+  - [default, 10]
+  - [eventsimple, 10]
+```
+
 Generate a migration and add `Eventsimple` to an existing ActiveRecord model.
 
 ```ruby

data/eventsimple.gemspec

@@ -28,7 +28,6 @@ Gem::Specification.new do |spec|
   spec.add_runtime_dependency 'pg', '~> 1.4'
   spec.add_runtime_dependency 'rails', '~> 7.0'
   spec.add_runtime_dependency 'retriable', '~> 3.1'
-  spec.add_runtime_dependency 'sidekiq', '~> 7.0'
 
   spec.add_development_dependency 'bundle-audit'
   spec.add_development_dependency 'fuubar'

data/lib/eventsimple/active_job/arguments.rb

@@ -0,0 +1,20 @@
+require 'active_job/arguments'
+
+module ActiveJob
+  module Arguments
+    extend self
+
+    def deserialize_global_id(hash)
+      # For non database based processors like sidekiq, the reactor may trigger before the
+      # transaction is committed. Attempt to wait for the transaction to be commited before
+      # running the reactor. This is not a perfect solution, but it's better than nothing.
+      if Eventsimple.configuration.retry_reactor_on_record_not_found
+        Retriable.with_context(:reactor) do
+          ApplicationRecord.uncached { GlobalID::Locator.locate hash[GLOBALID_KEY] }
+        end
+      else
+        GlobalID::Locator.locate hash[GLOBALID_KEY]
+      end
+    end
+  end
+end

data/lib/eventsimple/reactor.rb

@@ -4,29 +4,12 @@ module Eventsimple
   class Reactor < ActiveJob::Base # rubocop:disable Rails/ApplicationJob
     queue_as :eventsimple
 
-    def perform(event)
-      call(event)
+    discard_on ActiveJob::DeserializationError do |job, error|
+      Rails.logger.warn("Event #{job.arguments.first} not found for reactor: #{self.class}")
     end
 
-    around_perform do |job, block|
-      event_global_id = job.arguments.first
-      reactor_class = job.arguments.second
-
-      # For non database based processors like sidekiq, the reactor may trigger before the
-      # transaction is committed. Attempt to wait for the transaction to be commited before
-      # running the reactor. This is not a perfect solution, but it's better than nothing.
-      if Eventsimple.configuration.retry_reactor_on_record_not_found
-        begin
-          Retriable.with_context(:reactor) do
-            ApplicationRecord.uncached { GlobalID::Locator.locate(event_global_id) }
-          end
-        rescue ActiveRecord::RecordNotFound
-          Rails.logger.error("Event #{event_global_id} not found for reactor: #{reactor_class}")
-          return
-        end
-      end
-
-      block.call
+    def perform(event)
+      call(event)
     end
   end
 end

data/lib/eventsimple/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Eventsimple
-  VERSION = '1.1.1'
+  VERSION = '1.1.3'
 end

data/lib/eventsimple.rb

@@ -9,10 +9,10 @@ require 'active_support'
 require 'dry-types'
 require 'dry-struct'
 require 'retriable'
-require 'sidekiq'
 
 require 'dry_types'
 
+require 'eventsimple/active_job/arguments'
 require 'eventsimple/configuration'
 require 'eventsimple/message'
 require 'eventsimple/data_type'
@@ -21,7 +21,6 @@ require 'eventsimple/metadata'
 require 'eventsimple/dispatcher'
 require 'eventsimple/event_dispatcher'
 require 'eventsimple/reactor'
-require 'eventsimple/reactor_worker'
 require 'eventsimple/invalid_transition'
 
 require 'eventsimple/entity'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: eventsimple
 version: !ruby/object:Gem::Version
-  version: 1.1.1
+  version: 1.1.3
 platform: ruby
 authors:
 - Zulfiqar Ali
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2023-06-19 00:00:00.000000000 Z
+date: 2023-07-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: dry-struct
@@ -80,20 +80,6 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '3.1'
-- !ruby/object:Gem::Dependency
-  name: sidekiq
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '7.0'
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '7.0'
 - !ruby/object:Gem::Dependency
   name: bundle-audit
   requirement: !ruby/object:Gem::Requirement
@@ -253,6 +239,7 @@ files:
 - eventsimple.gemspec
 - lib/dry_types.rb
 - lib/eventsimple.rb
+- lib/eventsimple/active_job/arguments.rb
 - lib/eventsimple/configuration.rb
 - lib/eventsimple/data_type.rb
 - lib/eventsimple/dispatcher.rb