eventmachine 1.2.2 → 1.2.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 36a220365872f603cdcf0fa1d9ff74cb262f0e01
-  data.tar.gz: f2c20894debc62a45a5369426bc470415e2ee68d
+  metadata.gz: c795c80fc92f16416a7a88c0f81047d0d016ed60
+  data.tar.gz: 53eef8509e66f01d28dcb5a19a52893bcec527cf
 SHA512:
-  metadata.gz: cd3e24582a33fb6aae96d64b17c93140e9a9a20aad4b4f33f08f4c363ba20233e0e3188de70d1afe6f59d064dbc04721cc028cdfcc7ac37c1c516c4c1c7a972a
-  data.tar.gz: 8a2bfebaa1e5c8867f31b8bfce064f18fff0e7d913f7d3ccd60f7b13e1cf2601d8ede8cf8fad0cafb1ddd35c8f3bbe7ba08c12a5b5ac178a68fc61d062c42523
+  metadata.gz: 83002fd70bd092a2b57b4ff6e1c451e6ad30a7e5d7dc29365139ad517ef417c09b1aa4655a8c220def9a0ffa32594c510ec2a547f195c1066aa610a4c515ee29
+  data.tar.gz: a9efa0f099ef1ec3d0ae7a87da91a1f768cc5f7995e9df7f5cce529018217e6a6277a263a42bf294dfa61625780a89afb613d3a08646e90d8391442b09e1148f

data/CHANGELOG.md

@@ -1,6 +1,11 @@
 # Changelog
 
-## 1.2.2 (January 23, 2016)
+## 1.2.3 (February 22, 2017)
+* Pure Ruby: Add get_sockname [#308, #772]
+* Fix segfault when an Exception is raised from unbind callback [#765, #766]
+* Allow destructors to throw when compiling in >= C++11 [#767]
+
+## 1.2.2 (January 23, 2017)
 * Java: Fix Fixnum deprecated warning in Ruby 2.4+ [#759]
 * Fix uncaught C++ exception in file watcher and raise InvalidSignature [#512, #757]
 * Fix connection count off-by-one for epoll and kqueue [#750]

data/ext/binder.cpp

@@ -116,7 +116,7 @@ Bindable_t::Bindable_t()
 Bindable_t::~Bindable_t
 ***********************/
 
-Bindable_t::~Bindable_t()
+Bindable_t::~Bindable_t() NO_EXCEPT_FALSE
 {
 	BindingBag.erase (Binding);
 }

data/ext/binder.h

@@ -21,6 +21,12 @@ See the file COPYING for complete licensing information.
 #define __ObjectBindings__H_
 
 
+#if __cplusplus >= 201103L
+#define NO_EXCEPT_FALSE noexcept(false)
+#else
+#define NO_EXCEPT_FALSE
+#endif
+
 class Bindable_t
 {
 	public:
@@ -30,7 +36,7 @@ class Bindable_t
 
 	public:
 		Bindable_t();
-		virtual ~Bindable_t();
+		virtual ~Bindable_t() NO_EXCEPT_FALSE;
 
 		const uintptr_t GetBinding() {return Binding;}
 

data/ext/ed.cpp

@@ -126,7 +126,7 @@ EventableDescriptor::EventableDescriptor (SOCKET sd, EventMachine_t *em):
 EventableDescriptor::~EventableDescriptor
 *****************************************/
 
-EventableDescriptor::~EventableDescriptor()
+EventableDescriptor::~EventableDescriptor() NO_EXCEPT_FALSE
 {
 	if (NextHeartbeat)
 		MyEventMachine->ClearHeartbeat(NextHeartbeat, this);

data/ext/ed.h

@@ -37,7 +37,7 @@ class EventableDescriptor: public Bindable_t
 {
 	public:
 		EventableDescriptor (SOCKET, EventMachine_t*);
-		virtual ~EventableDescriptor();
+		virtual ~EventableDescriptor() NO_EXCEPT_FALSE;
 
 		SOCKET GetSocket() {return MySocket;}
 		void SetSocketInvalid() { MySocket = INVALID_SOCKET; }
@@ -365,7 +365,7 @@ class PipeDescriptor: public EventableDescriptor
 {
 	public:
 		PipeDescriptor (SOCKET, pid_t, EventMachine_t*);
-		virtual ~PipeDescriptor();
+		virtual ~PipeDescriptor() NO_EXCEPT_FALSE;
 
 		virtual void Read();
 		virtual void Write();

data/ext/em.cpp

@@ -164,6 +164,8 @@ EventMachine_t::~EventMachine_t()
 {
 	// Run down descriptors
 	size_t i;
+	for (i = 0; i < DescriptorsToDelete.size(); i++)
+ 		delete DescriptorsToDelete[i];
 	for (i = 0; i < NewDescriptors.size(); i++)
 		delete NewDescriptors[i];
 	for (i = 0; i < Descriptors.size(); i++)
@@ -840,6 +842,17 @@ void EventMachine_t::_CleanupSockets()
 		EventableDescriptor *ed = Descriptors[i];
 		assert (ed);
 		if (ed->ShouldDelete()) {
+			DescriptorsToDelete.push_back(ed);
+		}
+		else
+			Descriptors [j++] = ed;
+	}
+	while ((size_t)j < Descriptors.size())
+		Descriptors.pop_back();
+
+	nSockets = DescriptorsToDelete.size();
+	for (i=0; i < nSockets; i++) {
+		EventableDescriptor *ed = DescriptorsToDelete[i];
 		#ifdef HAVE_EPOLL
 			if (Poller == Poller_Epoll) {
 				assert (epfd != -1);
@@ -855,13 +868,9 @@ void EventMachine_t::_CleanupSockets()
 				ModifiedDescriptors.erase(ed);
 			}
 		#endif
-			delete ed;
-		}
-		else
-			Descriptors [j++] = ed;
+		delete ed;
 	}
-	while ((size_t)j < Descriptors.size())
-		Descriptors.pop_back();
+	DescriptorsToDelete.clear();
 }
 
 /*********************************

data/ext/em.h

@@ -242,6 +242,7 @@ class EventMachine_t
 		map<int, Bindable_t*> Pids;
 		vector<EventableDescriptor*> Descriptors;
 		vector<EventableDescriptor*> NewDescriptors;
+		vector<EventableDescriptor*> DescriptorsToDelete;
 		set<EventableDescriptor*> ModifiedDescriptors;
 
 		SOCKET LoopBreakerReader;

data/ext/extconf.rb

@@ -70,7 +70,7 @@ def pkg_config_wrapper(pretty_name, name)
 end
 
 if ENV['CROSS_COMPILING']
-  openssl_version = ENV.fetch("OPENSSL_VERSION", "1.0.2j")
+  openssl_version = ENV.fetch("OPENSSL_VERSION", "1.0.2e")
   openssl_dir = File.expand_path("~/.rake-compiler/builds/openssl-#{openssl_version}/")
   if File.exist?(openssl_dir)
     FileUtils.mkdir_p Dir.pwd+"/openssl/"

data/ext/pipe.cpp

@@ -46,7 +46,7 @@ PipeDescriptor::PipeDescriptor (int fd, pid_t subpid, EventMachine_t *parent_em)
 PipeDescriptor::~PipeDescriptor
 *******************************/
 
-PipeDescriptor::~PipeDescriptor()
+PipeDescriptor::~PipeDescriptor() NO_EXCEPT_FALSE
 {
 	// Run down any stranded outbound data.
 	for (size_t i=0; i < OutboundPages.size(); i++)

data/lib/em/pure_ruby.rb

@@ -214,6 +214,12 @@ module EventMachine
       selectable.get_peername
     end
 
+    # @private
+    def get_sockname sig
+      selectable = Reactor.instance.get_selectable( sig ) or raise "unknown get_sockname target"
+      selectable.get_sockname
+    end
+
     # @private
     def open_udp_socket host, port
       EvmaUDPSocket.create(host, port).uuid
@@ -657,6 +663,7 @@ class IO
   def_delegator :@my_selectable, :send_data
   def_delegator :@my_selectable, :schedule_close
   def_delegator :@my_selectable, :get_peername
+  def_delegator :@my_selectable, :get_sockname
   def_delegator :@my_selectable, :send_datagram
   def_delegator :@my_selectable, :get_outbound_data_size
   def_delegator :@my_selectable, :set_inactivity_timeout
@@ -716,6 +723,10 @@ module EventMachine
       nil
     end
 
+    def get_sockname
+      nil
+    end
+
     def set_inactivity_timeout tm
       @inactivity_timeout = tm
     end
@@ -847,6 +858,14 @@ module EventMachine
       io.getpeername
     end
 
+    # #get_sockname
+    # This is defined in the normal way on connected stream objects.
+    # Return an object that is suitable for passing to Socket#unpack_sockaddr_in or variants.
+    # We could also use a convenience method that did the unpacking automatically.
+    def get_sockname
+      io.getsockname
+    end
+
     # #get_outbound_data_size
     def get_outbound_data_size
       @outbound_q.inject(0) {|memo,obj| memo += (obj || "").length}

data/lib/em/version.rb

@@ -1,3 +1,3 @@
 module EventMachine
-  VERSION = "1.2.2"
+  VERSION = "1.2.3"
 end

data/tests/test_exc.rb

@@ -1,6 +1,13 @@
 require 'em_test_helper'
 
 class TestSomeExceptions < Test::Unit::TestCase
+  class DoomedConnectionError < StandardError
+  end
+  class DoomedConnection < EventMachine::Connection
+    def unbind
+      raise DoomedConnectionError
+    end
+  end
 
   # Read the commentary in EM#run.
   # This test exercises the ensure block in #run that makes sure
@@ -25,4 +32,12 @@ class TestSomeExceptions < Test::Unit::TestCase
     }
   end
 
+  def test_exception_on_unbind
+    assert_raises(DoomedConnectionError) {
+      EM.run {
+      EM.connect("localhost", 8888, DoomedConnection)
+    }
+    }
+  end
+
 end

metadata

@@ -1,53 +1,53 @@
 --- !ruby/object:Gem::Specification
 name: eventmachine
 version: !ruby/object:Gem::Version
-  version: 1.2.2
+  version: 1.2.3
 platform: ruby
 authors:
 - Francis Cianfrocca
 - Aman Gupta
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2017-01-23 00:00:00.000000000 Z
+date: 2017-02-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
-  name: test-unit
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '2.0'
-  type: :development
+  name: test-unit
   prerelease: false
+  type: :development
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '2.0'
 - !ruby/object:Gem::Dependency
-  name: rake-compiler
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
         version: 0.9.5
-  type: :development
+  name: rake-compiler
   prerelease: false
+  type: :development
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
         version: 0.9.5
 - !ruby/object:Gem::Dependency
-  name: rake-compiler-dock
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
         version: 0.5.1
-  type: :development
+  name: rake-compiler-dock
   prerelease: false
+  type: :development
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
@@ -262,7 +262,7 @@ licenses:
 - Ruby
 - GPL-2.0
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options:
 - "--title"
 - EventMachine
@@ -285,9 +285,9 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.5.1
-signing_key: 
+rubyforge_project:
+rubygems_version: 2.6.8
+signing_key:
 specification_version: 4
 summary: Ruby/EventMachine library
 test_files: