event_engine-subscribers 0.1.1 → 0.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d2a695d8809af3af1b9145dd9866e96aa710304f3ccdba661ec5ed46e059577e
-  data.tar.gz: 4625cf214a4b49c8814afd693b099f5d46bfe94421ceec5d346ce362acb87e33
+  metadata.gz: 34965b10a7789582de233120f7e16c220292225c732605797c7dd2759f84d070
+  data.tar.gz: 3936714ca836690e78228fdfe66c5be51b5c7a7826264ea5f745ea696c16a277
 SHA512:
-  metadata.gz: '08d6aeee53d7aa109bf72227d0cc5dd9698f57307389c052ff6113eb1859018ec4e852c5c9b2ef95d6ace4f057663c4e31e1596d106d3debd72162ccef0d4efd'
-  data.tar.gz: f0469ee662fd07bd01598b44125d1123f5a1bb2b972442c3b246ca28a1d8bb0d7a8a6b6c6dbf81c00db9f0575bdaf2598988af025c47e6dc55c2b09e96c20c53
+  metadata.gz: '08c34c7ddcdef975a9c8af1f2289e55bf13bcaa7426e18544bb92bebe80f3acd1f927a9f207d05b130a4481b4aed632506f0e8e24c7fe3384e3cefbf62821088'
+  data.tar.gz: a750d52e0fc9a50cde6feded5f5ac782a027f9618ce4104a7fc2c231bdc403f8e6e607f8e9326297796e6fc4aab740f4912a3e458536acd65ea85d04fc808a1f

data/README.md

@@ -92,9 +92,17 @@ EventEngine::UnregisteredProcessorError: the rule for event :lead_created
   under that name
 ```
 
-If subscribers do not run for an event that *is* routed here, check that the
-subscriber class is in `app/subscribers`. A subscriber anywhere else registers only
-once Rails has loaded its class.
+If an event is routed to `inline` or `background` and no subscriber is registered for
+it, the app refuses to start and names each such event:
+
+```
+EventEngine::Subscribers::UnsubscribedEventsError: These events are routed to
+  subscribers but have none: hay_baled
+```
+
+The check runs once the app has started, after every class in `app/subscribers` is
+registered. A subscriber anywhere else registers only once Rails has loaded its class,
+so keep subscribers in `app/subscribers`.
 
 ## A working example app
 

data/lib/event_engine/subscribers/engine.rb

@@ -14,6 +14,10 @@ module EventEngine
         end
       end
 
+      initializer "event_engine.subscribers.check_every_routed_event_has_a_subscriber" do
+        config.after_initialize { Subscribers.check!(Subscribers.routes) }
+      end
+
       initializer "event_engine.subscribers.forget_unloaded_subscribers" do |app|
         app.reloader.before_class_unload { Registry.clear! }
       end

data/lib/event_engine/subscribers/registry.rb

@@ -23,6 +23,13 @@ module EventEngine
         registrations[event_name&.to_sym] || []
       end
 
+      def self.unsubscribed(routes)
+        routes.select { |event_name, process_type| routed_to_subscribers?(process_type) && subscribers_for(event_name).empty? }.keys
+      end
+
+      def self.routed_to_subscribers?(process_type) = Processor::HANDLED_PROCESS_TYPES.include?(process_type&.to_sym)
+      private_class_method :routed_to_subscribers?
+
       # Removes all registrations. Intended for test isolation.
       #
       # @return [void]

data/lib/event_engine/subscribers/unsubscribed_events_error.rb

@@ -0,0 +1,9 @@
+module EventEngine
+  module Subscribers
+    class UnsubscribedEventsError < StandardError
+      def initialize(event_names)
+        super("These events are routed to subscribers but have none: #{event_names.join(", ")}")
+      end
+    end
+  end
+end

data/lib/event_engine/subscribers/version.rb

@@ -1,5 +1,5 @@
 module EventEngine
   module Subscribers
-    VERSION = "0.1.1"
+    VERSION = "0.2.0"
   end
 end

data/lib/event_engine/subscribers.rb

@@ -3,8 +3,25 @@ require "event_engine/subscribers/engine"
 require "event_engine/subscribers/registry"
 require "event_engine/subscribers/base"
 require "event_engine/subscribers/processor"
+require "event_engine/subscribers/unsubscribed_events_error"
 
 module EventEngine
   module Subscribers
+    def self.routes
+      EventEngine.schema_registry.events.to_h { |event_name| [ event_name, process_type_of(event_name) ] }
+    end
+
+    def self.process_type_of(event_name)
+      domain = EventEngine.schema_registry.latest_for(event_name).domain
+      EventEngine.processing_rules.for(event_name: event_name, pack: domain)
+    end
+    private_class_method :process_type_of
+
+    def self.check!(routes)
+      unsubscribed = Registry.unsubscribed(routes)
+      raise UnsubscribedEventsError, unsubscribed if unsubscribed.any?
+
+      true
+    end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: event_engine-subscribers
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.2.0
 platform: ruby
 authors:
 - tylercschneider
@@ -85,6 +85,7 @@ files:
 - lib/event_engine/subscribers/engine.rb
 - lib/event_engine/subscribers/processor.rb
 - lib/event_engine/subscribers/registry.rb
+- lib/event_engine/subscribers/unsubscribed_events_error.rb
 - lib/event_engine/subscribers/version.rb
 - lib/tasks/event_engine/subscribers_tasks.rake
 - the_local/agents/event_engine-subscribers-develop.md