evelpidon_validators 0.2.0 → 0.3.0

data/CHANGELOG.md

@@ -1,5 +1,11 @@
 # Evelpidon Validators changelog
 
+## 0.3.0 / 2011-12-29
+
+* Added AssociationValidator
+* Fix for `than` validation options finding only input siblings
+* README updates (+ StillMaintained and Travis-CI)
+
 ## 0.2.0 / 2011-11-07
 
 * or_equal option to greater and less validators

data/Gemfile

@@ -2,3 +2,7 @@ source "http://rubygems.org"
 
 # Specify your gem's dependencies in evelpidon_validators.gemspec
 gemspec
+
+group :development do
+  gem 'test-unit'
+end

data/README.md

@@ -1,5 +1,8 @@
 # Evelpidon Validators (for Rails / ActiveModel / ActiveRecord)
 
+[![Project Status](http://stillmaintained.com/e-travel/evelpidon_validators.png)](http://stillmaintained.com/e-travel/evelpidon_validators) 
+[![Build Status](https://secure.travis-ci.org/e-travel/evelpidon_validators.png)](http://travis-ci.org/e-travel/evelpidon_validators)
+
 Collection of various ActiveModel validators, alongside their client side implementation
 as ClientSideValidations::Middleware (see [ClientSideValidations](https://github.com/bcardarella/client_side_validations)
 for more info). Client side validations are optional and are enabled only if the client_side_validations gem is
@@ -17,31 +20,41 @@ already loaded.
 
 Add on your Gemfile :
 
-    gem 'evelpidon_validators'
+```ruby
+gem 'evelpidon_validators'
+```
 
 ### By hand
 
 On the console :
 
-    gem install evelpidon_validators
+```bash
+gem install evelpidon_validators
+```
 
 On your code :
 
-    require 'evelpidon_validators'
+```ruby
+require 'evelpidon_validators'
+```
 
 ## Usage
 
 Validators are *not* automatically loaded. You can require the validators you need either explicitly one-by-one
 or all of them. So for example :
 
-    # Load only "Greater than" and "Less than" validators :
-    require 'evelpidon_validators/greater'
-    require 'evelpidon_validators/greater'
+```ruby
+# Load only "Greater than" and "Less than" validators :
+require 'evelpidon_validators/greater'
+require 'evelpidon_validators/less'
+```
 
 or
 
-    # Load everything
-    require 'evelpidon_validators/all'
+```ruby
+# Load everything
+require 'evelpidon_validators/all'
+```
 
 ### Enable client side validations support
 
@@ -52,8 +65,10 @@ Client-side validations work out of the box with Rails 3.1 (through the asset pi
 
 So for example the following should work :
 
-    //= require rails.validations
-    //= require evelpidon_validators
+```javascript
+//= require rails.validations
+//= require evelpidon_validators
+```
 
 ## TODOs
 

data/evelpidon_validators.gemspec

@@ -21,6 +21,7 @@ Gem::Specification.new do |s|
   s.add_development_dependency "rake"
   s.add_development_dependency "activesupport"
   s.add_development_dependency "evelpidon_test_helpers"
+  s.add_development_dependency "test-unit"
 
   s.add_runtime_dependency "activemodel"
 end

data/lib/assets/javascripts/evelpidon_validators.js

@@ -5,5 +5,5 @@ clientSideValidations.helpers = clientSideValidations.helpers || {};
 
 clientSideValidations.helpers.getSiblingField = function(field, siblingName) {
     var thanName = field.attr('name').replace(/\[[^\]]*\]/, '[' + siblingName + ']');
-    return field.parents('form').find("input[name='" + thanName + "']");
+    return field.parents('form').find("[name='" + thanName + "']");
 };

data/lib/evelpidon_validators/all.rb

@@ -1,3 +1,4 @@
 require "evelpidon_validators/different"
 require "evelpidon_validators/greater"
 require "evelpidon_validators/less"
+require "evelpidon_validators/associated"

data/lib/evelpidon_validators/associated.rb

@@ -0,0 +1,15 @@
+module ActiveModel
+  module Validations
+    # Shamelessly stolen from:
+    # https://github.com/rails/rails/blob/v3.1.1/activerecord/lib/active_record/validations/associated.rb
+    #
+    # Beware! This validator is not triggered in the client side, however if the association is in a form, client side
+    # validations will handle that on its own.
+    class AssociatedValidator < EachValidator
+      def validate_each(record, attribute, value)
+        return if (value.is_a?(Array) ? value : [value]).collect{ |r| r.nil? || r.valid? }.all?
+        record.errors.add(attribute, :invalid, options.merge(:value => value))
+      end
+    end
+  end
+end

data/lib/evelpidon_validators/version.rb

@@ -1,3 +1,3 @@
 module EvelpidonValidators
-  VERSION = "0.2.0"
+  VERSION = "0.3.0"
 end

data/test/associated_test.rb

@@ -0,0 +1,55 @@
+require 'test_helper'
+require 'evelpidon_validators/associated'
+
+# Tests inspired by:
+# https://github.com/rails/rails/blob/v3.1.1/activerecord/test/cases/validations/association_validation_test.rb
+class AssociatedValidatorTest < ActiveSupport::TestCase
+
+  class Topic
+    include ActiveModel::Validations
+    attr_accessor :title, :content, :replies
+
+    def initialize(params = {})
+      self.title = params['title']
+      self.content = params['content']
+      self.replies = params['replies']
+    end
+  end
+
+  class Reply
+    include ActiveModel::Validations
+    attr_accessor :title, :content, :topic
+
+    def initialize(params = {})
+      self.title = params['title']
+      self.content = params['content']
+      self.topic = params['topic']
+    end
+  end
+
+  def test_validates_associated_many
+    Topic.validates :replies, :associated => true
+    Reply.validates :content, :presence => true
+    t = Topic.new("title" => "uhohuhoh", "content" => "whatever")
+    t.replies = [r = Reply.new("title" => "A reply"), r2 = Reply.new("title" => "Another reply", "content" => "non-empty"), r3 = Reply.new("title" => "Yet another reply"), r4 = Reply.new("title" => "The last reply", "content" => "non-empty")]
+    assert !t.valid?
+    assert t.errors[:replies].any?
+    assert_equal 1, r.errors.count  # make sure all associated objects have been validated
+    assert_equal 0, r2.errors.count
+    assert_equal 1, r3.errors.count
+    assert_equal 0, r4.errors.count
+    r.content = r3.content = "non-empty"
+    assert t.valid?
+  end
+
+  def test_validates_associated_one
+    Reply.validates :topic, :associated => true
+    Topic.validates :content, :presence => true
+    r = Reply.new("title" => "A reply", "content" => "with content!")
+    r.topic = Topic.new("title" => "uhohuhoh")
+    assert !r.valid?
+    assert r.errors[:topic].any?
+    r.topic.content = "non-empty"
+    assert r.valid?
+  end
+end

metadata

@@ -1,90 +1,80 @@
---- !ruby/object:Gem::Specification 
+--- !ruby/object:Gem::Specification
 name: evelpidon_validators
-version: !ruby/object:Gem::Version 
-  hash: 23
+version: !ruby/object:Gem::Version
+  version: 0.3.0
   prerelease: 
-  segments: 
-  - 0
-  - 2
-  - 0
-  version: 0.2.0
 platform: ruby
-authors: 
+authors:
 - Nikos Dimitrakopoulos
 - Eric Cohen
 autorequire: 
 bindir: bin
 cert_chain: []
-
-date: 2011-11-07 00:00:00 Z
-dependencies: 
-- !ruby/object:Gem::Dependency 
+date: 2011-12-29 00:00:00.000000000 Z
+dependencies:
+- !ruby/object:Gem::Dependency
   name: rake
-  prerelease: false
-  requirement: &id001 !ruby/object:Gem::Requirement 
+  requirement: &17211260 !ruby/object:Gem::Requirement
     none: false
-    requirements: 
-    - - ">="
-      - !ruby/object:Gem::Version 
-        hash: 3
-        segments: 
-        - 0
-        version: "0"
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
   type: :development
-  version_requirements: *id001
-- !ruby/object:Gem::Dependency 
-  name: activesupport
   prerelease: false
-  requirement: &id002 !ruby/object:Gem::Requirement 
+  version_requirements: *17211260
+- !ruby/object:Gem::Dependency
+  name: activesupport
+  requirement: &17210780 !ruby/object:Gem::Requirement
     none: false
-    requirements: 
-    - - ">="
-      - !ruby/object:Gem::Version 
-        hash: 3
-        segments: 
-        - 0
-        version: "0"
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
   type: :development
-  version_requirements: *id002
-- !ruby/object:Gem::Dependency 
+  prerelease: false
+  version_requirements: *17210780
+- !ruby/object:Gem::Dependency
   name: evelpidon_test_helpers
+  requirement: &17210360 !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
   prerelease: false
-  requirement: &id003 !ruby/object:Gem::Requirement 
+  version_requirements: *17210360
+- !ruby/object:Gem::Dependency
+  name: test-unit
+  requirement: &17209920 !ruby/object:Gem::Requirement
     none: false
-    requirements: 
-    - - ">="
-      - !ruby/object:Gem::Version 
-        hash: 3
-        segments: 
-        - 0
-        version: "0"
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
   type: :development
-  version_requirements: *id003
-- !ruby/object:Gem::Dependency 
-  name: activemodel
   prerelease: false
-  requirement: &id004 !ruby/object:Gem::Requirement 
+  version_requirements: *17209920
+- !ruby/object:Gem::Dependency
+  name: activemodel
+  requirement: &17209440 !ruby/object:Gem::Requirement
     none: false
-    requirements: 
-    - - ">="
-      - !ruby/object:Gem::Version 
-        hash: 3
-        segments: 
-        - 0
-        version: "0"
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
   type: :runtime
-  version_requirements: *id004
+  prerelease: false
+  version_requirements: *17209440
 description: Useful ActiveModel validators with ClientSideValidations support.
-email: 
+email:
 - n.dimitrakopoulos@pamediakopes.gr
 - e.koen@pamediakopes.gr
 executables: []
-
 extensions: []
-
 extra_rdoc_files: []
-
-files: 
+files:
 - .gitignore
 - CHANGELOG.md
 - Gemfile
@@ -98,48 +88,39 @@ files:
 - lib/assets/javascripts/evelpidon_validators/less.js
 - lib/evelpidon_validators.rb
 - lib/evelpidon_validators/all.rb
+- lib/evelpidon_validators/associated.rb
 - lib/evelpidon_validators/different.rb
 - lib/evelpidon_validators/greater.rb
 - lib/evelpidon_validators/less.rb
 - lib/evelpidon_validators/rails.rb
 - lib/evelpidon_validators/version.rb
+- test/associated_test.rb
 - test/different_test.rb
 - test/greater_test.rb
 - test/less_test.rb
 - test/test_helper.rb
-homepage: ""
+homepage: ''
 licenses: []
-
 post_install_message: 
 rdoc_options: []
-
-require_paths: 
+require_paths:
 - lib
-required_ruby_version: !ruby/object:Gem::Requirement 
+required_ruby_version: !ruby/object:Gem::Requirement
   none: false
-  requirements: 
-  - - ">="
-    - !ruby/object:Gem::Version 
-      hash: 3
-      segments: 
-      - 0
-      version: "0"
-required_rubygems_version: !ruby/object:Gem::Requirement 
+  requirements:
+  - - ! '>='
+    - !ruby/object:Gem::Version
+      version: '0'
+required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
-  requirements: 
-  - - ">="
-    - !ruby/object:Gem::Version 
-      hash: 3
-      segments: 
-      - 0
-      version: "0"
+  requirements:
+  - - ! '>='
+    - !ruby/object:Gem::Version
+      version: '0'
 requirements: []
-
 rubyforge_project: evelpidon_validators
 rubygems_version: 1.8.10
 signing_key: 
 specification_version: 3
 summary: Useful ActiveModel validators
 test_files: []
-
-has_rdoc: