europeana-blacklight 1.2.2 → 1.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 1338226ac374cda63d68acb030b3ebddfe1bd59e
-  data.tar.gz: 9c19b3ced71c14fce86af3d283291466930d2a5d
+SHA256:
+  metadata.gz: c4eb11c730a0cd1f642dcfc2da1cab5c3be8d352e39ce657100744e4d91cc5d9
+  data.tar.gz: 567559669e91097db14b419d12e10be276572d7d4cc680b46e1951b3d6281b5a
 SHA512:
-  metadata.gz: 0f35a80fdbd970b6481f7536b0de03838349aa58efe126c7c004f38da1bb61b02b274821c2ffa821aec96b44c5cd4269fed34fc312a6bd73a62f319ffef5ffb8
-  data.tar.gz: f2d7a8ca0b6542d0513e3cd2b954d2383de91fb7c0926549fbeff7c06dcf71fe7c77010d99833833c5c12fff14e75e5ec6074e0aa09e735c99f4c3ef46b13a8a
+  metadata.gz: d52aef50b7a719866d43f07bccbb77692aa6648229ad2a91dfb24f5d31a9a03a2a90c20a2a4578d194121388f392cfcef11b03f86314844278115a7e0e9fdd0a
+  data.tar.gz: f52f8a7e8b539151f50f37456256e61a06c86e05b7c5dd4a49af7d1585ce08afd6a14f4382a2eb90d45495a5baf912a41038b8e6c0662ad3450e09ef10cc9541

data/.ruby-style.yml

@@ -3,7 +3,7 @@ AllCops:
     - "vendor/**/*"
     - "db/schema.rb"
   UseCache: false
-  TargetRubyVersion: 2.4
+  TargetRubyVersion: 2.5
 Style/CollectionMethods:
   Description: Preferred collection methods.
   StyleGuide: https://github.com/bbatsov/ruby-style-guide#map-find-select-reduce-size

data/.travis.yml

@@ -3,14 +3,16 @@ rvm:
   - 2.3
   - 2.4
   - 2.5
+  - 2.6
 notifications:
   email: false
 sudo: false
 cache:
   bundler: true
+# Downgrade bundler to 1.x <https://docs.travis-ci.com/user/languages/ruby/#bundler-20>
 before_install:
-  - gem update --system
-  - gem install bundler
+  - gem uninstall -v '>= 2' -i $(rvm gemdir)@global -ax bundler || true
+  - gem install bundler -v '< 2'
 before_script:
   - curl -L https://codeclimate.com/downloads/test-reporter/test-reporter-latest-linux-amd64 > ./cc-test-reporter
   - chmod +x ./cc-test-reporter

data/Gemfile

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 source 'https://rubygems.org'
 
 # Specify your gem's dependencies in europeana-blacklight.gemspec

data/Rakefile

@@ -1,4 +1,6 @@
+# frozen_string_literal: true
+
 require 'bundler/gem_tasks'
 require 'rspec/core/rake_task'
-task :default => :spec
+task default: :spec
 RSpec::Core::RakeTask.new

data/app/controllers/concerns/europeana/blacklight/catalog.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Europeana
   module Blacklight
     module Catalog
@@ -61,8 +63,8 @@ module Europeana
 
       def europeana_api_query_facet_count(query_field_fq, user_params)
         query = search_builder_class.new(search_params_logic, self).
-          with(user_params).with_overlay_params(query_field_fq || {}).query.
-          merge(rows: 0, start: 1, profile: 'minimal')
+                with(user_params).with_overlay_params(query_field_fq || {}).query.
+                merge(rows: 0, start: 1, profile: 'minimal')
         repository.search(query).total
       end
     end

data/app/controllers/concerns/europeana/blacklight/search_helper.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Europeana
   module Blacklight
     ##

data/app/models/europeana/blacklight/document/lang_maps.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Europeana
   module Blacklight
     class Document
@@ -6,12 +8,12 @@ module Europeana
       # @see http://labs.europeana.eu/api/getting-started#datatypes
       module LangMaps
         # @see https://www.loc.gov/standards/iso639-2/php/code_changes.php
-        DEPRECATED_ISO_LANG_CODES = %w(in iw jaw ji jw mo mol scc scr sh)
+        DEPRECATED_ISO_LANG_CODES = %w(in iw jaw ji jw mo mol scc scr sh).freeze
 
         # Special keys API may return in a LangMap, not ISO codes
         # @todo Empty key acceptance is a workaround for malformed API data
         #   output; remove when fixed at source
-        NON_ISO_LANG_CODES = ['def', '']
+        NON_ISO_LANG_CODES = ['def', ''].freeze
 
         # @todo Are three-letter language codes valid in EDM?
         def lang_map?(obj)
@@ -75,7 +77,7 @@ module Europeana
 
           # Any sub-code will do
           lang_map.keys.select do |k|
-            k =~ %r{\A#{iso_code}-}
+            k =~ /\A#{iso_code}-/
           end.flatten.compact
         end
       end

data/app/models/europeana/blacklight/document/more_like_this.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Europeana
   module Blacklight
     class Document
@@ -8,9 +10,9 @@ module Europeana
         # @return [String]
         def more_like_this_query(param = nil)
           queries = more_like_this_field_queries(param)
-          return nil unless queries.size > 0
+          return nil if queries.empty?
           field_queries = queries.join(' OR ')
-          "(#{field_queries}) NOT europeana_id:\"#{self.id}\""
+          "(#{field_queries}) NOT europeana_id:\"#{id}\""
         end
 
         protected

data/app/models/europeana/blacklight/document/relations.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'active_support/core_ext/hash'
 
 module Europeana
@@ -11,7 +13,7 @@ module Europeana
         def fetch_through_relation(key, *default)
           field = nested_field_key(key)
           container = nested_field_container(key)
-          value = [container].flatten.compact.collect do |target|
+          value = [container].flatten.compact.map do |target|
             target.fetch(field, *default)
           end.compact.flatten
         end
@@ -52,7 +54,7 @@ module Europeana
             keys = split_edm_key(field)
             field = keys.last
             keys[0..-2].each do |relation_key|
-              container = [container].flatten.collect { |d| d.send(relation_key.to_sym) }
+              container = [container].flatten.map { |d| d.send(relation_key.to_sym) }
             end
           end
           container
@@ -104,8 +106,8 @@ module Europeana
         end
 
         def relation_keys
-          [:agents, :aggregations, :concepts, :europeanaAggregation, :licenses,
-           :places, :providedCHOs, :proxies, :timespans, :webResources]
+          %i(agents aggregations concepts europeanaAggregation licenses
+             places providedCHOs proxies timespans webResources)
          end
       end
     end

data/app/models/europeana/blacklight/document.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'active_model'
 require 'iso-639'
 
@@ -37,11 +39,11 @@ module Europeana
 
       def fetch(key, *default)
         value = if has_relation?(key)
-          relations[key]
-        elsif field_in_relation?(key)
-          fetch_through_relation(key, *default)
-        else
-          super
+                  relations[key]
+                elsif field_in_relation?(key)
+                  fetch_through_relation(key, *default)
+                else
+                  super
         end
         localize_lang_map(value)
       end

data/app/presenters/europeana/blacklight/document_presenter.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Europeana
   module Blacklight
     ##
@@ -19,7 +21,7 @@ module Europeana
 
         field_config = @configuration.send(:"#{context}_fields")[key]
         value = options[:value] || begin
-          [container].flatten.compact.collect do |target|
+          [container].flatten.compact.map do |target|
             presenter = self.class.new(target, @controller, @configuration)
             presenter.get_field_values(key, field_config, options)
           end.compact.flatten

data/europeana-blacklight.gemspec

@@ -1,4 +1,6 @@
-$:.push File.expand_path("../lib", __FILE__)
+# frozen_string_literal: true
+
+$:.push File.expand_path('lib', __dir__)
 
 require 'europeana/blacklight/version'
 

data/lib/europeana/blacklight/engine.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Europeana
   module Blacklight
     class Engine < Rails::Engine

data/lib/europeana/blacklight/repository.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Europeana
   module Blacklight
     ##

data/lib/europeana/blacklight/response/facets.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Europeana
   module Blacklight
     class Response
@@ -37,7 +39,8 @@ module Europeana
           attr_reader :name, :items
 
           def initialize(name, items, options = {})
-            @name, @items = name, items
+            @name = name
+            @items = items
             @options = options
           end
 
@@ -50,8 +53,7 @@ module Europeana
           end
 
           # Expected by {Blacklight::Facet#facet_paginator}
-          def prefix
-          end
+          def prefix; end
 
           def sort
             # Europeana API does not support facet sorting
@@ -92,7 +94,7 @@ module Europeana
           facet_fields.each_with_object({}) do |facet, hash|
             facet_field_name = facet['name']
 
-            items = facet['fields'].collect do |value|
+            items = facet['fields'].map do |value|
               FacetItem.new(value: value['label'], hits: value['count'])
             end
 
@@ -104,11 +106,10 @@ module Europeana
 
             hash[facet_field_name] = FacetField.new(facet_field_name, items, facet_field_aggregation_options(facet_field_name))
 
-            if blacklight_config && !blacklight_config.facet_fields[facet_field_name]
-              # alias all the possible blacklight config names..
-              blacklight_config.facet_fields.select { |_k, v| v.field == facet_field_name }.each do |key, _|
-                hash[key] = hash[facet_field_name]
-              end
+            next unless blacklight_config && !blacklight_config.facet_fields[facet_field_name]
+            # alias all the possible blacklight config names..
+            blacklight_config.facet_fields.select { |_k, v| v.field == facet_field_name }.each do |key, _|
+              hash[key] = hash[facet_field_name]
             end
           end
         end

data/lib/europeana/blacklight/response/more_like_this.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Europeana
   module Blacklight
     class Response

data/lib/europeana/blacklight/response/pagination.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'kaminari'
 
 module Europeana

data/lib/europeana/blacklight/response.rb

@@ -17,7 +17,7 @@ module Europeana
       attr_accessor :document_model, :blacklight_config
 
       def initialize(data, request_params, options = {})
-        super(force_to_utf8(data))
+        super(data)
         @request_params = request_params
         self.document_model = options[:document_model] || Document
         self.blacklight_config = options[:blacklight_config]
@@ -41,7 +41,7 @@ module Europeana
       end
 
       def documents
-        @documents ||= (self.key?('object') ? [self['object']] : (self['items'] || [])).collect do |doc|
+        @documents ||= (key?('object') ? [self['object']] : (self['items'] || [])).map do |doc|
           document_model.new(doc, self)
         end
       end
@@ -74,20 +74,6 @@ module Europeana
       def empty?
         total == 0
       end
-
-      private
-
-      def force_to_utf8(value)
-        case value
-        when Hash
-          value.each { |k, v| value[k] = force_to_utf8(v) }
-        when Array
-          value.each { |v| force_to_utf8(v) }
-        when String
-          String.new(value).force_encoding('utf-8') if value.respond_to?(:force_encoding)
-        end
-        value
-      end
     end
   end
 end

data/lib/europeana/blacklight/routes.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Europeana
   module Blacklight
     ##

data/lib/europeana/blacklight/search_builder/facet_pagination.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Europeana
   module Blacklight
     class SearchBuilder
@@ -9,21 +11,21 @@ module Europeana
         included do
           default_processor_chain << :add_facet_paging_to_api
         end
-        
+
         def add_facet_paging_to_api(api_parameters)
           return unless facet.present?
 
           facet_config = blacklight_config.facet_fields[facet]
 
           limit = if scope.respond_to?(:facet_list_limit)
-              scope.facet_list_limit.to_s.to_i
-            elsif api_parameters['facet.limit']
-              api_parameters['facet.limit'].to_i
-            else
-              20
+                    scope.facet_list_limit.to_s.to_i
+                  elsif api_parameters['facet.limit']
+                    api_parameters['facet.limit'].to_i
+                  else
+                    20
             end
 
-          offset = (blacklight_params.fetch(blacklight_config.facet_paginator_class.request_keys[:page], 1).to_i - 1) * (limit)
+          offset = (blacklight_params.fetch(blacklight_config.facet_paginator_class.request_keys[:page], 1).to_i - 1) * limit
 
           # Need to set as f.facet_field.facet.* to make sure we
           # override any field-specific default in the solr request handler.
@@ -35,4 +37,3 @@ module Europeana
     end
   end
 end
-

data/lib/europeana/blacklight/search_builder/more_like_this.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Europeana
   module Blacklight
     class SearchBuilder
@@ -9,7 +11,7 @@ module Europeana
         included do
           default_processor_chain.unshift :add_mlt_to_api
         end
-        
+
         def add_mlt_to_api(api_parameters)
           return unless blacklight_params[:mlt]
           repository = blacklight_config.repository_class.new(blacklight_config)

data/lib/europeana/blacklight/search_builder/overlay_params.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Europeana
   module Blacklight
     class SearchBuilder
@@ -23,11 +25,11 @@ module Europeana
           @overlay_params.each do |param_set|
             param_set.each_pair do |k, v|
               k = k.to_sym
-              if api_parameters.key?(k)
-                api_parameters[k] = [api_parameters[k]].flatten # in case it's not an Array
-              else
-                api_parameters[k] = []
-              end
+              api_parameters[k] = if api_parameters.key?(k)
+                                    [api_parameters[k]].flatten # in case it's not an Array
+                                  else
+                                    []
+                                  end
               api_parameters[k] += [v]
               api_parameters[k] = api_parameters[k].flatten.uniq
             end

data/lib/europeana/blacklight/search_builder/ranges.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Europeana
   module Blacklight
     class SearchBuilder

data/lib/europeana/blacklight/search_builder.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Europeana
   module Blacklight
     ##
@@ -8,12 +10,12 @@ module Europeana
       require 'europeana/blacklight/search_builder/overlay_params'
       require 'europeana/blacklight/search_builder/ranges'
 
-      self.default_processor_chain = [
-        :default_api_parameters, :add_profile_to_api,
-        :add_query_to_api, :add_qf_to_api, :add_facet_qf_to_api, :add_query_facet_to_api,
-        :add_standalone_facets_to_api, :add_facetting_to_api, :add_paging_to_api,
-        :add_sorting_to_api, :add_api_url_to_api
-      ]
+      self.default_processor_chain = %i(
+        default_api_parameters add_profile_to_api
+        add_query_to_api add_qf_to_api add_facet_qf_to_api add_query_facet_to_api
+        add_standalone_facets_to_api add_facetting_to_api add_paging_to_api
+        add_sorting_to_api add_api_url_to_api
+      )
 
       include FacetPagination
       include MoreLikeThis
@@ -36,13 +38,13 @@ module Europeana
       # @todo Rename default_solr_params to default_params upstream
       def default_api_parameters(api_parameters)
         blacklight_config.default_solr_params.each do |key, value|
-          if value.respond_to?(:deep_dup)
-            api_parameters[key] = value.deep_dup
-          elsif value.respond_to?(:dup) && value.duplicable?
-            api_parameters[key] = value.dup
-          else
-            api_parameters[key] = value
-          end
+          api_parameters[key] = if value.respond_to?(:deep_dup)
+                                  value.deep_dup
+                                elsif value.respond_to?(:dup) && value.duplicable?
+                                  value.dup
+                                else
+                                  value
+                                end
         end
       end
 
@@ -52,7 +54,7 @@ module Europeana
       # @see http://labs.europeana.eu/api/search/#profile-parameter
       def add_profile_to_api(api_parameters)
         api_parameters[:profile] = 'params rich'
-        api_parameters[:profile] << ' facets' if blacklight_config.facet_fields
+        api_parameters[:profile] = api_parameters[:profile] + ' facets' if blacklight_config.facet_fields
       end
 
       ##
@@ -211,7 +213,7 @@ module Europeana
       end
 
       def api_request_facet_fields
-        @api_request_facet_fields ||= blacklight_config.facet_fields.select do |field_name, facet|
+        @api_request_facet_fields ||= blacklight_config.facet_fields.select do |_field_name, facet|
           requestable_facet?(facet)
         end
       end
@@ -230,8 +232,8 @@ module Europeana
         return if query.blank?
         return if query == '*:*' && api_parameters[:query].present?
         api_parameters[:query] ||= ''
-        api_parameters[:query] << ' ' unless api_parameters[:query].blank?
-        api_parameters[:query] << query
+        api_parameters[:query] = api_parameters[:query] + ' ' unless api_parameters[:query].blank?
+        api_parameters[:query] = api_parameters[:query] + query
       end
     end
   end

data/lib/europeana/blacklight/version.rb

@@ -1,5 +1,7 @@
+# frozen_string_literal: true
+
 module Europeana
   module Blacklight
-    VERSION = '1.2.2'.freeze
+    VERSION = '1.3.0'
   end
 end

data/lib/europeana/blacklight.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'blacklight'
 require 'europeana/api'
 require 'europeana/blacklight/engine'

data/lib/generators/europeana/blacklight/install_generator.rb

@@ -1,7 +1,9 @@
+# frozen_string_literal: true
+
 module Europeana
   module Blacklight
     class Install < Rails::Generators::Base
-      source_root File.expand_path('../templates', __FILE__)
+      source_root File.expand_path('templates', __dir__)
 
       argument :europeana_api_key, type: :string
       argument :controller_name, type: :string, default: 'catalog'

data/spec/dummy/Rakefile

@@ -1,6 +1,8 @@
+# frozen_string_literal: true
+
 # Add your own tasks in files placed in lib/tasks ending in .rake,
 # for example lib/tasks/capistrano.rake, and they will automatically be available to Rake.
 
-require File.expand_path('../config/application', __FILE__)
+require File.expand_path('config/application', __dir__)
 
 Rails.application.load_tasks

data/spec/dummy/app/controllers/application_controller.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class ApplicationController < ActionController::Base
   # Prevent CSRF attacks by raising an exception.
   # For APIs, you may want to use :null_session instead.

data/spec/dummy/app/helpers/application_helper.rb

@@ -1,2 +1,4 @@
+# frozen_string_literal: true
+
 module ApplicationHelper
 end

data/spec/dummy/bin/bundle

@@ -1,3 +1,5 @@
 #!/usr/bin/env ruby
-ENV['BUNDLE_GEMFILE'] ||= File.expand_path('../../Gemfile', __FILE__)
+# frozen_string_literal: true
+
+ENV['BUNDLE_GEMFILE'] ||= File.expand_path('../Gemfile', __dir__)
 load Gem.bin_path('bundler', 'bundle')

data/spec/dummy/bin/rails

@@ -1,4 +1,6 @@
 #!/usr/bin/env ruby
-APP_PATH = File.expand_path('../../config/application', __FILE__)
+# frozen_string_literal: true
+
+APP_PATH = File.expand_path('../config/application', __dir__)
 require_relative '../config/boot'
 require 'rails/commands'

data/spec/dummy/bin/rake

@@ -1,4 +1,6 @@
 #!/usr/bin/env ruby
+# frozen_string_literal: true
+
 require_relative '../config/boot'
 require 'rake'
 Rake.application.run

data/spec/dummy/bin/setup

@@ -1,16 +1,18 @@
 #!/usr/bin/env ruby
+# frozen_string_literal: true
+
 require 'pathname'
 
 # path to your application root.
-APP_ROOT = Pathname.new File.expand_path('../../',  __FILE__)
+APP_ROOT = Pathname.new File.expand_path('..', __dir__)
 
 Dir.chdir APP_ROOT do
   # This script is a starting point to setup your application.
   # Add necessary setup steps to this file:
 
-  puts "== Installing dependencies =="
-  system "gem install bundler --conservative"
-  system "bundle check || bundle install"
+  puts '== Installing dependencies =='
+  system 'gem install bundler --conservative'
+  system 'bundle check || bundle install'
 
   # puts "\n== Copying sample files =="
   # unless File.exist?("config/database.yml")
@@ -18,12 +20,12 @@ Dir.chdir APP_ROOT do
   # end
 
   puts "\n== Preparing database =="
-  system "bin/rake db:setup"
+  system 'bin/rake db:setup'
 
   puts "\n== Removing old logs and tempfiles =="
-  system "rm -f log/*"
-  system "rm -rf tmp/cache"
+  system 'rm -f log/*'
+  system 'rm -rf tmp/cache'
 
   puts "\n== Restarting application server =="
-  system "touch tmp/restart.txt"
+  system 'touch tmp/restart.txt'
 end

data/spec/dummy/config/application.rb

@@ -1,4 +1,6 @@
-require File.expand_path('../boot', __FILE__)
+# frozen_string_literal: true
+
+require File.expand_path('boot', __dir__)
 
 # Pick the frameworks you want:
 # require 'active_record/railtie'

data/spec/dummy/config/boot.rb

@@ -1,5 +1,7 @@
+# frozen_string_literal: true
+
 # Set up gems listed in the Gemfile.
-ENV['BUNDLE_GEMFILE'] ||= File.expand_path('../../../../Gemfile', __FILE__)
+ENV['BUNDLE_GEMFILE'] ||= File.expand_path('../../../Gemfile', __dir__)
 
 require 'bundler/setup' if File.exist?(ENV['BUNDLE_GEMFILE'])
-$LOAD_PATH.unshift File.expand_path('../../../../lib', __FILE__)
+$LOAD_PATH.unshift File.expand_path('../../../lib', __dir__)

data/spec/dummy/config/environment.rb

@@ -1,5 +1,7 @@
+# frozen_string_literal: true
+
 # Load the Rails application.
-require File.expand_path('../application', __FILE__)
+require File.expand_path('application', __dir__)
 
 # Initialize the Rails application.
 Rails.application.initialize!

data/spec/dummy/config/environments/development.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 Rails.application.configure do
   # Settings specified here will take precedence over those in config/application.rb.
 

data/spec/dummy/config/environments/production.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 Rails.application.configure do
   # Settings specified here will take precedence over those in config/application.rb.
 

data/spec/dummy/config/environments/test.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 Rails.application.configure do
   # Settings specified here will take precedence over those in config/application.rb.
 

data/spec/dummy/config/initializers/assets.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Be sure to restart your server when you modify this file.
 
 # Version of your assets, change this if you want to expire all your assets.

data/spec/dummy/config/initializers/backtrace_silencers.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Be sure to restart your server when you modify this file.
 
 # You can add backtrace silencers for libraries that you're using but don't wish to see in your backtraces.

data/spec/dummy/config/initializers/cookies_serializer.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Be sure to restart your server when you modify this file.
 
 Rails.application.config.action_dispatch.cookies_serializer = :json

data/spec/dummy/config/initializers/filter_parameter_logging.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Be sure to restart your server when you modify this file.
 
 # Configure sensitive parameters which will be filtered from the log file.

data/spec/dummy/config/initializers/inflections.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Be sure to restart your server when you modify this file.
 
 # Add new inflection rules using the following format. Inflections

data/spec/dummy/config/initializers/mime_types.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Be sure to restart your server when you modify this file.
 
 # Add new mime types for use in respond_to blocks:

data/spec/dummy/config/initializers/session_store.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Be sure to restart your server when you modify this file.
 
 Rails.application.config.session_store :cookie_store, key: '_dummy_session'

data/spec/dummy/config/initializers/wrap_parameters.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Be sure to restart your server when you modify this file.
 
 # This file contains settings for ActionController::ParamsWrapper which

data/spec/dummy/config/routes.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 Rails.application.routes.draw do
   # The priority is based upon order of creation: first created -> highest priority.
   # See how all your routes lay out with "rake routes".

data/spec/dummy/config.ru

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # This file is used by Rack-based servers to start the application.
 
 require ::File.expand_path('../config/environment', __FILE__)

data/spec/europeana/blacklight/repository_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 RSpec.describe Europeana::Blacklight::Repository do
   let(:blacklight_config) do
     Blacklight::Configuration.new.tap do |config|
@@ -25,13 +27,13 @@ RSpec.describe Europeana::Blacklight::Repository do
     it 'should send a record query to the API' do
       subject.find(record_id)
       expect(a_request(:get, "https://www.europeana.eu/api/v2/record#{record_id}.json").
-        with(query: hash_including({ 'wskey' => api_key }))).to have_been_made
+        with(query: hash_including('wskey' => api_key))).to have_been_made
     end
 
     it 'should pass on API query params' do
       subject.find(record_id, callback: 'showRecord')
       expect(a_request(:get, "https://www.europeana.eu/api/v2/record#{record_id}.json").
-        with(query: hash_including({ 'wskey' => api_key, 'callback' => 'showRecord' }))).to have_been_made
+        with(query: hash_including('wskey' => api_key, 'callback' => 'showRecord'))).to have_been_made
     end
 
     it 'should return configured response model' do
@@ -45,7 +47,7 @@ RSpec.describe Europeana::Blacklight::Repository do
     it 'should send a search query to the API' do
       subject.search('query' => query)
       expect(a_request(:get, 'https://www.europeana.eu/api/v2/search.json').
-        with(query: hash_including({ 'wskey' => api_key, 'query' => query }))).to have_been_made
+        with(query: hash_including('wskey' => api_key, 'query' => query))).to have_been_made
     end
 
     it 'should return configured response model' do

data/spec/europeana/blacklight/search_builder_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 RSpec.describe Europeana::Blacklight::SearchBuilder do
   it 'does not add wskey param'
 end

data/spec/europeana/blacklight_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Europeana::Blacklight do

data/spec/models/europeana/blacklight/document/lang_maps_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 RSpec.describe Europeana::Blacklight::Document::LangMaps do
   it 'handles "LangMap" API response data type'
 end

data/spec/models/europeana/blacklight/document/more_like_this_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 RSpec.describe Europeana::Blacklight::Document::MoreLikeThis do
   subject { Europeana::Blacklight::Document.new(source) }
   let(:source) { {} }

data/spec/models/europeana/blacklight/document/relations_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 RSpec.describe Europeana::Blacklight::Document::Relations do
   subject { Europeana::Blacklight::Document.new(source) }
 
@@ -5,8 +7,8 @@ RSpec.describe Europeana::Blacklight::Document::Relations do
     let(:source) { { id: '/abc/123', title: ['test'] } }
 
     it 'returns an empty array' do
-      [:agents, :aggregations, :concepts, :europeanaAggregation, :places,
-       :providedCHOs, :proxies, :timespans].each do |relation|
+      %i(agents aggregations concepts europeanaAggregation places
+         providedCHOs proxies timespans).each do |relation|
         expect(subject.send(relation)).to eq([])
       end
     end

data/spec/models/europeana/blacklight/document_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 require 'i18n'
 
@@ -11,7 +13,7 @@ RSpec.describe Europeana::Blacklight::Document do
     {
       id: '/abc/123',
       type: 'IMAGE',
-      title: ['title1', 'title2'],
+      title: %w(title1 title2),
       proxies: [
         {
           about: '/proxy/provider/abc/123',
@@ -20,7 +22,7 @@ RSpec.describe Europeana::Blacklight::Document do
             en: ['Picture']
           },
           dcSubject: {
-            def: ['music', 'art']
+            def: %w(music art)
           },
           dcDescription: {
             en: ['object desc']
@@ -136,7 +138,7 @@ RSpec.describe Europeana::Blacklight::Document do
 
     context 'when value is array' do
       it 'returns array of values' do
-        expect(subject['title']).to eq(['title1', 'title2'])
+        expect(subject['title']).to eq(%w(title1 title2))
       end
     end
 
@@ -149,7 +151,7 @@ RSpec.describe Europeana::Blacklight::Document do
       end
     end
   end
-  
+
   describe '#fetch' do
     context 'when key is to relation' do
       it 'handles 2-level keys' do

data/spec/presenters/europeana/blacklight/document_presenter_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 require 'i18n'
 

data/spec/spec_helper.rb

@@ -1,10 +1,12 @@
+# frozen_string_literal: true
+
 ENV['RAILS_ENV'] ||= 'test'
 
 # Generate Simplecov report
 require 'simplecov'
 SimpleCov.start
 
-require File.expand_path('../dummy/config/environment.rb', __FILE__)
+require File.expand_path('dummy/config/environment.rb', __dir__)
 require 'rspec/rails'
 require 'shoulda/matchers'
 require 'webmock/rspec'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: europeana-blacklight
 version: !ruby/object:Gem::Version
-  version: 1.2.2
+  version: 1.3.0
 platform: ruby
 authors:
 - Richard Doe
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-07-19 00:00:00.000000000 Z
+date: 2019-01-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: blacklight
@@ -282,7 +282,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.12
+rubygems_version: 2.7.3
 signing_key: 
 specification_version: 4
 summary: Europeana REST API adapter for Blacklight