europe 0.0.19 → 0.0.21

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 4ed6dabe018e89d9bbf23e67b0137974b05035aa1bbe684634b5f486cb080675
-  data.tar.gz: 1d326773840b959bb92b198cc834ee1a90343c87ca5eed0f76b044f74cf5039e
+  metadata.gz: a1265263ae93ea1408b778a1bff21d44a913d54f10e034d2eb4f2536ed3e87ce
+  data.tar.gz: '079be0aeba6bf84a543b9df49e25d1571b3a8527b3770c176ae3014b3260d809'
 SHA512:
-  metadata.gz: e54ce40bbfa5985395dddbf38498b2a22887ebe12d81de4004b39a2643f0015a3adae16d49239e8b8ae3806f5300de3fa8aa474d36e545c9dab63548c5282094
-  data.tar.gz: 131df277ed531fe687f1f156d912d673f513e8806264572fb90343d5e0440cae6a4b20b8e1f0951bb964028d718d63a2b04f626070bddd375d784442ec7501d1
+  metadata.gz: fb51a61ff49138ce79b0e3919427967a62b79ece0f8285c3b2074cbb4cb2a960f02d611970991e43784dcb750e09d8708c822840b338cbd41cd3aa1c5df53666
+  data.tar.gz: 8c4eda6745c2a60a39e9c38dbb2770a23cf0597764bfab1e57deeac3c2bdbcbf5fe0659c0a96cf023176219808ccab0c91966d4e8454a1f0632f9c91eda61f02

data/.rubocop.yml

@@ -1,6 +1,6 @@
 AllCops:
   NewCops: enable
-  TargetRubyVersion: 3.1
+  TargetRubyVersion: 3.2
   SuggestExtensions: false
   Exclude:
     - 'europe.gemspec'

data/.travis.yml

@@ -9,3 +9,4 @@ rvm:
   - 2.6.0
   - 2.6.2
   - 2.6.3
+  - 3.1.1

data/CHANGELOG.md

@@ -1,6 +1,12 @@
 # Change Log
 All notable changes to this project will be documented in this file.
 This project adheres to [Semantic Versioning](http://semver.org/).
+## 0.0.21
+  - Added check to fail short VAT numbers under 5 characters
+  - [Full Changelog](https://github.com/gem-shards/europe.rb/compare/v0.0.20...v0.0.21)
+## 0.0.20
+  - Added fallback VAT rates in case the EU website is down or unresponsive
+  - [Full Changelog](https://github.com/gem-shards/europe.rb/compare/v0.0.19...v0.0.20)
 ## 0.0.19
   - Fixed VAT validation call because XML response was updated
   - [Full Changelog](https://github.com/gem-shards/europe.rb/compare/v0.0.18...v0.0.19)

data/lib/europe/vat/rates.rb

@@ -6,21 +6,33 @@ module Europe
   module Vat
     # Rates
     module Rates
+      FALLBACK_RATES = {
+        AT: 20.0, BE: 21.0, BG: 20.0, CY: 19.0, CZ: 21.0, DE: 19.0, DK: 25.0, EE: 20.0,
+        EL: 24.0, ES: 21.0, FI: 24.0, FR: 20.0, UK: 20.0, HR: 25.0, HU: 27.0, IE: 23.0,
+        IT: 22.0, LT: 21.0, LU: 17.0, LV: 21.0, MT: 18.0, NL: 21.0, PL: 23.0, PT: 23.0,
+        RO: 19.0, SE: 25.0, SI: 22.0, SK: 20.0
+      }.freeze
       RATES_URL = 'https://ec.europa.eu/taxation_customs/' \
                   'business/vat/telecommunications-broadcasting' \
                   '-electronic-services/vat-rates_en'
 
       def self.retrieve
         resp = fetch_rates
-        return resp if resp == :failed
+        return FALLBACK_RATES if resp.nil?
 
         extract_rates(resp)
       end
 
+      # rubocop:disable Metrics/MethodLength
       def self.extract_rates(resp)
         rates = {}
 
-        data = resp.scan(%r{\<tbody\>(.*)\<\/tbody\>}m).first.first.strip
+        begin
+          data = resp.scan(%r{\<tbody\>(.*)\<\/tbody\>}m).first.first.strip
+        rescue NoMethodError
+          return FALLBACK_RATES
+        end
+
         xml = REXML::Document.new("<root>#{data}</root>")
         xml.first.elements.each('tr') do |result|
           next if result[3].nil?
@@ -29,6 +41,7 @@ module Europe
         end
         rates
       end
+      # rubocop:enable Metrics/MethodLength
 
       def self.filter_rate(result, rates)
         country = result[0].text
@@ -40,7 +53,7 @@ module Europe
 
       def self.fetch_rates
         resp = Net::HTTP.get_response(URI.parse(RATES_URL))
-        resp.code.to_i == 200 ? resp.body : :failed
+        resp.code.to_i == 200 ? resp.body : nil
       end
     end
   end

data/lib/europe/vat/vat.rb

@@ -33,6 +33,8 @@ module Europe
     XML
 
     def self.validate(number)
+      return :failed if number.size < 4
+
       response = send_request(number[0..1], number[2..-1])
       return :failed unless response.is_a? Net::HTTPSuccess
       return :failed if response.body.include?('soap:Fault')

data/lib/europe/version.rb

@@ -2,5 +2,5 @@
 
 # Europe version
 module Europe
-  VERSION = '0.0.19'
+  VERSION = '0.0.21'
 end

data/test/europe/vat/format_test.rb

@@ -62,15 +62,15 @@ module Europe
       def check_character_and_digit(number)
         assert_equal true, Europe::Vat::Format.validate(
           number[0..1] +
-          number[2..-1].gsub(/X/, [*('A'..'Z'), *('0'..'9')].sample)
+          number[2..-1].gsub('X', [*('A'..'Z'), *('0'..'9')].sample)
         )
       end
 
       def check_integer(number)
         {
-          number[0..1] + number[2..-1].gsub(/9/, [*('0'..'9')].sample) => true,
-          number.gsub(/9/, rand(10).to_s) => true,
-          number.gsub(/9/, [*('A'..'Z')].sample(1).join) => false
+          number[0..1] + number[2..-1].gsub('9', [*('0'..'9')].sample) => true,
+          number.gsub('9', rand(10).to_s) => true,
+          number.gsub('9', [*('A'..'Z')].sample(1).join) => false
         }.each do |key, value|
           assert_equal value, Europe::Vat::Format.validate(key)
         end
@@ -78,10 +78,10 @@ module Europe
 
       def check_alphanumeric(number)
         assert_equal true, Europe::Vat::Format.validate(
-          number[0..1] + number[2..-1].gsub(/L/, [*('A'..'Z')].sample)
+          number[0..1] + number[2..-1].gsub('L', [*('A'..'Z')].sample)
         )
         assert_equal false, Europe::Vat::Format.validate(
-          number[0..1] + number[2..-1].gsub(/L/, [*('0'..'9')].sample)
+          number[0..1] + number[2..-1].gsub('L', [*('0'..'9')].sample)
         )
       end
 

data/test/europe/vat/rates_test.rb

@@ -14,11 +14,9 @@ module Europe
 
       def test_retrieval_of_vat_rates
         rates = Europe::Vat::Rates.retrieve
-        if rates == :failed
-          rates = { NL: 17, DE: 19, ES: 18 }
-        else
-          assert_equal rates.count, Europe::Countries::COUNTRIES.count
-        end
+
+        assert_equal rates.count, Europe::Countries::COUNTRIES.count
+
         assert rates[:NL]
         assert rates[:DE]
         assert rates[:ES]

data/test/europe/vat/validation_test.rb

@@ -12,6 +12,10 @@ module Europe
         WebMock.disable!
       end
 
+      def test_validation_of_short_vat_number
+        assert_equal :failed, Europe::Vat.validate('6')
+      end
+
       def test_validation_of_false_vat_number
         validate_false_vat = Europe::Vat.validate('NL123456789B01')
         assert_equal false, validate_false_vat[:valid]

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: europe
 version: !ruby/object:Gem::Version
-  version: 0.0.19
+  version: 0.0.21
 platform: ruby
 authors:
 - Gem shards
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2022-08-15 00:00:00.000000000 Z
+date: 2024-02-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: byebug