europe 0.0.16 → 0.0.19

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b8dfe84a1c050d715865f2f5878458f4f9708437770e629ee64564d59ff622d4
-  data.tar.gz: d59e3b667b741269bfb5db4dafeb6cc531a052fd79ccfcbe354e941c5976cb13
+  metadata.gz: 4ed6dabe018e89d9bbf23e67b0137974b05035aa1bbe684634b5f486cb080675
+  data.tar.gz: 1d326773840b959bb92b198cc834ee1a90343c87ca5eed0f76b044f74cf5039e
 SHA512:
-  metadata.gz: 5da3ca3fc8579d8b55043b6f9af8da9ac1f69aa46ec9e4c9858a2318cae1222724679553ec45f61308928f65595bbd71682279aa219e46e698811eb3a27217a2
-  data.tar.gz: 3c5f1f99dab00df6e1e66acf202c4a12cf339fb0207566b5ef613d93c8ac262e61b243a05045e30c82dbc3b36667f89bc99345bb4b42456420951a5d7b889420
+  metadata.gz: e54ce40bbfa5985395dddbf38498b2a22887ebe12d81de4004b39a2643f0015a3adae16d49239e8b8ae3806f5300de3fa8aa474d36e545c9dab63548c5282094
+  data.tar.gz: 131df277ed531fe687f1f156d912d673f513e8806264572fb90343d5e0440cae6a4b20b8e1f0951bb964028d718d63a2b04f626070bddd375d784442ec7501d1

data/.github/workflows/ruby.yml

@@ -0,0 +1,29 @@
+# This workflow uses actions that are not certified by GitHub.
+# They are provided by a third-party and are governed by
+# separate terms of service, privacy policy, and support
+# documentation.
+# This workflow will download a prebuilt Ruby version, install dependencies and run tests with Rake
+# For more information see: https://github.com/marketplace/actions/setup-ruby-jruby-and-truffleruby
+
+name: Ruby
+
+on:
+  push:
+    branches: [ master ]
+  pull_request:
+    branches: [ master ]
+
+jobs:
+  test:
+
+    runs-on: ubuntu-latest
+
+    steps:
+    - uses: actions/checkout@v2
+    - uses: ruby/setup-ruby@v1
+      with:
+        ruby-version: 3.1.1
+    - name: Install dependencies
+      run: bundle install
+    - name: Run tests
+      run: bundle exec rake

data/.gitignore

@@ -15,3 +15,4 @@ mkmf.log
 .DS_Store
 coverage
 .byebug_history
+*.gem

data/.rubocop.yml

@@ -1,6 +1,6 @@
 AllCops:
   NewCops: enable
-  TargetRubyVersion: 2.7
+  TargetRubyVersion: 3.1
   SuggestExtensions: false
   Exclude:
     - 'europe.gemspec'

data/CHANGELOG.md

@@ -1,6 +1,25 @@
 # Change Log
 All notable changes to this project will be documented in this file.
 This project adheres to [Semantic Versioning](http://semver.org/).
+## 0.0.19
+  - Fixed VAT validation call because XML response was updated
+  - [Full Changelog](https://github.com/gem-shards/europe.rb/compare/v0.0.18...v0.0.19)
+## 0.0.18
+  - Added Estonia and Lithuania to eurozone
+  - [Full Changelog](https://github.com/gem-shards/europe.rb/compare/v0.0.17...v0.0.18)
+## 0.0.17
+  - Removed all UK VAT logic
+  - Updated development dependencies
+  - [Full Changelog](https://github.com/gem-shards/europe.rb/compare/v0.0.16...v0.0.17)
+## 0.0.16
+  - Changed Slovak Republic to Slovakia in country names
+  - Updated outdated endpoint for VAT rates, thanks to @firstpromoter
+  - Fixed a couple of rubocop issues
+  - [Full Changelog](https://github.com/gem-shards/europe.rb/compare/v0.0.15...v0.0.16)
+## 0.0.15
+  - Checked library on Ruby 2.7
+  - Moved repository to gem-shards
+  - [Full Changelog](https://github.com/VvanGemert/europe/compare/v0.0.14...v0.0.15)
 
 ## 0.0.14
   - Fixed rubocop syntax issues

data/README.md

@@ -43,16 +43,16 @@ where this gem can be used for.
 ** Updated: Parameter now consists of one value.**
 Call to validate VAT number (always starts with country code as specified in VIES)
 ```ruby
-Europe::Vat.validate('GB440627467')
+Europe::Vat.validate('NL009291477B01')
 ```
 Response
 ```ruby
-{ :country_code=>"GB",
-  :vat_number=>"440627467",
-  :request_date=>#<Date: 2015-12-15 ((2457372j,0s,0n),+0s,2299161j)>,
-  :valid=>true,
-  :name=>"SKY PLC",
-  :address=>"6 CENTAURS BUSINESS PARK\nGRANT WAY\nISLEWORTH\nMIDDLESEX\n\nTW7 5QD" }
+{ :country_code => "NL",
+  :vat_number => "009291477B01",
+  :request_date => #<Date: 2015-12-15 ((2457372j,0s,0n),+0s,2299161j)>,
+  :valid => true,
+  :name => "KONINKLIJKE POSTNL B.V.",
+  :address => nil }
 ```
 
 ### Validate VAT number format

data/europe.gemspec

@@ -15,6 +15,9 @@ Gem::Specification.new do |spec|
                        'VAT validation, currency exchange rates and ' \
                        'country information.'
   spec.homepage      = 'https://github.com/gem-shards/europe.rb'
+  spec.metadata    = {
+    'source_code_uri' => 'https://github.com/gem-shards/europe.rb',
+    'changelog_uri' => 'https://github.com/gem-shards/europe.rb/blob/master/CHANGELOG.md' }
   spec.license       = 'MIT'
 
   spec.files         = `git ls-files -z`.split("\x0")

data/lib/europe/countries/countries.rb

@@ -26,7 +26,7 @@ module Europe
             tld: '.de', currency: :EUR, capital: 'Berlin' },
       EE: { name: 'Estonia', source_name: 'Eesti',
             official_name: 'Republic of Estonia',
-            tld: '.ee', currency: :EEK, capital: 'Tallinn' },
+            tld: '.ee', currency: :EUR, capital: 'Tallinn' },
       IE: { name: 'Ireland', source_name: 'Éire',
             official_name: 'Ireland',
             tld: '.ie', currency: :EUR, capital: 'Dublin' },
@@ -53,7 +53,7 @@ module Europe
             tld: '.lv', currency: :EUR, capital: 'Riga' },
       LT: { name: 'Lithuania', source_name: 'Lietuva',
             official_name: 'Republic of Lithuania',
-            tld: '.lt', currency: :LTL, capital: 'Vilnius' },
+            tld: '.lt', currency: :EUR, capital: 'Vilnius' },
       LU: { name: 'Luxembourg', source_name: 'Luxembourg',
             official_name: 'Grand Duchy of Luxembourg',
             tld: '.lu', currency: :EUR, capital: 'Luxembourg City' },

data/lib/europe/vat/format.rb

@@ -19,7 +19,6 @@ module Europe
         ES: /^ES([A-Z0-9]\d{7}[A-Z0-9])$/,
         FI: /^FI\d{8}$/,
         FR: /^FR[A-Z0-9][A-Z0-9] \d{9}$/,
-        GB: [/^GB(\d{3} \d{4} \d{2}( \d{3}5)?)$/, /^GB(HA|GD)\d{3}(6|7)$/],
         HR: /^HR\d{11}$/,
         HU: /^HU\d{8}$/,
         IE: /^IE\d[A-Z0-9\+\*|\d]\d{5}([A-Z]|WI)$/,
@@ -46,7 +45,7 @@ module Europe
       end
 
       def self.sanitize_number(number, country_code)
-        if %i[GB DK FR].include?(country_code)
+        if %i[DK FR].include?(country_code)
           number.gsub(/\.|\t/, '').upcase
         else
           number.gsub(/\.|\t|\s/, '').upcase

data/lib/europe/vat/vat.rb

@@ -47,18 +47,18 @@ module Europe
     def self.setup_response(response)
       body = response_xml(response)
       {
-        valid: extract_data(body, 4) == 'true',
-        country_code: extract_data(body, 1),
-        vat_number: extract_data(body, 2),
-        request_date: convert_date(extract_data(body, 3)),
-        name: extract_data(body, 5),
-        address: extract_data(body, 6)
+        valid: extract_data(body, 3) == 'true',
+        country_code: extract_data(body, 0),
+        vat_number: extract_data(body, 1),
+        request_date: convert_date(extract_data(body, 2)),
+        name: extract_data(body, 4),
+        address: extract_data(body, 5)
       }
     end
 
     def self.response_xml(response)
       xml = REXML::Document.new(response.body)
-      xml.first.elements.first.elements.first.elements
+      xml.elements.first.elements[2].elements[1]
     end
 
     def self.convert_date(date)
@@ -74,12 +74,8 @@ module Europe
     def self.charge_vat?(origin_country, number)
       return false if number.nil? || number.empty?
 
-      if origin_country.to_sym == number[0..1].to_sym
-        true
-      else
-        Europe::Countries::COUNTRIES
-          .key?(number[0..1].to_sym)
-      end
+      Europe::Vat::Fromat::VAT_REGEX.key?(origin_country.to_sym) ||
+        Europe::Vat::Fromat::VAT_REGEX.key?(number[0..1].to_sym)
     end
 
     def self.send_request(country_code, number)

data/lib/europe/version.rb

@@ -2,5 +2,5 @@
 
 # Europe version
 module Europe
-  VERSION = '0.0.16'
+  VERSION = '0.0.19'
 end

data/test/europe/countries/country_test.rb

@@ -16,7 +16,7 @@ module Europe
 
         reversed_hash =
           Europe::Countries::Reversed.generate(:currency)
-        assert_equal reversed_hash[:EUR].count, 17
+        assert_equal reversed_hash[:EUR].count, 19
       end
 
       def test_eurozone

data/test/europe/vat/format_test.rb

@@ -21,10 +21,6 @@ module Europe
         ES: 'ESX9999999X',
         FI: 'FI99999999',
         FR: 'FRXX 999999999',
-        GB: ['GB999 9999 99 9995',
-             'GBGD9996',
-             'GBHA9997',
-             'GB999 9999 99'],
         HR: 'HR99999999999',
         HU: 'HU99999999',
         IE: %w[IE9S99999L IE9999999WI],

data/test/europe/vat/validation_test.rb

@@ -23,11 +23,6 @@ module Europe
         assert validate_correct_vat[:valid] \
           unless %i[timeout failed].include?(validate_correct_vat)
 
-        # Sky
-        validate_correct_vat = Europe::Vat.validate('GB440627467')
-        assert validate_correct_vat[:valid] \
-          unless %i[timeout failed].include?(validate_correct_vat)
-
         # Volkswagen
         validate_correct_vat = Europe::Vat.validate('DE115235681')
         assert validate_correct_vat[:valid] \

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: europe
 version: !ruby/object:Gem::Version
-  version: 0.0.16
+  version: 0.0.19
 platform: ruby
 authors:
 - Gem shards
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2021-01-31 00:00:00.000000000 Z
+date: 2022-08-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: byebug
@@ -145,6 +145,7 @@ extensions: []
 extra_rdoc_files: []
 files:
 - ".coveralls.yml"
+- ".github/workflows/ruby.yml"
 - ".gitignore"
 - ".pryrc"
 - ".rubocop.yml"
@@ -180,7 +181,9 @@ files:
 homepage: https://github.com/gem-shards/europe.rb
 licenses:
 - MIT
-metadata: {}
+metadata:
+  source_code_uri: https://github.com/gem-shards/europe.rb
+  changelog_uri: https://github.com/gem-shards/europe.rb/blob/master/CHANGELOG.md
 post_install_message:
 rdoc_options: []
 require_paths:
@@ -196,7 +199,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.4
+rubygems_version: 3.3.7
 signing_key:
 specification_version: 4
 summary: Europe is a gem for retrieving and validating EU government data.