eu_central_bank 1.6.1 → 2.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 5a531cbda27d58075c18fb0ed04177d5d16872e178046854495fe87c2094678e
-  data.tar.gz: b87062758ed6a9ef559fbd42a8d3bdf4f59366abd3c201951a01af62bbfb46df
+  metadata.gz: ca70af38e85e1aa52636b0e86ed6a7686b4c5670451da56a01eb880d82b89138
+  data.tar.gz: e552f4eaf63c199a3fb4023a434c8f5d2b8fd324c86177a20628aac0d144e3a8
 SHA512:
-  metadata.gz: fffe386b9fadfa03a24e36e77bb52d66df0c21e9d042e96a74e945b314798ee942938a3e2f9aec29c69aabedd2b3934bca780574112c842764f7708816ddeee9
-  data.tar.gz: 6f495beaafc197894bbeecb9333f31d4d5b530879f64d162442fc8389793a23f87096100ee5ebc9a978143f350445dbd6e0c6651448dddc870b35e7efac8da04
+  metadata.gz: 18c56beb798fa5773b2dade4b59eae065abaee2d328532946695d0fa1a7acc2b3f725d4c4d21b5edf86040f766ee8b091588514848c3ab2e2ff258934b2c4669
+  data.tar.gz: 2b1de916b41d2304d615824c918faa4fae62d275521fddd842397758c22d80eb4d6a0e0f75ebb8726bf19ff6e8a520b51ebbc2255dd148744bcc238f0049bdf5

data/CHANGELOG.md

@@ -1,8 +1,23 @@
 # eu_central_bank changelog
 
+## Upcoming release (unreleased)
+
+## 2.0.0 (Dec 10 2025)
+
+* **Breaking change**: Require Ruby >= 3.1
+* **Breaking change**: Update Money dependency to 7.0. Make sure to read [the upgrade
+  guide](https://github.com/RubyMoney/money/blob/main/UPGRADING-7.0.md).
+* Update YAML loading from compatibility with recent Psych versions.
+* Move Croatian Kuna (HRK) and Russian Ruble (RUB) to legacy currencies
+* Add `EuCentralBank::VERSION`.
+
+## 1.7.0 (Nov 17 2021)
+
+* Support historical rates
+
 ## 1.6.1 (Mar 3 2021)
 
-* Allow a fallback when loading cached rate files to inhibit network fetch. 
+* Allow a fallback when loading cached rate files to inhibit network fetch.
 
 ## 1.5.0 (Dec 7 2019)
 

data/LICENSE

@@ -1,7 +1,7 @@
 MIT License
 
 Copyright (c) 2009 Wong Liang Zan
-Copyright (c) 2021 Shane Emmons
+Copyright (c) 2025 Shane Emmons
 
 Permission is hereby granted, free of charge, to any person obtaining a copy
 of this software and associated documentation files (the "Software"), to deal

data/README.md

@@ -1,6 +1,7 @@
 # eu_central_bank
 
-[![Build Status](https://travis-ci.org/RubyMoney/eu_central_bank.svg?branch=master)](https://travis-ci.org/RubyMoney/eu_central_bank)
+[![Gem Version](https://badge.fury.io/rb/eu_central_bank.svg)](https://rubygems.org/gems/eu_central_bank)
+[![Ruby](https://github.com/RubyMoney/eu_central_bank/actions/workflows/ruby.yml/badge.svg)](https://github.com/RubyMoney/eu_central_bank/actions/workflows/ruby.yml)
 
 ## Introduction
 
@@ -12,15 +13,10 @@ This gem downloads the exchange rates from the European Central Bank. You can ca
 gem install eu_central_bank
 ```
 
-In case you're using older ruby (< 2.1) you need nokogiri < 1.6.8, so add this to your `Gemfile`:
-
-```
-gem 'nokogiri', '1.6.8'
-```
-
 ## Dependencies
 
 - nokogiri
+- bigdecimal
 - money
 
 ## Usage
@@ -72,9 +68,9 @@ eu_bank.exchange_with(Money.new(100, "CAD"), "USD") # Money.new(80, "USD")
 
 - Fork the project.
 - Make your feature addition or bug fix.
-- Add tests for it. This is important so I don't break it in a  future version unintentionally.
+- Add tests for it. This is important so I don't break it in a future version unintentionally.
 - Commit, do not mess with rakefile, version, or history. (if you want to have your own version, that is fine but bump version in a commit by itself I can ignore when I pull)
 
 ## Copyright
 
-Copyright (c) 2010-2016 RubyMoney. See LICENSE for details.
+Copyright (c) 2010-2025 RubyMoney. See LICENSE for details.

data/lib/eu_central_bank/rates_document.rb

@@ -0,0 +1,45 @@
+class EuCentralBank < Money::Bank::VariableExchange
+  class RatesDocument < Nokogiri::XML::SAX::Document
+    attr_reader :rates
+    attr_reader :errors
+    attr_reader :updated_at
+
+    def initialize
+      @rates = {}
+      @errors = []
+      @updated_at = nil
+      @current_date = nil
+    end
+
+    def error(msg)
+      # TODO: remove this workaround after
+      # https://github.com/sparklemotion/nokogiri/pull/1872
+      # is released
+      @errors << msg
+      super
+    end
+
+    def start_element(name, attributes=[])
+      return if name != 'Cube' || attributes.empty?
+      begin
+        first_name, first_value = attributes[0]
+        case first_name
+        when 'time'
+          @current_date = Time.parse(first_value).to_date
+          @updated_at ||= @current_date
+          @rates[@current_date] = []
+        when 'currency'
+          currency = first_value
+          _, rate = attributes[1]
+          @rates[@current_date] << [currency, rate]
+        end
+      rescue StandardError => e
+        raise Nokogiri::XML::XPath::SyntaxError, e.message
+      end
+    end
+
+    def end_document
+      raise Nokogiri::XML::XPath::SyntaxError if @rates.empty? || @updated_at.nil?
+    end
+  end
+end

data/lib/eu_central_bank/version.rb

@@ -0,0 +1,5 @@
+# frozen_string_literal: true
+
+class EuCentralBank < Money::Bank::VariableExchange
+  VERSION = "2.0.0"
+end

data/lib/eu_central_bank.rb

@@ -2,6 +2,8 @@ require 'open-uri'
 require 'nokogiri'
 require 'money'
 require 'money/rates_store/store_with_historical_data_support'
+require 'eu_central_bank/rates_document'
+require 'eu_central_bank/version'
 
 class InvalidCache < StandardError ; end
 
@@ -16,9 +18,12 @@ class EuCentralBank < Money::Bank::VariableExchange
 
   SERIALIZER_DATE_SEPARATOR = '_AT_'
   DECIMAL_PRECISION = 5
-  CURRENCIES = %w(USD JPY BGN CZK DKK GBP HUF ILS ISK PLN RON SEK CHF NOK HRK RUB TRY AUD BRL CAD CNY HKD IDR INR KRW MXN MYR NZD PHP SGD THB ZAR).map(&:freeze).freeze
+  CURRENCIES = %w(USD JPY BGN CZK DKK GBP HUF ILS ISK PLN RON SEK CHF NOK TRY AUD BRL CAD CNY HKD IDR INR KRW MXN MYR NZD PHP SGD THB ZAR).map(&:freeze).freeze
   ECB_RATES_URL = 'https://www.ecb.europa.eu/stats/eurofxref/eurofxref-daily.xml'.freeze
   ECB_90_DAY_URL = 'https://www.ecb.europa.eu/stats/eurofxref/eurofxref-hist-90d.xml'.freeze
+  ECB_ALL_HIST_URL = 'https://www.ecb.europa.eu/stats/eurofxref/eurofxref-hist.xml'.freeze
+
+  LEGACY_CURRENCIES = %w(CYP HRK RUB SIT ROL TRL)
 
   def initialize(st = Money::RatesStore::StoreWithHistoricalDataSupport.new, &block)
     super
@@ -29,24 +34,30 @@ class EuCentralBank < Money::Bank::VariableExchange
     update_parsed_rates(doc(cache, url))
   end
 
-  def update_historical_rates(cache=nil)
-    update_parsed_historical_rates(doc(cache, ECB_90_DAY_URL))
+  def update_historical_rates(cache=nil, all=false)
+    url = all ? ECB_ALL_HIST_URL : ECB_90_DAY_URL
+    update_parsed_historical_rates(doc(cache, url))
   end
 
   def save_rates(cache, url=ECB_RATES_URL)
     raise InvalidCache unless cache
     File.open(cache, "w") do |file|
-      io = open_url(url);
+      io = URI.open(url)
       io.each_line { |line| file.puts line }
     end
   end
 
+  def save_historical_rates(cache, all=false)
+    url = all ? ECB_ALL_HIST_URL : ECB_90_DAY_URL
+    save_rates(cache, url)
+  end
+
   def update_rates_from_s(content)
-    update_parsed_rates(doc_from_s(content))
+    update_parsed_rates(parse_rates(content))
   end
 
   def save_rates_to_s(url=ECB_RATES_URL)
-    open_url(url).read
+    URI.open(url).read
   end
 
   def exchange(cents, from_currency, to_currency, date=nil)
@@ -139,7 +150,11 @@ class EuCentralBank < Money::Bank::VariableExchange
        when :ruby
          Marshal.load(s)
        when :yaml
-         YAML.load(s)
+         if Gem::Version.new(Psych::VERSION) >= Gem::Version.new('3.1.0')
+           YAML.safe_load(s, permitted_classes: [ BigDecimal ])
+         else
+           YAML.safe_load(s, [ BigDecimal ], [], true)
+         end
        end
 
       data.each do |key, rate|
@@ -164,48 +179,53 @@ class EuCentralBank < Money::Bank::VariableExchange
 
   def doc(cache, url=ECB_RATES_URL)
     rates_source = !!cache ? cache : url
-    Nokogiri::XML(open_url(rates_source)).tap { |doc| doc.xpath('gesmes:Envelope/xmlns:Cube/xmlns:Cube//xmlns:Cube') }
-  rescue Nokogiri::XML::XPath::SyntaxError
-    Nokogiri::XML(open_url(url))
+    begin
+      parse_rates(URI.open(rates_source))
+    rescue Nokogiri::XML::XPath::SyntaxError
+      parse_rates(URI.open(url))
+    end
   end
 
-  def doc_from_s(content)
-    Nokogiri::XML(content)
-  end
+  def parse_rates(io)
+    doc = ::EuCentralBank::RatesDocument.new
+    parser = Nokogiri::XML::SAX::Parser.new(doc)
+    parser.parse(io)
 
-  def update_parsed_rates(doc)
-    rates = doc.xpath('gesmes:Envelope/xmlns:Cube/xmlns:Cube//xmlns:Cube')
+    unless doc.errors.empty?
+      # Temporary workaround for jruby until
+      # https://github.com/sparklemotion/nokogiri/pull/1872 gets
+      # released and we bump nokogiri version to include it.
+      # TLDR: jruby version of SAX parser will mask all the exceptions
+      # raised in document so we will raise it here if there were errors.
+      raise Nokogiri::XML::XPath::SyntaxError, doc.errors.join("\n")
+    end
 
-    store.transaction true do
-      rates.each do |exchange_rate|
-        rate = BigDecimal(exchange_rate.attribute("rate").value, DECIMAL_PRECISION)
-        currency = exchange_rate.attribute("currency").value
-        set_rate("EUR", currency, rate)
+    doc
+  end
+
+  def copy_rates(rates_document, with_date = false)
+    rates_document.rates.each do |date, rates|
+      rates.each do |currency, rate|
+        next if LEGACY_CURRENCIES.include?(currency)
+        set_rate('EUR', currency, BigDecimal(rate, DECIMAL_PRECISION), with_date ? date : nil)
       end
-      set_rate("EUR", "EUR", 1)
+      set_rate('EUR', 'EUR', 1, with_date ? date : nil)
     end
+  end
 
-    rates_updated_at = doc.xpath('gesmes:Envelope/xmlns:Cube/xmlns:Cube/@time').first.value
-    @rates_updated_at = Time.parse(rates_updated_at)
-
+  def update_parsed_rates(rates_document)
+    store.transaction true do
+      copy_rates(rates_document)
+    end
+    @rates_updated_at = rates_document.updated_at
     @last_updated = Time.now
   end
 
-  def update_parsed_historical_rates(doc)
-    rates = doc.xpath('gesmes:Envelope/xmlns:Cube/xmlns:Cube//xmlns:Cube')
-
+  def update_parsed_historical_rates(rates_document)
     store.transaction true do
-      rates.each do |exchange_rate|
-        rate = BigDecimal(exchange_rate.attribute("rate").value, DECIMAL_PRECISION)
-        currency = exchange_rate.attribute("currency").value
-        date = exchange_rate.parent.attribute("time").value
-        set_rate("EUR", currency, rate, date)
-      end
+      copy_rates(rates_document, true)
     end
-
-    rates_updated_at = doc.xpath('gesmes:Envelope/xmlns:Cube/xmlns:Cube/@time').first.value
-    @historical_rates_updated_at = Time.parse(rates_updated_at)
-
+    @historical_rates_updated_at = rates_document.updated_at
     @historical_last_updated = Time.now
   end
 
@@ -218,12 +238,4 @@ class EuCentralBank < Money::Bank::VariableExchange
     money = (decimal_money * from.cents * rate).round
     Money.new(money, to_currency)
   end
-
-  def open_url(url)
-    if RUBY_VERSION >= '2.5.0'
-      URI.open(url)
-    else
-      open(url)
-    end
-  end
 end

metadata

@@ -1,63 +1,57 @@
 --- !ruby/object:Gem::Specification
 name: eu_central_bank
 version: !ruby/object:Gem::Version
-  version: 1.6.1
+  version: 2.0.0
 platform: ruby
 authors:
 - Shane Emmons
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2021-03-03 00:00:00.000000000 Z
+date: 2025-12-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
-  name: nokogiri
+  name: bigdecimal
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1.9'
+        version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1.9'
+        version: '0'
 - !ruby/object:Gem::Dependency
-  name: money
+  name: nokogiri
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '6.13'
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 6.13.6
+        version: '1.11'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '6.13'
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 6.13.6
+        version: '1.11'
 - !ruby/object:Gem::Dependency
-  name: rspec
+  name: money
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 3.5.0
-  type: :development
+        version: '7.0'
+  type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 3.5.0
+        version: '7.0'
 description: This gem reads exchange rates from the european central bank website.
   It uses it to calculates exchange rates. It is compatible with the money gem
 email:
@@ -70,11 +64,16 @@ files:
 - LICENSE
 - README.md
 - lib/eu_central_bank.rb
+- lib/eu_central_bank/rates_document.rb
+- lib/eu_central_bank/version.rb
 - lib/money/rates_store/store_with_historical_data_support.rb
 homepage: https://github.com/RubyMoney/eu_central_bank
 licenses:
 - MIT
-metadata: {}
+metadata:
+  changelog_uri: https://github.com/RubyMoney/eu_central_bank/blob/main/CHANGELOG.md
+  source_code_uri: https://github.com/RubyMoney/eu_central_bank
+  bug_tracker_uri: https://github.com/RubyMoney/eu_central_bank/issues
 post_install_message:
 rdoc_options: []
 require_paths:
@@ -83,14 +82,14 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 3.1.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.2.3
+rubygems_version: 3.5.22
 signing_key:
 specification_version: 4
 summary: Calculates exchange rates based on rates from european central bank. Money