eu_central_bank 1.4.2 → 1.5.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 01a35ff1906fc6fcb306bff2804ed3684b8925ab
-  data.tar.gz: 56e430e88205e5f30248570cacc32d7cfdcd7270
+SHA256:
+  metadata.gz: 52d1fe9c87277a5ff6fdb243688949f5159686690a1bab6d8210ff0c643381da
+  data.tar.gz: 8cc1b167c31e16ae87a4d89f62f298a5a05639f10611c5f5064bae72029818a4
 SHA512:
-  metadata.gz: e84505f83a5c70373b71cb0f07325fef8e11c313fa4936e607bc5162531b666a5e04f53a9dedf18270113ce402d3f3c65948cfac7633d1146782c437e64079fe
-  data.tar.gz: beef6198548c17b60f27e0151cee6df2a59280ebdd7c4261621ca4359274ada0aa6d7043db5e6d25be2e54330e3a150f6aea1dc7b671d4fff0bf96138dcafe30
+  metadata.gz: a026554544da7e040565e6daa9cca1aad9e35be6d041511dcf16fb8d4cae90e6d02430a5940f21464675b95a70a4a52e1c7eb09dfffa9dabb213a79ab5bc3938
+  data.tar.gz: c913cbcd6c2c0c8c247fba9eb582b57600ad75acf932b1fa5817bc81b260c2135193c876ed16d51a08d8150c2c464870b8a0a7f8f5ff48765bebd59a1879282f

data/CHANGELOG.md

@@ -1,5 +1,11 @@
 # eu_central_bank changelog
 
+## 1.5.0 (Dec 7 2019)
+
+* Fix issue with money gem incompatibility
+* Fix thread safety of the default rates store
+* Bump money dependency to >= 6.13.6
+
 ## 1.4.2 (Feb 2 2019)
 
 * Fix issue with importing exported rates

data/lib/eu_central_bank.rb

@@ -15,7 +15,7 @@ class EuCentralBank < Money::Bank::VariableExchange
   attr_accessor :historical_rates_updated_at
 
   SERIALIZER_DATE_SEPARATOR = '_AT_'
-
+  DECIMAL_PRECISION = 5
   CURRENCIES = %w(USD JPY BGN CZK DKK GBP HUF ILS ISK PLN RON SEK CHF NOK HRK RUB TRY AUD BRL CAD CNY HKD IDR INR KRW MXN MYR NZD PHP SGD THB ZAR).map(&:freeze).freeze
   ECB_RATES_URL = 'https://www.ecb.europa.eu/stats/eurofxref/eurofxref-daily.xml'.freeze
   ECB_90_DAY_URL = 'https://www.ecb.europa.eu/stats/eurofxref/eurofxref-hist-90d.xml'.freeze
@@ -146,7 +146,7 @@ class EuCentralBank < Money::Bank::VariableExchange
         from, to = key.split(SERIALIZER_SEPARATOR)
         to, date = to.split(SERIALIZER_DATE_SEPARATOR)
 
-        store.add_rate from, to, BigDecimal(rate), date
+        store.add_rate from, to, BigDecimal(rate, DECIMAL_PRECISION), date
       end
     end
 
@@ -178,7 +178,7 @@ class EuCentralBank < Money::Bank::VariableExchange
 
     store.transaction true do
       rates.each do |exchange_rate|
-        rate = BigDecimal(exchange_rate.attribute("rate").value)
+        rate = BigDecimal(exchange_rate.attribute("rate").value, DECIMAL_PRECISION)
         currency = exchange_rate.attribute("currency").value
         set_rate("EUR", currency, rate)
       end
@@ -196,7 +196,7 @@ class EuCentralBank < Money::Bank::VariableExchange
 
     store.transaction true do
       rates.each do |exchange_rate|
-        rate = BigDecimal(exchange_rate.attribute("rate").value)
+        rate = BigDecimal(exchange_rate.attribute("rate").value, DECIMAL_PRECISION)
         currency = exchange_rate.attribute("currency").value
         date = exchange_rate.parent.attribute("time").value
         set_rate("EUR", currency, rate, date)
@@ -214,7 +214,7 @@ class EuCentralBank < Money::Bank::VariableExchange
   def calculate_exchange(from, to_currency, rate)
     to_currency_money = Money::Currency.wrap(to_currency).subunit_to_unit
     from_currency_money = from.currency.subunit_to_unit
-    decimal_money = BigDecimal(to_currency_money) / BigDecimal(from_currency_money)
+    decimal_money = BigDecimal(to_currency_money, DECIMAL_PRECISION) / BigDecimal(from_currency_money, DECIMAL_PRECISION)
     money = (decimal_money * from.cents * rate).round
     Money.new(money, to_currency)
   end

data/lib/money/rates_store/store_with_historical_data_support.rb

@@ -3,33 +3,16 @@ module Money::RatesStore
     INDEX_DATE_SEPARATOR = '_AT_'.freeze
 
     def add_rate(currency_iso_from, currency_iso_to, rate, date = nil)
-      transaction { index[rate_key_for(currency_iso_from, currency_iso_to, date)] = rate }
+      transaction { rates[rate_key_for(currency_iso_from, currency_iso_to, date)] = rate }
     end
 
     def get_rate(currency_iso_from, currency_iso_to, date = nil)
-      transaction { index[rate_key_for(currency_iso_from, currency_iso_to, date)] }
+      transaction { rates[rate_key_for(currency_iso_from, currency_iso_to, date)] }
     end
 
     # Wraps block execution in a thread-safe transaction
-    def transaction(force_sync = false, &block)
-      # Ruby 1.9.3 does not support @mutex.owned?
-      if @mutex.respond_to?(:owned?)
-        force_sync = false if @mutex.locked? && @mutex.owned?
-      else
-        # If we allowed this in Ruby 1.9.3, it might possibly cause recursive
-        # locking within the same thread.
-        force_sync = false
-      end
-      if !force_sync && (@in_transaction || options[:without_mutex])
-        block.call self
-      else
-        @mutex.synchronize do
-          @in_transaction = true
-          result = block.call
-          @in_transaction = false
-          result
-        end
-      end
+    def transaction(_force_sync = false, &block)
+      super &block
     end
 
     # Iterate over rate tuples (iso_from, iso_to, rate)
@@ -47,7 +30,7 @@ module Money::RatesStore
     #   end
     def each_rate(&block)
       enum = Enumerator.new do |yielder|
-        index.each do |key, rate|
+        rates.each do |key, rate|
           iso_from, iso_to = key.split(Memory::INDEX_KEY_SEPARATOR)
           iso_to, date = iso_to.split(INDEX_DATE_SEPARATOR)
           date = Date.parse(date) if date
@@ -60,10 +43,10 @@ module Money::RatesStore
 
     private
 
-      def rate_key_for(currency_iso_from, currency_iso_to, date = nil)
-        key = [currency_iso_from, currency_iso_to].join(Memory::INDEX_KEY_SEPARATOR)
-        key = [key, date.to_s].join(INDEX_DATE_SEPARATOR) if date
-        key.upcase
-      end
+    def rate_key_for(currency_iso_from, currency_iso_to, date = nil)
+      key = [currency_iso_from, currency_iso_to].join(Memory::INDEX_KEY_SEPARATOR)
+      key = [key, date.to_s].join(INDEX_DATE_SEPARATOR) if date
+      key.upcase
+    end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: eu_central_bank
 version: !ruby/object:Gem::Version
-  version: 1.4.2
+  version: 1.5.0
 platform: ruby
 authors:
 - Shane Emmons
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-02-02 00:00:00.000000000 Z
+date: 2019-12-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: nokogiri
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.8'
+        version: '1.9'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.8'
+        version: '1.9'
 - !ruby/object:Gem::Dependency
   name: money
   requirement: !ruby/object:Gem::Requirement
@@ -31,6 +31,9 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '6.13'
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 6.13.6
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -38,6 +41,9 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '6.13'
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 6.13.6
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
@@ -66,7 +72,8 @@ files:
 - lib/eu_central_bank.rb
 - lib/money/rates_store/store_with_historical_data_support.rb
 homepage: https://github.com/RubyMoney/eu_central_bank
-licenses: []
+licenses:
+- MIT
 metadata: {}
 post_install_message: 
 rdoc_options: []
@@ -83,8 +90,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.6.8
+rubygems_version: 3.0.3
 signing_key: 
 specification_version: 4
 summary: Calculates exchange rates based on rates from european central bank. Money