eu_central_bank 1.0.1 → 1.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 4dbcc0a2aa33d3b41142677ca45615eeb9345633
-  data.tar.gz: cc9c0d602fcdbb84f904964cd3c6a5cd5d5bd0b4
+  metadata.gz: 1d5f8b86e4c137232c18a652e039693e6675b688
+  data.tar.gz: 6016b5f506d4ffc693afee6000c40d6e6f4e0fff
 SHA512:
-  metadata.gz: 096495025aa42d1e675990694465f4980a00e81622efa05d93ffc6d8b24fb24beb8b9f2db9a6aaed295bc4f9a741b5842d1761a72eb41dc1ab95275670c1bc0a
-  data.tar.gz: 2d484be4e3aa08ac418a0d2f7d0c7f3a51fa126a8269c49057df19906a237437ed2aea27641c8cb9fc2e28180eae597d732c50a1353f6b28eb98c70848b83bc3
+  metadata.gz: 94afc27fbe11e777cc59b319833354192e81a1df0622e6dd3dc680c4cbea6d0c079950447835f6f991595708723235b535d3d4beb3c350dd3e357634ea9a597a
+  data.tar.gz: be12ff053f29df84bee8cae7b6ddb067cfcdbcec2fec011c534bf433bfe2cf6085fb9618b77930ab1e0f7c986d1fb84a37b8fb3b7a2864c5547e9d7d8dc40da1

data/CHANGELOG.md

@@ -1,5 +1,13 @@
 # eu_central_bank changelog
 
+## 1.1.0 (Jan 19 2017)
+
+* Added support for ruby 2.3.0 and 2.4.0
+* Fixed ruby warnings
+* Fixed thread safety issue
+* Fixed issue with historical rates
+* Added exception for currencies not in the list
+
 ## 1.0.1 (May 20 2016)
 
 * Fixed compatibility with recent Money gem

data/README.md

@@ -22,6 +22,7 @@ gem install eu_central_bank
 With the gem, you do not need to manually add exchange rates. Calling update_rates will download the rates from the European Central Bank. The API is the same as the money gem. Feel free to use Money objects with the bank.
 
 ``` ruby
+require 'eu_central_bank'
 eu_bank = EuCentralBank.new
 Money.default_bank = eu_bank
 money1 = Money.new(10)
@@ -70,4 +71,4 @@ eu_bank.exchange_with(Money.new(100, "CAD"), "USD") # Money.new(80, "USD")
 
 ## Copyright
 
-Copyright (c) 2010-2013 RubyMoney. See LICENSE for details.
+Copyright (c) 2010-2016 RubyMoney. See LICENSE for details.

data/lib/eu_central_bank.rb

@@ -5,6 +5,8 @@ require 'money/rates_store/eu_central_bank_historical_data_support'
 
 class InvalidCache < StandardError ; end
 
+class CurrencyUnavailable < StandardError; end
+
 class EuCentralBank < Money::Bank::VariableExchange
 
   attr_accessor :last_updated
@@ -21,6 +23,7 @@ class EuCentralBank < Money::Bank::VariableExchange
   def initialize(*)
     super
     @store.extend Money::RatesStore::EuCentralBankHistoricalDataSupport
+    @currency_string = nil
   end
 
   def update_rates(cache=nil)
@@ -67,10 +70,16 @@ class EuCentralBank < Money::Bank::VariableExchange
   end
 
   def get_rate(from, to, date = nil)
+    return 1 if from == to
+
+    check_currency_available(from)
+    check_currency_available(to)
+
     if date.is_a?(Hash)
       # Backwards compatibility for the opts hash
       date = date[:date]
     end
+
     store.get_rate(::Money::Currency.wrap(from).iso_code, ::Money::Currency.wrap(to).iso_code, date)
   end
 
@@ -136,6 +145,13 @@ class EuCentralBank < Money::Bank::VariableExchange
     self
   end
 
+  def check_currency_available(currency)
+    currency_string = currency.to_s
+    return true if currency_string == "EUR"
+    return true if CURRENCIES.include?(currency_string)
+    raise CurrencyUnavailable, "No rates available for #{@currency_string}"
+  end
+
   protected
 
   def doc(cache, url=ECB_RATES_URL)

data/lib/money/rates_store/eu_central_bank_historical_data_support.rb

@@ -10,27 +10,27 @@ module Money::RatesStore
       transaction { index[rate_key_for(currency_iso_from, currency_iso_to, date)] }
     end
 
-  # Wraps block execution in a thread-safe transaction
-  def transaction(force_sync = false, &block)
-    # Ruby 1.9.3 does not support @mutex.owned?
-    if @mutex.respond_to?(:owned?)
-      force_sync = false if @mutex.locked? && @mutex.owned?
-    else
-      # If we allowed this in Ruby 1.9.3, it might possibly cause recursive
-      # locking within the same thread.
-      force_sync = false
-    end
-    if !force_sync && (@in_transaction || options[:without_mutex])
-      block.call self
-    else
-      @mutex.synchronize do
-        @in_transaction = true
-        result = block.call
-        @in_transaction = false
-        result
+    # Wraps block execution in a thread-safe transaction
+    def transaction(force_sync = false, &block)
+      # Ruby 1.9.3 does not support @mutex.owned?
+      if @mutex.respond_to?(:owned?)
+        force_sync = false if @mutex.locked? && @mutex.owned?
+      else
+        # If we allowed this in Ruby 1.9.3, it might possibly cause recursive
+        # locking within the same thread.
+        force_sync = false
+      end
+      if !force_sync && (@in_transaction || options[:without_mutex])
+        block.call self
+      else
+        @mutex.synchronize do
+          @in_transaction = true
+          result = block.call
+          @in_transaction = false
+          result
+        end
       end
     end
-  end
 
     # Iterate over rate tuples (iso_from, iso_to, rate)
     #
@@ -65,6 +65,5 @@ module Money::RatesStore
         key = [key, date.to_s].join(INDEX_DATE_SEPARATOR) if date
         key.upcase
       end
-
   end
-end
+end

metadata

@@ -1,57 +1,57 @@
 --- !ruby/object:Gem::Specification
 name: eu_central_bank
 version: !ruby/object:Gem::Version
-  version: 1.0.1
+  version: 1.1.0
 platform: ruby
 authors:
 - Shane Emmons
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-05-20 00:00:00.000000000 Z
+date: 2017-01-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: nokogiri
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: 1.6.3
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: 1.6.3
 - !ruby/object:Gem::Dependency
   name: money
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
-        version: 6.7.0
+        version: 6.8.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
-        version: 6.7.0
+        version: 6.8.0
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
-        version: 3.4.0
+        version: 3.5.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
-        version: 3.4.0
+        version: 3.5.0
 description: This gem reads exchange rates from the european central bank website.
   It uses it to calculates exchange rates. It is compatible with the money gem
 email:
@@ -60,11 +60,11 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- lib/eu_central_bank.rb
+- lib/money/rates_store/eu_central_bank_historical_data_support.rb
 - CHANGELOG.md
 - LICENSE
 - README.md
-- lib/eu_central_bank.rb
-- lib/money/rates_store/eu_central_bank_historical_data_support.rb
 homepage: https://github.com/RubyMoney/eu_central_bank
 licenses: []
 metadata: {}
@@ -74,17 +74,17 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">="
+  - - '>='
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">="
+  - - '>='
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.5.1
+rubygems_version: 2.0.14.1
 signing_key: 
 specification_version: 4
 summary: Calculates exchange rates based on rates from european central bank. Money