eu_central_bank 0.3.7 → 0.3.8

data/CHANGELOG.md

@@ -1,5 +1,9 @@
 # eu_central_bank changelog
 
+## 0.3.8 (Feb 12 2014)
+
+* Updated money version
+
 ## 0.3.6 (Sep 4 2013)
 
 * Bank url change

data/lib/eu_central_bank.rb

@@ -11,7 +11,7 @@ class EuCentralBank < Money::Bank::VariableExchange
   attr_accessor :rates_updated_at
 
   ECB_RATES_URL = 'http://www.ecb.europa.eu/stats/eurofxref/eurofxref-daily.xml'
-  CURRENCIES = %w(USD JPY BGN CZK DKK GBP HUF ILS LTL LVL PLN RON SEK CHF NOK HRK RUB TRY AUD BRL CAD CNY HKD IDR INR KRW MXN MYR NZD PHP SGD THB ZAR)
+  CURRENCIES = %w(USD JPY BGN CZK DKK GBP HUF ILS LTL PLN RON SEK CHF NOK HRK RUB TRY AUD BRL CAD CNY HKD IDR INR KRW MXN MYR NZD PHP SGD THB ZAR)
 
   def update_rates(cache=nil)
     update_parsed_rates(doc(cache))
@@ -40,18 +40,23 @@ class EuCentralBank < Money::Bank::VariableExchange
   def exchange_with(from, to_currency)
     rate = get_rate(from.currency, to_currency)
     unless rate
-      from_base_rate = get_rate("EUR", from.currency)
-      to_base_rate = get_rate("EUR", to_currency)
+      from_base_rate, to_base_rate = nil, nil
+      @mutex.synchronize {
+        from_base_rate = get_rate("EUR", from.currency, :without_mutex => true)
+        to_base_rate = get_rate("EUR", to_currency, :without_mutex => true)
+      }
       rate = to_base_rate / from_base_rate
     end
-    Money.new(((Money::Currency.wrap(to_currency).subunit_to_unit.to_f / from.currency.subunit_to_unit.to_f) * from.cents * rate).round, to_currency)
+    Money.new(((BigDecimal(Money::Currency.wrap(to_currency).subunit_to_unit) / BigDecimal(from.currency.subunit_to_unit)) * from.cents * rate).round, to_currency)
   end
 
   protected
 
   def doc(cache)
     rates_source = !!cache ? cache : ECB_RATES_URL
-    Nokogiri::XML(open(rates_source))
+    Nokogiri::XML(open(rates_source)).tap {|doc| doc.xpath('gesmes:Envelope/xmlns:Cube/xmlns:Cube//xmlns:Cube') }
+  rescue Nokogiri::XML::XPath::SyntaxError
+    Nokogiri::XML(open(ECB_RATES_URL))
   end
 
   def doc_from_s(content)
@@ -61,12 +66,14 @@ class EuCentralBank < Money::Bank::VariableExchange
   def update_parsed_rates(doc)
     rates = doc.xpath('gesmes:Envelope/xmlns:Cube/xmlns:Cube//xmlns:Cube')
 
-    rates.each do |exchange_rate|
-      rate = exchange_rate.attribute("rate").value.to_f
-      currency = exchange_rate.attribute("currency").value
-      add_rate("EUR", currency, rate)
+    @mutex.synchronize do 
+      rates.each do |exchange_rate|
+        rate = BigDecimal(exchange_rate.attribute("rate").value)
+        currency = exchange_rate.attribute("currency").value
+        set_rate("EUR", currency, rate, :without_mutex => true)
+      end
+      set_rate("EUR", "EUR", 1, :without_mutex => true)
     end
-    add_rate("EUR", "EUR", 1)
 
     rates_updated_at = doc.xpath('gesmes:Envelope/xmlns:Cube/xmlns:Cube/@time').first.value
     @rates_updated_at = Time.parse(rates_updated_at)

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: eu_central_bank
 version: !ruby/object:Gem::Version
-  version: 0.3.7
+  version: 0.3.8
   prerelease: 
 platform: ruby
 authors:
@@ -12,7 +12,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-09-04 00:00:00.000000000 Z
+date: 2014-02-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: nokogiri
@@ -37,7 +37,7 @@ dependencies:
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
-        version: 5.0.0
+        version: 6.0.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -45,7 +45,7 @@ dependencies:
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
-        version: 5.0.0
+        version: 6.0.1
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
@@ -118,9 +118,6 @@ required_ruby_version: !ruby/object:Gem::Requirement
   - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
-      segments:
-      - 0
-      hash: -2548782731518398539
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements: