eu_central_bank 0.1.0 → 0.1.1

data/README.rdoc

@@ -28,8 +28,11 @@ With the gem, you do not need to manually add exchange rates. Calling update_rat
 
   # exchange 100 CAD to USD
   # API is the same as the money gem
-  eu_bank.exchange(100, "CAD", "USD") # 124
-  Money.us_dollar(100).exchange_to("CAD")  # Money.ca_dollar(124)
+  eu_bank.exchange(100, "CAD", "USD") # Money.new(80, "USD")
+  Money.us_dollar(100).exchange_to("CAD")  # Money.new(124, "CAD")
+
+  # using the new exchange_with method
+  eu_bank.exchange_with(Money.new(100, "CAD"), "USD") # Money.new(80, "USD")
 
 For performance reasons, you may prefer to read from a file instead. Furthermore, ECB publishes their rates daily. It makes sense to save the rates in a file to read from.
 
@@ -40,7 +43,11 @@ For performance reasons, you may prefer to read from a file instead. Furthermore
   eu_bank.update_rates("/some/file/location/exchange_rates.xml")
 
   # exchange 100 CAD to USD as usual
-  eu_bank.exchange(100, "CAD", "USD") # 124
+  eu_bank.exchange_with(Money.new(100, "CAD"), "USD") # Money.new(80, "USD")
+
+== Deprecation
+
+Note that the *exchange* method will be deprecated in Money version 3.2.0. eu_central_bank will follow suite and deprecate the method in version 0.2.0
 
 == Note on Patches/Pull Requests
  

data/VERSION

@@ -1 +1 @@
-0.1.0
+0.1.1

data/eu_central_bank.gemspec

@@ -5,11 +5,11 @@
 
 Gem::Specification.new do |s|
   s.name = %q{eu_central_bank}
-  s.version = "0.1.0"
+  s.version = "0.1.1"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Wong Liang Zan"]
-  s.date = %q{2010-04-21}
+  s.date = %q{2010-07-17}
   s.description = %q{This gem reads exchange rates from the european central bank website. It uses it to calculates exchange rates. It is compatible with the money gem}
   s.email = %q{zan@liangzan.net}
   s.extra_rdoc_files = [
@@ -34,18 +34,18 @@ Gem::Specification.new do |s|
   s.homepage = %q{http://github.com/liangzan/eu_central_bank}
   s.rdoc_options = ["--charset=UTF-8"]
   s.require_paths = ["lib"]
-  s.rubygems_version = %q{1.3.6}
+  s.rubygems_version = %q{1.3.7}
   s.summary = %q{Calculates exchange rates based on rates from european central bank. Money gem compatible.}
   s.test_files = [
-    "spec/eu_central_bank_spec.rb",
-     "spec/spec_helper.rb"
+    "spec/spec_helper.rb",
+     "spec/eu_central_bank_spec.rb"
   ]
 
   if s.respond_to? :specification_version then
     current_version = Gem::Specification::CURRENT_SPECIFICATION_VERSION
     s.specification_version = 3
 
-    if Gem::Version.new(Gem::RubyGemsVersion) >= Gem::Version.new('1.2.0') then
+    if Gem::Version.new(Gem::VERSION) >= Gem::Version.new('1.2.0') then
       s.add_development_dependency(%q<rspec>, [">= 1.3.0"])
       s.add_development_dependency(%q<rr>, [">= 0.10.11"])
       s.add_development_dependency(%q<shoulda>, [">= 2.10.3"])

data/lib/eu_central_bank.rb

@@ -28,13 +28,18 @@ class EuCentralBank < Money::VariableExchangeBank
   end
 
   def exchange(cents, from_currency, to_currency)
-    rate = get_rate(from_currency, to_currency)
-    if !rate
-      from_base_rate = get_rate("EUR", from_currency)
+    warn '[DEPRECIATION] `exchange` will be removed in money v3.2.0 and eu_central_bank v0.2.0, use #exchange_with instead'
+    exchange_with(Money.new(cents, from_currency), to_currency)
+  end
+
+  def exchange_with(from, to_currency)
+    rate = get_rate(from.currency, to_currency)
+    unless rate
+      from_base_rate = get_rate("EUR", from.currency)
       to_base_rate = get_rate("EUR", to_currency)
       rate = to_base_rate / from_base_rate
     end
-    (cents * rate).floor
+    Money.new((from.cents * rate).floor, to_currency)
   end
 
   protected

data/spec/eu_central_bank_spec.rb

@@ -1,4 +1,5 @@
 require File.expand_path(File.dirname(__FILE__) + '/spec_helper')
+require 'yaml'
 
 describe "EuCentralBank" do
   before(:each) do
@@ -38,11 +39,19 @@ describe "EuCentralBank" do
     end
   end
 
-  it "should return the correct exchange rates" do
+  it "should return the correct exchange rates using exchange" do
     EXCHANGE_RATES = YAML.load_file(@yml_cache_path)
     @bank.update_rates(@cache_path)
     EuCentralBank::CURRENCIES.each do |currency|
-      @bank.exchange(100, "EUR", currency).should == (EXCHANGE_RATES["currencies"][currency].to_f * 100).floor
+      @bank.exchange(100, "EUR", currency).cents.should == (EXCHANGE_RATES["currencies"][currency].to_f * 100).floor
+    end
+  end
+
+  it "should return the correct exchange rates using exchange_with" do
+    EXCHANGE_RATES = YAML.load_file(@yml_cache_path)
+    @bank.update_rates(@cache_path)
+    EuCentralBank::CURRENCIES.each do |currency|
+      @bank.exchange_with(Money.new(100, "EUR"), currency).cents.should == (EXCHANGE_RATES["currencies"][currency].to_f * 100).floor
     end
   end
 end

metadata

@@ -1,12 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: eu_central_bank
 version: !ruby/object:Gem::Version 
+  hash: 25
   prerelease: false
   segments: 
   - 0
   - 1
-  - 0
-  version: 0.1.0
+  - 1
+  version: 0.1.1
 platform: ruby
 authors: 
 - Wong Liang Zan
@@ -14,16 +15,18 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2010-04-21 00:00:00 +08:00
+date: 2010-07-17 00:00:00 +08:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency 
   name: rspec
   prerelease: false
   requirement: &id001 !ruby/object:Gem::Requirement 
+    none: false
     requirements: 
     - - ">="
       - !ruby/object:Gem::Version 
+        hash: 27
         segments: 
         - 1
         - 3
@@ -35,9 +38,11 @@ dependencies:
   name: rr
   prerelease: false
   requirement: &id002 !ruby/object:Gem::Requirement 
+    none: false
     requirements: 
     - - ">="
       - !ruby/object:Gem::Version 
+        hash: 33
         segments: 
         - 0
         - 10
@@ -49,9 +54,11 @@ dependencies:
   name: shoulda
   prerelease: false
   requirement: &id003 !ruby/object:Gem::Requirement 
+    none: false
     requirements: 
     - - ">="
       - !ruby/object:Gem::Version 
+        hash: 33
         segments: 
         - 2
         - 10
@@ -63,9 +70,11 @@ dependencies:
   name: nokogiri
   prerelease: false
   requirement: &id004 !ruby/object:Gem::Requirement 
+    none: false
     requirements: 
     - - ">="
       - !ruby/object:Gem::Version 
+        hash: 5
         segments: 
         - 1
         - 4
@@ -77,9 +86,11 @@ dependencies:
   name: money
   prerelease: false
   requirement: &id005 !ruby/object:Gem::Requirement 
+    none: false
     requirements: 
     - - ">="
       - !ruby/object:Gem::Version 
+        hash: 3
         segments: 
         - 2
         - 3
@@ -120,26 +131,30 @@ rdoc_options:
 require_paths: 
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement 
+  none: false
   requirements: 
   - - ">="
     - !ruby/object:Gem::Version 
+      hash: 3
       segments: 
       - 0
       version: "0"
 required_rubygems_version: !ruby/object:Gem::Requirement 
+  none: false
   requirements: 
   - - ">="
     - !ruby/object:Gem::Version 
+      hash: 3
       segments: 
       - 0
       version: "0"
 requirements: []
 
 rubyforge_project: 
-rubygems_version: 1.3.6
+rubygems_version: 1.3.7
 signing_key: 
 specification_version: 3
 summary: Calculates exchange rates based on rates from european central bank. Money gem compatible.
 test_files: 
-- spec/eu_central_bank_spec.rb
 - spec/spec_helper.rb
+- spec/eu_central_bank_spec.rb