estorm-message-processor 0.2.3 → 0.2.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: b3f32e9c558e654f196251ce4c1db0d66ea9ecfa
-  data.tar.gz: aee686b7611bcf483c18e2e0796ef85aa650f09f
+  metadata.gz: 59894a7026a89b5051d9c38d91b287e83b33efd4
+  data.tar.gz: 8cee09cd6216eed0413476468e62b13fa7c685f2
 SHA512:
-  metadata.gz: 79861e5783af9a9bbc5a5386f3ea58ebc4f93e064170913f886afa88ff933aa07e78ac4030a0301c0dc83c8bcf6b5411c12b748c32790b297712771b42d3acef
-  data.tar.gz: d13b8e283a817df5804573a1b47f4af8be7366b66a4e45801b87847b95db15ed766b3be9a1c2518819a0d379c9a9c9467bb6c230d1c1f4145e66aebe3a14dda5
+  metadata.gz: 0ff1bca8a78f3c8af4c98fb5b6c7bcf3a36441ceca7eb4096d6f72f9ce544b7547f29ec6275b485fd88320342b965930beb67ea8444877b432abb087b9632d20
+  data.tar.gz: 43627967020def843be31fce67df66e402ae5804bde7dadee8431e77f55fc1707d5e2b4fbd87c969b60c35c33ff44e35292ae3cca3e34c92427a2cf9e7a1e966

data/README.md

@@ -6,7 +6,11 @@ estorm-message-processor gem
 ============
 
 
-Simple gem to use in rails apps for AMQP inclusion. Send a hash via AMQP and then have the message processor process the files.  See the test pages
+Simple gem to use in rails apps for AMQP inclusion. Send a hash via AMQP and then have the message processor process the files.  See the test pages.  They key use cases for this are
+* When you want a back ground task to continually process messages (see _test_estorm.rb_ for examples)
+* When you want to schedule a background task to periodically consume and process messages. (eg every 30 minutes perform the task see _test_single.rb_)
+
+The second usage case allows you to use periodic jobs on heroku.  Thus your costing is just for time taken to process all the messages. IN hte first case you need to pay for a dyno for a 24 hour period.  The difference between the two usage patterns is a simple flag so it is convenient to start inexpensively and scale when needed.
 
 Usage
 =======

data/lib/estorm-message-processor/base.rb

@@ -53,19 +53,17 @@ module EstormMessageProcessor
           logger.info msg
           count=0
         #  @channel.prefetch(1)   # set quality of service to only delivery one message at a time....
-          msg_count,consumer_count = @consumer.queue_statistics  # just to get the stats before entering hte queue
+          @msg_count,consumer_count = @consumer.queue_statistics  # just to get the stats before entering hte queue
        #  @queue.subscribe(:block => config[:blocking]) do |delivery_info, properties, body|
-         @consumer.target(msg_count,config[:exit_when_done]) if config[:exit_when_done]
+         @consumer.target(@msg_count,config[:exit_when_done]) if config[:exit_when_done]
          @consumer.on_delivery() do |delivery_info, metadata, payload|
             @consumer.process_messages(delivery_info,metadata,payload)
-       #     @consumer.channel.acknowledge(delivery_info.delivery_tag, false) if @consumer.channel!=nil && @consumer.channel.open?
             msg=   "ON DELIVERY: #{@consumer.count}: messages processed"
             logger.info msg
             @channel.close if @consumer.cancelled? 
-               # ack the message to get the next message
-            #msg_count,consumer_count = @consumer.queue_statistics  # POSSIBLE RACE CONDITION
+           
            # @consumer.cancel if msg_count==0 && config[:exit_when_empty]
-           end if !config[:exit_when_done] or msg_count >0
+           end 
        end
        def queue_creation(config)
           setup_bunny_communications(config[:url],config[:connecturlflag],config[:queuename])
@@ -74,20 +72,21 @@ module EstormMessageProcessor
 
           @consumer.logger=logger
           raise "consumer creation problem" if @consumer==nil
-          msg_count,consumer_count =@consumer.queue_statistics
           queue_mgmt(config)
        end
        
        def start(config)
          msg= "Connecting to bunny environment #{config.inspect}"
          logger.info msg
-         queue_creation(config)
          config[:exit_when_done]=false if  config[:exit_when_done]==nil
+         queue_creation(config)
+         
          # the block flag shuts down the thread. the timeout values says whether to unsubscriber
          #need to set ack to true to manage the qos parameter
         # retval= @queue.subscribe_with(@consumer,:ack => true, :block => config[:blocking], :timeout => config[:timeout])
         #  retval= @queue.subscribe_with(@consumer,:ack => true, :block => config[:blocking])
-        retval= @queue.subscribe_with(@consumer, :block => config[:blocking])
+        retval ="[did not subscribe as msg count = 0]"
+        retval= @queue.subscribe_with(@consumer, :block => config[:blocking])  if !config[:exit_when_done] or @msg_count >0
         # loop do   
              #should loop forever if blocking... otherwise needs  a loop
          #   sleep 1

data/lib/estorm-message-processor/consumer.rb

@@ -13,8 +13,10 @@ module EstormMessageProcessor
         @mycount
     end
     @exit_flag=false
+    # this is a target to count messages and exit if needed
     def target(count,flag)
-      puts "target is #{count} flag is #{flag}"
+      msg = "-- Message Processor exit when complete flag set: target messages is #{count} flag is #{flag}"
+      logger.info msg
       @exit_flag=flag
       @exit_count=count-1
     end

data/test/coverage/index.html

@@ -14,7 +14,7 @@
       <img src="./assets/0.7.1/loading.gif" alt="loading"/>
     </div>
     <div id="wrapper" style="display:none;">
-      <div class="timestamp">Generated <abbr class="timeago" title="2013-10-17T23:03:58+08:00">2013-10-17T23:03:58+08:00</abbr></div>
+      <div class="timestamp">Generated <abbr class="timeago" title="2013-10-18T19:42:06+08:00">2013-10-18T19:42:06+08:00</abbr></div>
       <ul class="group_tabs"></ul>
 
       <div id="content">

data/test/test_consumer.rb

@@ -99,6 +99,7 @@ class EstormConsumerProcessTest <  Minitest::Test
       @consumer.logger=@f.logger
       assert @consumer.consumer_tag=config[:consumer_name]
       mc,cc=@consumer.queue_statistics
+      puts "MESSAGE COUNT #{mc.inspect}"
       assert mc!=nil, "mc should have vlue"
       assert cc!=nil, "concsumer count should have value"
       assert true, "should get here without a problem"

data/test/test_single.rb

@@ -86,4 +86,30 @@ class EstormMessageProcessTest <  Minitest::Test
        assert MessageFlag.testval==7, "should receive 7 message and set temp #{MessageFlag.testval}"
 
    end
+    def test_processor_exits_when_queue_empty
+        puts "test several  message"
+        assert MessageFlag.flag==false, "should be flase #{MessageFlag.inspect}"
+        config={:url => 'fakeurl',:connecturlflag=> false,:queuename => 'testEmptyqueueMessageExit', :blocking => true, :consumer_name => "test exit consumer",  :exit_when_done => true}
+        # PRELOAD THE QUEUE WITH MESSAGES
+          bunnysender=EstormMessageProcessor::Client.new
+          conn,chan=bunnysender.setup_bunny(config[:url],config[:connnecturlflag])
+          assert conn!=nil, "connection shold be established"
+          assert chan!=nil, "connection shold be established"
+          chan.queue(config[:queuename]).purge
+          
+
+        puts "after purging queue in test message"
+         @f.start(config) 
+   #        bunnysender.connection.close
+         puts " should  get here this thread about to exit in tes_messag"
+
+         time=10
+         puts "sleeping #{time} seconds"
+         sleep time
+
+        sleep 1
+
+          assert true,"should get here..."
+
+      end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: estorm-message-processor
 version: !ruby/object:Gem::Version
-  version: 0.2.3
+  version: 0.2.4
 platform: ruby
 authors:
 - Scott Sproule
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-10-17 00:00:00.000000000 Z
+date: 2013-10-18 00:00:00.000000000 Z
 dependencies: []
 description: a gem to help rails app process AMQP queues for background jobs
 email: scott.sproule@ficonab.com