essential 0.9.0 → 0.9.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 7fef856a4598b665b03c68baaf34c34eb79a8d8d
-  data.tar.gz: 81c1e44539dfbe8b6dc59dd7f61165640247a2a7
+  metadata.gz: 0294238d2f9124a97f0c5c0c32f36a38280fc357
+  data.tar.gz: f26dba74bc362acf8f9cb59af12a6b7fb95ed560
 SHA512:
-  metadata.gz: 2f81a83c772e1190736131d8c99444538b1451b2ce609625e4528474584e992eb78f9d2cb45ab0067ddedb15e3a8dafede902da1c3233cba1db48b0c3233d803
-  data.tar.gz: 061610d3b785a2d8ee7d9dffa12605b93c9da1a59c6401b6668a170f420c534727a2480e3519b175450272160a3fe47d4f3c9e057003213572a11e5cd37da373
+  metadata.gz: 136ca9cff95bde947f462bd8c5a8f02a407868d1720c5cb47761cefb59e84ee19a889733ebb346d94dc4a8cd3c79d46071ca2c05f2923713bf1fa332e70995b0
+  data.tar.gz: 3c8d1bf4e9424b0a2c89b36552f357ba9872a615e536339174d4a2917447f2f45b54f4499dd6cdfb02915571a57348ca96a9261cbd83b2ff37aff7187c3adc7c

data/README.md

@@ -88,20 +88,3 @@ message = Essential::Messaging::Message.create(
   body: 'explicit channel'
 )
 ```
-
-### Properties
-
-```ruby
-subscriber = channel.subscribers.create(phone_number: '2065551212')
-
-# set new properties
-subscriber.properties.create(name: 'external_id', value: 1234)
-subscriber.properties.create(name: 'name', value: 'Brendan Ribera')
-subscriber.properties.create(name: 'state', value: 'WA')
-
-# print them
-puts JSON.pretty_generate(subscriber.properties.as_json)
-
-# update one
-subscriber.properties.create(name: 'name', value: 'Nabnerb Arebir')
-```

data/lib/essential.rb

@@ -15,7 +15,6 @@ require 'essential/account'
 
 # Messaging Resources
 require 'essential/messaging/message'
-require 'essential/messaging/property'
 require 'essential/messaging/transport'
 require 'essential/messaging/subscriber'
 require 'essential/messaging/channel'

data/lib/essential/messaging/subscriber.rb

@@ -27,15 +27,6 @@ module Essential::Messaging
       )
     end
 
-    def properties
-      Essential::Resource::PaginatorProxy.new(
-        Property,
-        url: Property.url(self.sid),
-        headers: @headers,
-        attrs: {subscriber_sid: self.sid},
-      )
-    end
-
     def self.by_carrier(params: {}, headers: @headers)
       # permitted:
       # :start_date, :end_date, :carrier

data/lib/essential/resource/paginator_proxy.rb

@@ -62,18 +62,20 @@ module Essential
       end
 
       def inspect
+        innards = [:proxied_class, :total, :per_page, :headers, :params].map do |m|
+          attr = self.send(m)
+          if attr
+            format('  @%s=%s', m, attr.inspect)
+          else
+            nil
+          end
+        end
+
         format(
-          '#<%s:0x%s %s>',
+          "#<%s:0x%s\n%s\n>",
           self.class.name,
           (self.object_id << 1).to_s(16),
-          [:total, :per_page, :headers, :params].map do |m|
-            attr = self.send(m)
-            if attr
-              format('@%s=%s', m, attr.inspect)
-            else
-              nil
-            end
-          end.compact.join(', ')
+          innards.compact.join(",\n")
         )
       end
 
@@ -98,7 +100,7 @@ module Essential
 
         json = JSON.parse(response)
         @fetched_pages[page || 1] = json.map do |json|
-          # persist @attrs across returned objects, as when listing a Subscriber Property.
+          # persist @attrs across returned objects
           attrs = @attrs.merge(json)
           @proxied_class.from_attributes(attrs, headers: @headers)
         end

data/lib/essential/version.rb

@@ -1,3 +1,3 @@
 module Essential
-  VERSION = '0.9.0'.freeze
+  VERSION = '0.9.1'.freeze
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: essential
 version: !ruby/object:Gem::Version
-  version: 0.9.0
+  version: 0.9.1
 platform: ruby
 authors:
 - Brendan Ribera
@@ -70,7 +70,6 @@ files:
 - lib/essential/errors/api_error.rb
 - lib/essential/messaging/channel.rb
 - lib/essential/messaging/message.rb
-- lib/essential/messaging/property.rb
 - lib/essential/messaging/subscriber.rb
 - lib/essential/messaging/transport.rb
 - lib/essential/resource.rb
@@ -85,7 +84,6 @@ files:
 - test/essential/account_test.rb
 - test/essential/messaging/channel_test.rb
 - test/essential/messaging/message_test.rb
-- test/essential/messaging/property_test.rb
 - test/essential/messaging/subscriber_test.rb
 - test/essential/messaging/transport_test.rb
 - test/integration/alternate_authentication_test.rb
@@ -118,7 +116,6 @@ test_files:
 - test/essential/account_test.rb
 - test/essential/messaging/channel_test.rb
 - test/essential/messaging/message_test.rb
-- test/essential/messaging/property_test.rb
 - test/essential/messaging/subscriber_test.rb
 - test/essential/messaging/transport_test.rb
 - test/integration/alternate_authentication_test.rb

data/lib/essential/messaging/property.rb

@@ -1,27 +0,0 @@
-module Essential::Messaging
-  class Property < Essential::Resource
-    include Essential::Resource::Update
-    include Essential::Resource::Delete
-
-    undef_method :sid
-    attr_property :subscriber_sid, :name, :value
-
-    def self.retrieve(*args)
-      raise NotImplementedError, 'must be retrieved from a Subscriber'
-    end
-
-    def self.url(subscriber_sid)
-      format('%s/%s/properties', Subscriber.url, CGI.escape(subscriber_sid))
-    end
-
-    def url
-      format('%s/%s', self.class.url(subscriber_sid), CGI.escape(name))
-    end
-
-    protected
-
-    def loaded?
-      @attributes.key?('name') && @attributes.key?('value')
-    end
-  end
-end

data/test/essential/messaging/property_test.rb

@@ -1,27 +0,0 @@
-require 'test_helper'
-
-class PropertyTest < EssentialTest
-  def setup
-    channel = Essential::Messaging::Channel.list.first
-    @sub_a = channel.subscribers.create(phone_number: '2221110000')
-    @sub_b = channel.subscribers.create(phone_number: '2221110001')
-    refute_equal @sub_a, @sub_b, 'test requires at least two subscribers'
-  end
-
-  def test_set_props
-    props_a = @sub_a.properties
-    existing_names = Set.new(props_a.map(&:name))
-
-    five_new = (5.times).map do
-      props_a.create(name: SecureRandom.uuid, value: SecureRandom.uuid)
-    end
-
-    new_names = Set.new(five_new.map(&:name))
-
-    assert (existing_names & new_names).empty?, 'new_names must be new'
-
-    props_a.refresh
-    existing_names = Set.new(props_a.map(&:name))
-    assert_equal (existing_names & new_names), new_names, 'must contain all new_names'
-  end
-end