espn_pub 0.1.7 → 0.1.8

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 9825c4b3b3277d1addc0d50c01683144de143366bfb394bccceee46f3b043d2c
-  data.tar.gz: 6fc6a99c1285f4523cdd60696e340e868c4a48c49c9e9b7f6a6188fcad9b28e6
+  metadata.gz: 2313dc03f24eb1a9ece5883a51a186acd8497790d2d6b2b4291cdaa997c4c977
+  data.tar.gz: f2238e3abe174ade734ac70e183d2741e9f11f5fd49a96d6a77000b82086cd75
 SHA512:
-  metadata.gz: b7c63799f4d0bdb87601e31a89bbadce8b3ce77dd14ac93dfff521d4a3cd1586b483b0490f86814d29e10093b52839bcb0ea5aec84e11831f794915f3149d316
-  data.tar.gz: 23f0d9d8af7f36469fa15734aeea9c02162133f92c48ff67b46737d98eec811c0cac01c4f4b37c465ae1b333f39e5af78007872c3e9b30ead77c5d77669194a4
+  metadata.gz: 32011085498d278e9076c1332e53bc6aee395345f30adc547ded45705713e7e358e2c3da8663f3abd0c1ec7f179fc6b4f703f4d84e27c4f6f9ccc3dd79d4eb3f
+  data.tar.gz: 2b4bbf38c0aa43eeee07b4848c7eaaf9bde8d167cacb2890c657ea668ebd5132042a51b815c5485eaece594d7f8a3cab89ae8290f3eec5c99a6e29dce15de9f6

data/lib/espn_pub/entities/base.rb

@@ -24,6 +24,10 @@ module EspnPub
           version: Client::API_VERSION
         )
       end
+
+      def normalize_name(name)
+        name.gsub(/[^a-zA-Z0-9]/i, '_').downcase
+      end
     end
   end
 end

data/lib/espn_pub/entities/league.rb

@@ -20,13 +20,13 @@ module EspnPub
         'nfl' => 'football'
       }.freeze
 
-      attr_reader :name
+      attr_reader :league_name
 
-      def self.fetch_season_details(name, season_year)
-        raise ArgumentError, "Unknown league name: #{name}" unless NAME_TO_SPORT.key?(name)
+      def self.fetch_season_details(league_name, season_year)
+        raise ArgumentError, "Unknown league name: #{league_name}" unless NAME_TO_SPORT.key?(league_name)
         raise ArgumentError, 'Season year must be an integer' unless season_year.to_i.positive?
 
-        path = format GAMES_PATH, EspnPub::Client::API_VERSION, NAME_TO_SPORT[name], name
+        path = format GAMES_PATH, EspnPub::Client::API_VERSION, NAME_TO_SPORT[league_name], league_name
         path += "?dates=#{Time.new(season_year).strftime('%Y%m%d')}"
         resp = EspnPub::Client.new.send_request(path)
         season = resp.dig('leagues', 0, 'season')
@@ -42,9 +42,9 @@ module EspnPub
 
       # Initialize a League instance.
       #
-      # @param name [String] The league identifier string.
-      def initialize(name)
-        @name = name
+      # @param league_name [String] The league identifier string.
+      def initialize(league_name)
+        @league_name = normalize_name(league_name)
         super()
       end
 
@@ -54,7 +54,7 @@ module EspnPub
       def teams
         unless defined?(@teams)
           begin
-            path = format TEAMS_PATH, client.version, sport, name
+            path = format TEAMS_PATH, client.version, sport, league_name
             teams_resp = client.send_request(path)
             @teams = (teams_resp.dig('sports', 0, 'leagues', 0, 'teams') || []).map do |team_data|
               EspnPub::Entities::Team.new(
@@ -63,11 +63,11 @@ module EspnPub
                 location: team_data.dig('team', 'location'),
                 abbreviation: team_data.dig('team', 'abbreviation'),
                 sport: sport,
-                league: name
+                league_name: league_name
               )
             end
           rescue Client::UnexpectedResponseCodeError => e
-            warn "Failed to fetch teams for league #{name}: #{e.message}"
+            warn "Failed to fetch teams for league #{league_name}: #{e.message}"
             return []
           end
         end
@@ -80,7 +80,7 @@ module EspnPub
       # @param date [Date, DateTime, nil] An optional date to filter games.
       # @return [Array<EspnPub::Entities::Game>]
       def games(date: nil)
-        path = format GAMES_PATH, client.version, sport, name
+        path = format GAMES_PATH, client.version, sport, league_name
         path += "?dates=#{date.strftime('%Y%m%d')}" if date
         games_resp = client.send_request(path)
         (games_resp['events'] || []).map do |game_data|
@@ -90,18 +90,18 @@ module EspnPub
             home_team: EspnPub::Entities::Team.fetch_by_id(
               id: game_data.dig('competitions', 0, 'competitors', 0, 'id'),
               sport: sport,
-              league: name
+              league_name: league_name
             ),
             away_team: EspnPub::Entities::Team.fetch_by_id(
               id: game_data.dig('competitions', 0, 'competitors', 1, 'id'),
               sport: sport,
-              league: name
+              league_name: league_name
             ),
             date: DateTime.parse(game_data['date'])
           )
         end
       rescue Client::UnexpectedResponseCodeError => e
-        warn "Failed to fetch games for league #{name}: #{e.message}"
+        warn "Failed to fetch games for league #{league_name}: #{e.message}"
         []
       end
 
@@ -109,7 +109,7 @@ module EspnPub
       #
       # @return [String, nil] The sport name or nil when unknown.
       def sport
-        NAME_TO_SPORT[name]
+        NAME_TO_SPORT[league_name]
       end
     end
   end

data/lib/espn_pub/entities/player.rb

@@ -10,7 +10,7 @@ module EspnPub
 
       attr_reader :id,
                   :sport,
-                  :league,
+                  :league_name,
                   :first_name,
                   :last_name,
                   :position,
@@ -27,7 +27,7 @@ module EspnPub
       #
       # @param id [String] The player identifier.
       # @param sport [String] The sport name.
-      # @param league [String] The league identifier.
+      # @param league_name [String] The league identifier.
       # @param first_name [String, nil] The player's first name.
       # @param last_name [String, nil] The player's last name.
       # @param position [String, nil] The player's position abbreviation.
@@ -39,11 +39,11 @@ module EspnPub
       # @param height [String, nil] The player's listed height.
       # @param weight [String, nil] The player's listed weight.
       # @param debut_year [Integer, nil] The year the player made their debut.
-      def initialize(id:, sport:, league:, first_name: nil, last_name: nil, position: nil, team_id: nil,
+      def initialize(id:, sport:, league_name:, first_name: nil, last_name: nil, position: nil, team_id: nil,
                      date_of_birth: nil, birth_city: nil, birth_state: nil, birth_country: nil, height: nil, weight: nil, debut_year: nil)
         @id = id
         @sport = sport
-        @league = league
+        @league_name = league_name
         @first_name = first_name
         @last_name = last_name
         @position = position
@@ -64,9 +64,9 @@ module EspnPub
       # @param sport [String] The sport name.
       # @param league [String] The league identifier.
       # @return [Player, nil] The player, or nil when the request fails or data is missing.
-      def self.fetch_by_id(id:, sport:, league:)
+      def self.fetch_by_id(id:, sport:, league_name:)
         client = EspnPub::Client.new
-        path = format ATHLETE_PATH, sport, league, id
+        path = format ATHLETE_PATH, sport, league_name, id
         begin
           athlete_data = client.send_request(path)['athlete']
         rescue Client::UnexpectedResponseCodeError => e
@@ -79,7 +79,7 @@ module EspnPub
         new(
           id: athlete_data['id'],
           sport: sport,
-          league: league,
+          league_name: league_name,
           first_name: athlete_data['firstName'],
           last_name: athlete_data['lastName'],
           position: athlete_data.dig('position', 'abbreviation'),

data/lib/espn_pub/entities/team.rb

@@ -12,7 +12,7 @@ module EspnPub
                   :location,
                   :abbreviation,
                   :sport,
-                  :league,
+                  :league_name,
                   :venue
 
       # Initialize a Team entity.
@@ -22,24 +22,24 @@ module EspnPub
       # @param location [String] The team location.
       # @param abbreviation [String] The team abbreviation.
       # @param sport [String] The sport name.
-      # @param league [String] The league identifier.
+      # @param league_name [String] The league identifier.
       # @param venue [EspnPub::Entities::Venue, nil] The team's home venue.
-      def initialize(id:, name:, location:, abbreviation:, sport:, league:, venue: nil)
+      def initialize(id:, name:, location:, abbreviation:, sport:, league_name:, venue: nil)
         @id = id
         @name = name
         @location = location
         @abbreviation = abbreviation
         @sport = sport
-        @league = league
+        @league_name = league_name
         @venue = venue
         super()
       end
 
-      def self.fetch_by_id(id:, sport:, league:, user_agent: nil)
+      def self.fetch_by_id(id:, sport:, league_name:, user_agent: nil)
         client = EspnPub::Client.new
         client.user_agent = user_agent if user_agent
 
-        path = format TEAM_PATH, client.version, sport, league, id
+        path = format TEAM_PATH, client.version, sport, league_name, id
         begin
           team_data = client.send_request(path)['team']
         rescue Client::UnexpectedResponseCodeError => e
@@ -55,7 +55,7 @@ module EspnPub
           location: team_data['location'],
           abbreviation: team_data['abbreviation'],
           sport: sport,
-          league: league,
+          league_name: league_name,
           venue: EspnPub::Entities::Venue.from_api(team_data.dig('franchise', 'venue'))
         )
       end
@@ -66,13 +66,13 @@ module EspnPub
       def players
         unless defined?(@roster)
           begin
-            path = format ROSTER_PATH, client.version, sport, league, id
+            path = format ROSTER_PATH, client.version, sport, league_name, id
             roster_resp = client.send_request(path)
             @roster = (roster_resp['athletes'] || []).map do |athlete_data|
               EspnPub::Entities::Player.new(
                 id: athlete_data['id'],
                 sport: sport,
-                league: league,
+                league_name: league_name,
                 first_name: athlete_data['firstName'],
                 last_name: athlete_data['lastName'],
                 position: athlete_data['position']['abbreviation'],

data/lib/espn_pub/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module EspnPub
-  VERSION = '0.1.7'
+  VERSION = '0.1.8'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: espn_pub
 version: !ruby/object:Gem::Version
-  version: 0.1.7
+  version: 0.1.8
 platform: ruby
 authors:
 - Jeffrey Bowman