esp_sdk 2.4.0 → 2.5.0

data/lib/esp/resources/dashboard.rb

@@ -1,13 +1,13 @@
 module ESP
   class Dashboard < ESP::Resource
-    # Not Implemented. You cannot search for Suppression::Region.
+    # Not Implemented. You cannot search for a Dashboard.
     #
     # Regular ARELlike methods are disabled.
     def self.find(*)
       fail ESP::NotImplementedError, 'Regular ARELlike methods are disabled.  Use the .recent method.'
     end
 
-    # Not Implemented. You cannot search for Suppression::Region.
+    # Not Implemented. You cannot search for a Dashboard.
     #
     # Regular ARELlike methods are disabled.
     def self.where(*)

data/lib/esp/resources/report.rb

@@ -1,5 +1,9 @@
 module ESP
   class Report < ESP::Resource
+    module Export
+      autoload :Integration, File.expand_path(File.dirname(__FILE__) + '/reports/export/integration')
+    end
+
     ##
     # The organization the report belongs to.
     belongs_to :organization, class_name: 'ESP::Organization'
@@ -16,7 +20,7 @@ module ESP
     # The external_account the report belongs to.
     belongs_to :external_account, class_name: 'ESP::ExternalAccount'
 
-    # Not Implemented. You cannot create or update a Report.
+    # Not Implemented. You cannot update a Report.
     def update
       fail ESP::NotImplementedError
     end

data/lib/esp/resources/suppression.rb

@@ -1,5 +1,9 @@
 module ESP
   class Suppression < ESP::Resource
+    autoload :UniqueIdentifier, File.expand_path(File.dirname(__FILE__) + '/suppression/unique_identifier')
+    autoload :Signature, File.expand_path(File.dirname(__FILE__) + '/suppression/signature')
+    autoload :Region, File.expand_path(File.dirname(__FILE__) + '/suppression/region')
+
     ##
     # The organization this sub organization belongs to.
     belongs_to :organization, class_name: 'ESP::Organization'

data/lib/esp/version.rb

@@ -1,3 +1,3 @@
 module ESP
-  VERSION = '2.4.0'.freeze
+  VERSION = '2.5.0'.freeze
 end

data/test/esp/integration/custom_signature_definition_integration_test.rb

@@ -0,0 +1,95 @@
+require File.expand_path(File.dirname(__FILE__) + '/../../test_helper')
+
+module ESP::Integration
+  class CustomSignatureDefinitionTest < ESP::Integration::TestCase
+    context ESP::CustomSignature::Definition do
+      context 'live calls' do
+        context '#custom_signature' do
+          should 'return a custom_signature' do
+            archived_definition = ESP::CustomSignature::Definition.where(status_eq: 'archived').last
+            fail 'Missing definition' if archived_definition.blank?
+
+            custom_signature = archived_definition.custom_signature
+
+            assert_equal archived_definition.custom_signature_id, custom_signature.id
+            assert_equal ESP::CustomSignature, custom_signature.class
+          end
+        end
+
+        context '#results' do
+          should 'return list of results' do
+            archived_definition = ESP::CustomSignature::Definition.where(status_eq: 'archived').last
+            fail 'Missing definition' if archived_definition.blank?
+
+            results = archived_definition.results
+
+            assert_equal ESP::CustomSignature::Result, results.resource_class
+          end
+        end
+
+        context '.where' do
+          should 'return definition objects' do
+            archived_definition = ESP::CustomSignature::Definition.where(status_eq: 'archived').last
+            fail 'Missing definition' if archived_definition.blank?
+
+            definitions = ESP::CustomSignature::Definition.where(id_eq: archived_definition.id)
+
+            assert_equal ESP::CustomSignature::Definition, definitions.resource_class
+          end
+        end
+
+        context '.archive' do
+          should 'archive definition' do
+            definition = ESP::CustomSignature::Definition.where(status_eq: 'active').last
+            fail 'Missing definition' if definition.blank?
+
+            definition.archive
+
+            assert_equal 'archived', definition.status
+          end
+        end
+
+        context '.activate' do
+          should 'activate definition' do
+            custom_signature = ESP::CustomSignature.last
+            fail 'Missing custom signature' if custom_signature.blank?
+            definition = ESP::CustomSignature::Definition.create(custom_signature_id: custom_signature.id)
+
+            assert_equal 'editable', definition.status
+
+            definition.activate
+
+            assert_equal 'validating', definition.status
+          end
+        end
+
+        context '#CRUD' do
+          should 'be able to create, update and destroy' do
+            custom_signature = ESP::CustomSignature.last
+            fail 'Missing custom signature' if custom_signature.blank?
+            definition = ESP::CustomSignature::Definition.new(custom_signature_id: custom_signature.id)
+
+            assert_predicate definition, :new?
+
+            definition.save
+
+            refute_predicate definition, :new?
+
+            definition.code = 'ABC123'
+            definition.save
+
+            assert_nothing_raised do
+              ESP::CustomSignature::Definition.find(definition.id)
+            end
+
+            definition.destroy
+
+            assert_raises ActiveResource::ResourceNotFound do
+              ESP::CustomSignature::Definition.find(definition.id)
+            end
+          end
+        end
+      end
+    end
+  end
+end

data/test/esp/integration/custom_signature_integration_test.rb

@@ -26,38 +26,6 @@ module ESP::Integration
           end
         end
 
-        context '.run' do
-          should 'return alerts' do
-            skip "Can't run sigs on CI" if ENV['CI_SERVER']
-            external_account_id = ESP::ExternalAccount.last.id
-            alerts = ESP::CustomSignature.run(external_account_id: external_account_id, regions: 'us_east_1', language: @custom_signature.language, signature: @custom_signature.signature)
-
-            assert_equal ESP::Alert, alerts.resource_class
-          end
-
-          should 'return errors' do
-            signature = ESP::CustomSignature.run(external_account_id: 999_999_999_999, regions: 'us_east_1', language: @custom_signature.language, signature: @custom_signature.signature)
-
-            assert_equal "Couldn't find ExternalAccount", signature.errors.full_messages.first
-          end
-        end
-
-        context '#run' do
-          should 'return alerts' do
-            skip "Can't run sigs on CI" if ENV['CI_SERVER']
-            external_account_id = ESP::ExternalAccount.last.id
-            alerts = @custom_signature.run(external_account_id: external_account_id, regions: ['us_east_1'])
-
-            assert_equal ESP::Alert, alerts.resource_class
-          end
-
-          should 'return errors' do
-            @custom_signature.run(external_account_id: 999_999_999_999)
-
-            assert_equal "Couldn't find ExternalAccount", @custom_signature.errors.full_messages.first
-          end
-        end
-
         context '.where' do
           should 'return custom_signature objects' do
             custom_signatures = ESP::CustomSignature.where(id_eq: @custom_signature.id)
@@ -68,7 +36,6 @@ module ESP::Integration
 
         context '#CRUD' do
           should 'be able to create, update and destroy' do
-            skip "Can't run sigs on CI" if ENV['CI_SERVER']
             custom_signature = ESP::CustomSignature.new(@custom_signature.attributes)
 
             assert_predicate custom_signature, :new?

data/test/esp/integration/custom_signature_result_alert_integration_test.rb

@@ -0,0 +1,59 @@
+require File.expand_path(File.dirname(__FILE__) + '/../../test_helper')
+
+module ESP::Integration
+  class CustomSignatureResultAlertTest < ESP::Integration::TestCase
+    context ESP::CustomSignature::Result::Alert do
+      context 'live calls' do
+        context '#for_result' do
+          should 'return alerts' do
+            result = ESP::CustomSignature::Result.first
+            fail 'Missing result' if result.blank?
+
+            alerts = ESP::CustomSignature::Result::Alert.for_result(result.id)
+
+            assert_equal ESP::CustomSignature::Result::Alert, alerts.resource_class
+          end
+        end
+
+        context '#custom_signature' do
+          should 'return a custom_signature' do
+            result = ESP::CustomSignature::Result.first
+            fail 'Missing result' if result.blank?
+            alert = ESP::CustomSignature::Result::Alert.for_result(result.id).first
+
+            custom_signature = alert.custom_signature
+
+            assert_equal ESP::CustomSignature, custom_signature.class
+            assert_equal alert.custom_signature_id, custom_signature.id
+          end
+        end
+
+        context '#external_account' do
+          should 'return a external_account' do
+            result = ESP::CustomSignature::Result.first
+            fail 'Missing result' if result.blank?
+            alert = ESP::CustomSignature::Result::Alert.for_result(result.id).first
+
+            external_account = alert.external_account
+
+            assert_equal ESP::ExternalAccount, external_account.class
+            assert_equal alert.external_account_id, external_account.id
+          end
+        end
+
+        context '#region' do
+          should 'return a region' do
+            result = ESP::CustomSignature::Result.first
+            fail 'Missing result' if result.blank?
+            alert = ESP::CustomSignature::Result::Alert.for_result(result.id).first
+
+            region = alert.region
+
+            assert_equal ESP::Region, region.class
+            assert_equal alert.region_id, region.id
+          end
+        end
+      end
+    end
+  end
+end

data/test/esp/integration/custom_signature_result_integration_test.rb

@@ -0,0 +1,83 @@
+require File.expand_path(File.dirname(__FILE__) + '/../../test_helper')
+
+module ESP::Integration
+  class CustomSignatureResultTest < ESP::Integration::TestCase
+    context ESP::CustomSignature::Result do
+      context 'live calls' do
+        context '#definition' do
+          should 'return a definition' do
+            result = ESP::CustomSignature::Result.last
+            fail 'Missing result' if result.blank?
+
+            definition = result.definition
+
+            assert_equal ESP::CustomSignature::Definition, definition.class
+            assert_equal result.definition_id, definition.id
+          end
+        end
+
+        context '#region' do
+          should 'return a region' do
+            result = ESP::CustomSignature::Result.last
+            fail 'Missing result' if result.blank?
+
+            region = result.region
+
+            assert_equal ESP::Region, region.class
+            assert_equal result.region_id, region.id
+          end
+        end
+
+        context '#external_account' do
+          should 'return a external_account' do
+            result = ESP::CustomSignature::Result.last
+            fail 'Missing result' if result.blank?
+
+            external_account = result.external_account
+
+            assert_equal ESP::ExternalAccount, external_account.class
+            assert_equal result.external_account_id, external_account.id
+          end
+        end
+
+        context '#alerts' do
+          should 'return list of alerts' do
+            result = ESP::CustomSignature::Result.last
+            fail 'Missing result' if result.blank?
+
+            alerts = result.alerts
+
+            assert_equal ESP::CustomSignature::Result::Alert, alerts.resource_class
+          end
+        end
+
+        context '.where' do
+          should 'return result objects' do
+            result = ESP::CustomSignature::Result.last
+            fail 'Missing result' if result.blank?
+
+            results = ESP::CustomSignature::Result.where(id_eq: result.id)
+
+            assert_equal ESP::CustomSignature::Result, results.resource_class
+          end
+        end
+
+        context '#create' do
+          should 'be able to create' do
+            custom_signature = ESP::CustomSignature.create(name: 'ABC', identifier: 'ABC', risk_level: 'High')
+            refute_predicate custom_signature, :new?
+            definition = custom_signature.definitions.first
+            fail 'Missing definition' if definition.blank?
+            result = ESP::CustomSignature::Result.new(custom_signature_definition_id: definition.id, external_account_id: 1, region_id: 1, code: 'abc', language: 'ruby')
+
+            assert_predicate result, :new?
+
+            result.save
+
+            refute_predicate result, :new?
+          end
+        end
+      end
+    end
+  end
+end

data/test/esp/integration/external_account_integration_test.rb

@@ -48,28 +48,6 @@ module ESP::Integration
             assert_equal ESP::ExternalAccount, external_accounts.resource_class
           end
         end
-
-        context '#CRUD' do
-          should 'be able to create, update and destroy' do
-            skip "There are to many dependencies to validate an external account to create or update one. Besides esp_web, esp_query has to be running and there must be valid AWS keys assigned as well."
-
-            external_account = ESP::ExternalAccount.create(name: 'bob', arn: @external_account.arn, sub_organization_id: @external_account.sub_organization_id, team_id: @external_account.team_id)
-
-            assert_predicate external_account, :new?
-            assert_contains external_account.errors, "The account for this ARN is already being checked by Dev"
-
-            refute_predicate @external_account, :new?
-            @external_account.name = @external_account.name
-
-            assert_predicate @external_account, :save
-
-            external_account = build(:external_account, id: 999)
-
-            assert_raises ActiveResource::ResourceNotFound do
-              external_account.destroy
-            end
-          end
-        end
       end
     end
   end

data/test/esp/integration/report_export_integration_integration_test.rb

@@ -7,7 +7,7 @@ module ESP::Integration
         context ESP::Report::Export::Integration do
           context 'live calls' do
             context '#create' do
-              should 'return regions' do
+              should 'queue export' do
                 report = ESP::Report.last
                 fail "Live DB does not have any reports.  Add a report with stats and run tests again." if report.blank?
 

data/test/esp/resources/custom_signature/definition_test.rb

@@ -0,0 +1,77 @@
+require File.expand_path(File.dirname(__FILE__) + '/../../../test_helper')
+
+module ESP
+  class CustomSignature
+    class DefinitionTest < ActiveSupport::TestCase
+      context ESP::CustomSignature::Definition do
+        context '#custom_signature' do
+          should 'call the api' do
+            definition = build(:definition, custom_signature_id: 4)
+            stubbed_custom_signature = stub_request(:get, %r{custom_signatures/#{definition.custom_signature_id}.json*}).to_return(body: json(:custom_signature))
+
+            definition.custom_signature
+
+            assert_requested(stubbed_custom_signature)
+          end
+        end
+
+        context '#results' do
+          should 'call the api' do
+            definition = build(:definition)
+            stub_request(:get, /custom_signature_results.json*/).to_return(body: json_list(:result, 2))
+
+            definition.results
+
+            assert_requested(:get, /custom_signature_results.json*/) do |req|
+              assert_equal "filter[definition_id_eq]=#{definition.id}", URI.unescape(req.uri.query)
+            end
+          end
+        end
+
+        context 'activate' do
+          should 'call the api' do
+            definition = build(:definition)
+            stubbed_defintion = stub_request(:patch, %r{custom_signature_definitions/#{definition.id}/activate.json}).to_return(body: json(:definition))
+
+            definition.activate
+
+            assert_requested stubbed_defintion
+          end
+
+          should 'parse errors' do
+            definition = build(:definition)
+            stub_request(:patch, %r{custom_signature_definitions/#{definition.id}/activate.json}).to_return(status: 422, body: json(:error, :active_record))
+
+            definition.activate
+
+            assert_contains definition.errors.full_messages, "Name can't be blank"
+            assert_contains definition.errors.full_messages, "Name is invalid"
+            assert_contains definition.errors.full_messages, "Description can't be blank"
+          end
+        end
+
+        context 'archive' do
+          should 'call the api' do
+            definition = build(:definition)
+            stubbed_defintion = stub_request(:patch, %r{custom_signature_definitions/#{definition.id}/archive.json}).to_return(body: json(:definition))
+
+            definition.archive
+
+            assert_requested stubbed_defintion
+          end
+
+          should 'parse errors' do
+            definition = build(:definition)
+            stub_request(:patch, %r{custom_signature_definitions/#{definition.id}/archive.json}).to_return(status: 422, body: json(:error, :active_record))
+
+            definition.archive
+
+            assert_contains definition.errors.full_messages, "Name can't be blank"
+            assert_contains definition.errors.full_messages, "Name is invalid"
+            assert_contains definition.errors.full_messages, "Description can't be blank"
+          end
+        end
+      end
+    end
+  end
+end