esp_sdk 2.0.0 → 2.1.0

data/test/esp/external_account_creator_test.rb

@@ -0,0 +1,153 @@
+require_relative '../test_helper'
+require_relative '../../lib/esp/aws_clients'
+require_relative '../../lib/esp/external_account_creator'
+
+module ESP
+  class ExternalAccountCreatorTest < ActiveSupport::TestCase
+    context ESP::ExternalAccountCreator do
+      context "#create" do
+        setup do
+          @external_account_creator = ExternalAccountCreator.new
+
+          @external_account_creator.aws.stubs(:owner_id).returns('012345678912')
+
+          role = mock
+          role.stubs(:arn).returns('arn')
+          aws_role_object = mock
+          aws_role_object.stubs(:role).returns(role)
+          @external_account_creator.aws.stubs(:create_and_attach_role!).returns(aws_role_object)
+
+          @team_stub             = stub_request(:put, /teams.json*/).to_return(body: json_list(:team, 1))
+          @sub_organization_stub = stub_request(:put, /sub_organizations.json*/).to_return(body: json_list(:sub_organization, 1))
+
+          @external_account_creator.stubs(:sleep).returns(0)
+
+          @external_account_stub = stub_request(:post, /external_accounts.json*/).to_return(body: json(:external_account))
+        end
+
+        should "fail if aws is not valid" do
+          @external_account_creator.aws.unstub(:owner_id)
+          @external_account_creator.aws.stubs(:owner_id).returns('abc')
+
+          exception = assert_raises AddExternalAccountError do
+            @external_account_creator.create
+          end
+
+          assert_match(/wrong length/, exception.message)
+          assert_equal AddExternalAccountError::EXIT_CODES['12 characters'], exception.exit_code
+        end
+
+        should "create and attach aws role" do
+          @external_account_creator.create
+
+          assert_received(@external_account_creator.aws, :create_and_attach_role!) do |expect|
+            expect.with do |external_account_id|
+              assert_equal @external_account_creator.send(:external_account_id), external_account_id
+            end
+          end
+        end
+
+        context "#organization" do
+          setup do
+            stub_request(:get, /organizations.json*/).to_return(body: json_list(:empty, 1))
+            remove_request_stub(@sub_organization_stub)
+            stub_request(:put, /sub_organizations.json*/).to_return(body: json_list(:empty, 1))
+          end
+
+          should "fail if organization is not returned" do
+            exception = assert_raises AddExternalAccountError do
+              @external_account_creator.create
+            end
+
+            assert_match(/Organization not found/, exception.message)
+            assert_equal AddExternalAccountError::EXIT_CODES['organization not found'], exception.exit_code
+          end
+        end
+
+        context "#sub_organization" do
+          setup do
+            stub_request(:get, /organizations.json*/).to_return(body: json_list(:organization, 1))
+            remove_request_stub(@sub_organization_stub)
+          end
+
+          should "fail if sub_organization is not found or created" do
+            stub_request(:put, /sub_organizations.json*/).to_return(body: json_list(:empty, 1))
+            stub_request(:post, /sub_organizations.json*/).to_return(status: 422, body: json(:error, :active_record))
+
+            exception = assert_raises AddExternalAccountError do
+              @external_account_creator.create
+            end
+
+            assert_match(/On Sub Organization/, exception.message)
+            assert_equal AddExternalAccountError::EXIT_CODES['sub organization'], exception.exit_code
+          end
+
+          should "create sub organization if sub_organization is not found" do
+            stub_request(:put, /sub_organizations.json*/).to_return(body: json_list(:empty, 1))
+            sub_org_stub = stub_request(:post, /sub_organizations.json*/).to_return(status: 422, body: json(:sub_organization))
+
+            @external_account_creator.create
+
+            assert_requested sub_org_stub
+            assert_not_nil @external_account_creator.send(:sub_organization)
+          end
+        end
+
+        context "#team" do
+          setup do
+            stub_request(:get, /sub_organizations.json*/).to_return(body: json_list(:sub_organization, 1))
+            remove_request_stub(@team_stub)
+          end
+
+          should "fail if team is not found or created" do
+            stub_request(:put, /teams.json*/).to_return(body: json_list(:empty, 1))
+            stub_request(:post, /teams.json*/).to_return(status: 422, body: json(:error, :active_record))
+
+            exception = assert_raises AddExternalAccountError do
+              @external_account_creator.create
+            end
+
+            assert_match(/On Team/, exception.message)
+            assert_equal AddExternalAccountError::EXIT_CODES['team'], exception.exit_code
+          end
+
+          should "create team if team is not found" do
+            stub_request(:put, /teams.json*/).to_return(body: json_list(:empty, 1))
+            team_stub = stub_request(:post, /teams.json*/).to_return(status: 422, body: json(:team))
+
+            @external_account_creator.create
+
+            assert_requested team_stub
+            assert_not_nil @external_account_creator.send(:team)
+          end
+        end
+
+        should "fail if external account is not created" do
+          remove_request_stub @external_account_stub
+          stub_request(:post, /external_accounts.json*/).to_return(status: 422, body: json(:error, :active_record))
+
+          exception = assert_raises AddExternalAccountError do
+            @external_account_creator.create
+          end
+
+          assert_match(/On External Account/, exception.message)
+          assert_equal AddExternalAccountError::EXIT_CODES['external account'], exception.exit_code
+        end
+
+        should "create and return external_account" do
+          external_account = @external_account_creator.create
+
+          assert_requested(:post, /external_accounts.json*/) do |req|
+            body = JSON.parse(req.body)
+            assert_equal @external_account_creator.aws.create_and_attach_role!.role.arn, body['data']['attributes']['arn']
+            assert_equal @external_account_creator.send(:external_account_id), body['data']['attributes']['external_id']
+            assert_equal @external_account_creator.send(:team_name), body['data']['attributes']['name']
+            assert_equal @external_account_creator.send(:sub_organization).id, body['data']['attributes']['sub_organization_id']
+            assert_equal @external_account_creator.send(:team).id, body['data']['attributes']['team_id']
+          end
+          assert_not_nil external_account
+        end
+      end
+    end
+  end
+end

data/test/esp/resources/alert_test.rb

@@ -106,34 +106,21 @@ module ESP
         end
       end
 
-      context '#metadata' do
-        should 'call the api for the alert' do
-          alert = build(:alert)
-          stubbed_metadata = stub_request(:get, %r{alerts/#{alert.id}/metadata.json*}).to_return(body: json(:metadata))
-
-          alert.metadata
-
-          assert_requested(stubbed_metadata)
-        end
-      end
-
-      context '.for_report' do
+      context '.where' do
         should 'throw an error if report_id is not supplied' do
           error = assert_raises ArgumentError do
-            ESP::Alert.for_report
+            ESP::Alert.where(status: 'complete')
           end
           assert_equal 'You must supply a report id.', error.message
         end
 
-        should 'call the api and pass params' do
-          stub_request(:get, %r{reports/5/alerts.json*}).to_return(body: json_list(:alert, 2))
+        should 'call the api and return alerts when report_id is supplied' do
+          stub_alert = stub_request(:put, %r{reports/5/alerts.json*}).to_return(body: json_list(:alert, 2))
 
-          alerts = ESP::Alert.for_report(5, status: 'pass')
+          alert = ESP::Alert.where(report_id: 5)
 
-          assert_requested(:get, %r{reports/5/alerts.json*}) do |req|
-            assert_equal "filter[status]=pass", URI.unescape(req.uri.query)
-          end
-          assert_equal ESP::Alert, alerts.resource_class
+          assert_requested(stub_alert)
+          assert_equal ESP::Alert, alert.resource_class
         end
       end
 
@@ -243,7 +230,7 @@ module ESP
         setup do
           skip "Make sure you run the live calls locally to ensure proper integration" if ENV['CI_SERVER']
           WebMock.allow_net_connect!
-          @report = ESP::Report.last
+          @report = ESP::Report.all.detect { |r| r.status == 'complete' }
           skip "Live DB does not have any reports.  Add a report and run tests again." if @report.blank?
           @alert = @report.alerts.last
         end
@@ -252,31 +239,82 @@ module ESP
           WebMock.disable_net_connect!
         end
 
-        context '#metadata' do
-          should 'return metata' do
+        context '#external_account' do
+          should 'return an external_account' do
+            external_account = @alert.external_account
+
+            assert_equal ESP::ExternalAccount, external_account.class
+            assert_equal @alert.external_account_id, external_account.id
+          end
+        end
+
+        context '#region' do
+          should 'return a region' do
+            region = @alert.region
+
+            assert_equal ESP::Region, region.class
+            assert_equal @alert.region_id, region.id
+          end
+        end
+
+        context '#signature' do
+          should 'return a signature' do
+            signature = @alert.signature
+
+            assert_equal ESP::Signature, signature.class
+            assert_equal @alert.signature_id, signature.id
+          end
+        end
+
+        context '#custom_signature' do
+          should 'return a custom_signature' do
             assert_nothing_raised do
-              @alert.metadata
+              @alert.attributes['custom_signature_id'] ||= 1
+              @alert.custom_signature
             end
           end
         end
 
-        context '.for_report' do
-          should 'return events for report id' do
-            report = ESP::Report.last
-            alerts = ESP::Alert.for_report(report.id)
+        context '#suppression' do
+          should 'return a suppression' do
+            assert_nothing_raised do
+              @alert.attributes['suppression_id'] ||= 1
+              @alert.suppression
+            end
+          end
+        end
 
-            assert_equal ESP::Alert, alerts.resource_class
+        context '#cloud_trail_events' do
+          should 'return cloud_trail_events' do
+            assert_nothing_raised do
+              @alert.cloud_trail_events
+            end
+          end
+        end
+
+        context '#tags' do
+          should 'return tags' do
+            assert_nothing_raised do
+              @alert.tags
+            end
           end
         end
 
         context '.find' do
           should 'return an alert by id' do
-            report = ESP::Report.last
-            alert_id = report.alerts.last.id
-            alert = ESP::Alert.find(alert_id.to_i)
+            alert = ESP::Alert.find(@alert.id.to_i)
 
             assert_equal ESP::Alert, alert.class
-            assert_equal alert_id, alert.id
+            assert_equal @alert.id, alert.id
+          end
+        end
+
+        context '.where' do
+          should 'return alert objects' do
+            alerts = ESP::Alert.where(report_id: @report.id, id_eq: @alert.id)
+
+            assert_equal ESP::Alert, alerts.resource_class
+            assert_equal @alert.id, alerts.first.id
           end
         end
       end

data/test/esp/resources/cloud_trail_event_test.rb

@@ -3,6 +3,14 @@ require File.expand_path(File.dirname(__FILE__) + '/../../test_helper')
 module ESP
   class CloudTrailEventTest < ActiveSupport::TestCase
     context ESP::CloudTrailEvent do
+      context '.where' do
+        should 'not be implemented' do
+          assert_raises ESP::NotImplementedError do
+            ESP::CloudTrailEvent.where(id_eq: 2)
+          end
+        end
+      end
+
       context '#create' do
         should 'not be implemented' do
           assert_raises ESP::NotImplementedError do
@@ -86,7 +94,7 @@ module ESP
 
         context '.for_alert' do
           should 'return events for alert id' do
-            report = ESP::Report.last
+            report = ESP::Report.all.detect { |r| r.status == 'complete' }
             events = ESP::CloudTrailEvent.for_alert(report.alerts.last.id)
 
             assert_equal ESP::CloudTrailEvent, events.resource_class

data/test/esp/resources/contact_request_test.rb

@@ -11,6 +11,14 @@ module ESP
         end
       end
 
+      context '.where' do
+        should 'not be implemented' do
+          assert_raises ESP::NotImplementedError do
+            ESP::ContactRequest.where(id_eq: 2)
+          end
+        end
+      end
+
       context '#update' do
         should 'not be implemented' do
           s = ESP::ContactRequest.new

data/test/esp/resources/custom_signature_test.rb

@@ -211,6 +211,14 @@ module ESP
           end
         end
 
+        context '.where' do
+          should 'return custom_signature objects' do
+            custom_signatures = ESP::CustomSignature.where(id_eq: @custom_signature.id)
+
+            assert_equal ESP::CustomSignature, custom_signatures.resource_class
+          end
+        end
+
         context '#CRUD' do
           should 'be able to create, update and destroy' do
             custom_signature = ESP::CustomSignature.new(@custom_signature.attributes)

data/test/esp/resources/dashboard_test.rb

@@ -11,6 +11,14 @@ module ESP
         end
       end
 
+      context '.where' do
+        should 'not be implemented' do
+          assert_raises ESP::NotImplementedError do
+            ESP::Dashboard.where(id_eq: 2)
+          end
+        end
+      end
+
       context '#create' do
         should 'not be implemented' do
           assert_raises ESP::NotImplementedError do

data/test/esp/resources/external_account_test.rb

@@ -98,6 +98,14 @@ module ESP
           end
         end
 
+        context '.where' do
+          should 'return external_account objects' do
+            external_accounts = ESP::ExternalAccount.where(id_eq: @external_account.id)
+
+            assert_equal ESP::ExternalAccount, external_accounts.resource_class
+          end
+        end
+
         context '#CRUD' do
           should 'be able to create, update and destroy' do
             skip "There are to many dependencies to validate an external account to create or update one. Besides esp_web, esp_query has to be running and there must be valid AWS keys assigned as well."

data/test/esp/resources/metadata_test.rb

@@ -86,7 +86,7 @@ module ESP
 
         context '.for_alert' do
           should 'return metadata for alert id' do
-            report = ESP::Report.last
+            report = ESP::Report.all.detect { |r| r.status == 'complete' }
             metadata = ESP::Metadata.for_alert(report.alerts.last.id)
 
             assert_equal ESP::Metadata, metadata.class

data/test/esp/resources/organization_test.rb

@@ -159,6 +159,14 @@ module ESP
           end
         end
 
+        context '.where' do
+          should 'return organization objects' do
+            organizations = ESP::Organization.where(id_eq: @organization.id)
+
+            assert_equal ESP::Organization, organizations.resource_class
+          end
+        end
+
         context '#CRUD' do
           should 'be able to update' do
             @organization.name = @organization.name

data/test/esp/resources/region_test.rb

@@ -61,19 +61,27 @@ module ESP
         setup do
           skip "Make sure you run the live calls locally to ensure proper integration" if ENV['CI_SERVER']
           WebMock.allow_net_connect!
+          @region = ESP::Region.last
+          skip "Live DB does not have any regions.  Add a region and run tests again." if @region.blank?
         end
 
         teardown do
           WebMock.disable_net_connect!
         end
 
+        context '.where' do
+          should 'return region objects' do
+            regions = ESP::Region.where(id_eq: @region.id)
+
+            assert_equal ESP::Region, regions.resource_class
+          end
+        end
+
         context '#CRUD' do
           should 'be able to read' do
-            region = ESP::Region.last
-
-            assert_not_nil region
+            assert_not_nil @region
 
-            region = ESP::Region.find(region.id)
+            region = ESP::Region.find(@region.id)
 
             assert_not_nil region
           end

data/test/esp/resources/report_test.rb

@@ -60,12 +60,13 @@ module ESP
       context '#alerts' do
         should 'call the api for the report and the passed in params' do
           report = build(:report)
-          stub_request(:get, %r{reports/#{report.id}/alerts.json*}).to_return(body: json_list(:alert, 2))
+          stub_request(:put, %r{reports/#{report.id}/alerts.json*}).to_return(body: json_list(:alert, 2))
 
           report.alerts(status: 'pass')
 
-          assert_requested(:get, %r{reports/#{report.id}/alerts.json*}) do |req|
-            assert_equal "filter[status]=pass", URI.unescape(req.uri.query)
+          assert_requested(:put, %r{reports/#{report.id}/alerts.json*}) do |req|
+            body = JSON.parse(req.body)
+            assert_equal 'pass', body['filter']['status']
           end
         end
       end
@@ -118,7 +119,7 @@ module ESP
         setup do
           skip "Make sure you run the live calls locally to ensure proper integration" if ENV['CI_SERVER']
           WebMock.allow_net_connect!
-          @report = ESP::Report.last
+          @report = ESP::Report.all.detect { |r| r.status == 'complete' }
           skip "Live DB does not have any reports.  Add a report and run tests again." if @report.blank?
         end
 
@@ -166,6 +167,14 @@ module ESP
           end
         end
 
+        context '.where' do
+          should 'return report objects' do
+            reports = ESP::Report.where(id_eq: @report.id)
+
+            assert_equal ESP::Report, reports.resource_class
+          end
+        end
+
         context '.create' do
           should 'return an error if a bad team_id is passed' do
             assert_nothing_raised do