esi-sdk 1.1.1 → 2.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: f9e2a18361aa7db1d4cdda4bbea2cbb20bf13be9c55c0f09508875b10a669648
-  data.tar.gz: 40823ea81c2590c58058280d9c5a20bf11c6996e92ca58cbe16f67b9fe5d5693
+  metadata.gz: b65c246beb4ff8ae1f851071d58394a3bdc9c879277d33ee2267c8ba57586b9c
+  data.tar.gz: be6ce8a4242acb9a51ae39b38397861c8b1ff22fc4ae6f9f2a6dad941627de2a
 SHA512:
-  metadata.gz: bfff60dc11675e8cec7f94bedf744abb970b67a6e1753655f6ebda5d95f5412bc5fbbc7e26bb37b512d8b2e0825570cffcbe2431a27c37a53415007b9bf9e4e2
-  data.tar.gz: f27e443090c80e0fd069b9e782d26211d96fc26f21ce866e699ea9151b55a3d8939b98250ddf1fadcbef6fc1a9229aef9fe3a775b5d16628102aed84d57bd1f0
+  metadata.gz: f49d61698e073ea71c5f950eb251fdb4278aeac68e1c0dd2c07455bcb55af9e177f9057f0c13c6f0d55b51e4a4f688db2882d882ec9fead74c6c33c0c32dd218
+  data.tar.gz: 1b2fb34cf860ee60518fc38059c230f53adcf739a1f3dae9ea0527e095b6db2c6997b4659de46808e712b85bfb83a3dcc81539d0e3fa2ab3c2be98aaac451117

data/.github/workflows/cicd.yml

@@ -168,6 +168,22 @@ jobs:
         with:
           node-version: '16'
 
+      - name: Find yarn cache location
+        id: yarn-cache
+        run: echo "::set-output name=dir::$(yarn cache dir)"
+
+      - name: Yarn package cache
+        uses: actions/cache@v2
+        with:
+          path: ${{ steps.yarn-cache.outputs.dir }}
+          key: ${{ runner.os }}-yarn-${{ hashFiles('**/yarn.lock') }}
+          restore-keys: |
+            ${{ runner.os }}-yarn-
+
+      - name: Install yarn packages
+        run: |
+          yarn install --pure-lockfile
+
       - name: Release
         env:
           GEM_HOST_API_KEY: ${{ secrets.RUBYGEMS_API_KEY }}
@@ -177,5 +193,4 @@ jobs:
           GIT_COMMITTER_EMAIL: "shahni@bokobo.space"
           GITHUB_TOKEN: ${{ secrets.GH_TOKEN }}
         run: |
-          npm install -g @semantic-release/changelog @semantic-release/exec @semantic-release/git
-          npx semantic-release ${{ github.event_name == 'pull_request' && '--dry-run' || ' ' }}
+          yarn release ${{ github.event_name == 'pull_request' && '--dry-run' || ' ' }}

data/.gitignore

@@ -9,3 +9,5 @@
 
 # rspec failure tracking
 .rspec_status
+vendor/bundle
+node_modules/

data/CHANGELOG.md

@@ -1,5 +1,38 @@
 # ESI SDK Changelog
 
+# [2.0.0](https://github.com/bokoboshahni/esi-sdk-ruby/compare/v1.2.0...v2.0.0) (2021-10-08)
+
+
+### Bug Fixes
+
+* require name from esi/sdk to esi-sdk ([2e5e996](https://github.com/bokoboshahni/esi-sdk-ruby/commit/2e5e9966343baef91bd037579607bb562edce301))
+
+
+### Features
+
+* migrate to httpx ([fd6ec0d](https://github.com/bokoboshahni/esi-sdk-ruby/commit/fd6ec0d6910805215efceb80a5361dc4d72b9599))
+
+
+### BREAKING CHANGES
+
+* use httpx instead of faraday for http calls
+
+# [1.2.0](https://github.com/bokoboshahni/esi-sdk-ruby/compare/v1.1.3...v1.2.0) (2021-07-20)
+
+
+### Features
+
+* Client improvements ([bad70ae](https://github.com/bokoboshahni/esi-sdk-ruby/commit/bad70ae4d97b8b0f93019b5b4dac73f97aad7dc0))
+
+## [1.1.3](https://github.com/bokoboshahni/esi-sdk-ruby/compare/v1.1.2...v1.1.3) (2021-07-19)
+
+
+### Bug Fixes
+
+* Use double splat for cache options ([db32f35](https://github.com/bokoboshahni/esi-sdk-ruby/commit/db32f35fe1737af8a856720366829d2da8a036de))
+
+## [1.1.2](https://github.com/bokoboshahni/esi-sdk-ruby/compare/v1.1.1...v1.1.2) (2021-07-19)
+
 ## [1.1.1](https://github.com/bokoboshahni/esi-sdk-ruby/compare/v1.1.0...v1.1.1) (2021-07-19)
 
 # [1.1.0](https://github.com/bokoboshahni/esi-sdk-ruby/compare/v1.0.0...v1.1.0) (2021-07-19)

data/Gemfile

@@ -7,6 +7,7 @@ ruby "3.0.2"
 gemspec
 
 gem "activesupport", "~> 6.1"
+gem "awesome_print", "~> 1.9"
 gem "rake", "~> 13.0"
 gem "rspec", "~> 3.10"
 gem "rubocop", "~> 1.18"

data/Gemfile.lock

@@ -1,15 +1,14 @@
 PATH
   remote: .
   specs:
-    esi-sdk (1.1.1)
-      faraday (~> 1.5)
-      faraday-http-cache (~> 2.2)
-      faraday_middleware (~> 1.0)
+    esi-sdk (2.0.0)
+      httpx (~> 0.18)
+      retriable (~> 3.1)
 
 GEM
   remote: https://rubygems.org/
   specs:
-    activesupport (6.1.4)
+    activesupport (6.1.4.1)
       concurrent-ruby (~> 1.0, >= 1.0.2)
       i18n (>= 1.6, < 2)
       minitest (>= 5.1)
@@ -18,33 +17,16 @@ GEM
     addressable (2.8.0)
       public_suffix (>= 2.0.2, < 5.0)
     ast (2.4.2)
+    awesome_print (1.9.2)
     concurrent-ruby (1.1.9)
     crack (0.4.5)
       rexml
     diff-lcs (1.4.4)
     docile (1.4.0)
-    faraday (1.5.1)
-      faraday-em_http (~> 1.0)
-      faraday-em_synchrony (~> 1.0)
-      faraday-excon (~> 1.1)
-      faraday-httpclient (~> 1.0.1)
-      faraday-net_http (~> 1.0)
-      faraday-net_http_persistent (~> 1.1)
-      faraday-patron (~> 1.0)
-      multipart-post (>= 1.2, < 3)
-      ruby2_keywords (>= 0.0.4)
-    faraday-em_http (1.0.0)
-    faraday-em_synchrony (1.0.0)
-    faraday-excon (1.1.0)
-    faraday-http-cache (2.2.0)
-      faraday (>= 0.8)
-    faraday-httpclient (1.0.1)
-    faraday-net_http (1.0.1)
-    faraday-net_http_persistent (1.2.0)
-    faraday-patron (1.0.0)
-    faraday_middleware (1.0.0)
-      faraday (~> 1.0)
     hashdiff (1.0.1)
+    http-2-next (0.5.0)
+    httpx (0.18.0)
+      http-2-next (>= 0.4.1)
     i18n (1.8.10)
       concurrent-ruby (~> 1.0)
     kramdown (2.3.1)
@@ -52,16 +34,16 @@ GEM
     kramdown-parser-gfm (1.1.0)
       kramdown (~> 2.0)
     minitest (5.14.4)
-    multipart-post (2.1.1)
-    parallel (1.20.1)
+    parallel (1.21.0)
     parser (3.0.2.0)
       ast (~> 2.4.1)
     public_suffix (4.0.6)
     rainbow (3.0.0)
     rake (13.0.6)
     regexp_parser (2.1.1)
+    retriable (3.1.2)
     rexml (3.2.5)
-    rouge (3.26.0)
+    rouge (3.26.1)
     rspec (3.10.0)
       rspec-core (~> 3.10.0)
       rspec-expectations (~> 3.10.0)
@@ -75,27 +57,25 @@ GEM
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.10.0)
     rspec-support (3.10.2)
-    rubocop (1.18.3)
+    rubocop (1.22.1)
       parallel (~> 1.10)
       parser (>= 3.0.0.0)
       rainbow (>= 2.2.2, < 4.0)
       regexp_parser (>= 1.8, < 3.0)
       rexml
-      rubocop-ast (>= 1.7.0, < 2.0)
+      rubocop-ast (>= 1.12.0, < 2.0)
       ruby-progressbar (~> 1.7)
       unicode-display_width (>= 1.4.0, < 3.0)
-    rubocop-ast (1.8.0)
+    rubocop-ast (1.12.0)
       parser (>= 3.0.1.1)
-    rubocop-performance (1.11.4)
+    rubocop-performance (1.11.5)
       rubocop (>= 1.7.0, < 2.0)
       rubocop-ast (>= 0.4.0)
     rubocop-rake (0.6.0)
       rubocop (~> 1.0)
-    rubocop-rspec (2.4.0)
-      rubocop (~> 1.0)
-      rubocop-ast (>= 1.1.0)
+    rubocop-rspec (2.5.0)
+      rubocop (~> 1.19)
     ruby-progressbar (1.11.0)
-    ruby2_keywords (0.0.5)
     simplecov (0.21.2)
       docile (~> 1.1)
       simplecov-html (~> 0.11)
@@ -104,10 +84,10 @@ GEM
     simplecov_json_formatter (0.1.3)
     tzinfo (2.0.4)
       concurrent-ruby (~> 1.0)
-    unicode-display_width (2.0.0)
+    unicode-display_width (2.1.0)
     vcr (6.0.0)
-    webmock (3.13.0)
-      addressable (>= 2.3.6)
+    webmock (3.14.0)
+      addressable (>= 2.8.0)
       crack (>= 0.3.2)
       hashdiff (>= 0.4.0, < 2.0.0)
     yard (0.9.26)
@@ -119,6 +99,7 @@ PLATFORMS
 
 DEPENDENCIES
   activesupport (~> 6.1)
+  awesome_print (~> 1.9)
   esi-sdk!
   kramdown-parser-gfm (~> 1.1)
   rake (~> 13.0)

data/README.md

@@ -1,3 +1,5 @@
+![Build images](https://github.com/bokoboshahni/esi-sdk-ruby/workflows/CICD/badge.svg)
+
 # EVE Swagger Interface (ESI) SDK
 
 ESI SDK is a Ruby API client for the EVE Swagger Interface (ESI), the official API for the [EVE Online](https://eveonline.com) MMORPG.

data/Rakefile

@@ -142,7 +142,7 @@ task :generate do
       end
 
       param_tags = operation[:params].map do |p|
-        "# @param #{p["name"]} [Integer,String] #{p["description"]}"
+        "# @param #{p["name"]} [#{p["type"].capitalize}] #{p["description"]}"
       end
 
       if operation[:body]
@@ -161,14 +161,26 @@ task :generate do
       end
 
       operation[:query]&.each do |p|
-        signature_params << "#{p["name"]}:"
-        param_tags << "# @param #{p["name"]} [#{p["type"].capitalize}] #{p["description"]}"
+        p_tag = "# @param #{p["name"]} [#{p["type"].capitalize}] "
+        p_tag += (p["description"]).to_s
+        p_tag += ". Must be one of: #{p["enum"].map { |e| "`#{e}`" }.join(", ")}" if p["enum"]
+        p_str = if p["default"] && p["type"] == "integer"
+                  "#{p["name"]}: #{p["default"]}"
+                elsif p["default"] && p["type"] == "string"
+                  "#{p["name"]}: \"#{p["default"]}\""
+                elsif !p["required"]
+                  "#{p["name"]}: nil"
+                else
+                  "#{p["name"]}:"
+                end
+        signature_params << p_str
+        param_tags << p_tag
       end
 
-      if %w[delete get].include?(operation[:method])
-        signature_params << "params: {}"
-        param_tags << "# @param params [Hash] Additional query string parameters"
+      signature_params += %w[headers params].map do |p|
+        "#{p}: {}"
       end
+      param_tags << "# @param params [Hash] Additional query string parameters"
 
       param_tags += [
         "# @param headers [Hash] Additional headers"
@@ -188,9 +200,6 @@ task :generate do
       description += "# @see https://esi.evetech.net/ui/#/#{operation[:tag]}/#{operation[:name]}"
       description.gsub!(/^$\n/m, "")
 
-      signature_params += %w[headers].map do |p|
-        "#{p}: {}"
-      end
       signature = "(#{signature_params.join(", ")})"
       path_parts = operation[:path].split("/")
       path_parts.map! do |p|
@@ -202,19 +211,16 @@ task :generate do
       end
       path = "#{path_parts.join("/")}/"
 
-      http_call_params = %w[headers].map { |p| "#{p}: #{p}" }
-      http_call_params << if %w[delete get].include?(operation[:method])
-                            "params: params"
-                          elsif operation[:body]
-                            "payload: #{body_param["name"]}"
-                          end
+      http_call_params = %w[headers params].map { |p| "#{p}: #{p}" }
+      http_call_params << ("payload: #{body_param["name"]}" if operation[:body])
 
-      if operation[:query].any?
-        http_call = "query_string = URI.encode_www_form([#{operation[:query].map { |q| "['#{q["name"]}', #{q["name"]}]" }.join(", ")}])\n"
-        http_call += "#{operation[:method]}(\"#{path}?\#{query_string}\", #{http_call_params.join(", ")})"
-      else
-        http_call = "#{operation[:method]}(\"#{path}\", #{http_call_params.join(", ")})"
-      end
+      params_merge = if operation[:query].any?
+                       "params.merge!(#{operation[:query].map { |q| "'#{q["name"]}' => #{q["name"]}" }.join(", ")})"
+                     else
+                       ""
+                     end
+
+      http_call = "#{operation[:method]}(\"#{path}\", #{http_call_params.join(", ")})"
 
       alias_methods = if method_aliases[method_name]
                         Array(method_aliases[method_name]).sort.map do |alias_name|
@@ -226,13 +232,26 @@ task :generate do
       alias_methods << "alias_method :#{operation[:name]}, :#{method_name}" unless operation[:name] == method_name
       alias_methods = alias_methods.join("\n")
 
-      a << <<~METHOD_DEFINITION
-        #{description}
-        def #{method_name}#{signature}
-          #{http_call}
-        end
-        #{alias_methods}
-      METHOD_DEFINITION
+      if operation[:responses]["200"] && operation[:responses]["200"]["headers"] && operation[:responses]["200"]["headers"].key?("X-Pages")
+        a << <<~METHOD_DEFINITION
+          #{description}
+          def #{method_name}#{signature}
+            #{params_merge}
+            responses = #{http_call}
+            responses.map(&:json).reduce([], :concat)
+          end
+          #{alias_methods}
+        METHOD_DEFINITION
+      else
+        a << <<~METHOD_DEFINITION
+          #{description}
+          def #{method_name}#{signature}
+            #{params_merge}
+            #{http_call}.json
+          end
+          #{alias_methods}
+        METHOD_DEFINITION
+      end
     end
 
     lib_content = <<~MODULE_DEFINITION
@@ -269,11 +288,6 @@ task :generate do
       success_params = operation[:params].map { |p| "#{p["name"]}: \"1234567890\"" }
       success_params += operation[:query].map { |p| "#{p["name"]}: \"1234567890\"" }
 
-      if operation[:query].any?
-        query = URI.encode_www_form(operation[:query].map { |q| [q["name"], "1234567890"] })
-        success_path = "#{success_path}?#{query}"
-      end
-
       if operation[:body]
         body_param = operation[:body]
         body_name = body_param["name"]
@@ -287,12 +301,16 @@ task :generate do
         success_params << "#{body_name}: #{body_value}"
       end
 
+      with_query = operation[:query].any? ? ".with(query: { #{operation[:query].map { |p| "#{p["name"]}: \"1234567890\"" }.join(", ")} })" : ""
+
+      extra_headers = success_desc["headers"] && success_desc["headers"]["X-Pages"] ? ", 'X-Pages': '1'" : ""
+
       describe = "  describe \"##{method_name}\" do\n"
       describe += "    context \"when the response is #{success_code}\" do\n"
       describe += "      let(:response) { #{success_response_body} }\n"
       describe += "\n"
       describe += "      before do\n"
-      describe += "        stub_request(:#{operation[:method]}, \"https://esi.evetech.net/latest#{success_path}\").to_return(body: response.to_json)\n"
+      describe += "        stub_request(:#{operation[:method]}, \"https://esi.evetech.net/latest#{success_path}\")#{with_query}.to_return(body: response.to_json, headers: { 'Content-Type': 'application/json'#{extra_headers} })\n"
       describe += "      end\n"
       describe += "\n"
       describe += "      it \"returns the response\" do\n"
@@ -303,13 +321,15 @@ task :generate do
       describe += "\n"
 
       error_contexts = operation[:errors].map do |(code, error)|
+        next if %w[502 503 504].include?(code)
+
         error_response_body = error["examples"]["application/json"].inspect
 
         context = "    context \"when the response is #{code}\" do\n"
         context += "      let(:response) { #{error_response_body} }\n"
         context += "\n"
         context += "      before do\n"
-        context += "        stub_request(:#{operation[:method]}, \"https://esi.evetech.net/latest#{success_path}\").to_return(body: response.to_json, status: #{code})\n"
+        context += "        stub_request(:#{operation[:method]}, \"https://esi.evetech.net/latest#{success_path}\")#{with_query}.to_return(body: response.to_json, status: #{code}, headers: { 'Content-Type': 'application/json' })\n"
         context += "      end\n"
         context += "\n"
         context += "      it \"raises a #{error_mapping[code.to_i]} error\" do\n"
@@ -327,8 +347,8 @@ task :generate do
     spec_content = <<~SPEC_FILE
       # frozen_string_literal: true
 
-      RSpec.describe ESI::Client::#{module_name} do
-        subject(:client) { ESI::Client.new(user_agent: \"ESI SDK Tests/1.0; +(https://github.com/bokoboshahni/esi-sdk)\") }
+      RSpec.describe ESI::Client::#{module_name}, type: :stub do
+        subject(:client) { ESI::Client.new(user_agent: \"esi-sdk-ruby Tests/1.0; +(https://github.com/bokoboshahni/esi-sdk-ruby)\") }
 
       #{describe_blocks.join("\n\n")}
       end

data/bin/console

@@ -2,7 +2,7 @@
 # frozen_string_literal: true
 
 require "bundler/setup"
-require "esi/sdk"
+require "esi-sdk"
 
 # You can add fixtures and/or initialization code here to make experimenting
 # with your gem easier. You can also use a different console, if you like.

data/esi-sdk.gemspec

@@ -26,7 +26,6 @@ Gem::Specification.new do |spec|
   spec.executables   = spec.files.grep(%r{\Aexe/}) { |f| File.basename(f) }
   spec.require_paths = ["lib"]
 
-  spec.add_dependency "faraday", "~> 1.5"
-  spec.add_dependency "faraday-http-cache", "~> 2.2"
-  spec.add_dependency "faraday_middleware", "~> 1.0"
+  spec.add_dependency "httpx", "~> 0.18"
+  spec.add_dependency "retriable", "~> 3.1"
 end

data/lib/esi/client/alliance.rb

@@ -13,7 +13,7 @@ module ESI
       # @esi_version v3
       # @esi_version v4
       #
-      # @param alliance_id [Integer,String] An EVE alliance ID
+      # @param alliance_id [Integer] An EVE alliance ID
       # @param params [Hash] Additional query string parameters
       # @param headers [Hash] Additional headers
       #
@@ -25,8 +25,8 @@ module ESI
       # @raise [ESI::Errors::GatewayTimeoutError] Gateway timeout
       #
       # @see https://esi.evetech.net/ui/#/Alliance/get_alliances_alliance_id
-      def get_alliance(alliance_id:, params: {}, headers: {})
-        get("/alliances/#{alliance_id}/", headers: headers, params: params)
+      def get_alliance(alliance_id:, headers: {}, params: {})
+        get("/alliances/#{alliance_id}/", headers: headers, params: params).json
       end
       alias get_alliances_alliance_id get_alliance
 
@@ -39,7 +39,7 @@ module ESI
       # @esi_version v1
       # @esi_version v2
       #
-      # @param alliance_id [Integer,String] An EVE alliance ID
+      # @param alliance_id [Integer] An EVE alliance ID
       # @param params [Hash] Additional query string parameters
       # @param headers [Hash] Additional headers
       #
@@ -50,8 +50,8 @@ module ESI
       # @raise [ESI::Errors::GatewayTimeoutError] Gateway timeout
       #
       # @see https://esi.evetech.net/ui/#/Alliance/get_alliances_alliance_id_corporations
-      def get_alliance_corporations(alliance_id:, params: {}, headers: {})
-        get("/alliances/#{alliance_id}/corporations/", headers: headers, params: params)
+      def get_alliance_corporations(alliance_id:, headers: {}, params: {})
+        get("/alliances/#{alliance_id}/corporations/", headers: headers, params: params).json
       end
       alias get_alliances_alliance_id_corporations get_alliance_corporations
 
@@ -60,7 +60,7 @@ module ESI
       # @esi_version legacy
       # @esi_version v1
       #
-      # @param alliance_id [Integer,String] An EVE alliance ID
+      # @param alliance_id [Integer] An EVE alliance ID
       # @param params [Hash] Additional query string parameters
       # @param headers [Hash] Additional headers
       #
@@ -72,8 +72,8 @@ module ESI
       # @raise [ESI::Errors::GatewayTimeoutError] Gateway timeout
       #
       # @see https://esi.evetech.net/ui/#/Alliance/get_alliances_alliance_id_icons
-      def get_alliance_icons(alliance_id:, params: {}, headers: {})
-        get("/alliances/#{alliance_id}/icons/", headers: headers, params: params)
+      def get_alliance_icons(alliance_id:, headers: {}, params: {})
+        get("/alliances/#{alliance_id}/icons/", headers: headers, params: params).json
       end
       alias get_alliances_alliance_id_icons get_alliance_icons
 
@@ -96,8 +96,8 @@ module ESI
       # @raise [ESI::Errors::GatewayTimeoutError] Gateway timeout
       #
       # @see https://esi.evetech.net/ui/#/Alliance/get_alliances
-      def get_alliances(params: {}, headers: {})
-        get("/alliances/", headers: headers, params: params)
+      def get_alliances(headers: {}, params: {})
+        get("/alliances/", headers: headers, params: params).json
       end
     end
   end

data/lib/esi/client/assets.rb

@@ -15,7 +15,7 @@ module ESI
       # @esi_version dev
       # @esi_version v5
       #
-      # @param character_id [Integer,String] An EVE character ID
+      # @param character_id [Integer] An EVE character ID
       # @param params [Hash] Additional query string parameters
       # @param headers [Hash] Additional headers
       #
@@ -29,8 +29,9 @@ module ESI
       # @raise [ESI::Errors::GatewayTimeoutError] Gateway timeout
       #
       # @see https://esi.evetech.net/ui/#/Assets/get_characters_character_id_assets
-      def get_character_assets(character_id:, params: {}, headers: {})
-        get("/characters/#{character_id}/assets/", headers: headers, params: params)
+      def get_character_assets(character_id:, headers: {}, params: {})
+        responses = get("/characters/#{character_id}/assets/", headers: headers, params: params)
+        responses.map(&:json).reduce([], :concat)
       end
       alias get_characters_character_id_assets get_character_assets
 
@@ -45,7 +46,7 @@ module ESI
       # @esi_version dev
       # @esi_version v5
       #
-      # @param corporation_id [Integer,String] An EVE corporation ID
+      # @param corporation_id [Integer] An EVE corporation ID
       # @param params [Hash] Additional query string parameters
       # @param headers [Hash] Additional headers
       #
@@ -58,8 +59,9 @@ module ESI
       # @raise [ESI::Errors::GatewayTimeoutError] Gateway timeout
       #
       # @see https://esi.evetech.net/ui/#/Assets/get_corporations_corporation_id_assets
-      def get_corporation_assets(corporation_id:, params: {}, headers: {})
-        get("/corporations/#{corporation_id}/assets/", headers: headers, params: params)
+      def get_corporation_assets(corporation_id:, headers: {}, params: {})
+        responses = get("/corporations/#{corporation_id}/assets/", headers: headers, params: params)
+        responses.map(&:json).reduce([], :concat)
       end
       alias get_corporations_corporation_id_assets get_corporation_assets
 
@@ -72,8 +74,9 @@ module ESI
       # @esi_version dev
       # @esi_version v2
       #
-      # @param character_id [Integer,String] An EVE character ID
+      # @param character_id [Integer] An EVE character ID
       # @param item_ids [Array] A list of item ids
+      # @param params [Hash] Additional query string parameters
       # @param headers [Hash] Additional headers
       #
       # @raise [ESI::Errors::BadRequestError] Bad request
@@ -85,8 +88,8 @@ module ESI
       # @raise [ESI::Errors::GatewayTimeoutError] Gateway timeout
       #
       # @see https://esi.evetech.net/ui/#/Assets/post_characters_character_id_assets_locations
-      def post_character_asset_locations(character_id:, item_ids:, headers: {})
-        post("/characters/#{character_id}/assets/locations/", headers: headers, payload: item_ids)
+      def post_character_asset_locations(character_id:, item_ids:, headers: {}, params: {})
+        post("/characters/#{character_id}/assets/locations/", headers: headers, params: params, payload: item_ids).json
       end
       alias post_characters_character_id_assets_locations post_character_asset_locations
 
@@ -100,8 +103,9 @@ module ESI
       # @esi_version legacy
       # @esi_version v1
       #
-      # @param character_id [Integer,String] An EVE character ID
+      # @param character_id [Integer] An EVE character ID
       # @param item_ids [Array] A list of item ids
+      # @param params [Hash] Additional query string parameters
       # @param headers [Hash] Additional headers
       #
       # @raise [ESI::Errors::BadRequestError] Bad request
@@ -113,8 +117,8 @@ module ESI
       # @raise [ESI::Errors::GatewayTimeoutError] Gateway timeout
       #
       # @see https://esi.evetech.net/ui/#/Assets/post_characters_character_id_assets_names
-      def post_character_asset_names(character_id:, item_ids:, headers: {})
-        post("/characters/#{character_id}/assets/names/", headers: headers, payload: item_ids)
+      def post_character_asset_names(character_id:, item_ids:, headers: {}, params: {})
+        post("/characters/#{character_id}/assets/names/", headers: headers, params: params, payload: item_ids).json
       end
       alias post_characters_character_id_assets_names post_character_asset_names
 
@@ -127,8 +131,9 @@ module ESI
       # @esi_version dev
       # @esi_version v2
       #
-      # @param corporation_id [Integer,String] An EVE corporation ID
+      # @param corporation_id [Integer] An EVE corporation ID
       # @param item_ids [Array] A list of item ids
+      # @param params [Hash] Additional query string parameters
       # @param headers [Hash] Additional headers
       #
       # @raise [ESI::Errors::BadRequestError] Bad request
@@ -141,8 +146,8 @@ module ESI
       # @raise [ESI::Errors::GatewayTimeoutError] Gateway timeout
       #
       # @see https://esi.evetech.net/ui/#/Assets/post_corporations_corporation_id_assets_locations
-      def post_corporation_asset_locations(corporation_id:, item_ids:, headers: {})
-        post("/corporations/#{corporation_id}/assets/locations/", headers: headers, payload: item_ids)
+      def post_corporation_asset_locations(corporation_id:, item_ids:, headers: {}, params: {})
+        post("/corporations/#{corporation_id}/assets/locations/", headers: headers, params: params, payload: item_ids).json
       end
       alias post_corporations_corporation_id_assets_locations post_corporation_asset_locations
 
@@ -156,8 +161,9 @@ module ESI
       # @esi_version legacy
       # @esi_version v1
       #
-      # @param corporation_id [Integer,String] An EVE corporation ID
+      # @param corporation_id [Integer] An EVE corporation ID
       # @param item_ids [Array] A list of item ids
+      # @param params [Hash] Additional query string parameters
       # @param headers [Hash] Additional headers
       #
       # @raise [ESI::Errors::BadRequestError] Bad request
@@ -170,8 +176,8 @@ module ESI
       # @raise [ESI::Errors::GatewayTimeoutError] Gateway timeout
       #
       # @see https://esi.evetech.net/ui/#/Assets/post_corporations_corporation_id_assets_names
-      def post_corporation_asset_names(corporation_id:, item_ids:, headers: {})
-        post("/corporations/#{corporation_id}/assets/names/", headers: headers, payload: item_ids)
+      def post_corporation_asset_names(corporation_id:, item_ids:, headers: {}, params: {})
+        post("/corporations/#{corporation_id}/assets/names/", headers: headers, params: params, payload: item_ids).json
       end
       alias post_corporations_corporation_id_assets_names post_corporation_asset_names
     end