escobar 0.3.20 → 0.3.21

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: bb04d677eebc0ac17e368692988dfd4f96064b7b
-  data.tar.gz: d97b59f78e386147c660c2c1c5890554c6fe096e
+  metadata.gz: 080f542dae7c68a66f17f597ae5c9609d123236e
+  data.tar.gz: 66d42c2379938b6c93f03b991e5a57d2cedc4853
 SHA512:
-  metadata.gz: fddf34ceb60477480a82ac4c4bec70f7cc412f144cbdf9247945a42adc133ee4eec4ddb66903e1cf3dc4e972e94dbc91ba2e98b311b72b537267058da652157f
-  data.tar.gz: 8998e4d80bdaf17c2601bfdc40bd739ca8187b922f796a44298c6a4b78a17d0415be1ad8e0d8614cb5e50659953ae6d82fc8089fc490851cca9370b934e720f5
+  metadata.gz: aa08fce37d50953594f632f1f3f18045015308e0a86889c28119f9ada5597fac66d8c567e4fbe1cc7c6d20c0a407d851a9a5a330b2168f65c1f9bbf912041b46
+  data.tar.gz: bb47e7aa460281a7ff7109bd584061ba493253ff21ada49088354f578dae22efdb4a7e95be19aba5401ec075b6e110f77d92e7e8c5f98fb9baa55f3f67002eb8

data/lib/escobar.rb

@@ -60,6 +60,7 @@ end
 
 require_relative "./escobar/client"
 require_relative "./escobar/github/client"
+require_relative "./escobar/github/deployment_error"
 require_relative "./escobar/heroku/app"
 require_relative "./escobar/heroku/build"
 require_relative "./escobar/heroku/build_request"

data/lib/escobar/github/deployment_error.rb

@@ -0,0 +1,37 @@
+module Escobar
+  module GitHub
+    # Consolidate GitHub deployment api failures for easier messaging
+    class DeploymentError < StandardError
+      attr_accessor :repo, :response, :required_commit_contexts
+
+      def initialize(repo, response, required_commit_contexts)
+        @repo = repo
+        @response = response
+        @required_commit_contexts = required_commit_contexts
+      end
+
+      def missing_contexts?
+        missing_contexts.any?
+      end
+
+      def missing_contexts
+        error = response.fetch("errors", [])[0]
+        return [] unless error && error["field"] == "required_contexts"
+        contexts = error["contexts"]
+        contexts.each_with_object([]) do |context, missing|
+          failed = (context["state"] != "success")
+          required = required_commit_contexts.include?(context["context"])
+          missing << context["context"] if required && failed
+        end
+      end
+
+      def response_message
+        response["message"]
+      end
+
+      def default_message
+        "Unable to create GitHub deployments for #{repo}: #{response_message}"
+      end
+    end
+  end
+end

data/lib/escobar/heroku/build_request.rb

@@ -17,6 +17,17 @@ module Escobar
         end
       end
 
+      # Class representing a rejected GitHub deployment
+      class MissingContextsError < Error
+        attr_accessor :missing_contexts
+        def self.new_from_build_request_and_error(build_request, error)
+          err = new(error.default_message)
+          err.build_request = build_request
+          err.missing_contexts = error.missing_contexts
+          err
+        end
+      end
+
       class RequiresTwoFactorError < Error
       end
 
@@ -97,10 +108,7 @@ module Escobar
 
       def handle_github_deployment_response(response)
         unless response["sha"]
-          raise error_for(
-            "Unable to create GitHub deployments for " \
-            "#{pipeline.github_repository}: #{response['message']}"
-          )
+          handle_github_deployment_error(response)
         end
 
         @sha = response["sha"]
@@ -108,6 +116,14 @@ module Escobar
         response
       end
 
+      def handle_github_deployment_error(response)
+        error = Escobar::GitHub::DeploymentError.new(
+          pipeline.github_repository, response, required_commit_contexts
+        )
+        raise error_for(error.default_message) unless error.missing_contexts?
+        raise MissingContextsError.new_from_build_request_and_error(self, error)
+      end
+
       def create_github_deployment(task)
         options = {
           ref: ref,

data/lib/escobar/version.rb

@@ -1,3 +1,3 @@
 module Escobar
-  VERSION = "0.3.20".freeze
+  VERSION = "0.3.21".freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: escobar
 version: !ruby/object:Gem::Version
-  version: 0.3.20
+  version: 0.3.21
 platform: ruby
 authors:
 - Corey Donohoe
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2017-03-09 00:00:00.000000000 Z
+date: 2017-03-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday
@@ -190,6 +190,7 @@ files:
 - lib/escobar.rb
 - lib/escobar/client.rb
 - lib/escobar/github/client.rb
+- lib/escobar/github/deployment_error.rb
 - lib/escobar/heroku/app.rb
 - lib/escobar/heroku/build.rb
 - lib/escobar/heroku/build_request.rb