errorinbox 0.0.1a → 0.0.2a

data/lib/error_inbox/notifier.rb

@@ -4,7 +4,7 @@ require "json"
 module ErrorInbox
   class Notifier
     def initialize(options)
-      @options = options
+      @options = options.dup
     end
 
     def save(ex)
@@ -39,34 +39,31 @@ module ErrorInbox
         :message => ex.message,
         :backtrace => ex.backtrace.join("\n"),
         :environmentName => ENV["RAILS_ENV"] || ENV["RACK_ENV"] || "development",
+        :environment => {},
         :occurredAt => Time.now.xmlschema
       }
 
-      if rack_env
+      rack_env = @options.delete(:rack_env)
+      if rack_env.respond_to?(:each)
         require "rack"
         body[:request] = { :url => ::Rack::Request.new(rack_env).url }
 
-        body[:environment] = {}
         rack_env.each do |key, value|
           body[:environment][key] = value.to_s
         end
 
-        if rack_session
+        if rack_session = rack_env["rack.session"]
           rack_session.each do |key, value|
             body[:session][key] = value.to_s
-          end
+          end if rack_session.respond_to?(:each)
         end
       end
 
-      JSON.dump(body)
-    end
-
-    def rack_env
-      @rack_env ||= @options[:rack_env] if @options[:rack_env].respond_to?(:each)
-    end
+      @options.each do |key, value|
+        body[:environment][key] = value
+      end
 
-    def rack_session
-      @rack_session ||= rack_env["rack.session"] if rack_env["rack.session"].respond_to?(:each)
+      JSON.dump(body)
     end
   end
 end

data/lib/error_inbox/version.rb

@@ -1,3 +1,3 @@
 module ErrorInbox
-  VERSION = "0.0.1a"
+  VERSION = "0.0.2a"
 end

data/spec/error_inbox/notifier_spec.rb

@@ -9,12 +9,44 @@ describe ErrorInbox::Notifier do
     end
   end
 
-  it "sends rack exceptions" do
+  it "raises an error if credentials are missing" do
+    ErrorInbox.stub(:configuration => double("configuration", :username => nil, :password => nil))
+
+    notifier = described_class.new(:rack_env => { :foo => "bar" })
+    expect { notifier.save(ex) }.to raise_error(ErrorInbox::MissingCredentialsError)
+  end
+
+  it "raises an error if credentials are invalid" do
     ErrorInbox.stub(:configuration => double("configuration", :username => "foo", :password => "bar"))
 
+    stub_forbidden_request
+
+    notifier = described_class.new(:rack_env => { :foo => "bar" })
+    expect { notifier.save(ex) }.to raise_error(ErrorInbox::InvalidCredentialsError)
+  end
+
+  it "sends rack exception" do
+    ErrorInbox.stub(:configuration => double("configuration", :username => "foo", :password => "bar"))
+
+    stub_created_request_for_rack_exception
+
+    notifier = described_class.new(:rack_env => { :foo => "bar" })
+    expect(notifier.save(ex)).to eq(1)
+  end
+
+  it "sends any exception" do
+    ErrorInbox.stub(:configuration => double("configuration", :username => "foo", :password => "bar"))
+
+    stub_created_request_for_any_exception
+
+    notifier = described_class.new(:sidekiq => { :queue => "default" })
+    expect(notifier.save(ex)).to eq(1)
+  end
+
+  def stub_created_request_for_rack_exception
     stub_request(:post, "http://foo:bar@oops.errorinbox.com").
       with(
-        :body => "{\"type\":\"RSpec::Mocks::Mock\",\"message\":\"some message\",\"backtrace\":\"a.rb:10\\nb.rb:11\",\"environmentName\":null,\"occurredAt\":\"2013-08-21T11:57:00-03:00\",\"request\":{\"url\":\"://::0\"},\"environment\":{\"foo\":\"bar\"}}",
+        :body => "{\"type\":\"RSpec::Mocks::Mock\",\"message\":\"some message\",\"backtrace\":\"a.rb:10\\nb.rb:11\",\"environmentName\":\"development\",\"environment\":{\"foo\":\"bar\"},\"occurredAt\":\"2013-08-21T11:57:00-03:00\",\"request\":{\"url\":\"://::0\"}}",
         :headers => { "Content-Type" => "application/json" }
       ).
       to_return(
@@ -22,24 +54,25 @@ describe ErrorInbox::Notifier do
         :body => "{\"id\":1}",
         :headers => { "Content-Type" => "application/json" }
       )
-
-    notifier = described_class.new(:rack_env => { :foo => "bar" })
-    expect(notifier.save(ex)).to eq(1)
   end
 
-  it "raises an error if credentials are missing" do
-    ErrorInbox.stub(:configuration => double("configuration", :username => nil, :password => nil))
-
-    notifier = described_class.new(:rack_env => { :foo => "bar" })
-    expect { notifier.save(ex) }.to raise_error(ErrorInbox::MissingCredentialsError)
+  def stub_created_request_for_any_exception
+    stub_request(:post, "http://foo:bar@oops.errorinbox.com").
+      with(
+        :body => "{\"type\":\"RSpec::Mocks::Mock\",\"message\":\"some message\",\"backtrace\":\"a.rb:10\\nb.rb:11\",\"environmentName\":\"development\",\"environment\":{\"sidekiq\":{\"queue\":\"default\"}},\"occurredAt\":\"2013-08-21T11:57:00-03:00\"}",
+        :headers => { "Content-Type" => "application/json" }
+      ).
+      to_return(
+        :status => 201,
+        :body => "{\"id\":1}",
+        :headers => { "Content-Type" => "application/json" }
+      )
   end
 
-  it "raises an error if credentials are invalid" do
-    ErrorInbox.stub(:configuration => double("configuration", :username => "foo", :password => "bar"))
-
+  def stub_forbidden_request
     stub_request(:post, "http://foo:bar@oops.errorinbox.com").
       with(
-        :body => "{\"type\":\"RSpec::Mocks::Mock\",\"message\":\"some message\",\"backtrace\":\"a.rb:10\\nb.rb:11\",\"environmentName\":null,\"occurredAt\":\"2013-08-21T11:57:00-03:00\",\"request\":{\"url\":\"://::0\"},\"environment\":{\"foo\":\"bar\"}}",
+        :body => "{\"type\":\"RSpec::Mocks::Mock\",\"message\":\"some message\",\"backtrace\":\"a.rb:10\\nb.rb:11\",\"environmentName\":\"development\",\"environment\":{\"foo\":\"bar\"},\"occurredAt\":\"2013-08-21T11:57:00-03:00\",\"request\":{\"url\":\"://::0\"}}",
         :headers => { 'Content-Type'=>'application/json' }
       ).
       to_return(
@@ -47,8 +80,5 @@ describe ErrorInbox::Notifier do
         :body => "{\"error\":\"forbidden\"}",
         :headers => { "Content-Type" => "application/json" }
       )
-
-    notifier = described_class.new(:rack_env => { :foo => "bar" })
-    expect { notifier.save(ex) }.to raise_error(ErrorInbox::InvalidCredentialsError)
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: errorinbox
 version: !ruby/object:Gem::Version
-  version: 0.0.1a
+  version: 0.0.2a
   prerelease: 5
 platform: ruby
 authors:
@@ -82,7 +82,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: -1940987844180716958
+      hash: -231840207079135962
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements: