errorgap 0.3.0 → 0.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: cabe7a082d767651c4e56f067d77fa21486056cde995842eb4ef7f8531adbf00
-  data.tar.gz: 10cc33121d252ce987eb92ccd2e57301ea4399bafa42c2b8cada4ab0dd4d1f63
+  metadata.gz: 3a6d206f60530a163bfebf7cbc25d4ef0f889a81d1b15c78f440c2141e4efc3a
+  data.tar.gz: d9346233cd3aec6e191a13efcec513fdfec9fadececb304549afc1527f4da3a7
 SHA512:
-  metadata.gz: 283fcdf5b95bcbf34a175b2e9249c5e2a5b4c16f46bedfe9852f088214ada0e6aa022d84f816a4c692b36291c9a3d8a0f099ee0f18beb15cf5c856d014ecdb14
-  data.tar.gz: a66f945ca3d16ee996aeec660dc24351baa3799e7b7404ce209202e98a3c10e6df7eac940c4bdea82e4b7ca86391c98ed3b718c174c0cfe5499485cfb14bd1b2
+  metadata.gz: c35e78949f9cbd4e30e24acacfbd5857f3d3003aa763f6d41c26a1713dde9c3e55a62bfe0bc24caa6941029910423ba1c5b0609ee4f48fed890ff1dbc4364e5a
+  data.tar.gz: 73a7f26536826709ceb3feb1624f48caa336dc2f6981c558a7d692a2ddbbef93206ff6397f4fa4192cc6f2306a486d8125f80df5750d4ecce168845ed6466e61

data/CHANGELOG.md

@@ -5,6 +5,28 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [0.4.0] - 2026-07-16
+
+### Fixed
+
+- Backtrace frames are now parsed on Ruby 3.4+, which formats frames as
+  `file.rb:12:in 'Class#method'` (straight quote) instead of the pre-3.4
+  `` file.rb:12:in `method' `` (backtick). Unparsed frames carried no line
+  number or function, which also prevented source excerpts from being
+  attached — the UI showed "Source is not available for this frame yet."
+  for every frame.
+
+- DB span durations are now computed from the notification event's
+  start/finish timestamps. The `sql.active_record` payload carries no
+  `:duration` key, so every query previously shipped `0.0` — showing as
+  0.0ms 50th/95th percentiles on the Performance > Queries page.
+
+### Added
+
+- DB spans now carry the application call site (`file`, `line`, `fn_name`),
+  captured from the first non-gem backtrace frame, so Performance > Queries
+  can attribute each query to app code.
+
 ## [0.3.0] - 2026-07-16
 
 ### Fixed

data/lib/errorgap/notice.rb

@@ -102,8 +102,10 @@ module Errorgap
       nil
     end
 
+    # Ruby <= 3.3 formats frames as `file.rb:42:in `method'` (backtick),
+    # Ruby >= 3.4 as `file.rb:42:in 'Class#method'` (straight quote).
     def parse_backtrace_line(line)
-      match = line.match(/\A(.+?):(\d+)(?::in `(.*)')?\z/)
+      match = line.match(/\A(.+?):(\d+)(?::in [`'](.*)')?\z/)
       return [line, nil, nil] unless match
 
       [match[1], match[2].to_i, match[3]]

data/lib/errorgap/span_collector.rb

@@ -25,15 +25,22 @@ module Errorgap
 
         @installed = true
 
-        ActiveSupport::Notifications.subscribe("sql.active_record") do |*, payload|
+        # The 5-arg block form receives the event's start/finish times; the
+        # sql.active_record payload itself carries no duration key.
+        ActiveSupport::Notifications.subscribe("sql.active_record") do |_name, started, finished, _id, payload|
           next unless Thread.current[THREAD_KEY]
           next if SKIP_NAMES.any? { |n| payload[:name]&.start_with?(n) }
           next if payload[:cached]
 
-          duration_ms = payload[:duration] || 0.0
+          duration_ms = ((finished - started) * 1000.0).to_f
           sql = normalize_sql(payload[:sql].to_s)
+          file, line, fn_name = app_call_site
 
-          store << Span.new(kind: "db", sql: sql, duration_ms: duration_ms.round(3))
+          store << Span.new(
+            kind: "db", sql: sql,
+            file: file, line: line, fn_name: fn_name,
+            duration_ms: duration_ms.round(3)
+          )
         end
 
         # Rails reports view_runtime with database time already subtracted, so
@@ -65,6 +72,31 @@ module Errorgap
       def normalize_sql(sql)
         sql.gsub(NORMALIZE_PATTERN, "?").gsub(/\s+/, " ").strip
       end
+
+      # The first backtrace frame belonging to the application — skipping this
+      # gem, other gems, and the Ruby standard library — so a query can be
+      # attributed to the app code that ran it. Returns [file, line, fn_name]
+      # with the file relative to Rails.root when available, or nils when no
+      # app frame is present (e.g. queries run from a console or gem).
+      def app_call_site
+        root = defined?(Rails) && Rails.respond_to?(:root) && Rails.root ? Rails.root.to_s : nil
+        location = caller_locations(1, 60)&.find do |loc|
+          path = loc.absolute_path || loc.path
+          next false unless path
+          next false if path.start_with?(LIB_ROOT)
+          next false if GEM_PATH_MARKERS.any? { |marker| path.include?(marker) }
+
+          root ? path.start_with?(root) : true
+        end
+        return [nil, nil, nil] unless location
+
+        path = location.absolute_path || location.path
+        path = path.delete_prefix("#{root}/") if root
+        [path, location.lineno, location.label]
+      end
     end
+
+    LIB_ROOT = File.expand_path("..", __dir__)
+    GEM_PATH_MARKERS = ["/gems/", "/rubygems/", "/lib/ruby/", "/bundler/"].freeze
   end
 end

data/lib/errorgap/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Errorgap
-  VERSION = "0.3.0"
+  VERSION = "0.4.0"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: errorgap
 version: !ruby/object:Gem::Version
-  version: 0.3.0
+  version: 0.4.0
 platform: ruby
 authors:
 - Errorgap
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2026-07-16 00:00:00.000000000 Z
+date: 2026-07-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake