errorgap 0.2.0 → 0.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e386d7d085d300b5364be4f27918288b5b62509895afe19ed525afee51c3f92a
-  data.tar.gz: 158ae2443f061e6ff63487dd0f4fe061a54ea4ba7933d65305743d42f84fcb1f
+  metadata.gz: 3a6d206f60530a163bfebf7cbc25d4ef0f889a81d1b15c78f440c2141e4efc3a
+  data.tar.gz: d9346233cd3aec6e191a13efcec513fdfec9fadececb304549afc1527f4da3a7
 SHA512:
-  metadata.gz: f43d61f09d546dc69c6a837e2ae7fee478589f510990e2740119f1945236b179feac4364c70e73459da787e4110757398cb876e44976d4709085cd8303887f96
-  data.tar.gz: a20b31f480acfe98543fb8a79d79b1d14427461a9b08d5847249dfa88b67633bcecac0af213d089b1d383d85032ef2f1cb7bb7de51befc108f5cffd1fa9e9c8a
+  metadata.gz: c35e78949f9cbd4e30e24acacfbd5857f3d3003aa763f6d41c26a1713dde9c3e55a62bfe0bc24caa6941029910423ba1c5b0609ee4f48fed890ff1dbc4364e5a
+  data.tar.gz: 73a7f26536826709ceb3feb1624f48caa336dc2f6981c558a7d692a2ddbbef93206ff6397f4fa4192cc6f2306a486d8125f80df5750d4ecce168845ed6466e61

data/CHANGELOG.md

@@ -5,6 +5,49 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [0.4.0] - 2026-07-16
+
+### Fixed
+
+- Backtrace frames are now parsed on Ruby 3.4+, which formats frames as
+  `file.rb:12:in 'Class#method'` (straight quote) instead of the pre-3.4
+  `` file.rb:12:in `method' `` (backtick). Unparsed frames carried no line
+  number or function, which also prevented source excerpts from being
+  attached — the UI showed "Source is not available for this frame yet."
+  for every frame.
+
+- DB span durations are now computed from the notification event's
+  start/finish timestamps. The `sql.active_record` payload carries no
+  `:duration` key, so every query previously shipped `0.0` — showing as
+  0.0ms 50th/95th percentiles on the Performance > Queries page.
+
+### Added
+
+- DB spans now carry the application call site (`file`, `line`, `fn_name`),
+  captured from the first non-gem backtrace frame, so Performance > Queries
+  can attribute each query to app code.
+
+## [0.3.0] - 2026-07-16
+
+### Fixed
+
+- APM span collection now works when `config.apm_enabled` is set in a Rails
+  app initializer (the common case). The `sql.active_record` subscriber was
+  previously installed only if APM was already enabled during railtie
+  initialization, which runs before `config/initializers` — so transactions
+  shipped without spans and the time breakdown showed everything as
+  "App / other".
+
+### Added
+
+- In-app backtrace frames now include a source excerpt (`source: {start_line,
+  lines}`, ±6 lines around the failing line) so the errorgap UI can render
+  backtrace source without a repository integration.
+
+- View-rendering time is now recorded as a `view` span (from Rails'
+  `process_action.action_controller` `view_runtime`), populating the
+  "View rendering" segment of the route time breakdown.
+
 ## [0.2.0] - 2026-07-10
 
 ### Added
@@ -27,5 +70,6 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
   timing and DB query spans, sampled by `config.apm_sample_rate`.
 - Authentication via the `X-Errorgap-Project-Key` header.
 
+[0.3.0]: https://github.com/errorgaphq/errorgap-ruby/compare/v0.2.0...v0.3.0
 [0.2.0]: https://github.com/errorgaphq/errorgap-ruby/compare/v0.1.0...v0.2.0
 [0.1.0]: https://github.com/errorgaphq/errorgap-ruby/releases/tag/v0.1.0

data/lib/errorgap/notice.rb

@@ -4,6 +4,13 @@ require "time"
 
 module Errorgap
   class Notice
+    # Lines of context shipped either side of the failing line for in-app
+    # frames, and a cap on how many frames include an excerpt so deep
+    # backtraces don't inflate the payload.
+    SOURCE_RADIUS = 6
+    MAX_SOURCE_FRAMES = 25
+    MAX_SOURCE_LINE_LENGTH = 400
+
     def self.from_exception(error, configuration:, context: {}, environment: {}, session: {}, params: {})
       new(
         error: error,
@@ -54,20 +61,51 @@ module Errorgap
     end
 
     def backtrace_frames
+      source_frames = 0
       Array(@error.backtrace).map.with_index do |line, index|
         file, line_number, function = parse_backtrace_line(line)
-        {
+        frame = {
           file: relative_file(file),
           line: line_number,
           function: function,
           in_app: in_app?(file),
           index: index
-        }.compact
+        }
+        if in_app?(file) && source_frames < MAX_SOURCE_FRAMES &&
+           (source = source_excerpt(file, line_number))
+          frame[:source] = source
+          source_frames += 1
+        end
+        frame.compact
       end
     end
 
+    # Reads the lines around the failing line so the server can show source
+    # without needing repository access. Returns nil when the file cannot be
+    # read (precompiled deploys, eval'd code, template paths).
+    def source_excerpt(file, line_number)
+      return nil unless line_number && line_number >= 1
+      return nil unless file && File.file?(file) && File.readable?(file)
+
+      lines = File.readlines(file)
+      return nil if lines.empty? || line_number > lines.length
+
+      start_line = [line_number - SOURCE_RADIUS, 1].max
+      end_line = [line_number + SOURCE_RADIUS, lines.length].min
+      {
+        start_line: start_line,
+        lines: lines[(start_line - 1)..(end_line - 1)].map do |text|
+          text.chomp[0, MAX_SOURCE_LINE_LENGTH]
+        end
+      }
+    rescue StandardError
+      nil
+    end
+
+    # Ruby <= 3.3 formats frames as `file.rb:42:in `method'` (backtick),
+    # Ruby >= 3.4 as `file.rb:42:in 'Class#method'` (straight quote).
     def parse_backtrace_line(line)
-      match = line.match(/\A(.+?):(\d+)(?::in `(.*)')?\z/)
+      match = line.match(/\A(.+?):(\d+)(?::in [`'](.*)')?\z/)
       return [line, nil, nil] unless match
 
       [match[1], match[2].to_i, match[3]]

data/lib/errorgap/rails/railtie.rb

@@ -18,7 +18,11 @@ module Errorgap
       end
 
       initializer "errorgap.install_span_collector" do
-        SpanCollector.install if Errorgap.configuration.apm_enabled
+        # Unconditional: apps enable APM in config/initializers, which runs
+        # after railtie initializers, so the flag cannot be checked here. The
+        # subscribers no-op unless the middleware starts a per-request
+        # collection, which does check the flag.
+        SpanCollector.install
       end
 
       generators do

data/lib/errorgap/span_collector.rb

@@ -14,19 +14,44 @@ module Errorgap
     SKIP_NAMES = %w[SCHEMA EXPLAIN CACHE].freeze
 
     class << self
-      # Call once at boot (from Railtie) when APM is enabled.
+      # Call once at boot (from Railtie). Subscribers only record while a
+      # transaction is being collected (the middleware starts one per request
+      # when APM is enabled), so installing unconditionally is safe — and
+      # required, since app initializers that enable APM run after railtie
+      # initializers.
       def install
         return unless defined?(ActiveSupport::Notifications)
+        return if @installed
 
-        ActiveSupport::Notifications.subscribe("sql.active_record") do |*, payload|
+        @installed = true
+
+        # The 5-arg block form receives the event's start/finish times; the
+        # sql.active_record payload itself carries no duration key.
+        ActiveSupport::Notifications.subscribe("sql.active_record") do |_name, started, finished, _id, payload|
           next unless Thread.current[THREAD_KEY]
           next if SKIP_NAMES.any? { |n| payload[:name]&.start_with?(n) }
           next if payload[:cached]
 
-          duration_ms = payload[:duration] || 0.0
+          duration_ms = ((finished - started) * 1000.0).to_f
           sql = normalize_sql(payload[:sql].to_s)
+          file, line, fn_name = app_call_site
+
+          store << Span.new(
+            kind: "db", sql: sql,
+            file: file, line: line, fn_name: fn_name,
+            duration_ms: duration_ms.round(3)
+          )
+        end
+
+        # Rails reports view_runtime with database time already subtracted, so
+        # this does not double count the db spans above.
+        ActiveSupport::Notifications.subscribe("process_action.action_controller") do |*, payload|
+          next unless Thread.current[THREAD_KEY]
+
+          view_ms = payload[:view_runtime]
+          next unless view_ms&.positive?
 
-          store << Span.new(kind: "db", sql: sql, duration_ms: duration_ms.round(3))
+          store << Span.new(kind: "view", duration_ms: view_ms.round(3))
         end
       end
 
@@ -47,6 +72,31 @@ module Errorgap
       def normalize_sql(sql)
         sql.gsub(NORMALIZE_PATTERN, "?").gsub(/\s+/, " ").strip
       end
+
+      # The first backtrace frame belonging to the application — skipping this
+      # gem, other gems, and the Ruby standard library — so a query can be
+      # attributed to the app code that ran it. Returns [file, line, fn_name]
+      # with the file relative to Rails.root when available, or nils when no
+      # app frame is present (e.g. queries run from a console or gem).
+      def app_call_site
+        root = defined?(Rails) && Rails.respond_to?(:root) && Rails.root ? Rails.root.to_s : nil
+        location = caller_locations(1, 60)&.find do |loc|
+          path = loc.absolute_path || loc.path
+          next false unless path
+          next false if path.start_with?(LIB_ROOT)
+          next false if GEM_PATH_MARKERS.any? { |marker| path.include?(marker) }
+
+          root ? path.start_with?(root) : true
+        end
+        return [nil, nil, nil] unless location
+
+        path = location.absolute_path || location.path
+        path = path.delete_prefix("#{root}/") if root
+        [path, location.lineno, location.label]
+      end
     end
+
+    LIB_ROOT = File.expand_path("..", __dir__)
+    GEM_PATH_MARKERS = ["/gems/", "/rubygems/", "/lib/ruby/", "/bundler/"].freeze
   end
 end

data/lib/errorgap/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Errorgap
-  VERSION = "0.2.0"
+  VERSION = "0.4.0"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: errorgap
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.4.0
 platform: ruby
 authors:
 - Errorgap
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2026-07-11 00:00:00.000000000 Z
+date: 2026-07-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
@@ -38,6 +38,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '5.0'
+- !ruby/object:Gem::Dependency
+  name: activesupport
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '6.1'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '6.1'
 description: Captures Ruby exceptions and sends them to a Errorgap server.
 email:
 - support@errorgap.com