errorapp_notifier 0.1.0 → 0.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 73aabada015e5a366a71f919330dbda250a796b6
-  data.tar.gz: 81180c1a660b66aa8e2968245bef973665fdabb4
+  metadata.gz: 26d615b0799422d7a3449d1ce0ec29a6bcd3308d
+  data.tar.gz: c34b497b8a47c06b1f5accee7f915efe6a0d42e2
 SHA512:
-  metadata.gz: 454ba40d8c73c1cdd81a1081c77e221bf41884ccd3b3afa0024daecb15882199635ec80622338a0eb9e3bb64e383b27dc83b9e0ffd178381f188a5e63cb400c8
-  data.tar.gz: 7bf777670b0e10f70c8dfdb2ea1ba5ca29453f28b7ed35adbacf52b42b46e2758637042275d20de4a9a016fe3b3061fd7b90702ce7e569264336c87b96c7d58c
+  metadata.gz: f5b8b4fc273534027f02f4985b7f6326b52ee7cf5d862590f808ead32659162e29546ff80a7e86d0c3ff3b43b96cb18aa50ad8842a75a784fa38f0119ffcc2ae
+  data.tar.gz: df8d45f77120650a3f3c3e97c4d2df9ee5566a527ca6b45815b262c2bb581a45f5598b89e562bd14555c545861f196863cd8d68c0c70b7c120b76ccbfd8e07e1

data/lib/errorapp_notifier/notify.rb

@@ -2,23 +2,20 @@ module ErrorappNotifier
   class Notify
     class << self
       def notify_with_controller(exception, controller = nil, request = nil)
-        notify_exception(exception) do
-          if !ignore?(exception, request)
-            ControllerFailureData.new(exception, controller, request)
-          end
+        data = ControllerFailureData.new(exception, controller, request)
+        if data && !ignore?(exception, request)
+          notify_exception(exception, data)
         end
       end
 
       def notify_with_rack(exception, environment, request)
-        notify_exception(exception) do
-          RackFailureData.new(exception, environment, request)
-        end
+        data = RackFailureData.new(exception, environment, request)
+        notify_exception(exception, data)
       end
 
       def notify(exception, name = nil)
-        notify_exception(exception) do
-          FailureData.new(exception, name)
-        end
+        data = FailureData.new(exception, name)
+        notify_exception(exception, data)
       end
 
       def ignore?(exception, request)
@@ -39,9 +36,9 @@ module ErrorappNotifier
 
       private
 
-      def notify_exception(exception, &block)
+      def notify_exception(exception, data)
         if config.should_send_to_api?
-          notify!(yield)
+          notify!(data)
         else
           raise exception
         end

data/lib/errorapp_notifier/version.rb

@@ -1,3 +1,3 @@
 module ErrorappNotifier
-  VERSION = "0.1.0"
+  VERSION = "0.1.1"
 end

data/spec/errorapp_notifier/notify_spec.rb

@@ -34,6 +34,19 @@ describe ErrorappNotifier::Notify do
         ErrorappNotifier::Notifier.should_receive(:notify_error).with(data)
         ErrorappNotifier::Notify.notify_with_controller(*args)
       end
+
+      it "should not notify if ignored" do
+        @config.ignore_exceptions = ['IgnoreMe']
+        exception = double('exception', class: 'IgnoreMe')
+        controller = double('controller')
+        request = double('request')
+        args = [exception, controller, request]
+        data = double("data")
+
+        ErrorappNotifier::ControllerFailureData.should_receive(:new).with(*args).and_return(data)
+        ErrorappNotifier::Notifier.should_not_receive(:notify_error).with(data)
+        ErrorappNotifier::Notify.notify_with_controller(*args)
+      end
     end
 
     describe "#notify_with_rack" do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: errorapp_notifier
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.1
 platform: ruby
 authors:
 - Rashmi
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-11-04 00:00:00.000000000 Z
+date: 2014-11-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler