error_radar 1.0.3 → 1.0.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: a67d42eee4ae7e2d87cd14daeea36484e94cb4e6408cf7d4867f5c00303dc6c2
-  data.tar.gz: ccdb606ec04483e63f572d524f5551c1d7306cb15d3314503bc46b3f76ecbea8
+  metadata.gz: c45267122a7ded92caa20eb6eb1d34f40ac5691222a8f69f0d32e7418f3f9934
+  data.tar.gz: d51638ec8c8e79d536c9b81bee62fb09381d9ce1dc3096bfe3161dc74566e3a5
 SHA512:
-  metadata.gz: 14128cfcaf6abd33a6fd03c7b1e1fc86f1c0f6cfcc1e77a6f9317e886aad3bc780da4b342a6db222ad80bae2a3f910443fccee1ed1b2523b3e31996e690a6dee
-  data.tar.gz: 90c830658f039a376bc4889bb86ec8b054b93bfbe222f6bfb02643e1b9622e0813d7a11b141fb6a34057dd892727a62bf51fdb8ac6963750ccf15e44e946bd1c
+  metadata.gz: 74f8c559c90cb25db39413355a61f987fc2c6cb4ca406327a6bb47a379b68e4ddaed048b4b9da538ce9aabfec3c1556fceecc6b9c9580a6c5acf15c2446b067d
+  data.tar.gz: 5feb61f2843942481bb718f69617a3ebf0a1b64d21aea0c5f4c1ea33f60775ace0afb127d6eee708fb4efb3396a3976a814f0d1ccd929045ebac598a98a76831

data/CHANGELOG.md

@@ -2,6 +2,41 @@
 
 All notable changes to this project will be documented in this file.
 
+## [1.0.4] - 2026-07-03
+
+### Fixed
+- **Rake integration: `SystemStackError` / infinite recursion on `rake db:migrate`**
+  Three compounding issues caused deployment to fail:
+
+  1. **Double-patching infinite loop** — if the host app's `lib/tasks/error_radar.rake`
+     contained an older version of the Rake integration (using `alias_method`), the
+     gem's own `alias_method :error_radar_original_execute, :execute` in v1.0.3
+     overwrote the alias so both copies called each other indefinitely. Fixed by
+     switching to `prepend` with an `ancestors.include?` idempotency guard — `prepend`
+     does not touch any existing aliases and composes cleanly with prior patches.
+
+  2. **Recursive capture** — if `ErrorRadar.capture` itself raised (e.g. because the
+     model wasn't loaded yet), the exception propagated back into the rescue block and
+     triggered `capture` again. Fixed with a thread-local `error_radar_rake_capturing`
+     guard and by never trying to capture `SystemStackError` / `SignalException` /
+     `NoMemoryError` (unrecoverable errors).
+
+  3. **AR 7.1 `respond_to_missing?` recursion** — ActiveRecord 7.1's
+     `detect_enum_conflict!` calls `dangerous_class_method?` → `Base.respond_to?`
+     → `respond_to_missing?` which can recurse infinitely when the table does not
+     exist yet (first deploy). Added `_scopes: false` to all three enum declarations
+     so the class-method conflict-detection path is skipped entirely. Also changed
+     `rescue StandardError` → `rescue Exception` in `Tracking.capture` so
+     `SystemStackError` is always absorbed and never escapes `capture`.
+
+- **`Api::StatsController` used enum-generated scopes** (`ErrorLog.status_open`,
+  etc.) which no longer exist with `_scopes: false`. Replaced with explicit
+  `where(status: ErrorLog.statuses[:open])` calls.
+
+**If you have a `lib/tasks/error_radar.rake` file in your host app** (not inside
+the gem), delete it — the engine loads the rake tasks automatically from the gem,
+and keeping a copy in the host app causes tasks to be defined twice.
+
 ## [1.0.3] - 2026-07-03
 
 ### Fixed

data/app/controllers/error_radar/api/stats_controller.rb

@@ -7,10 +7,10 @@ module ErrorRadar
       def show
         render json: {
           total:       ErrorLog.count,
-          open:        ErrorLog.status_open.count,
-          in_progress: ErrorLog.status_in_progress.count,
-          resolved:    ErrorLog.status_resolved.count,
-          ignored:     ErrorLog.status_ignored.count,
+          open:        ErrorLog.where(status: ErrorLog.statuses[:open]).count,
+          in_progress: ErrorLog.where(status: ErrorLog.statuses[:in_progress]).count,
+          resolved:    ErrorLog.where(status: ErrorLog.statuses[:resolved]).count,
+          ignored:     ErrorLog.where(status: ErrorLog.statuses[:ignored]).count,
           unresolved:  ErrorLog.unresolved.count,
           by_severity: ErrorLog.group(:severity).count,
           by_category: ErrorLog.group(:category).count,

data/app/models/error_radar/error_log.rb

@@ -10,11 +10,15 @@ module ErrorRadar
     # registers via ErrorRadar.config). Read at class-load, which happens after
     # the host's initializer has run `ErrorRadar.configure`, so custom
     # categories are already merged in. See ErrorRadar::Configuration.
-    enum category: ErrorRadar.config.categories, _prefix: :category
+    #
+    # _scopes: false avoids the class-method conflict-detection path in AR 7.1
+    # (detect_enum_conflict! → dangerous_class_method? → respond_to_missing?)
+    # that raises SystemStackError when the table does not yet exist.
+    enum category: ErrorRadar.config.categories, _prefix: :category, _scopes: false
 
-    enum severity: { info: 0, warning: 1, error: 2, critical: 3 }, _prefix: :severity
+    enum severity: { info: 0, warning: 1, error: 2, critical: 3 }, _prefix: :severity, _scopes: false
 
-    enum status: { open: 0, in_progress: 1, resolved: 2, ignored: 3 }, _prefix: :status
+    enum status: { open: 0, in_progress: 1, resolved: 2, ignored: 3 }, _prefix: :status, _scopes: false
 
     has_many :error_occurrences, class_name: 'ErrorRadar::ErrorOccurrence',
                                 foreign_key: :error_log_id,

data/lib/error_radar/integrations/rake.rb

@@ -2,31 +2,44 @@
 
 module ErrorRadar
   module Integrations
-    # Patches Rake::Task#execute so any exception raised inside a rake task is
-    # automatically captured as an ErrorLog, then re-raised so rake's normal
-    # failure handling (exit code, output) is unaffected.
     module Rake
-      def self.install!
-        return if @installed
-
-        @installed = true
+      # Prepended into Rake::Task to auto-capture exceptions raised inside any
+      # task body. Uses `prepend` (not alias_method) so it composes safely with
+      # any other patches already in place — including older versions of this
+      # integration that may be in the host app's lib/tasks/error_radar.rake.
+      module Capture
+        def execute(args = nil)
+          super
+        rescue Exception => e # rubocop:disable Lint/RescueException
+          # Never try to capture signals or stack overflows — we can't recover.
+          raise if e.is_a?(SignalException) || e.is_a?(SystemStackError) || e.is_a?(NoMemoryError)
 
-        ::Rake::Task.class_eval do
-          alias_method :error_radar_original_execute, :execute
-
-          def execute(args = nil)
-            error_radar_original_execute(args)
-          rescue Exception => e # rubocop:disable Lint/RescueException
-            ErrorRadar.capture(
-              e,
-              source: "rake:#{name}",
-              category: :background_job,
-              context: { task: name }
-            )
-            raise
+          # Thread-local guard: if capture itself fails and re-raises, we must
+          # not enter an infinite rescue loop.
+          unless Thread.current[:error_radar_rake_capturing]
+            Thread.current[:error_radar_rake_capturing] = true
+            begin
+              ErrorRadar.capture(
+                e,
+                source:   "rake:#{name}",
+                category: :background_job,
+                context:  { task: name }
+              )
+            ensure
+              Thread.current[:error_radar_rake_capturing] = false
+            end
           end
+          raise
         end
       end
+
+      def self.install!
+        # `ancestors.include?` is idempotent across multiple calls AND across
+        # multiple versions of the gem that may both try to install.
+        return if ::Rake::Task.ancestors.include?(Capture)
+
+        ::Rake::Task.prepend(Capture)
+      end
     end
   end
 end

data/lib/error_radar/tracking.rb

@@ -41,7 +41,7 @@ module ErrorRadar
       log = ErrorRadar::ErrorLog.record(**attrs)
       ErrorRadar::Notifier.dispatch(log) if log
       log
-    rescue StandardError => e
+    rescue Exception => e # rubocop:disable Lint/RescueException
       warn_internal("capture failed: #{e.class}: #{e.message}")
       nil
     end

data/lib/error_radar/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module ErrorRadar
-  VERSION = '1.0.3'
+  VERSION = '1.0.5'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: error_radar
 version: !ruby/object:Gem::Version
-  version: 1.0.3
+  version: 1.0.5
 platform: ruby
 authors:
 - chienbn9x
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2026-07-02 00:00:00.000000000 Z
+date: 2026-07-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails