error_radar 1.0.2 → 1.0.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 57a9bb51c11180d90dfedb8bce99c6f6c989c725bc44991a5c6ca42812148713
-  data.tar.gz: d4a31ea7b1e3317ddd392584099d5ce7811dd32468985a4d8f8e18c3498c05c0
+  metadata.gz: b7f170a894e4a6b29a0c95c2fc96630ba5ed1412eb7ee67bee2b547007bcc5c1
+  data.tar.gz: 89574f8768d969fbd5e73c56d50d6f502f700ead1e258bd475db9164c6d298df
 SHA512:
-  metadata.gz: fc4dcc84da998c26f0f348149e9d50b36be365b91f37cd69769a66afd9f0fe8d94c9a5e630496930150acfdb9d9f5b0ec37daef145e00b090e3817ad6d77eacc
-  data.tar.gz: fc4b1b73d7f3c4115c6ee3f00f12e8ab48420973ec41bd958ab9edafa27a36dce425d6c69e84a28eeacffc683d06f6cdce270dd06ab8759201b6c042aee44850
+  metadata.gz: beee5c8c764906d4bfcf82c3726b29a0c4e8c226174c68c166af5ff0ae622bce4167644b8d7b202e825b8c481084c1defb00b3088e9c9af55a9eaec4cfdca882
+  data.tar.gz: f337f436c786420fd9c9f13aec3d838e26d8f85365c13d4d30e3718204d2fb7166a692aa3667611388266fe8372a14ebfbd3cf908bca7e2d5e50cc1f87d7fd63

data/CHANGELOG.md

@@ -2,6 +2,53 @@
 
 All notable changes to this project will be documented in this file.
 
+## [1.0.4] - 2026-07-03
+
+### Fixed
+- **Rake integration: `SystemStackError` / infinite recursion on `rake db:migrate`**
+  Three compounding issues caused deployment to fail:
+
+  1. **Double-patching infinite loop** — if the host app's `lib/tasks/error_radar.rake`
+     contained an older version of the Rake integration (using `alias_method`), the
+     gem's own `alias_method :error_radar_original_execute, :execute` in v1.0.3
+     overwrote the alias so both copies called each other indefinitely. Fixed by
+     switching to `prepend` with an `ancestors.include?` idempotency guard — `prepend`
+     does not touch any existing aliases and composes cleanly with prior patches.
+
+  2. **Recursive capture** — if `ErrorRadar.capture` itself raised (e.g. because the
+     model wasn't loaded yet), the exception propagated back into the rescue block and
+     triggered `capture` again. Fixed with a thread-local `error_radar_rake_capturing`
+     guard and by never trying to capture `SystemStackError` / `SignalException` /
+     `NoMemoryError` (unrecoverable errors).
+
+  3. **AR 7.1 `respond_to_missing?` recursion** — ActiveRecord 7.1's
+     `detect_enum_conflict!` calls `dangerous_class_method?` → `Base.respond_to?`
+     → `respond_to_missing?` which can recurse infinitely when the table does not
+     exist yet (first deploy). Added `_scopes: false` to all three enum declarations
+     so the class-method conflict-detection path is skipped entirely. Also changed
+     `rescue StandardError` → `rescue Exception` in `Tracking.capture` so
+     `SystemStackError` is always absorbed and never escapes `capture`.
+
+- **`Api::StatsController` used enum-generated scopes** (`ErrorLog.status_open`,
+  etc.) which no longer exist with `_scopes: false`. Replaced with explicit
+  `where(status: ErrorLog.statuses[:open])` calls.
+
+**If you have a `lib/tasks/error_radar.rake` file in your host app** (not inside
+the gem), delete it — the engine loads the rake tasks automatically from the gem,
+and keeping a copy in the host app causes tasks to be defined twice.
+
+## [1.0.3] - 2026-07-03
+
+### Fixed
+- **`::Digest::SHA1` namespace clash**: `ErrorRadar::Digest` (our digest mailer
+  module) was shadowing Ruby stdlib's `Digest` inside `ErrorLog.build_fingerprint`,
+  causing `NameError: uninitialized constant ErrorRadar::Digest::SHA1` on every
+  captured error. Fixed by using `::Digest::SHA1` (root-level constant path).
+- **`ErrorLog` unresolved in views**: ERB templates run in `ActionView::Base`
+  context — outside the `ErrorRadar` module — so bare `ErrorLog` raised
+  `NameError: uninitialized constant ErrorLog` on the All Errors filter bar.
+  Changed to fully-qualified `ErrorRadar::ErrorLog` in the view.
+
 ## [1.0.2] - 2026-07-03
 
 ### Fixed

data/app/controllers/error_radar/api/stats_controller.rb

@@ -7,10 +7,10 @@ module ErrorRadar
       def show
         render json: {
           total:       ErrorLog.count,
-          open:        ErrorLog.status_open.count,
-          in_progress: ErrorLog.status_in_progress.count,
-          resolved:    ErrorLog.status_resolved.count,
-          ignored:     ErrorLog.status_ignored.count,
+          open:        ErrorLog.where(status: ErrorLog.statuses[:open]).count,
+          in_progress: ErrorLog.where(status: ErrorLog.statuses[:in_progress]).count,
+          resolved:    ErrorLog.where(status: ErrorLog.statuses[:resolved]).count,
+          ignored:     ErrorLog.where(status: ErrorLog.statuses[:ignored]).count,
           unresolved:  ErrorLog.unresolved.count,
           by_severity: ErrorLog.group(:severity).count,
           by_category: ErrorLog.group(:category).count,

data/app/models/error_radar/error_log.rb

@@ -10,11 +10,15 @@ module ErrorRadar
     # registers via ErrorRadar.config). Read at class-load, which happens after
     # the host's initializer has run `ErrorRadar.configure`, so custom
     # categories are already merged in. See ErrorRadar::Configuration.
-    enum category: ErrorRadar.config.categories, _prefix: :category
+    #
+    # _scopes: false avoids the class-method conflict-detection path in AR 7.1
+    # (detect_enum_conflict! → dangerous_class_method? → respond_to_missing?)
+    # that raises SystemStackError when the table does not yet exist.
+    enum category: ErrorRadar.config.categories, _prefix: :category, _scopes: false
 
-    enum severity: { info: 0, warning: 1, error: 2, critical: 3 }, _prefix: :severity
+    enum severity: { info: 0, warning: 1, error: 2, critical: 3 }, _prefix: :severity, _scopes: false
 
-    enum status: { open: 0, in_progress: 1, resolved: 2, ignored: 3 }, _prefix: :status
+    enum status: { open: 0, in_progress: 1, resolved: 2, ignored: 3 }, _prefix: :status, _scopes: false
 
     has_many :error_occurrences, class_name: 'ErrorRadar::ErrorOccurrence',
                                 foreign_key: :error_log_id,
@@ -95,7 +99,7 @@ module ErrorRadar
                           .gsub(/0x[0-9a-f]+/i, '0x#')             # object addresses
                           .gsub(/[0-9a-f]{8}-[0-9a-f-]{27}/i, '#') # uuids
                           .strip
-      Digest::SHA1.hexdigest([category, error_class, source, normalized].join('|'))
+      ::Digest::SHA1.hexdigest([category, error_class, source, normalized].join('|'))
     end
 
     def self.severity_rank(value)

data/app/views/error_radar/errors/index.html.erb

@@ -70,21 +70,21 @@
 
       <select name="status">
         <option value="">All statuses</option>
-        <% ErrorLog.statuses.each_key do |s| %>
+        <% ErrorRadar::ErrorLog.statuses.each_key do |s| %>
           <option value="<%= s %>" <%= 'selected' if fp['status'] == s %>><%= s.humanize %></option>
         <% end %>
       </select>
 
       <select name="severity">
         <option value="">All severities</option>
-        <% ErrorLog.severities.each_key do |s| %>
+        <% ErrorRadar::ErrorLog.severities.each_key do |s| %>
           <option value="<%= s %>" <%= 'selected' if fp['severity'] == s %>><%= s.capitalize %></option>
         <% end %>
       </select>
 
       <select name="category">
         <option value="">All categories</option>
-        <% ErrorLog.categories.each_key do |s| %>
+        <% ErrorRadar::ErrorLog.categories.each_key do |s| %>
           <option value="<%= s %>" <%= 'selected' if fp['category'] == s.to_s %>><%= s.to_s.humanize %></option>
         <% end %>
       </select>

data/lib/error_radar/integrations/rake.rb

@@ -2,31 +2,44 @@
 
 module ErrorRadar
   module Integrations
-    # Patches Rake::Task#execute so any exception raised inside a rake task is
-    # automatically captured as an ErrorLog, then re-raised so rake's normal
-    # failure handling (exit code, output) is unaffected.
     module Rake
-      def self.install!
-        return if @installed
-
-        @installed = true
+      # Prepended into Rake::Task to auto-capture exceptions raised inside any
+      # task body. Uses `prepend` (not alias_method) so it composes safely with
+      # any other patches already in place — including older versions of this
+      # integration that may be in the host app's lib/tasks/error_radar.rake.
+      module Capture
+        def execute(args = nil)
+          super
+        rescue Exception => e # rubocop:disable Lint/RescueException
+          # Never try to capture signals or stack overflows — we can't recover.
+          raise if e.is_a?(SignalException) || e.is_a?(SystemStackError) || e.is_a?(NoMemoryError)
 
-        ::Rake::Task.class_eval do
-          alias_method :error_radar_original_execute, :execute
-
-          def execute(args = nil)
-            error_radar_original_execute(args)
-          rescue Exception => e # rubocop:disable Lint/RescueException
-            ErrorRadar.capture(
-              e,
-              source: "rake:#{name}",
-              category: :background_job,
-              context: { task: name }
-            )
-            raise
+          # Thread-local guard: if capture itself fails and re-raises, we must
+          # not enter an infinite rescue loop.
+          unless Thread.current[:error_radar_rake_capturing]
+            Thread.current[:error_radar_rake_capturing] = true
+            begin
+              ErrorRadar.capture(
+                e,
+                source:   "rake:#{name}",
+                category: :background_job,
+                context:  { task: name }
+              )
+            ensure
+              Thread.current[:error_radar_rake_capturing] = false
+            end
           end
+          raise
         end
       end
+
+      def self.install!
+        # `ancestors.include?` is idempotent across multiple calls AND across
+        # multiple versions of the gem that may both try to install.
+        return if ::Rake::Task.ancestors.include?(Capture)
+
+        ::Rake::Task.prepend(Capture)
+      end
     end
   end
 end

data/lib/error_radar/tracking.rb

@@ -41,7 +41,7 @@ module ErrorRadar
       log = ErrorRadar::ErrorLog.record(**attrs)
       ErrorRadar::Notifier.dispatch(log) if log
       log
-    rescue StandardError => e
+    rescue Exception => e # rubocop:disable Lint/RescueException
       warn_internal("capture failed: #{e.class}: #{e.message}")
       nil
     end

data/lib/error_radar/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module ErrorRadar
-  VERSION = '1.0.2'
+  VERSION = '1.0.4'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: error_radar
 version: !ruby/object:Gem::Version
-  version: 1.0.2
+  version: 1.0.4
 platform: ruby
 authors:
 - chienbn9x