errdo 0.11.3 → 0.11.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 8248415a05b7019172a5af28071f172b742b5205
-  data.tar.gz: 7cdc8eac963f93d6e3bad8085200705c97fdbeba
+  metadata.gz: a1c02753b228820b93c239b4e9ebc3165d28ae24
+  data.tar.gz: 692b5bccf41783f97e64d1a2966870f812d35c74
 SHA512:
-  metadata.gz: 0f99749ff9ed1f28a1f891e57d2ac8866ecbad9bbe1cb022b3b03408f9f68d0c0a1c2e885545a4fcf91a1999c8e3e82d467bb7126effae3ef7f37caf09862f48
-  data.tar.gz: f5b0423971719d38471e7f4bd1d1292bfbee34b082ac0301b6051bd408554696134ae1a7dd256c5c0f07aec44fceb2948f8ad6deee3c0551bcaa3d7b15783151
+  metadata.gz: c597f080b1063557aeae0a7f1cb138daa6cad60495490e2cbd2a00e12db8154402043cd5a8b4f86d9b243ac7d4d66823267c6505fc4aa87c2363489520462049
+  data.tar.gz: 18e5d90035c81216865bef07427ceace199cdffa487b85cb7cf545481f7303db9fe550107ae83764e60c74975face2bcbb40d640ed6ad65c263985a3f3eb81da

data/app/controllers/errdo/errors_controller.rb

@@ -9,7 +9,7 @@ module Errdo
     before_action :authorize_user
 
     def index
-      @errors = Errdo::Error.order(last_occurred_at: :desc).page params[:page]
+      @errors = Errdo::Error.order(last_occurred_at: :desc).includes(:last_experiencer).page params[:page]
     end
 
     def show

data/app/models/errdo/exception.rb

@@ -4,9 +4,11 @@ module Errdo
     def initialize(env)
       user_parser = Errdo::Models::UserParser.new(env)
       @env_parser = Errdo::Models::ErrorEnvParser.new(env, user_parser)
-      create_errors(@env_parser) unless Errdo.error_name.blank?
+
+      error = nil
+      error = create_errors(@env_parser) unless Errdo.error_name.blank?
       Errdo.notify_with.each do |notifier|
-        notifier.notify(@env_parser)
+        notifier.notify(@env_parser, error: error)
       end
     end
 
@@ -15,6 +17,7 @@ module Errdo
     def create_errors(parser)
       error = Errdo::Error.find_or_create(parser.error_hash)
       error.try(:error_occurrences).try(:create, parser.error_occurrence_hash)
+      return error
     end
 
   end

data/config/routes.rb

@@ -1,4 +1,6 @@
 Errdo::Engine.routes.draw do
+  default_url_options host: Rails.application.config.action_mailer.default_url_options[:host]
+
   resources :errors, only: [:show, :update]
 
   root to: "errors#index"

data/lib/errdo/helpers/views_helper.rb

@@ -18,6 +18,10 @@ module Errdo
           errdo.root_path
         end
       end
+
+      def user_show_url(user)
+        user_show_path(user)
+      end
     end
   end
 end

data/lib/errdo/logger.rb

@@ -12,6 +12,7 @@ module Errdo
     def log
       error = Errdo::Error.find_or_create(**@parser.error_hash, importance: @importance)
       error.try(:error_occurrences).try(:create, @parser.error_occurrence_hash)
+      return error
     end
 
   end

data/lib/errdo/models/error_env_parser.rb

@@ -2,7 +2,7 @@ module Errdo
   module Models
     class ErrorEnvParser
 
-      attr_accessor :user, :exception_class_name, :exception_message, :http_method,
+      attr_accessor :exception_class_name, :exception_message, :http_method,
                     :host_name, :url, :backtrace, :ip, :user_agent, :referer,
                     :query_string, :param_values, :cookie_values, :header_values,
                     :experiencer_id, :experiencer_type
@@ -51,9 +51,13 @@ module Errdo
         @backtrace.first if @backtrace.respond_to?(:first)
       end
 
+      def user
+        @experiencer_type.constantize.find_by(id: @experiencer_id) if @experiencer_type && Errdo.error_name
+      end
+
       private
 
-      def set_accessible_params(env, request, controller, user)
+      def set_accessible_params(env, request, controller, new_user)
         @exception_class_name = env["action_dispatch.exception"].class.to_s
         @exception_message =    env["action_dispatch.exception"].try(:message)
         @http_method =          request.try(:request_method)
@@ -67,8 +71,8 @@ module Errdo
         @param_values =         scrubbed_params(request)
         @cookie_values =        request.try(:cookies)
         @header_values =        controller.try(:headers)
-        @experiencer_id =       user.try(:id)
-        @experiencer_type =     user.try(:class).try(:name)
+        @experiencer_id =       new_user.try(:id)
+        @experiencer_type =     new_user.try(:class).try(:name)
       end
 
       def prepare_backtrace(env)

data/lib/errdo/notifications/slack/notification_adapter.rb

@@ -15,10 +15,10 @@ module Errdo
                                                   username: options[:name] || 'Errdo-bot'
         end
 
-        def notify(parser)
-          messager = SlackMessager.new(parser)
+        def notify(parser, options = nil)
+          messager = SlackMessager.new(parser, options)
           begin
-            @slack_notifier.ping messager.message
+            @slack_notifier.ping(*messager.message)
           rescue => e
             Rails.logger.error e
           end
@@ -30,25 +30,40 @@ module Errdo
 
         include Errdo::Helpers::ViewsHelper # For the naming of the user in the message
 
-        def initialize(parser)
+        def initialize(parser, options = nil)
           @user = parser.user
           @backtrace = parser.short_backtrace
           @exception_name = parser.exception_name
           @exception_message = parser.exception_message
+          @error = options ? options[:error] : nil
         end
 
         def message
-          "#{exception_string}#{user_message_addon}\n#{@backtrace}"
+          url_helpers = Errdo::Engine.routes.url_helpers
+          error_url = url_helpers.error_url(@error) if @error
+          [exception_string, attachments:
+                                [
+                                  title: @exception_message,
+                                  title_link: error_url,
+                                  fields: additional_fields,
+                                  color: "#36a64f"
+                                ]]
         end
 
         private
 
         def exception_string
-          "#{@exception_name || 'None'} | #{@exception_message}"
+          @exception_name || 'None'
         end
 
-        def user_message_addon
-          "\nExperienced by #{user_show_string(@user)} " if @user
+        def additional_fields
+          fields = [{ title: "Backtrace",
+                      value: @backtrace.to_s }]
+          if @user
+            fields += [{ title: "User Affected",
+                         value: user_show_string(@user) }]
+          end
+          return fields
         end
 
       end

data/lib/errdo/version.rb

@@ -1,3 +1,3 @@
 module Errdo
-  VERSION = '0.11.3'.freeze
+  VERSION = '0.11.4'.freeze
 end

data/lib/errdo.rb

@@ -123,14 +123,14 @@ module Errdo
 
   # Logs the error to the database as a warning
   def self.warn(*args)
-    Errdo::Logger.new('warning', *args).log
-    Errdo::Notifier.new(*args).notify
+    error = Errdo::Logger.new('warning', *args).log
+    Errdo::Notifier.new(*args, error: error).notify
   end
 
   # Logs the error to the database and notifies the user
   def self.error(*args)
-    Errdo::Logger.new('error', *args).log
-    Errdo::Notifier.new(*args).notify
+    error = Errdo::Logger.new('error', *args).log
+    Errdo::Notifier.new(*args, error: error).notify
   end
 
   def self.setup

data/test/dummy/config/environments/development.rb

@@ -40,4 +40,5 @@ Rails.application.configure do
 
   # Raises error for missing translations
   # config.action_view.raise_on_missing_translations = true
+  config.action_mailer.default_url_options = { host: 'localhost:3000' }
 end

data/test/dummy/config/environments/production.rb

@@ -76,4 +76,6 @@ Rails.application.configure do
 
   # Do not dump schema after migrations.
   config.active_record.dump_schema_after_migration = false
+
+  config.action_mailer.default_url_options = { host: 'localhost:3000' }
 end

data/test/dummy/config/environments/test.rb

@@ -39,4 +39,6 @@ Rails.application.configure do
 
   # Raises error for missing translations
   # config.action_view.raise_on_missing_translations = true
+
+  config.action_mailer.default_url_options = { host: 'localhost:3000' }
 end