errbit_plugin 0.6.0 → 0.7.0

data/spec/errbit_plugin/registry_spec.rb

@@ -1,6 +1,8 @@
-require 'spec_helper'
+# frozen_string_literal: true
 
-describe ErrbitPlugin::Registry do
+require "spec_helper"
+
+RSpec.describe ErrbitPlugin::Registry do
   before do
     ErrbitPlugin::Registry.clear_issue_trackers
   end
@@ -8,7 +10,7 @@ describe ErrbitPlugin::Registry do
   let(:tracker) {
     tracker = Class.new(ErrbitPlugin::IssueTracker) do
       def self.label
-        'something'
+        "something"
       end
     end
     tracker
@@ -17,19 +19,19 @@ describe ErrbitPlugin::Registry do
   describe ".add_issue_tracker" do
     context "with issue_tracker class valid" do
       before do
-        allow(ErrbitPlugin::ValidateIssueTracker)
+        allow(ErrbitPlugin::IssueTrackerValidator)
           .to receive(:new)
           .with(tracker)
-          .and_return(double(:valid? => true, :message => ''))
+          .and_return(double(valid?: true, message: ""))
       end
-      it 'add new issue_tracker plugin' do
+      it "add new issue_tracker plugin" do
         ErrbitPlugin::Registry.add_issue_tracker(tracker)
         expect(ErrbitPlugin::Registry.issue_trackers).to eq({
-          'something' => tracker
+          "something" => tracker
         })
       end
       context "with already issue_tracker with this key" do
-        it 'raise ErrbitPlugin::AlreadyRegisteredError' do
+        it "raise ErrbitPlugin::AlreadyRegisteredError" do
           ErrbitPlugin::Registry.add_issue_tracker(tracker)
           expect {
             ErrbitPlugin::Registry.add_issue_tracker(tracker)
@@ -39,26 +41,26 @@ describe ErrbitPlugin::Registry do
     end
 
     context "with an IssueTracker not valid" do
-      it 'raise an IncompatibilityError' do
-        allow(ErrbitPlugin::ValidateIssueTracker)
+      it "raise an IncompatibilityError" do
+        allow(ErrbitPlugin::IssueTrackerValidator)
           .to receive(:new)
           .with(tracker)
-          .and_return(double(:valid? => false, :message => 'foo', :errors => []))
+          .and_return(double(valid?: false, message: "foo", errors: []))
         expect {
           ErrbitPlugin::Registry.add_issue_tracker(tracker)
         }.to raise_error(ErrbitPlugin::IncompatibilityError)
       end
 
-      it 'puts the errors in the exception message' do
-        allow(ErrbitPlugin::ValidateIssueTracker)
+      it "puts the errors in the exception message" do
+        allow(ErrbitPlugin::IssueTrackerValidator)
           .to receive(:new)
           .with(tracker)
-          .and_return(double(:valid? => false, :message => 'foo', :errors => ['one', 'two']))
+          .and_return(double(valid?: false, message: "foo", errors: ["one", "two"]))
 
         begin
           ErrbitPlugin::Registry.add_issue_tracker(tracker)
         rescue ErrbitPlugin::IncompatibilityError => e
-          expect(e.message).to eq('one; two')
+          expect(e.message).to eq("one; two")
         end
       end
     end

data/spec/spec_helper.rb

@@ -1,26 +1,25 @@
-if ENV['COVERAGE']
-  require 'simplecov'
-  if ENV['CI']
-    require 'coveralls'
-    Coveralls.wear!
-    SimpleCov.formatter = SimpleCov::Formatter::MultiFormatter[
-      SimpleCov::Formatter::HTMLFormatter,
-      Coveralls::SimpleCov::Formatter
-    ]
-  end
+# frozen_string_literal: true
+
+require "simplecov"
+
+SimpleCov.start do
+  enable_coverage :branch
+
+  primary_coverage :branch
 
-  SimpleCov.start
+  add_filter "spec/"
 end
 
-require 'errbit_plugin'
+require "errbit_plugin"
 
 RSpec.configure do |config|
-  config.run_all_when_everything_filtered = true
-  config.filter_run :focus
-
-  # Run specs in random order to surface order dependencies. If you find an
-  # order dependency and want to debug it, you can fix the order by providing
-  # the seed, which is printed after each run.
-  #     --seed 1234
-  config.order = 'random'
+  # Enable flags like --only-failures and --next-failure
+  config.example_status_persistence_file_path = ".rspec_status"
+
+  # Disable RSpec exposing methods globally on `Module` and `main`
+  config.disable_monkey_patching!
+
+  config.expect_with :rspec do |c|
+    c.syntax = :expect
+  end
 end

metadata

@@ -1,43 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: errbit_plugin
 version: !ruby/object:Gem::Version
-  version: 0.6.0
+  version: 0.7.0
 platform: ruby
 authors:
 - Stephen Crosby
-autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-02-26 00:00:00.000000000 Z
-dependencies:
-- !ruby/object:Gem::Dependency
-  name: bundler
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.3'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.3'
-- !ruby/object:Gem::Dependency
-  name: rake
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
+date: 1980-01-02 00:00:00.000000000 Z
+dependencies: []
 description: Base to create an errbit plugin
 email:
 - stevecrozz@gmail.com
@@ -45,11 +16,16 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- ".coveralls.yml"
+- ".envrc"
+- ".github/workflows/jruby.yml"
+- ".github/workflows/rspec.yml"
 - ".gitignore"
-- ".travis.yml"
+- ".rspec"
+- ".rubocop.yml"
+- ".ruby-version"
+- ".standard.yml"
 - Gemfile
-- Guardfile
+- Gemfile.lock
 - LICENSE
 - LICENSE.txt
 - README.md
@@ -57,22 +33,26 @@ files:
 - errbit_plugin.gemspec
 - lib/errbit_plugin.rb
 - lib/errbit_plugin/issue_tracker.rb
-- lib/errbit_plugin/issue_trackers/none.rb
+- lib/errbit_plugin/issue_tracker_validator.rb
+- lib/errbit_plugin/none_issue_tracker.rb
 - lib/errbit_plugin/registry.rb
-- lib/errbit_plugin/validate_issue_tracker.rb
 - lib/errbit_plugin/version.rb
+- spec/errbit_plugin/issue_tracker_validator_spec.rb
+- spec/errbit_plugin/none_issue_tracker_spec.rb
 - spec/errbit_plugin/registry_spec.rb
-- spec/errbit_plugin/validate_issue_tracker_spec.rb
 - spec/spec_helper.rb
 - static/fake_create.png
 - static/fake_inactive.png
 - static/none_create.png
 - static/none_inactive.png
-homepage: http://github.com/errbit/errbit
+homepage: https://github.com/errbit/errbit_plugin
 licenses:
 - MIT
-metadata: {}
-post_install_message: 
+metadata:
+  homepage_uri: https://github.com/errbit/errbit_plugin
+  source_code_uri: https://github.com/errbit/errbit_plugin
+  bug_tracker_uri: https://github.com/errbit/errbit_plugin/issues
+  rubygems_mfa_required: 'true'
 rdoc_options: []
 require_paths:
 - lib
@@ -80,20 +60,14 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 3.1.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.2.2
-signing_key: 
+rubygems_version: 3.6.7
 specification_version: 4
 summary: Base to create an errbit plugin
-test_files:
-- spec/errbit_plugin/registry_spec.rb
-- spec/errbit_plugin/validate_issue_tracker_spec.rb
-- spec/spec_helper.rb
-has_rdoc: 
+test_files: []

data/.coveralls.yml

@@ -1,2 +0,0 @@
-service_name: travis-pro
-repo_token: gNB8KeAdYQKNW2YC4uut6Zh2ToBnPyMqB

data/.travis.yml

@@ -1,15 +0,0 @@
-language: ruby
-env:
-    - COVERAGE=true
-before_install:
-  - gem install bundler
-script: bundle exec rspec spec
-rvm:
-  - 2.1
-  - 2.2
-  - 2.3.0
-  - rbx-2
-  - ruby-head
-matrix:
-  allow_failures:
-    - rvm: ruby-head

data/Guardfile

@@ -1,8 +0,0 @@
-# A sample Guardfile
-# More info at https://github.com/guard/guard#readme
-
-guard 'rspec' do
-  watch(%r{^spec/.+_spec\.rb$})
-  watch(%r{^lib/(.+)\.rb$})     { |m| "spec/lib/#{m[1]}_spec.rb" }
-  watch('spec/spec_helper.rb')  { "spec" }
-end

data/lib/errbit_plugin/issue_trackers/none.rb

@@ -1,31 +0,0 @@
-module ErrbitPlugin
-  class NoneIssueTracker < IssueTracker
-    def self.label; 'none'; end
-    def self.note
-      'When no issue tracker has been configured, you will be able to ' <<
-      'leave comments on errors.'
-    end
-    def self.fields; {}; end
-    def self.icons
-      @icons ||= {
-        create: ['image/png', read_static_file('none_create.png')],
-        goto: ['image/png', read_static_file('none_create.png')],
-        inactive: ['image/png', read_static_file('none_inactive.png')],
-      }
-    end
-    def self.read_static_file(file)
-      File.read(File.expand_path(File.join(
-        File.dirname(__FILE__), '..', '..', '..', 'static', file)))
-    end
-    ##
-    # The NoneIssueTracker is mark like configured? false because it not valid
-    # like a real IssueTracker
-    def configured?; false; end
-    def errors; {}; end
-    def url; ''; end
-    def create_issue(*); false; end
-    def close_issue(*); false; end
-  end
-end
-
-ErrbitPlugin::Registry.add_issue_tracker(ErrbitPlugin::NoneIssueTracker)

data/spec/errbit_plugin/validate_issue_tracker_spec.rb

@@ -1,255 +0,0 @@
-require 'spec_helper'
-
-describe ErrbitPlugin::ValidateIssueTracker do
-  describe "#valid?" do
-
-    context "with a complete class" do
-      klass = Class.new(ErrbitPlugin::IssueTracker) do
-        def self.label; 'foo'; end
-        def self.note; 'foo'; end
-        def self.fields; ['foo']; end
-        def self.icons; {}; end
-        def configured?; true; end
-        def errors; true; end
-        def create_issue; 'http'; end
-        def close_issue; 'http'; end
-        def url; 'http'; end
-      end
-
-      it 'valid' do
-        expect(ErrbitPlugin::ValidateIssueTracker.new(klass).valid?).to be true
-      end
-    end
-
-    context "with class not inherit from ErrbitPlugin::IssueTracker" do
-      klass = Class.new do
-        def self.label; 'foo'; end
-        def self.note; 'foo'; end
-        def self.fields; ['foo']; end
-        def self.icons; {}; end
-        def initialize(params); end
-        def configured?; true; end
-        def errors; true; end
-        def create_issue; 'http'; end
-        def close_issue; 'http'; end
-        def url; 'http'; end
-      end
-
-      it 'not valid' do
-        expect(ErrbitPlugin::ValidateIssueTracker.new(klass).valid?).to be false
-      end
-
-      it 'says :not_inherited' do
-        is = ErrbitPlugin::ValidateIssueTracker.new(klass)
-        is.valid?
-        expect(is.errors).to eql [[:not_inherited]]
-      end
-    end
-
-    context "with no label method" do
-      klass = Class.new(ErrbitPlugin::IssueTracker) do
-        def self.note; 'foo'; end
-        def self.fields; ['foo']; end
-        def self.icons; {}; end
-        def configured?; true; end
-        def errors; true; end
-        def create_issue; 'http'; end
-        def close_issue; 'http'; end
-        def url; 'http'; end
-      end
-
-      it 'not valid' do
-        expect(ErrbitPlugin::ValidateIssueTracker.new(klass).valid?).to be false
-      end
-
-      it 'say not implement label method' do
-        is = ErrbitPlugin::ValidateIssueTracker.new(klass)
-        is.valid?
-        expect(is.errors).to eql [[:class_method_missing, :label]]
-      end
-    end
-
-    context "with no icons method" do
-      klass = Class.new(ErrbitPlugin::IssueTracker) do
-        def self.note; 'foo'; end
-        def self.fields; ['foo']; end
-        def self.label; 'alabel'; end
-        def configured?; true; end
-        def errors; true; end
-        def create_issue; 'http'; end
-        def close_issue; 'http'; end
-        def url; 'http'; end
-      end
-
-      it 'not valid' do
-        expect(ErrbitPlugin::ValidateIssueTracker.new(klass).valid?).to be false
-      end
-
-      it 'say not implement icons method' do
-        is = ErrbitPlugin::ValidateIssueTracker.new(klass)
-        is.valid?
-        expect(is.errors).to eql [[:class_method_missing, :icons]]
-      end
-    end
-
-    context "without fields method" do
-      klass = Class.new(ErrbitPlugin::IssueTracker) do
-        def self.label; 'foo'; end
-        def self.note; 'foo'; end
-        def self.icons; {}; end
-        def configured?; true; end
-        def errors; true; end
-        def create_issue; 'http'; end
-        def close_issue; 'http'; end
-        def url; 'http'; end
-      end
-
-      it 'not valid' do
-        expect(ErrbitPlugin::ValidateIssueTracker.new(klass).valid?).to be false
-      end
-
-      it 'say not implement fields method' do
-        is = ErrbitPlugin::ValidateIssueTracker.new(klass)
-        is.valid?
-        expect(is.errors).to eql [[:class_method_missing, :fields]]
-      end
-    end
-
-    context "without configured? method" do
-      klass = Class.new(ErrbitPlugin::IssueTracker) do
-        def self.label; 'foo'; end
-        def self.note; 'foo'; end
-        def self.fields; ['foo']; end
-        def self.icons; {}; end
-        def errors; true; end
-        def create_issue; 'http'; end
-        def close_issue; 'http'; end
-        def url; 'http'; end
-      end
-
-      it 'not valid' do
-        expect(ErrbitPlugin::ValidateIssueTracker.new(klass).valid?).to be false
-      end
-
-      it 'say not implement configured? method' do
-        is = ErrbitPlugin::ValidateIssueTracker.new(klass)
-        is.valid?
-        expect(is.errors).to eql [[:instance_method_missing, :configured?]]
-      end
-    end
-
-    context "without errors method" do
-      klass = Class.new(ErrbitPlugin::IssueTracker) do
-        def self.label; 'foo'; end
-        def self.note; 'foo'; end
-        def self.fields; ['foo']; end
-        def self.icons; {}; end
-        def configured?; true; end
-        def create_issue; 'http'; end
-        def close_issue; 'http'; end
-        def url; 'http'; end
-      end
-
-      it 'not valid' do
-        expect(ErrbitPlugin::ValidateIssueTracker.new(klass).valid?).to be false
-      end
-
-      it 'say not implement errors method' do
-        is = ErrbitPlugin::ValidateIssueTracker.new(klass)
-        is.valid?
-        expect(is.errors).to eql [[:instance_method_missing, :errors]]
-      end
-    end
-
-    context "without create_issue method" do
-      klass = Class.new(ErrbitPlugin::IssueTracker) do
-        def self.label; 'foo'; end
-        def self.note; 'foo'; end
-        def self.fields; ['foo']; end
-        def self.icons; {}; end
-        def configured?; true; end
-        def errors; true; end
-        def close_issue; 'http'; end
-        def url; 'http'; end
-      end
-
-      it 'not valid' do
-        expect(ErrbitPlugin::ValidateIssueTracker.new(klass).valid?).to be false
-      end
-      it 'say not implement create_issue method' do
-        is = ErrbitPlugin::ValidateIssueTracker.new(klass)
-        is.valid?
-        expect(is.errors).to eql [[:instance_method_missing, :create_issue]]
-      end
-    end
-
-    context "without close_issue method" do
-      # this is an optional method
-      klass = Class.new(ErrbitPlugin::IssueTracker) do
-        def self.label; 'foo'; end
-        def self.note; 'foo'; end
-        def self.fields; ['foo']; end
-        def self.icons; {}; end
-        def configured?; true; end
-        def errors; true; end
-        def create_issue; 'http'; end
-        def url; 'http'; end
-      end
-
-      it 'is valid' do
-        expect(ErrbitPlugin::ValidateIssueTracker.new(klass).valid?).to be true
-      end
-      it 'not say not implement close_issue method' do
-        is = ErrbitPlugin::ValidateIssueTracker.new(klass)
-        is.valid?
-        expect(is.errors).not_to eql [[:instance_method_missing, :close_issue]]
-      end
-    end
-
-    context "without url method" do
-      klass = Class.new(ErrbitPlugin::IssueTracker) do
-        def self.label; 'foo'; end
-        def self.note; 'foo'; end
-        def self.fields; ['foo']; end
-        def self.icons; {}; end
-        def configured?; true; end
-        def errors; true; end
-        def create_issue; 'http'; end
-        def close_issue; 'http'; end
-      end
-
-      it 'not valid' do
-        expect(ErrbitPlugin::ValidateIssueTracker.new(klass).valid?).to be false
-      end
-
-      it 'say not implement url method' do
-        is = ErrbitPlugin::ValidateIssueTracker.new(klass)
-        is.valid?
-        expect(is.errors).to eql [[:instance_method_missing, :url]]
-      end
-    end
-
-    context "without note method" do
-      klass = Class.new(ErrbitPlugin::IssueTracker) do
-        def self.label; 'foo'; end
-        def self.fields; ['foo']; end
-        def self.icons; {}; end
-        def configured?; true; end
-        def errors; true; end
-        def create_issue; 'http'; end
-        def close_issue; 'http'; end
-        def url; 'foo'; end
-      end
-
-      it 'not valid' do
-        expect(ErrbitPlugin::ValidateIssueTracker.new(klass).valid?).to be false
-      end
-
-      it 'say not implement note method' do
-        is = ErrbitPlugin::ValidateIssueTracker.new(klass)
-        is.valid?
-        expect(is.errors).to eql [[:class_method_missing, :note]]
-      end
-    end
-  end
-end