errbit_github_plugin 0.2.0 → 0.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: afa68dc7f2ff60cfa5bca4d26fd9889a36bca7ad
-  data.tar.gz: f80c19060d3f571fe4882b3c62efbe6bc585ad42
+  metadata.gz: 03e8b522abb3f21ad344c7fc8daa4f3488858567
+  data.tar.gz: 14c8b3453aa7376a0addec27428516d261c8ad67
 SHA512:
-  metadata.gz: e6101c37634049d1a0cdba1fad9c4f272f70ce64fa4e925265272974ad21d4fed6b61f91c4c133b957215931d40dc600ab81d4dccb715879a6a671023c0e1ef1
-  data.tar.gz: f3af3a3f80dda0814de880fd94b40a0497ecc7960f98df2c8bfb9063a078acd4c2ae73d91ba137130d2368c1432c0bcc4d9d0c1de836ae0b60153a3fb5e874cd
+  metadata.gz: cbb84ca9d1757a665200ce84e57f87d6be39f9ca3f949e90a66b5ad961e691195512da8401b83322e0bb901d8c5205ea0f8c634325bed4b9c7728e0af2cc1f51
+  data.tar.gz: 82c69cfe8522e76c4eb4a0e53fa0b4b62af7763a0c2cccfa7fe39cfe0ec4fcd9032e0ec96eecd68a339ce4aacdb0812730905c1f72f991a0ec1943038778df42

data/.gitignore

@@ -15,3 +15,6 @@ spec/reports
 test/tmp
 test/version_tmp
 tmp
+*.swp
+.rspec
+vendor/bundle

data/.travis.yml

@@ -0,0 +1,9 @@
+language: ruby
+rvm:
+  - 2.1
+  - 2.2
+  - 2.3.0
+sudo: false
+cache: bundler
+script:
+  - bundle exec rspec

data/Gemfile

@@ -1,10 +1,2 @@
 source 'https://rubygems.org'
-
-# Specify your gem's dependencies in errbit_github_plugin.gemspec
 gemspec
-
-gem 'errbit_plugin', :git => 'https://github.com/errbit/errbit_plugin.git'
-gem 'rspec'
-gem 'guard'
-gem 'guard-rspec'
-gem 'coveralls', :require => false

data/README.md

@@ -1,29 +1,7 @@
-# ErrbitGithubPlugin
+# Errbit Github Plugin [![TravisCI][travis-img-url]][travis-ci-url]
 
-TODO: Write a gem description
+[travis-img-url]: https://travis-ci.org/errbit/errbit_github_plugin.svg?branch=master
+[travis-ci-url]: http://travis-ci.org/errbit/errbit_github_plugin
 
-## Installation
-
-Add this line to your application's Gemfile:
-
-    gem 'errbit_github_plugin'
-
-And then execute:
-
-    $ bundle
-
-Or install it yourself as:
-
-    $ gem install errbit_github_plugin
-
-## Usage
-
-TODO: Write usage instructions here
-
-## Contributing
-
-1. Fork it
-2. Create your feature branch (`git checkout -b my-new-feature`)
-3. Commit your changes (`git commit -am 'Add some feature'`)
-4. Push to the branch (`git push origin my-new-feature`)
-5. Create new Pull Request
+This plugin provides GitHub issue tracker integration for Errbit and it is the
+only plugin included by default in Errbit.

data/errbit_github_plugin.gemspec

@@ -4,24 +4,29 @@ $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 require 'errbit_github_plugin/version'
 
 Gem::Specification.new do |spec|
-  spec.name          = "errbit_github_plugin"
+  spec.name          = 'errbit_github_plugin'
   spec.version       = ErrbitGithubPlugin::VERSION
-  spec.authors       = ["Stephen Crosby", "Cyril Mougel"]
-  spec.email         = ["stevecrozz@gmail.com", "cyril.mougel@gmail.com"]
+  spec.authors       = ['Stephen Crosby']
+  spec.email         = ['stevecrozz@gmail.com']
 
   spec.description   = %q{GitHub integration for Errbit}
   spec.summary       = %q{GitHub integration for Errbit}
-  spec.homepage      = "https://github.com/brandedcrate/errbit_github_plugin"
-  spec.license       = "MIT"
+  spec.homepage      = 'https://github.com/errbit/errbit_github_plugin'
+  spec.license       = 'MIT'
 
   spec.files         = `git ls-files`.split($/)
   spec.executables   = spec.files.grep(%r{^bin/}) { |f| File.basename(f) }
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
-  spec.require_paths = ["lib"]
+  spec.require_paths = ['lib']
 
-  spec.add_dependency "errbit_plugin"
-  spec.add_dependency "octokit"
+  spec.add_dependency 'errbit_plugin'
+  spec.add_dependency 'octokit'
 
-  spec.add_development_dependency "bundler", "~> 1.3"
-  spec.add_development_dependency "rake"
+  spec.add_development_dependency 'rspec'
+  spec.add_development_dependency 'guard'
+  spec.add_development_dependency 'guard-rspec'
+  spec.add_development_dependency 'coveralls'
+  spec.add_development_dependency 'bundler'
+  spec.add_development_dependency 'rake'
+  spec.add_development_dependency 'activesupport'
 end

data/lib/errbit_github_plugin/issue_tracker.rb

@@ -82,5 +82,23 @@ module ErrbitGithubPlugin
     rescue Octokit::Unauthorized
       raise ErrbitGithubPlugin::AuthenticationError, "Could not authenticate with GitHub. Please check your username and password."
     end
+
+    def close_issue(url, user: {})
+      if user['github_login'] && user['github_oauth_token']
+        github_client = Octokit::Client.new(
+          login: user['github_login'], access_token: user['github_oauth_token'])
+      else
+        github_client = Octokit::Client.new(
+          login: options['username'], password: options['password'])
+      end
+      # It would be better to get the number from issue.number when we create the issue,
+      # however, since we only have the url, get the number from it.
+      # ex: "https://github.com/octocat/Hello-World/issues/1347"
+      issue_number = url.split("/").last
+      issue = github_client.close_issue(repo, issue_number)
+      issue.html_url
+    rescue Octokit::Unauthorized
+      raise ErrbitGithubPlugin::AuthenticationError, "Could not authenticate with GitHub. Please check your username and password."
+    end
   end
 end

data/lib/errbit_github_plugin/version.rb

@@ -1,3 +1,3 @@
 module ErrbitGithubPlugin
-  VERSION = "0.2.0"
+  VERSION = '0.3.0'
 end

data/spec/issue_tracker_spec.rb

@@ -0,0 +1,156 @@
+describe ErrbitGithubPlugin::IssueTracker do
+  describe '.label' do
+    it 'return LABEL' do
+      expect(described_class.label).to eq described_class::LABEL
+    end
+  end
+
+  describe '.note' do
+    it 'return NOTE' do
+      expect(described_class.note).to eq described_class::NOTE
+    end
+  end
+
+  describe '.fields' do
+    it 'return FIELDS' do
+      expect(described_class.fields).to eq described_class::FIELDS
+    end
+  end
+
+  describe '.icons' do
+
+    it 'puts create icon onto the icons' do
+      expect(described_class.icons[:create][0]).to eq 'image/png'
+      expect(
+        described_class.icons[:create][1]
+      ).to eq ErrbitGithubPlugin.read_static_file('github_create.png')
+    end
+
+    it 'puts goto icon onto the icons' do
+      expect(described_class.icons[:goto][0]).to eq 'image/png'
+      expect(
+        described_class.icons[:goto][1]
+      ).to eq ErrbitGithubPlugin.read_static_file('github_goto.png')
+    end
+
+    it 'puts inactive icon onto the icons' do
+      expect(described_class.icons[:inactive][0]).to eq 'image/png'
+      expect(
+        described_class.icons[:inactive][1]
+      ).to eq ErrbitGithubPlugin.read_static_file('github_inactive.png')
+    end
+  end
+
+  let(:tracker) { described_class.new(options) }
+
+  describe '#configured?' do
+    context 'with errors' do
+      let(:options) { { invalid_key: '' } }
+      it 'return false' do
+        expect(tracker.configured?).to eq false
+      end
+    end
+    context 'without errors' do
+      let(:options) do
+        { username: 'foo', password: 'bar', github_repo: 'user/repos' }
+      end
+      it 'return true' do
+        expect(tracker.configured?).to eq true
+      end
+    end
+  end
+
+  describe '#url' do
+    let(:options) { { github_repo: 'repo' } }
+    it 'returns issues url' do
+      expect(tracker.url).to eq 'https://github.com/repo/issues'
+    end
+  end
+
+  describe '#errors' do
+    subject { tracker.errors }
+    context 'without username' do
+      let(:options) { { username: '', password: 'bar', github_repo: 'repo' } }
+      it { is_expected.not_to be_empty }
+    end
+    context 'without password' do
+      let(:options) do
+        { username: '', password: 'bar', github_repo: 'repo' }
+      end
+      it { is_expected.not_to be_empty }
+    end
+    context 'without github_repo' do
+      let(:options) do
+        { username: 'foo', password: 'bar', github_repo: '' }
+      end
+      it { is_expected.not_to be_empty }
+    end
+    context 'with completed options' do
+      let(:options) do
+        { username: 'foo', password: 'bar', github_repo: 'repo' }
+      end
+      it { is_expected.to be_empty }
+    end
+  end
+
+  describe '#repo' do
+    let(:options) { { github_repo: 'baz' } }
+    it 'returns github repo' do
+      expect(tracker.repo).to eq 'baz'
+    end
+  end
+
+  describe '#create_issue' do
+    subject { tracker.create_issue('title', 'body', user: user) }
+    let(:options) do
+      { username: 'foo', password: 'bar', github_repo: 'user/repos' }
+    end
+    let(:fake_github_client) do
+      double('Fake GitHub Client').tap do |github_client|
+        github_client.stub(:create_issue).and_return(fake_issue)
+      end
+    end
+    let(:fake_issue) do
+      double('Fake Issue').tap do |issue|
+        issue.stub(:html_url).and_return('http://github.com/user/repos/issues/878')
+      end
+    end
+
+    context 'signed in with token' do
+      let(:user) do
+        {
+          'github_login' => 'bob',
+          'github_oauth_token' => 'valid_token'
+        }
+      end
+      it 'return issue url' do
+        Octokit::Client.stub(:new).with(
+          login: user['github_login'], access_token: user['github_oauth_token']
+        ).and_return(fake_github_client)
+        expect(subject).to eq fake_issue.html_url
+      end
+    end
+
+    context 'signed in with password' do
+      let(:user) { {} }
+      it 'return issue url' do
+        (Octokit::Client).stub(:new).with(
+          login: options['username'], password: options['password']
+        ).and_return(fake_github_client)
+        expect(subject).to eq fake_issue.html_url
+      end
+    end
+
+    context 'when unauthentication error' do
+      let(:user) do
+        { 'github_login' => 'alice', 'github_oauth_token' => 'invalid_token' }
+      end
+      it 'raise AuthenticationError' do
+        (Octokit::Client).stub(:new).with(
+          login: user['github_login'], access_token: user['github_oauth_token']
+        ).and_raise(Octokit::Unauthorized)
+        expect { subject }.to raise_error
+      end
+    end
+  end
+end

data/spec/spec_helper.rb

@@ -0,0 +1,28 @@
+if ENV['COVERAGE']
+  require 'simplecov'
+  if ENV['CI']
+    require 'coveralls'
+    Coveralls.wear!
+    SimpleCov.formatter = SimpleCov::Formatter::MultiFormatter[
+      SimpleCov::Formatter::HTMLFormatter,
+      Coveralls::SimpleCov::Formatter
+    ]
+  end
+
+  SimpleCov.start
+end
+
+require 'errbit_plugin'
+require 'errbit_github_plugin'
+require 'active_support/all'
+
+RSpec.configure do |config|
+  config.run_all_when_everything_filtered = true
+  config.filter_run :focus
+
+  # Run specs in random order to surface order dependencies. If you find an
+  # order dependency and want to debug it, you can fix the order by providing
+  # the seed, which is printed after each run.
+  #     --seed 1234
+  config.order = 'random'
+end

metadata

@@ -1,15 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: errbit_github_plugin
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.3.0
 platform: ruby
 authors:
 - Stephen Crosby
-- Cyril Mougel
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-04-23 00:00:00.000000000 Z
+date: 2016-03-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: errbit_plugin
@@ -39,20 +38,76 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: rspec
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: guard
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: guard-rspec
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: coveralls
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1.3'
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1.3'
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -67,15 +122,30 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: activesupport
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 description: GitHub integration for Errbit
 email:
 - stevecrozz@gmail.com
-- cyril.mougel@gmail.com
 executables: []
 extensions: []
 extra_rdoc_files: []
 files:
 - ".gitignore"
+- ".rspec"
+- ".travis.yml"
 - Gemfile
 - LICENSE.txt
 - README.md
@@ -85,12 +155,14 @@ files:
 - lib/errbit_github_plugin/error.rb
 - lib/errbit_github_plugin/issue_tracker.rb
 - lib/errbit_github_plugin/version.rb
+- spec/issue_tracker_spec.rb
+- spec/spec_helper.rb
 - static/github_create.png
 - static/github_goto.png
 - static/github_inactive.png
 - vendor/assets/images/github_create.png
 - vendor/assets/images/github_inactive.png
-homepage: https://github.com/brandedcrate/errbit_github_plugin
+homepage: https://github.com/errbit/errbit_github_plugin
 licenses:
 - MIT
 metadata: {}
@@ -114,5 +186,7 @@ rubygems_version: 2.2.2
 signing_key: 
 specification_version: 4
 summary: GitHub integration for Errbit
-test_files: []
+test_files:
+- spec/issue_tracker_spec.rb
+- spec/spec_helper.rb
 has_rdoc: