erp_integration 0.62.0 → 1.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 63269c49afd5a3ed49f2a21df8a3e4f102b4206f807ec2b856c0e35a62cea05a
-  data.tar.gz: 5a31d04b8d8a7d45f08921a32d470e80d717b0e76d5e01757eb2c6ff6a3fe22c
+  metadata.gz: 2cd27cee73fe0ca1c7df7893b35f52f3cdf54f9ae32a4559c739cc804d80bd4a
+  data.tar.gz: 5194f43286bf53cd04ea22b01d261268c32749b0b9dc8d5db24cc778d6b1ae70
 SHA512:
-  metadata.gz: adffdd3bf7d3746d1256509f5572e52d4ab7be28cc064efc9dabc870ab6c0846ee81e5523ed37e641b13a870b686a53e84be2cb7c9ec478466c009c7aa0074e1
-  data.tar.gz: 2b93cf2f5299db27f9a8dec86df24803641d58f641ec484437b21f943848da29068953952b96d236a2d95cf9de0588726fd2f28a52d562b2e0b3581247d9328f
+  metadata.gz: 10885ee89ef3960ba1d192ff6b5c32f51193b235d5c10d10831af1dc28b6583e65547a69d1db2c2738fe22ba94bcf72ff2bbccabdcbed9b27ab38fee6a14565c
+  data.tar.gz: 783e67561264e6734caeca1bffc8ab67f758c09675ec261ed0f6238bf1c13bf523356f6d114c6f56c6d9869f5625b5975f1e6c6e2bba06217139d0ccb9e50b9b

data/.github/workflows/main.yml

@@ -8,7 +8,7 @@ jobs:
 
     strategy:
       matrix:
-        ruby-version: ['3.0', '2.7', '2.6', '2.5', '2.4', '2.3']
+        ruby-version: ['3.0', '3.3', '3.4']
 
     steps:
     - uses: actions/checkout@v2

data/.rubocop.yml

@@ -16,7 +16,7 @@ Metrics/BlockLength:
     # 1. Specs tend to include big blocks (e.g. `RSpec.describe` or `it`).
     # 2. `mejuri-web` also has disabled the `Metrics/BlockLength` for specs.
     - spec/**/*
-  ExcludedMethods: ['class_eval']
+  AllowedMethods: ['class_eval']
 
 Lint/AmbiguousBlockAssociation:
   Enabled: true
@@ -88,3 +88,8 @@ Metrics/ClassLength:
 
 Style/AndOr:
   EnforcedStyle: conditionals
+
+Lint/ConstantDefinitionInBlock:
+  Exclude:
+    - spec/**/*
+

data/.ruby-version

@@ -1 +1 @@
-3.0.2
+3.3.6

data/README.md

@@ -155,7 +155,7 @@ $ ErpIntegration::SalesOrder.select(:id, :reference).find_by(reference: 'MT1000S
 
 ## Development
 
-After checking out the repo, run `bin/setup` to install dependencies. Then, run `rake test` to run the tests. You can also run `bin/console` for an interactive prompt that will allow you to experiment.
+After checking out the repo, run `bin/setup` to install dependencies. Then, run `bundle exec rspec` to run the tests. You can also run `bin/console` for an interactive prompt that will allow you to experiment.
 
 ### Releasing
 

data/erp_integration.gemspec

@@ -32,17 +32,16 @@ Gem::Specification.new do |spec|
   spec.add_dependency 'activesupport', '>= 4.1.16'
 
   # Faraday is a HTTP/REST API client library to interact with third-party API vendors
-  spec.add_dependency 'faraday', '>= 0.17.3', '< 1.9.0'
-  spec.add_dependency 'faraday_middleware', '>= 0.14', '< 1.3'
+  spec.add_dependency 'faraday', '~> 2.12'
 
   # Development dependencies
   spec.add_development_dependency 'byebug', '~> 11.0'
   spec.add_development_dependency 'flay', '~> 2.12', '>= 2.12.1'
   spec.add_development_dependency 'github_changelog_generator', '~> 1.15.2'
-  spec.add_development_dependency 'rake', '~> 13.0'
-  spec.add_development_dependency 'reek', '< 6.0'
+  spec.add_development_dependency 'rake', '>= 13.0'
+  spec.add_development_dependency 'reek', '<= 6.4.0'
   spec.add_development_dependency 'rspec', '~> 3.10'
-  spec.add_development_dependency 'rubocop', '< 0.82.0'
+  spec.add_development_dependency 'rubocop', '~> 1.71'
   spec.add_development_dependency 'rubocop-rake', '~> 0.5'
   spec.add_development_dependency 'rubocop-rspec', '< 1.39.0'
   spec.add_development_dependency 'webmock', '~> 3.18.1'

data/lib/erp_integration/fulfil/api_resource.rb

@@ -17,6 +17,7 @@ module ErpIntegration
       include QueryMethods
 
       attr_accessor :resource_klass
+
       delegate :api_keys_pool=, :client, :model_name, to: 'self.class'
 
       def initialize(resource_klass)
@@ -72,9 +73,9 @@ module ErpIntegration
       # be executed and the results will be fetched.
       # @return [Array] An enumerable collection object with all API results.
       def all
-        return @results if defined?(@results)
+        return @all if defined?(@all)
 
-        @results =
+        @all =
           client.put(
             api_resource_path,
             Query.new(

data/lib/erp_integration/fulfil/client.rb

@@ -26,18 +26,15 @@ module ErpIntegration
         @connection ||= Faraday.new(url: base_url) do |faraday|
           faraday.headers = default_headers
 
-          faraday.request :json # Encode request bodies as JSON
-          faraday.request :retry # Retry transient failures
-
-          faraday.response :follow_redirects
-          faraday.response :json # Decode response bodies as JSON
+          faraday.request :json_encode # Encode request bodies as JSON
+          faraday.response :json_decode # Decode response bodies as JSON
 
           # Custom error handling for the error response
-          faraday.use ErpIntegration::Middleware::ErrorHandling
+          faraday.use :error_handling
           # Custom middleware for rotating API keys
-          faraday.use ErpIntegration::Middleware::ApiKeysRotation, rotation_options
+          faraday.use :api_keys_rotation, rotation_options
           # Custom middleware for logging requests and responses
-          faraday.use ErpIntegration::Middleware::Logger, @logger, formatter: FORMATTER if @logger
+          faraday.use :custom_logger, @logger, formatter: FORMATTER if @logger
 
           # Adapter definition should be last in order to make the json parsers be loaded correctly
           faraday.adapter faraday_adapter

data/lib/erp_integration/fulfil/query.rb

@@ -29,7 +29,7 @@ module ErpIntegration
       # @param alternative_filters [Array<OrClause>] A list of or clauses for Fulfil.
       # @param offset [Integer] Offset for pagination.
       # @param limit [Integer] Limit for pagination.
-      def initialize(fields:, filters:, alternative_filters: [], offset: nil, limit: nil)
+      def initialize(fields:, filters:, alternative_filters: [], offset: nil, limit: nil) # rubocop:disable Metrics/CyclomaticComplexity
         @fields = (fields || DEFAULT_FIELDS).map(&:to_s).uniq
         @filters = (filters || []).map(&:to_filter).uniq
         @filters += alternative_filters.map(&:to_filter).uniq if alternative_filters&.any?

data/lib/erp_integration/logger.rb

@@ -11,11 +11,11 @@ module ErpIntegration
 
     # Logs the given tags if the logger is present.
     # If the logger does not respond to `tagged`, it logs the tags as an info message.
-    def with_tags(*tags)
+    def with_tags(*tags, &block)
       return yield unless logger
 
       if logger.respond_to?(:tagged)
-        logger.tagged(*tags) { yield }
+        logger.tagged(*tags) { block.call }
       else
         logger.info("Requested ERP with #{tags.join(', ')}")
         yield

data/lib/erp_integration/middleware/api_keys_rotation.rb

@@ -38,3 +38,5 @@ module ErpIntegration
     end
   end
 end
+
+Faraday::Middleware.register_middleware(api_keys_rotation: ErpIntegration::Middleware::ApiKeysRotation)

data/lib/erp_integration/middleware/error_handling.rb

@@ -4,7 +4,7 @@ module ErpIntegration
   module Middleware
     # The `ErrorHandling` middleware allows to raise our own exceptions that
     # are easier to catch for the host application (e.g. `mejuri-web`).
-    class ErrorHandling < Faraday::Response::Middleware
+    class ErrorHandling < Faraday::Middleware
       HTTP_ERROR_CODES = {
         400 => ErpIntegration::HttpError::BadRequest,
         401 => ErpIntegration::HttpError::AuthorizationRequired,
@@ -29,3 +29,5 @@ module ErpIntegration
     end
   end
 end
+
+Faraday::Middleware.register_middleware(error_handling: ErpIntegration::Middleware::ErrorHandling)

data/lib/erp_integration/middleware/json_decode.rb

@@ -0,0 +1,27 @@
+# frozen_string_literal: true
+
+module ErpIntegration
+  module Middleware
+    class JsonDecode < Faraday::Middleware
+      class ParseError < StandardError; end
+
+      def call(env)
+        @app.call(env).on_complete { |response| on_complete(response) }
+      end
+
+      private
+
+      def on_complete(env)
+        return unless env.body.is_a?(String)
+
+        begin
+          env.body = env.body.empty? ? nil : JSON.parse(env.body)
+        rescue JSON::ParserError
+          raise ParseError, "Failed to parse JSON response: #{env.body}"
+        end
+      end
+    end
+  end
+end
+
+Faraday::Response.register_middleware(json_decode: ErpIntegration::Middleware::JsonDecode)

data/lib/erp_integration/middleware/json_encode.rb

@@ -0,0 +1,21 @@
+# frozen_string_literal: true
+
+module ErpIntegration
+  module Middleware
+    class JsonEncode < Faraday::Middleware
+      def call(env)
+        on_request(env)
+
+        @app.call(env)
+      end
+
+      private
+
+      def on_request(env)
+        env.body = env.body.to_json if env.body
+      end
+    end
+  end
+end
+
+Faraday::Request.register_middleware(json_encode: ErpIntegration::Middleware::JsonEncode)

data/lib/erp_integration/middleware/logger.rb

@@ -49,3 +49,5 @@ module ErpIntegration
     end
   end
 end
+
+Faraday::Middleware.register_middleware(custom_logger: ErpIntegration::Middleware::Logger)

data/lib/erp_integration/resource.rb

@@ -105,25 +105,13 @@ module ErpIntegration
       # @param kwargs [Hash] The list of arguments for the missing method.
       # @param block [Proc] Any block given to the missing method.
       #
-      # rubocop:disable Style/MissingRespondToMissing
-      if RUBY_VERSION < '2.7'
-        def method_missing(method_name, *args, &block)
-          if adapter.respond_to?(method_name)
-            adapter.send(method_name, *args, &block)
-          else
-            super
-          end
-        end
-      else
-        def method_missing(method_name, *args, **kwargs, &block)
-          if adapter.respond_to?(method_name)
-            adapter.send(method_name, *args, **kwargs, &block)
-          else
-            super
-          end
+      def method_missing(method_name, *args, **kwargs, &block)
+        if adapter.respond_to?(method_name)
+          adapter.send(method_name, *args, **kwargs, &block)
+        else
+          super
         end
       end
-      # rubocop:enable Style/MissingRespondToMissing
 
       # The `respond_to_missing?` complements the `method_missing` method.
       # @param method_name [Symbol] The name of the missing method.

data/lib/erp_integration/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module ErpIntegration
-  VERSION = '0.62.0'
+  VERSION = '1.0.0'
 end

data/lib/erp_integration.rb

@@ -5,7 +5,6 @@ require 'active_support/core_ext/string/inflections'
 require 'active_support/core_ext/module/delegation' # Allows using `delegate`
 require 'active_support/core_ext/object/blank'
 require 'faraday'
-require 'faraday_middleware'
 require 'json'
 
 require_relative 'erp_integration/version'
@@ -20,9 +19,13 @@ require_relative 'erp_integration/middleware/api_keys_rotation'
 require_relative 'erp_integration/middleware/error_handling'
 require_relative 'erp_integration/middleware/logger'
 require_relative 'erp_integration/middleware/formatter'
+require_relative 'erp_integration/middleware/json_encode'
+require_relative 'erp_integration/middleware/json_decode'
 
 # HTTP clients
 require_relative 'erp_integration/fulfil/client'
+require_relative 'erp_integration/fulfil/persistence'
+require_relative 'erp_integration/fulfil/api_resource'
 
 # The `ErpIntegration` integrates Mejuri with third-party ERP vendors.
 module ErpIntegration
@@ -66,6 +69,7 @@ module ErpIntegration
     autoload :Persistence, 'erp_integration/resources/persistence'
     autoload :Validations, 'erp_integration/resources/validations'
   end
+
   module Types
     autoload :Decimal, 'erp_integration/types/decimal'
   end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: erp_integration
 version: !ruby/object:Gem::Version
-  version: 0.62.0
+  version: 1.0.0
 platform: ruby
 authors:
 - Stefan Vermaas
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2025-02-03 00:00:00.000000000 Z
+date: 2025-02-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -28,42 +28,16 @@ dependencies:
   name: faraday
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 0.17.3
-    - - "<"
-      - !ruby/object:Gem::Version
-        version: 1.9.0
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 0.17.3
-    - - "<"
-      - !ruby/object:Gem::Version
-        version: 1.9.0
-- !ruby/object:Gem::Dependency
-  name: faraday_middleware
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0.14'
-    - - "<"
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.3'
+        version: '2.12'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0.14'
-    - - "<"
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.3'
+        version: '2.12'
 - !ruby/object:Gem::Dependency
   name: byebug
   requirement: !ruby/object:Gem::Requirement
@@ -116,30 +90,30 @@ dependencies:
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '13.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '13.0'
 - !ruby/object:Gem::Dependency
   name: reek
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "<"
+    - - "<="
       - !ruby/object:Gem::Version
-        version: '6.0'
+        version: 6.4.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "<"
+    - - "<="
       - !ruby/object:Gem::Version
-        version: '6.0'
+        version: 6.4.0
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
@@ -158,16 +132,16 @@ dependencies:
   name: rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "<"
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.82.0
+        version: '1.71'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "<"
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.82.0
+        version: '1.71'
 - !ruby/object:Gem::Dependency
   name: rubocop-rake
   requirement: !ruby/object:Gem::Requirement
@@ -322,6 +296,8 @@ files:
 - lib/erp_integration/middleware/api_keys_rotation.rb
 - lib/erp_integration/middleware/error_handling.rb
 - lib/erp_integration/middleware/formatter.rb
+- lib/erp_integration/middleware/json_decode.rb
+- lib/erp_integration/middleware/json_encode.rb
 - lib/erp_integration/middleware/logger.rb
 - lib/erp_integration/party_address.rb
 - lib/erp_integration/product.rb